| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-07 | |||
| 19:02:39 | Nisha_Agarwal | we have customers who in their production(not on master branch), use non-exact filter | |
| 19:02:50 | Nisha_Agarwal | for ironic node scheduling | |
| 19:03:41 | Nisha_Agarwal | with the custom resource class that scheduling doesnt happen | |
| 19:04:56 | Nisha_Agarwal | mriedem, thats the main reason we want atleast scheduling to happen for these resources. Eventually we would want to leverage the same resource class structure in ironic for any other quantitative resources | |
| 19:05:32 | Nisha_Agarwal | which cannot be handled by capabilities whenever they are deprecated and taken over by traits | |
| 19:06:43 | openstackgerrit | Merged openstack/nova master: Refactor out claim_resources_on_destination into a utility https://review.openstack.org/499718 | |
| 19:07:50 | mriedem | Nisha_Agarwal: so you're aware of these release notes in pike right? http://docs-draft.openstack.org/77/501477/1/check/gate-nova-releasenotes/1dc7513//releasenotes/build/html/unreleased.html#id2 | |
| 19:08:14 | Nisha_Agarwal | mriedem, yes. | |
| 19:08:48 | Nisha_Agarwal | but the same filter_scheduler could be used for scheduling ironic nodes as well, isnt it? | |
| 19:09:25 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Set regex flag on ostestr command for osprofiler tests https://review.openstack.org/501842 | |
| 19:09:32 | Nisha_Agarwal | mriedem, s/filter_scheduler/enabled_filters | |
| 19:13:17 | mriedem | i think that depends on if you're using the IronicHostManager doesn't it? | |
| 19:14:10 | mtreinish | mriedem: it also looks like that second command breaks openstack-health. We're only capturing the subunit for the last run | |
| 19:14:20 | mtreinish | so we only ever track that one test: http://status.openstack.org/openstack-health/#/job/gate-nova-python27-ubuntu-xenial | |
| 19:14:54 | mriedem | guh | |
| 19:15:00 | mriedem | idk, what are other projects doing for the osprofiler test? | |
| 19:15:03 | mriedem | running it in a separate job? | |
| 19:15:12 | mtreinish | I have no idea | |
| 19:15:16 | mriedem | cinder doesn't run it | |
| 19:15:23 | mtreinish | oh, well that answers that | |
| 19:15:33 | mriedem | nor glance | |
| 19:15:35 | mriedem | i'm not sure why nova does | |
| 19:15:49 | Nisha_Agarwal | mriedem, yeah but could we configure that? | |
| 19:16:27 | Nisha_Agarwal | means IronicHostManager is not configurable IMO, and Nova use it for ironic nodes | |
| 19:16:33 | mriedem | Nisha_Agarwal: yes it looks like if use_baremetal_filters is False, which is the default, it uses the normal enabled_filters | |
| 19:16:50 | Nisha_Agarwal | mriedem, yes thats true. ^^ | |
| 19:17:07 | mtreinish | mriedem: should I just drop that from the tox.ini? | |
| 19:17:07 | mriedem | and as of pike, enabled_filters no longer has ram/disk filters in there by default | |
| 19:17:09 | mriedem | because of placement | |
| 19:17:51 | mriedem | idk, is DinaBelova around? | |
| 19:18:04 | Nisha_Agarwal | mriedem, even non-exact filters like RamFilter, CoreFilter, diskFilter are deprecated? | |
| 19:18:22 | mriedem | Nisha_Agarwal: those weren't deprecated, just removed from the default enabled_filters list for new installs | |
| 19:18:34 | mriedem | since they are redundant with placement | |
| 19:18:49 | Nisha_Agarwal | ok. that makes sense | |
| 19:19:28 | mtreinish | mriedem: if we need to keep it around I can switch nova over to stestr which would let us combine the results into a single subunit stream | |
| 19:19:40 | Nisha_Agarwal | but they are replaced with resource classes n schedulin still happen based on them | |
| 19:19:46 | mriedem | stestr is your testrepository fork? | |
| 19:19:59 | mtreinish | yeah | |
| 19:20:16 | mtreinish | we just switched ostestr over to use that internally which is how I found all of this | |
| 19:21:16 | mriedem | reading the note at the top of https://review.openstack.org/#/c/254703/60/nova/tests/unit/test_profiler.py i don't know if we could just make the osprofiler stuff run first or not | |
| 19:22:34 | mriedem | but whatever, if we need to combine results then yeah do whatever | |
| 19:23:10 | mtreinish | mriedem: I mean yeah we could swap the order too, you'd lose the capture on the osprofiler test, but that's much lower impact than losing all the unit tests | |
| 19:23:23 | mriedem | i don't care about the capture on that | |
| 19:23:30 | mriedem | but i'm not sure if swapping it causes problems | |
| 19:23:40 | mriedem | because it instruments the classes | |
| 19:24:12 | Nisha_Agarwal | mriedem, so if we want scheduling for non-exact filters we need the resource classes for disk/vcpus/ram in place | |
| 19:24:24 | Nisha_Agarwal | for ironic nodes too | |
| 19:24:42 | mtreinish | mriedem: it sholud be isolated between runs because python exits after the tests run | |
| 19:24:55 | mtreinish | things definitely fail if you run all the tests with OS_PROFILER set to true | |
| 19:25:18 | mriedem | Nisha_Agarwal: "if we want scheduling for non-exact filters" is the major question | |
| 19:25:33 | mriedem | and it's been my limited understanding that is not what people have wanted long-term | |
| 19:25:42 | Nisha_Agarwal | mriedem, Atleast thats done in customers env | |
| 19:26:10 | mriedem | i'm really not the best person to talk about this though, it was jroll before and dtantsur|afk now, plus people running ironic deployments | |
| 19:26:35 | mriedem | Nisha_Agarwal: it would be interesting to know how many operators are running w/o the exact filters | |
| 19:26:39 | mriedem | and why | |
| 19:26:43 | mriedem | like, in the operators ML | |
| 19:27:48 | Nisha_Agarwal | ironic team says nova should agree to make changes for all this then its fine to do corresponding changes in ironic | |
| 19:28:29 | Nisha_Agarwal | mriedem, i cannot get such list but i do know one customer atleast(cannot name the customer) who does have such env | |
| 19:28:44 | mriedem | Nisha_Agarwal: can you start a thread about this in the openstack-operators mailing list? | |
| 19:28:51 | Nisha_Agarwal | and they just have ironic nodes in their datacenter | |
| 19:29:01 | mriedem | tag it with [nova][ironic] | |
| 19:29:21 | Nisha_Agarwal | is it not our usual mailing list? | |
| 19:29:32 | mriedem | you could cross-post to the openstack-dev mailing list | |
| 19:29:43 | mriedem | but i'm mostly interested in hearing from ironic operators | |
| 19:30:25 | Nisha_Agarwal | ok. will just start a thread. Never wrote in this mailing list though :) | |
| 19:30:36 | mriedem | i have faith that you can do it | |
| 19:30:38 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Set regex flag on ostestr command for osprofiler tests https://review.openstack.org/501842 | |
| 19:30:43 | mtreinish | mriedem: ^^^ lets see if that does it | |
| 19:32:40 | mriedem | i will hold my breath in anticipation | |
| 19:33:02 | Nisha_Agarwal | mriedem, :) | |
| 19:36:58 | Nisha_Agarwal | mriedem, it would be good if you could suggest the subject for the mail....i dont know what to write actually | |
| 19:37:10 | Nisha_Agarwal | in the subject | |
| 19:37:14 | mriedem | hmm | |
| 19:37:15 | Nisha_Agarwal | body i can fill up | |
| 19:37:43 | mriedem | [nova][ironic] Concerns over rigid resource class-only ironic scheduling | |
| 19:37:43 | mriedem | ? | |
| 19:39:59 | Nisha_Agarwal | mriedem, looks good :) | |
| 19:42:08 | mriedem | stvnoyes: well looky here http://logs.openstack.org/05/501805/2/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/069e82e/console.html#_2017-09-07_17_45_00_706868 | |
| 19:45:46 | Nisha_Agarwal | mriedem, do i need to subscribe to openstack-operators@lists.openstack.org for sending an email? | |
| 19:45:51 | mriedem | yeah | |
| 19:45:55 | Nisha_Agarwal | ok | |
| 19:46:38 | mriedem | ildikov: why does https://review.openstack.org/#/c/330285/ need to depend on https://review.openstack.org/#/c/498828/ ? | |
| 19:47:50 | ildikov | mriedem: uWSGI changes in Cinder blew up | |
| 19:48:13 | mriedem | why would that matter here? | |
| 19:49:00 | Nisha_Agarwal | mriedem, i sent an email just now. if you would want to add to any thing to the body of the mail please add it. | |
| 19:49:44 | ildikov | mriedem: because the url wasn't working with the microversion checks in the client | |
| 19:50:02 | Nisha_Agarwal | mriedem, meanwhile i would open a blueprint at nova side or i should do it after responses on the email and probably after the PTG? | |
| 19:50:13 | Nisha_Agarwal | just asking | |
| 19:50:55 | ildikov | mriedem: smcginnis might be able to describe it in details | |
| 19:52:48 | smcginnis | Wha? | |
| 19:53:29 | smcginnis | Ah | |
| 19:53:53 | smcginnis | mriedem: There's an issue right now with the way the public endpoint is being set and how that works for microversions. | |
| 19:54:01 | smcginnis | So that needs to get fixed first. | |
| 19:56:24 | stvnoyes | mriedem: nice to see it pass. I also figured out why I put the change in the iscsi test. the other live migrate block test was skipped dur a bug. I just removed that skip decorator - https://review.openstack.org/#/c/501828/ . If you're OK with that, I'll add the new attach checks to that test too. | |
| 19:56:48 | stvnoyes | dur = 'due to' | |
| 19:57:28 | mriedem | Nisha_Agarwal: replied with some more details from our irc discussion | |
| 19:57:31 | mriedem | thanks for starting that thread | |
| 19:58:10 | mriedem | stvnoyes: probably less worthwhile to add things to a skipped test in tempest | |
| 19:58:24 | mriedem | fwiw this does test that volume-backed live migration test https://review.openstack.org/#/c/481290/ | |
| 19:58:34 | mriedem | because it depends on https://review.openstack.org/#/c/481346/ | |