| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-07 | |||
| 19:16:33 | mriedem | Nisha_Agarwal: yes it looks like if use_baremetal_filters is False, which is the default, it uses the normal enabled_filters | |
| 19:16:50 | Nisha_Agarwal | mriedem, yes thats true. ^^ | |
| 19:17:07 | mtreinish | mriedem: should I just drop that from the tox.ini? | |
| 19:17:07 | mriedem | and as of pike, enabled_filters no longer has ram/disk filters in there by default | |
| 19:17:09 | mriedem | because of placement | |
| 19:17:51 | mriedem | idk, is DinaBelova around? | |
| 19:18:04 | Nisha_Agarwal | mriedem, even non-exact filters like RamFilter, CoreFilter, diskFilter are deprecated? | |
| 19:18:22 | mriedem | Nisha_Agarwal: those weren't deprecated, just removed from the default enabled_filters list for new installs | |
| 19:18:34 | mriedem | since they are redundant with placement | |
| 19:18:49 | Nisha_Agarwal | ok. that makes sense | |
| 19:19:28 | mtreinish | mriedem: if we need to keep it around I can switch nova over to stestr which would let us combine the results into a single subunit stream | |
| 19:19:40 | Nisha_Agarwal | but they are replaced with resource classes n schedulin still happen based on them | |
| 19:19:46 | mriedem | stestr is your testrepository fork? | |
| 19:19:59 | mtreinish | yeah | |
| 19:20:16 | mtreinish | we just switched ostestr over to use that internally which is how I found all of this | |
| 19:21:16 | mriedem | reading the note at the top of https://review.openstack.org/#/c/254703/60/nova/tests/unit/test_profiler.py i don't know if we could just make the osprofiler stuff run first or not | |
| 19:22:34 | mriedem | but whatever, if we need to combine results then yeah do whatever | |
| 19:23:10 | mtreinish | mriedem: I mean yeah we could swap the order too, you'd lose the capture on the osprofiler test, but that's much lower impact than losing all the unit tests | |
| 19:23:23 | mriedem | i don't care about the capture on that | |
| 19:23:30 | mriedem | but i'm not sure if swapping it causes problems | |
| 19:23:40 | mriedem | because it instruments the classes | |
| 19:24:12 | Nisha_Agarwal | mriedem, so if we want scheduling for non-exact filters we need the resource classes for disk/vcpus/ram in place | |
| 19:24:24 | Nisha_Agarwal | for ironic nodes too | |
| 19:24:42 | mtreinish | mriedem: it sholud be isolated between runs because python exits after the tests run | |
| 19:24:55 | mtreinish | things definitely fail if you run all the tests with OS_PROFILER set to true | |
| 19:25:18 | mriedem | Nisha_Agarwal: "if we want scheduling for non-exact filters" is the major question | |
| 19:25:33 | mriedem | and it's been my limited understanding that is not what people have wanted long-term | |
| 19:25:42 | Nisha_Agarwal | mriedem, Atleast thats done in customers env | |
| 19:26:10 | mriedem | i'm really not the best person to talk about this though, it was jroll before and dtantsur|afk now, plus people running ironic deployments | |
| 19:26:35 | mriedem | Nisha_Agarwal: it would be interesting to know how many operators are running w/o the exact filters | |
| 19:26:39 | mriedem | and why | |
| 19:26:43 | mriedem | like, in the operators ML | |
| 19:27:48 | Nisha_Agarwal | ironic team says nova should agree to make changes for all this then its fine to do corresponding changes in ironic | |
| 19:28:29 | Nisha_Agarwal | mriedem, i cannot get such list but i do know one customer atleast(cannot name the customer) who does have such env | |
| 19:28:44 | mriedem | Nisha_Agarwal: can you start a thread about this in the openstack-operators mailing list? | |
| 19:28:51 | Nisha_Agarwal | and they just have ironic nodes in their datacenter | |
| 19:29:01 | mriedem | tag it with [nova][ironic] | |
| 19:29:21 | Nisha_Agarwal | is it not our usual mailing list? | |
| 19:29:32 | mriedem | you could cross-post to the openstack-dev mailing list | |
| 19:29:43 | mriedem | but i'm mostly interested in hearing from ironic operators | |
| 19:30:25 | Nisha_Agarwal | ok. will just start a thread. Never wrote in this mailing list though :) | |
| 19:30:36 | mriedem | i have faith that you can do it | |
| 19:30:38 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Set regex flag on ostestr command for osprofiler tests https://review.openstack.org/501842 | |
| 19:30:43 | mtreinish | mriedem: ^^^ lets see if that does it | |
| 19:32:40 | mriedem | i will hold my breath in anticipation | |
| 19:33:02 | Nisha_Agarwal | mriedem, :) | |
| 19:36:58 | Nisha_Agarwal | mriedem, it would be good if you could suggest the subject for the mail....i dont know what to write actually | |
| 19:37:10 | Nisha_Agarwal | in the subject | |
| 19:37:14 | mriedem | hmm | |
| 19:37:15 | Nisha_Agarwal | body i can fill up | |
| 19:37:43 | mriedem | [nova][ironic] Concerns over rigid resource class-only ironic scheduling | |
| 19:37:43 | mriedem | ? | |
| 19:39:59 | Nisha_Agarwal | mriedem, looks good :) | |
| 19:42:08 | mriedem | stvnoyes: well looky here http://logs.openstack.org/05/501805/2/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/069e82e/console.html#_2017-09-07_17_45_00_706868 | |
| 19:45:46 | Nisha_Agarwal | mriedem, do i need to subscribe to openstack-operators@lists.openstack.org for sending an email? | |
| 19:45:51 | mriedem | yeah | |
| 19:45:55 | Nisha_Agarwal | ok | |
| 19:46:38 | mriedem | ildikov: why does https://review.openstack.org/#/c/330285/ need to depend on https://review.openstack.org/#/c/498828/ ? | |
| 19:47:50 | ildikov | mriedem: uWSGI changes in Cinder blew up | |
| 19:48:13 | mriedem | why would that matter here? | |
| 19:49:00 | Nisha_Agarwal | mriedem, i sent an email just now. if you would want to add to any thing to the body of the mail please add it. | |
| 19:49:44 | ildikov | mriedem: because the url wasn't working with the microversion checks in the client | |
| 19:50:02 | Nisha_Agarwal | mriedem, meanwhile i would open a blueprint at nova side or i should do it after responses on the email and probably after the PTG? | |
| 19:50:13 | Nisha_Agarwal | just asking | |
| 19:50:55 | ildikov | mriedem: smcginnis might be able to describe it in details | |
| 19:52:48 | smcginnis | Wha? | |
| 19:53:29 | smcginnis | Ah | |
| 19:53:53 | smcginnis | mriedem: There's an issue right now with the way the public endpoint is being set and how that works for microversions. | |
| 19:54:01 | smcginnis | So that needs to get fixed first. | |
| 19:56:24 | stvnoyes | mriedem: nice to see it pass. I also figured out why I put the change in the iscsi test. the other live migrate block test was skipped dur a bug. I just removed that skip decorator - https://review.openstack.org/#/c/501828/ . If you're OK with that, I'll add the new attach checks to that test too. | |
| 19:56:48 | stvnoyes | dur = 'due to' | |
| 19:57:28 | mriedem | Nisha_Agarwal: replied with some more details from our irc discussion | |
| 19:57:31 | mriedem | thanks for starting that thread | |
| 19:58:10 | mriedem | stvnoyes: probably less worthwhile to add things to a skipped test in tempest | |
| 19:58:24 | mriedem | fwiw this does test that volume-backed live migration test https://review.openstack.org/#/c/481290/ | |
| 19:58:34 | mriedem | because it depends on https://review.openstack.org/#/c/481346/ | |
| 19:58:58 | Nisha_Agarwal | mriedem, thanks for the reply there | |
| 19:59:33 | stvnoyes | ah you already did it. ok I'll abandon my review since it does the same thing | |
| 19:59:50 | Nisha_Agarwal | mriedem, with respect to "eventually lead to scheduling failures later because of the scheduler thinking a node is available for more than one instance when it's really not." doesnt happen in the customer env where he uses non-exact filters | |
| 20:00:29 | mriedem | mtreinish: i'm +2 on your ostestr change, maybe you want to review this now https://review.openstack.org/#/c/498828/ | |
| 20:00:48 | Nisha_Agarwal | mriedem, the ironic node doesnt get scheduled again if use non-exact filters | |
| 20:02:34 | Nisha_Agarwal | atleast with this customer we have never heard of this issue | |
| 20:02:38 | mtreinish | mriedem: +2 | |
| 20:03:04 | mtreinish | although I wonder how much the tls-proxy is used now. As things move to use uwsgi the standalone proxy isn't used anymore | |
| 20:12:14 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add spec to use cinder's new attachment API https://review.openstack.org/497552 | |
| 20:16:22 | ildikov | mriedem: thanks ^^ | |
| 20:16:57 | mriedem | ildikov: johnthetubaguy found the same thing i did in https://review.openstack.org/#/c/493323/ | |
| 20:18:45 | ildikov | mriedem: I bumped the version for all the calls to 3.44 in the attach patch | |
| 20:19:50 | mriedem | that's not clear here, it wasn't called out in the commit message, and it would probably just be cleaner if we did it in this change | |
| 20:20:12 | ildikov | mriedem: I got lost on the newer version note in the review though | |
| 20:20:30 | mriedem | mine? | |
| 20:20:31 | ildikov | I was debating where to do it and thought to try to keep the patches clean | |
| 20:20:47 | mriedem | i noticed the skip_version_check=True thing, | |
| 20:20:55 | mriedem | which is wrong here, as i noted | |
| 20:21:20 | ildikov | because I haven't bumped all versions? | |
| 20:21:41 | mriedem | i'd just bump the version for attachment_create to be 3.44 as john pointed out, update whatever unit tests and make a comment about it in the commit message that we need the minimum microversion for creating the attachment to equal the microversoin needed for complete | |
| 20:21:57 | mnaser | abaranov https://review.openstack.org/#/c/501820/1 looks lik ethis failed somewhere along the line | |
| 20:22:05 | mnaser | it doesnt seem unrelated but does anyone know the bug # offhand | |
| 20:22:12 | ildikov | mriedem: that's what I planned to do | |
| 20:23:21 | mriedem | mnaser: unrelated, just recheck it | |