Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-30
18:54:47 cdent mriedem: left a query
18:54:53 mriedem http://json-schema.org/latest/json-schema-validation.html#rfc.section.6.12
18:55:17 mriedem oh minProperties
18:55:23 cdent the same question is coming up on the spec dansmith has prompted me to write (which is nearly ready)
18:57:48 mriedem cdent: replied
18:58:49 mriedem also means i can't really do the whole (1) provide recreate test patch then (2) provide fix
18:59:02 mriedem because (1) is essentially blocked
18:59:30 mriedem but that's not the end of the world
18:59:55 openstackgerrit Chris Dent proposed openstack/nova-specs master: Add a spec for POST /allocations in placement https://review.openstack.org/499259
19:00:04 cdent dansmith: at your service ^
19:00:19 cdent it’s got a fair few open questions on it, but I think they’ll resolve relatively quickly
19:00:24 dansmith wow, not even a WIP in front.. ballsy
19:01:18 cdent it should be fairly obivousl from the not just one but two entirely different body representations that it is a wip
19:01:36 cdent i’ll take that bug right now, mriedem
19:01:47 cdent unless you’ve already started?
19:02:22 mriedem it's yours
19:02:31 mriedem i have to get my hairs cut in <1 hour
19:03:24 cdent check
19:22:48 cfriesen_ mriedem: if you're still around, would the changes you're talking about doing for https://bugs.launchpad.net/nova/+bug/1427772 (with the claims in the scheduler) still handle the resources that aren't handled by Placement? (all the per-numa stuff, basically)
19:22:50 openstack Launchpad bug 1427772 in OpenStack Compute (nova) "Instance that uses force-host still needs to run some filters" [Low,Confirmed]
19:33:17 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Add test for empty resources in allocation https://review.openstack.org/499269
19:33:18 openstackgerrit Chris Dent proposed openstack/nova master: [placememnt] Require at least one resource class in allocation https://review.openstack.org/499270
19:33:26 cdent mriedem_away, dansmith ^^
19:47:44 openstackgerrit Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948
19:47:44 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
19:47:45 openstackgerrit Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
19:47:45 openstackgerrit Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947
20:27:25 openstackgerrit melanie witt proposed openstack/nova master: Save updated libvirt domain XML after swapping volume https://review.openstack.org/498983
20:52:36 openstackgerrit Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
21:00:27 cdent dansmith: i responded to your comments on that spec, but haven’t pushed a new version yet figured may as well wait for ed, matt, jay
21:01:43 dansmith sure
23:22:38 mriedem god the fix for this forced host evacuate allocation patch is going to be a biggun
23:22:46 mriedem 'uge
23:26:22 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/499389
23:28:39 openstackgerrit OpenStack Proposal Bot proposed openstack/os-traits master: Updated from global requirements https://review.openstack.org/495255
#openstack-nova - 2017-08-31
00:38:46 openstackgerrit Matt Riedemann proposed openstack/nova master: [placement] Require at least one resource class in allocation https://review.openstack.org/499270
00:45:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Create allocations against forced dest host during evacuate https://review.openstack.org/499399
00:52:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Document tagged attach in the feature support matrix https://review.openstack.org/498086
00:53:29 openstackgerrit Merged openstack/os-traits master: Updated from global requirements https://review.openstack.org/495255
01:43:37 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954
01:56:09 openstackgerrit Hesam Chobanlou proposed openstack/nova master: add online_data_migrations to nova docs adding cli documentation for online_data_migrations to clarify when the command is complete. https://review.openstack.org/493442
03:46:56 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/499389
06:01:47 openstackgerrit Merged openstack/nova master: [placement] Add test for empty resources in allocation https://review.openstack.org/499269
06:22:42 openstackgerrit Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
06:31:17 abhi89 hey guys.. can someone please review https://review.openstack.org/#/c/485121/
06:35:20 openstackgerrit jichenjc proposed openstack/nova master: check query param for used_limits function https://review.openstack.org/499091
06:57:26 openstackgerrit Kevin Zhao proposed openstack/nova master: Add video type virtio for AArch64 https://review.openstack.org/493822
07:00:42 openstackgerrit Merged openstack/nova master: [placement] Require at least one resource class in allocation https://review.openstack.org/499270
07:19:46 jichen alex_xu: have time to look at https://review.openstack.org/#/c/485121/ ? seems abhi89 is eager to get it merged and backport to older release
07:44:52 openstackgerrit Zhenyu Zheng proposed openstack/nova master: block_device_mapping_v2.bus_type is missing from api-ref https://review.openstack.org/499488
07:48:03 openstackgerrit Kevin Zhao proposed openstack/nova master: Make uefi as the default boot perproties for AArch64 https://review.openstack.org/489951
08:59:37 openstackgerrit Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399
09:21:17 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add VersionedObjectPrintable mixin https://review.openstack.org/493082
09:26:58 openstackgerrit jichenjc proposed openstack/nova master: Enhance doc for nova services https://review.openstack.org/499536
09:38:14 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159
09:38:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539
10:11:09 openstackgerrit Vladyslav Drok proposed openstack/nova master: Allow reschedules for ironic computes if one forced host specified https://review.openstack.org/499545
10:13:49 bauzas hello folks
10:13:58 bauzas back from traveling
10:19:22 gibi bauzas: hello! welcome back
10:20:07 bauzas gibi: congrats to you ;)
10:20:22 bauzas gibi: sorry, missed matt's email but was definitely +1 to you :)
10:20:49 bauzas now, I have a fun time to look at all the problems
10:20:53 openstackgerrit Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
10:22:41 gibi bauzas: thanks. :) We knew that you were off so no worries about the missing vote
10:24:31 bauzas looks like we have some problems with forcing a destination
10:25:47 gibi bauzas: yeah, that the finding of the week I guess :)
10:26:46 bauzas again, I'm sad
10:27:31 bauzas because I forgot to think about forced moves when I reviewing the scheduler allocations :(
10:28:47 gibi don't be hard on yourself none of us noticed this in that review
10:29:23 gibi on the plus side now we are creating an extensive set of functional tests that will cover these cases so the next modification of that claim code will be a lot safer to do
10:30:09 openstackgerrit Vladyslav Drok proposed openstack/nova master: Allow reschedules for ironic computes if one forced host specified https://review.openstack.org/499545
11:43:26 openstackgerrit Lajos Katona proposed openstack/nova master: Add functional migrate force_complete test https://review.openstack.org/496202
12:16:48 mriedem funny that we don't check if the host specified during an evacuate is the same host that the instance is already running on and fail with a 400 early in the api
12:17:16 openstackgerrit Bob Ball proposed openstack/nova master: XenAPI: Unit tests must mock os_xenapi calls https://review.openstack.org/499573
12:17:48 mriedem conductor would eventually fail with an rpc error probably but you don't get that information from the api, no fault is recorded, and the instance task_state is left in 'rebuilding'
12:19:31 gibi mriedem: could this be related to the bug https://bugs.launchpad.net/nova/+bug/1713783
12:19:32 openstack Launchpad bug 1713783 in OpenStack Compute (nova) "After failed evacuation the recovered source compute tries to delete the instance" [Undecided,New]
12:20:09 gibi mriedem: in that bug it seems that when the evacuation fails the migration object is not set to error statae
12:21:55 mriedem gibi: unrelated
12:23:28 mriedem https://bugs.launchpad.net/nova/+bug/1714235
12:23:28 openstack Launchpad bug 1714235 in OpenStack Compute (nova) "evacuate API does not restrict one from trying to evacuate to the source host" [Low,Confirmed]
12:23:30 openstackgerrit Eric Fried proposed openstack/nova master: Bump keystoneauth1 minimum to 3.2.0 https://review.openstack.org/499577
12:25:17 mriedem gibi: for that bug you pointed out, if the evacuate failed, the instance.host should still be pointed at the source host
12:25:48 mriedem we should only be removing the instance allocation for the source node if the instance.host != CONF.host
12:26:20 mriedem _destroy_evacuated_instances doesn't seem to take that into account
12:28:43 mriedem gibi: actually it looks like that's a recent regression https://review.openstack.org/#/c/491808/
12:32:16 mriedem maybe not, but it looks suspect
12:34:12 mriedem gibi: we could revert https://review.openstack.org/#/c/491808/ on top of https://review.openstack.org/#/c/498482/ and see what happens
12:36:05 gibi mriedem: thanks. I can try out the revert
12:38:51 efried sdague https://github.com/openstack/nova/blob/master/nova/cmd/status.py#L198 <== I can't see where we're checking for registered compute nodes in this method. Is this comment obsolete?
12:39:09 efried (or, more likely, am I missing something?)
12:39:29 gibi mriedem: hm, _destory_evacuated_instances does filter for the instance.host https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L638
12:40:21 mriedem that's finding the migrations
12:40:28 mriedem so it will find the migration that started from this source host
12:40:38 mriedem but that's not checking that the instance.host has changed to another host
12:40:40 gibi mriedem: ahh, yes, my bad
12:40:59 mriedem it's also weird that it's filtering on 'accepted' migrations, because that is set when the migration record is created in the api
12:41:00 openstackgerrit Lajos Katona proposed openstack/nova master: Add functional for live migrate delete https://review.openstack.org/499583
12:41:07 mriedem so the migration might not actually be done

Earlier   Later