Posted	Nick	Remark
#openstack-nova - 2017-08-31
00:38:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: [placement] Require at least one resource class in allocation https://review.openstack.org/499270
00:45:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Create allocations against forced dest host during evacuate https://review.openstack.org/499399
00:52:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: Document tagged attach in the feature support matrix https://review.openstack.org/498086
00:53:29	openstackgerrit	Merged openstack/os-traits master: Updated from global requirements https://review.openstack.org/495255
01:43:37	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954
01:56:09	openstackgerrit	Hesam Chobanlou proposed openstack/nova master: add online_data_migrations to nova docs adding cli documentation for online_data_migrations to clarify when the command is complete. https://review.openstack.org/493442
03:46:56	openstackgerrit	Merged openstack/nova master: Updated from global requirements https://review.openstack.org/499389
06:01:47	openstackgerrit	Merged openstack/nova master: [placement] Add test for empty resources in allocation https://review.openstack.org/499269
06:22:42	openstackgerrit	Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
06:31:17	abhi89	hey guys.. can someone please review https://review.openstack.org/#/c/485121/
06:35:20	openstackgerrit	jichenjc proposed openstack/nova master: check query param for used_limits function https://review.openstack.org/499091
06:57:26	openstackgerrit	Kevin Zhao proposed openstack/nova master: Add video type virtio for AArch64 https://review.openstack.org/493822
07:00:42	openstackgerrit	Merged openstack/nova master: [placement] Require at least one resource class in allocation https://review.openstack.org/499270
07:19:46	jichen	alex_xu: have time to look at https://review.openstack.org/#/c/485121/ ? seems abhi89 is eager to get it merged and backport to older release
07:44:52	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: block_device_mapping_v2.bus_type is missing from api-ref https://review.openstack.org/499488
07:48:03	openstackgerrit	Kevin Zhao proposed openstack/nova master: Make uefi as the default boot perproties for AArch64 https://review.openstack.org/489951
08:59:37	openstackgerrit	Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399
09:21:17	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add VersionedObjectPrintable mixin https://review.openstack.org/493082
09:26:58	openstackgerrit	jichenjc proposed openstack/nova master: Enhance doc for nova services https://review.openstack.org/499536
09:38:14	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159
09:38:15	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539
10:11:09	openstackgerrit	Vladyslav Drok proposed openstack/nova master: Allow reschedules for ironic computes if one forced host specified https://review.openstack.org/499545
10:13:49	bauzas	hello folks
10:13:58	bauzas	back from traveling
10:19:22	gibi	bauzas: hello! welcome back
10:20:07	bauzas	gibi: congrats to you ;)
10:20:22	bauzas	gibi: sorry, missed matt's email but was definitely +1 to you :)
10:20:49	bauzas	now, I have a fun time to look at all the problems
10:20:53	openstackgerrit	Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
10:22:41	gibi	bauzas: thanks. :) We knew that you were off so no worries about the missing vote
10:24:31	bauzas	looks like we have some problems with forcing a destination
10:25:47	gibi	bauzas: yeah, that the finding of the week I guess :)
10:26:46	bauzas	again, I'm sad
10:27:31	bauzas	because I forgot to think about forced moves when I reviewing the scheduler allocations :(
10:28:47	gibi	don't be hard on yourself none of us noticed this in that review
10:29:23	gibi	on the plus side now we are creating an extensive set of functional tests that will cover these cases so the next modification of that claim code will be a lot safer to do
10:30:09	openstackgerrit	Vladyslav Drok proposed openstack/nova master: Allow reschedules for ironic computes if one forced host specified https://review.openstack.org/499545
11:43:26	openstackgerrit	Lajos Katona proposed openstack/nova master: Add functional migrate force_complete test https://review.openstack.org/496202
12:16:48	mriedem	funny that we don't check if the host specified during an evacuate is the same host that the instance is already running on and fail with a 400 early in the api
12:17:16	openstackgerrit	Bob Ball proposed openstack/nova master: XenAPI: Unit tests must mock os_xenapi calls https://review.openstack.org/499573
12:17:48	mriedem	conductor would eventually fail with an rpc error probably but you don't get that information from the api, no fault is recorded, and the instance task_state is left in 'rebuilding'
12:19:31	gibi	mriedem: could this be related to the bug https://bugs.launchpad.net/nova/+bug/1713783
12:19:32	openstack	Launchpad bug 1713783 in OpenStack Compute (nova) "After failed evacuation the recovered source compute tries to delete the instance" [Undecided,New]
12:20:09	gibi	mriedem: in that bug it seems that when the evacuation fails the migration object is not set to error statae
12:21:55	mriedem	gibi: unrelated
12:23:28	mriedem	https://bugs.launchpad.net/nova/+bug/1714235
12:23:28	openstack	Launchpad bug 1714235 in OpenStack Compute (nova) "evacuate API does not restrict one from trying to evacuate to the source host" [Low,Confirmed]
12:23:30	openstackgerrit	Eric Fried proposed openstack/nova master: Bump keystoneauth1 minimum to 3.2.0 https://review.openstack.org/499577
12:25:17	mriedem	gibi: for that bug you pointed out, if the evacuate failed, the instance.host should still be pointed at the source host
12:25:48	mriedem	we should only be removing the instance allocation for the source node if the instance.host != CONF.host
12:26:20	mriedem	_destroy_evacuated_instances doesn't seem to take that into account
12:28:43	mriedem	gibi: actually it looks like that's a recent regression https://review.openstack.org/#/c/491808/
12:32:16	mriedem	maybe not, but it looks suspect
12:34:12	mriedem	gibi: we could revert https://review.openstack.org/#/c/491808/ on top of https://review.openstack.org/#/c/498482/ and see what happens
12:36:05	gibi	mriedem: thanks. I can try out the revert
12:38:51	efried	sdague https://github.com/openstack/nova/blob/master/nova/cmd/status.py#L198 <== I can't see where we're checking for registered compute nodes in this method. Is this comment obsolete?
12:39:09	efried	(or, more likely, am I missing something?)
12:39:29	gibi	mriedem: hm, _destory_evacuated_instances does filter for the instance.host https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L638
12:40:21	mriedem	that's finding the migrations
12:40:28	mriedem	so it will find the migration that started from this source host
12:40:38	mriedem	but that's not checking that the instance.host has changed to another host
12:40:40	gibi	mriedem: ahh, yes, my bad
12:40:59	mriedem	it's also weird that it's filtering on 'accepted' migrations, because that is set when the migration record is created in the api
12:41:00	openstackgerrit	Lajos Katona proposed openstack/nova master: Add functional for live migrate delete https://review.openstack.org/499583
12:41:07	mriedem	so the migration might not actually be done
12:41:41	gibi	mriedem: also the regression test shows that this migration never goes to error of failed state
12:41:48	gibi	mriedem: it remains in accepted state
12:42:02	mriedem	that was another question - how is the evacuate actually failing?
12:42:04	gibi	mriedem: here is the regression test https://review.openstack.org/#/c/498482/
12:42:07	mriedem	is it failing in conductor?
12:42:15	gibi	mriedem: scheduler fails to found a host
12:42:17	mriedem	ah
12:42:18	mriedem	yeah
12:43:14	gibi	mriedem: here is one way to solve this https://review.openstack.org/#/c/499237/1/nova/conductor/manager.py (still WIP)
12:44:58	mriedem	yeah that's pretty straight forward
12:45:21	gibi	mriedem: btw is there a doc about the possible migration status values? I found both error and failed in the code
12:45:22	mriedem	odd that we don't pass the migration record over rpc from api to conductor, but that would be a separate cleanup
12:45:32	mriedem	i don't think there is really
12:46:08	mriedem	i think takashi was cataloging some of that for his blueprint to list more than just in-progress live migrations out of the api
12:46:14	mriedem	so he was defining what 'in-progress' meant
12:46:36	gibi	mriedem: cool I fully support documenting the possible statuses
12:46:52	mriedem	some of it is in here https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/list-show-all-server-migration-types.html#proposed-change
12:46:53	bauzas	mriedem: when you say "asking to evacuate to the same host", do you imply using the force flag or not ?
12:47:05	mriedem	bauzas: sure
12:47:24	mriedem	if force=False, you'd get NoValidHost
12:47:28	mriedem	because of the ComputeFilter
12:47:34	bauzas	correct
12:47:35	mriedem	but if force=True, you'd bypass the scheduler
12:47:39	mriedem	and fail the rpc cast to compute
12:47:45	bauzas	but that's your fault
12:47:52	bauzas	you *forced*
12:48:30	mriedem	it just seems weird that we don't have that one line validation check in the api code
12:48:39	mriedem	if host and host == instance.host: raise 400
12:48:44	bauzas	that said, I think there is a call made by the API verifying if the destination is alive before we call the conductor
12:48:54	bauzas	for evacuate I mean
12:48:54	mriedem	bauzas: yes there is
12:48:56	mriedem	and that can pass
12:49:03	mriedem	and you can call conductor on the same host as instance.host
12:49:13	bauzas	wait
12:49:25	bauzas	ah, nevremind

Earlier   Later