| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-10 | |||
| 18:24:30 | mriedem | like https://review.openstack.org/#/c/491517/ | |
| 18:24:47 | sdague | I rebased that and stuck it on the end | |
| 18:25:01 | sdague | as it was in merge conflict, and I didn't want to generate more conflicts | |
| 18:25:03 | mriedem | alright i'm fine with following up at the end of the series | |
| 18:25:10 | sdague | ok, can do | |
| 18:25:19 | mriedem | melwitt: you want the +W ? | |
| 18:25:33 | openstackgerrit | Merged openstack/nova master: Add format_dom for PCI device addresses https://review.openstack.org/491822 | |
| 18:25:55 | melwitt | mriedem: hell yes I do | |
| 18:26:00 | sdague | I also tried to set expectations here - https://review.openstack.org/#/c/492124 how we really do need to think about docs reviews a bit differently than code reviews, especially because they are merge magnets | |
| 18:27:04 | sdague | yeh, it looks like we're at 3.5 hours hold to get check nodes | |
| 18:27:23 | cdent | mtreinish: you added the sendcl, do you remember why? https://review.openstack.org/#/c/459451/ | |
| 18:27:42 | melwitt | +Warthogged | |
| 18:27:42 | cdent | it looks like maybe you accidentally left it in | |
| 18:27:54 | cdent | after choosing a different approach | |
| 18:27:54 | sdague | melwitt: thanks | |
| 18:28:16 | sdague | ok, I'll work on follow up fix patch at top of stack | |
| 18:28:53 | mtreinish | cdent: my intent there was specifically for the non-glance case. If nova or others gets a chunked request we don't want it to blow up an invalid content length error | |
| 18:29:16 | mtreinish | so I wanted sendcl for the mod_proxy_uwsgi case so it would handle those requests properly | |
| 18:29:55 | mtreinish | none of the projects using that path should be taking large chunked uploads over the api (it's only nova, cinder, and placement) | |
| 18:30:28 | mriedem | oh no | |
| 18:31:28 | mriedem | sdague: you've just started two major new ML thread wars https://review.openstack.org/#/c/491834/3/doc/source/index.rst | |
| 18:31:38 | mriedem | sdague: crisis the first: you omitted CONTAINERS! | |
| 18:31:55 | mriedem | crisis the second: OpenSack is a new competing community of cloud hacky sack based software that will kill us all! | |
| 18:32:16 | sdague | mriedem: the only in tree container support is untested libvirt lxc, right? | |
| 18:32:21 | mriedem | virtuozzo | |
| 18:32:25 | sdague | oh, right | |
| 18:32:25 | mriedem | and lxc | |
| 18:32:35 | mriedem | but yes lxc is likely a floating turd | |
| 18:32:47 | mriedem | tried getting CI running for that several releases ago | |
| 18:32:47 | sdague | yeh, I debated it, someone else can tweak that | |
| 18:32:57 | sdague | my goals, make this page navigable | |
| 18:33:02 | mriedem | "limited container support" is probably ok | |
| 18:34:29 | mriedem | heh, nova-net! https://review.openstack.org/#/c/492105/2/doc/source/figures/nova-conf-xen-flat.png,unified | |
| 18:36:55 | sdague | yeh, there is all kinds of fun that came over with that import | |
| 18:38:02 | openstackgerrit | Ilya Popov proposed openstack/nova master: Tests: Add cleanup of 'instances' directory https://review.openstack.org/491589 | |
| 18:40:23 | mriedem | yeah, i finally know about the EMC system enabler https://review.openstack.org/#/c/492105/2/doc/source/figures/emc-enabler.png,unified | |
| 18:42:35 | mtreinish | cdent: looks like you're right the file is coming from mod_proxy | |
| 18:43:08 | mtreinish | I'll write up a patch to create an isolated virtual host for the glance apache endpoint and hopefully that should isolate the sendcl param | |
| 18:43:20 | openstackgerrit | Sean Dague proposed openstack/nova master: clean ups from I6815958b2533d462a2e5d27e7be57440d9f4f40a https://review.openstack.org/492645 | |
| 18:43:33 | sdague | mriedem / melwitt ^^^ ok, go to town ripping on that | |
| 18:43:43 | sdague | I'll iterate until we get it good enough | |
| 18:45:07 | melwitt | cool, thanks | |
| 18:55:22 | sdague | melwitt: on https://review.openstack.org/#/c/491853 realize that's just the import plus reference corrections to make it build | |
| 18:56:06 | melwitt | sdague: ah, I see that now. I thought the Cells v1 vs v2 warning was new but I see now that it's not | |
| 18:56:14 | sdague | yeh | |
| 18:56:46 | sdague | let us say... the existing docs are a mixed bag. It's probably better to have them in, but I think we're going to need a doc sprint early in the cycle to clean up a bunch of this | |
| 18:57:15 | melwitt | sdague: I think the only other thing not imported is the database config section that's not mentioned as skipped in the commit message. is that one supposed to be skipped? | |
| 18:57:39 | sdague | yeh, it turned into a really goofy thing | |
| 18:57:44 | melwitt | k | |
| 18:57:49 | sdague | let me pull up a couple of links | |
| 18:58:34 | sdague | the database doc in question was this - https://github.com/openstack/openstack-manuals/blob/6f9fc171800e8a435011f38cd4558e900884ce86/doc/config-reference/source/compute/database-connections.rst#L2 | |
| 18:59:04 | sdague | which besides being kind of inaccurate with the "any sqla" bit, it was also pretty vapid in what it said | |
| 18:59:37 | sdague | and was mostly a link to https://github.com/openstack/openstack-manuals/blob/6f9fc171800e8a435011f38cd4558e900884ce86/doc/config-reference/source/tables/common-database.rst#L11 | |
| 18:59:49 | melwitt | cool. just making sure it wasn't missed. I'm kind of just skimming this | |
| 18:59:56 | sdague | yeh | |
| 19:00:05 | sdague | the common tables things was kind of a bear | |
| 19:01:22 | sdague | steven spent a day or two fixing references, and I spent another day after him doing that. There was a lot more common normalization in the openstack-manuals repo that had to be denormalized for all of this. | |
| 19:03:03 | sdague | ok, afk for a bit | |
| 19:03:12 | mtreinish | efried_afk: https://review.openstack.org/#/c/492651/ | |
| 19:03:20 | mtreinish | sdague: ^^^ that should fix the glance thing | |
| 19:07:00 | mriedem | sdague: melwitt: ok several comments in the config reference one https://review.openstack.org/#/c/491853/6 | |
| 19:07:04 | mriedem | looks like some are duplicates of mel's | |
| 19:07:45 | melwitt | mriedem: yeah, turns out this is a straight forklift and I didn't realize that at first | |
| 19:07:54 | melwitt | so there's lots of latent issues in it | |
| 19:08:10 | mriedem | heh, | |
| 19:08:10 | mriedem | "The nova-conductor service is the only service that writes to the database." | |
| 19:08:20 | mriedem | "If nova-conductor is not used, entries to the database are mostly written by the nova-scheduler service, although all services must be able to update entries in the database." | |
| 19:08:27 | mriedem | ffs | |
| 19:08:30 | melwitt | noice | |
| 19:08:51 | mriedem | only conductor can write to the database, except everything else can and must be able to also, including your dog | |
| 19:08:55 | melwitt | o local conductor, I barely remember you | |
| 19:08:56 | mriedem | mr ruffles | |
| 19:09:21 | melwitt | heh | |
| 19:09:22 | mriedem | some of the other stuff i pointed out is just plain wrong, like "kvm is the default compute driver" | |
| 19:09:29 | mriedem | "to change compute drivers, configure the [libvirt] section" | |
| 19:09:41 | mriedem | hello libvirt, please to be giving me vmware | |
| 19:09:41 | mriedem | thanks | |
| 19:10:09 | melwitt | as you do | |
| 19:11:09 | mriedem | sdague: i think we should rename that cells.rst to cellsv1.rst at some point | |
| 19:11:14 | mriedem | since it's totally cellsv1 content | |
| 19:11:34 | mriedem | mikal: this is for you https://review.openstack.org/#/c/491853/6/doc/source/admin/configuration/samples/rootwrap.conf.rst@5 | |
| 19:19:23 | openstackgerrit | Ed Leafe proposed openstack/nova master: Deprecate bare metal filters https://review.openstack.org/492563 | |
| 19:20:26 | mnaser | jaypipes whenever you have a minute re https://review.openstack.org/#/c/491561/ -- i was thinking about this and realized that all_weighers will now include this which might mean that both ramweigher and rampercentageweigher would both be used (and maybe that might cause some weird scheduling and a change in default behaviour) .. any thoughts (more than welcome anyone else input too) | |
| 19:21:14 | jaypipes | mnaser: hmm... | |
| 19:21:26 | mriedem | ok the other rc1 things are approved, that just leaves https://review.openstack.org/#/c/487954/ | |
| 19:21:52 | jaypipes | mnaser: yeah, that's a good point. keep it in the separate file then... | |
| 19:22:08 | jaypipes | mnaser: mb add a note to the top saying "this is a separate file because..." | |
| 19:22:23 | mnaser | jaypipes i think that even if its a separate file it'll automatically get included with all_weighers :X | |
| 19:22:32 | mnaser | let me find the code for that again | |
| 19:22:43 | mnaser | if i remember right, its not hard coded, used some loadable stuff to autoload all of the stuff in the folder | |
| 19:23:37 | mnaser | https://github.com/openstack/nova/blob/master/nova/scheduler/weights/__init__.py#L46-L48 => https://github.com/openstack/nova/blob/master/nova/loadables.py#L78-L96 | |
| 19:24:30 | jaypipes | mnaser: ugh... | |
| 19:24:31 | mnaser | the reason this test didnt catch it because it doesnt check for an exact match but "if it contains" https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/weights/test_weights_hosts.py | |
| 19:24:37 | mnaser | yeah.. its not pretty | |
| 19:25:25 | jaypipes | mnaser: well, even if it's included in the list of filters, that doesn't necessarily mean it's enabled, right? | |
| 19:25:41 | mnaser | jaypipes this is weigher and afaik there is no enabled or disabled | |
| 19:26:42 | mnaser | jaypipes ouch.. "but wait, there's more" - https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L389-L394 | |
| 19:26:48 | mnaser | we couldnt even drop it from all_weighers lol | |
| 19:27:43 | mriedem | weighers are all enabled by default | |
| 19:27:57 | efried | mtreinish Sweet, trying... | |