| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-10 | |||
| 19:22:32 | mnaser | let me find the code for that again | |
| 19:22:43 | mnaser | if i remember right, its not hard coded, used some loadable stuff to autoload all of the stuff in the folder | |
| 19:23:37 | mnaser | https://github.com/openstack/nova/blob/master/nova/scheduler/weights/__init__.py#L46-L48 => https://github.com/openstack/nova/blob/master/nova/loadables.py#L78-L96 | |
| 19:24:30 | jaypipes | mnaser: ugh... | |
| 19:24:31 | mnaser | the reason this test didnt catch it because it doesnt check for an exact match but "if it contains" https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/weights/test_weights_hosts.py | |
| 19:24:37 | mnaser | yeah.. its not pretty | |
| 19:25:25 | jaypipes | mnaser: well, even if it's included in the list of filters, that doesn't necessarily mean it's enabled, right? | |
| 19:25:41 | mnaser | jaypipes this is weigher and afaik there is no enabled or disabled | |
| 19:26:42 | mnaser | jaypipes ouch.. "but wait, there's more" - https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L389-L394 | |
| 19:26:48 | mnaser | we couldnt even drop it from all_weighers lol | |
| 19:27:43 | mriedem | weighers are all enabled by default | |
| 19:27:57 | efried | mtreinish Sweet, trying... | |
| 19:28:11 | mriedem | mnaser: you can't set weight_classes ? | |
| 19:28:17 | mriedem | default=["nova.scheduler.weights.all_weighers"], | |
| 19:28:39 | mriedem | mnaser: you should be able to specify the specific list of weighers if you want to exclude some | |
| 19:28:46 | jaypipes | mnaser: yeah, you'd essentially have to list all the other weight classes, minus RamWeigher, and add in RamPercentageWeigher. ugh. | |
| 19:28:51 | mnaser | mriedem - i could, but the idea is when introducing this change -- https://review.openstack.org/#/c/491561/ -- that weigher will become included with the list of default all_weighers | |
| 19:29:05 | mnaser | i have them manually listed and it works fine for me right now | |
| 19:29:08 | mriedem | so you want an excluded_weighers option | |
| 19:29:27 | mriedem | how about, included_by_conditional_on_virt_backend_weighers? :) | |
| 19:29:33 | mriedem | s/by/but./ | |
| 19:29:36 | mnaser | i dont need it, i can manually list it, but if that change merges, the behaviour of all_weighers will change .. which is probably not okay? | |
| 19:29:53 | jaypipes | mriedem: no, he needs to change the behaviour of the existing RamWeigher if, say, a [scheduler]ram_weight_use_percentage configuration option is set... | |
| 19:30:16 | mriedem | ok, so you need a config option to change the behavior of the existing ram weigher, | |
| 19:30:19 | jaypipes | mnaser: right, it's not ok, since both Ram weighers will produce different weights. | |
| 19:30:20 | mriedem | and default it to behave the old way | |
| 19:30:25 | mnaser | thats a good idea | |
| 19:30:29 | jaypipes | yeah | |
| 19:30:30 | mnaser | i can do that | |
| 19:30:35 | mriedem | $5 please | |
| 19:30:37 | jaypipes | mnaser: thanks man. :) | |
| 19:30:56 | mnaser | jaypipes np | |
| 19:31:02 | mnaser | mriedem i'll start a tab | |
| 19:31:24 | mriedem | speaking of, | |
| 19:31:40 | mriedem | craiglist person is coming over in an hour to buy a $10 kids wagon, emailed me asking if i have change for a $20 | |
| 19:31:45 | mriedem | this will be fun | |
| 19:31:59 | mriedem | "i do, if you're ok with singles and $1 coins" | |
| 19:32:06 | mriedem | "here is a bag of nickels" | |
| 19:32:18 | melwitt | mriedem: anything else need review for rc1 that I can look at? | |
| 19:32:29 | mriedem | melwitt: hell yes you can https://review.openstack.org/#/c/487954/ | |
| 19:32:44 | melwitt | sweet | |
| 19:41:06 | sdague | mriedem: I agree. I honestly think we should probably rename all the cells v1 stuff to legacy cells actually | |
| 19:41:31 | sdague | especially when dealing with bugs, people don't really understand the v1 v2 thing | |
| 19:41:46 | sdague | legacy cells vs. cells would probably make things clearer | |
| 19:43:09 | sdague | mriedem: can we get ironic folks voting on https://review.openstack.org/#/c/487954 | |
| 19:44:25 | bauzas | do I need to chime in somewhere? | |
| 19:45:10 | sdague | bauzas: I think 487954 is the last patch required for the branch | |
| 19:47:22 | mriedem | sdague: they were ok with one of the earlier patch sets | |
| 19:47:26 | mriedem | dtantsur|afk: is ok with it i think | |
| 19:49:05 | bauzas | sdague: a bit latey for the gate, nope? | |
| 19:49:23 | bauzas | unless mriedem is a night owl | |
| 19:50:08 | mriedem | bauzas: i'll be up | |
| 19:51:10 | sdague | we apparently got more rax nodes too a couple hours ago as well, so we're actually starting to burn down the wait queue | |
| 19:51:13 | sdague | which is good | |
| 19:51:22 | sdague | at least its not still growing :) | |
| 19:51:53 | bauzas | cool :) | |
| 20:22:19 | mriedem | melwitt: are you still going through https://review.openstack.org/#/c/487954/ ? | |
| 20:22:48 | melwitt | mriedem: yes, going through the tests, trying to understand what "dupe" means and how the first dupe test is different from the second | |
| 20:26:24 | sdague | oof, citycloud lon1 fail again | |
| 20:26:34 | edleafe | melwitt: the first verifies that only one call to save is made, since one instance already has been migrated | |
| 20:26:57 | mnaser | 2017-08-10 20:24:19.406877 | MAGNUM_GUEST_IMAGE_URL='\''http://mirror.mtl01.internap.openstack.org/fedora/atomic/stable/Fedora-Atomic-26-20170723.0/CloudImages/x86_64/images/Fedora-Atomic-26-20170723.0.x86_64.qcow2'\'' | |
| 20:27:06 | mnaser | oops, wrong chan | |
| 20:27:16 | edleafe | the second verifies that if refresh_cache is called a second time, the instances are not saved again | |
| 20:27:31 | melwitt | thanks edleafe | |
| 20:27:57 | edleafe | it has some old code in that second call - I'm correcting that from _refresh_hash_ring() to _refresh_cache() | |
| 20:31:32 | mriedem | sdague: per gmann's doc change, i don't see where this stable api doc is even linked from http://docs-draft.openstack.org/26/489926/9/check/gate-nova-docs-ubuntu-xenial/24e8cc4//doc/build/html/reference/stable-api.html | |
| 20:32:31 | mriedem | like https://developer.openstack.org/api-guide/compute/ | |
| 20:32:46 | mriedem | or http://docs-draft.openstack.org/26/489926/9/check/gate-nova-docs-ubuntu-xenial/24e8cc4//doc/build/html/contributor/index.html#the-nova-api | |
| 20:33:05 | sdague | reference/index | |
| 20:33:20 | sdague | http://docs-draft.openstack.org/26/489926/9/check/gate-nova-docs-ubuntu-xenial/24e8cc4//doc/build/html/reference/index.html | |
| 20:34:00 | mriedem | oh | |
| 20:34:03 | mriedem | sheesh | |
| 20:34:04 | sdague | from the reorged page it would be index -> Technical Reference Deep Dives | |
| 20:34:18 | sdague | -> Nova Stable REST API | |
| 20:34:39 | mriedem | yeah... | |
| 20:34:43 | mriedem | that was a hunt | |
| 20:35:28 | sdague | yeh, we're going to need a slice of time to figure out what the right information architecture is for all this stuff is at PTG | |
| 20:35:43 | sdague | this first stage grouping was just that, a first stage grouping, without creating *more* 404s | |
| 20:37:28 | sdague | so, the contributor and reference consolidations were first, and I made sub pages for them. But the admin subpage was already claimed as the main url for the admin guide, so I inlined the equivalent user / admin chunks into the top index page | |
| 20:37:49 | sdague | it might be good to unwind all of that for the contributor / reference pages | |
| 20:38:09 | sdague | so you get there without the intermediate hop | |
| 20:39:11 | sdague | I also think we might be able to use refs in the toctree and get something more sane out of all of that | |
| 20:41:33 | openstackgerrit | Ed Leafe proposed openstack/nova master: Handle addition of new nodes/instances in ironic flavor migration https://review.openstack.org/487954 | |
| 20:41:57 | efried | mtreinish With your fix I did indeed hit https://bugs.launchpad.net/glance/+bug/1703856 | |
| 20:41:58 | openstack | Launchpad bug 1703856 in Glance "502 Bad gateway error on image-create" [High,Confirmed] | |
| 20:45:46 | efried | mtreinish ...and so did the gate. | |
| 20:46:59 | edleafe | mriedem: melwitt: ^^ addressed your comments (and your terrible taste in indentation) | |
| 20:47:16 | melwitt | hah | |
| 20:48:35 | melwitt | +2, looks cool to me | |
| 20:49:41 | melwitt | thanks for changing those test names, makes it a lot clearer to someone not in-the-know | |
| 20:51:39 | edleafe | melwitt: yeah, well, they went through a bunch of back-and-forth as people had different opinions on how the migration should work. | |
| 20:57:47 | openstackgerrit | Merged openstack/nova master: update policy UT fixtures https://review.openstack.org/398610 | |
| 20:58:28 | openstackgerrit | Merged openstack/nova master: Require Placement 1.10 in nova-status upgrade check https://review.openstack.org/492234 | |
| 20:59:09 | openstackgerrit | Merged openstack/nova master: Add For Operators section to front page https://review.openstack.org/491815 | |
| 20:59:51 | mikal | mriedem: replying now | |
| 20:59:53 | openstackgerrit | Merged openstack/nova master: rework index intro to describe nova https://review.openstack.org/491834 | |
| 21:00:37 | openstackgerrit | Merged openstack/nova master: Bulk import all config reference figures https://review.openstack.org/492105 | |
| 21:01:20 | mriedem | if i work from home, and your dog next to my house barks non-stop for 30+ minutes, | |
| 21:01:23 | mriedem | i should be able to do something bad | |
| 21:02:06 | openstackgerrit | Merged openstack/nova master: nova-manage: Deprecate '--version' parameters https://review.openstack.org/453808 | |