Posted	Nick	Remark
#openstack-nova - 2017-08-08
19:43:28	mriedem	not disable
19:43:43	mriedem	force-down is what the api will check for is_up
19:43:44	dansmith	will force down trigger a local delete?
19:43:45	melwitt	but the code you linked to was doing a disable
19:43:52	melwitt	gah
19:44:07	melwitt	okay, lemme look at force-down then
19:44:54	dansmith	ah yeah it will work
19:45:01	dansmith	service_is_up() checks it and that's what api is using
19:45:18	dansmith	you should kill the service first though,
19:45:25	melwitt	sweet
19:45:26	dansmith	to make sure you're not running periodics I think
19:45:34	melwitt	thanks yall
19:45:53	mriedem	let me -1 quick
19:45:54	mriedem	for points
19:46:08	melwitt	and to mess up jaypipes stats
19:48:27	mriedem	melwitt: https://review.openstack.org/#/c/470578/3/nova/tests/functional/regressions/test_bug_1679750.py@31 was confusing
19:48:36	mriedem	i said force down and then linked to gibi's thing which was disable
19:48:41	mriedem	i guess i meant the same PUT /os-services API
19:48:47	mriedem	it was an exercise for the reader
19:49:18	melwitt	yeah, I got too excited about it and didn't put two and two together
19:49:34	mriedem	well this is exciting stuff
19:50:10	melwitt	yeah it is
19:50:34	mriedem	ok here comes the placement scheduler interaction thingy
19:50:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Mark max microversion for Pike in history doc https://review.openstack.org/491581
19:50:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add release note for shared storage known issue https://review.openstack.org/491582
19:50:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add a prelude section for Pike https://review.openstack.org/491424
19:50:40	openstackgerrit	Matt Riedemann proposed openstack/nova master: doc: provide more details on scheduling with placement https://review.openstack.org/491900
20:00:24	openstackgerrit	melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578
20:00:50	melwitt	gdi left a commented out line
20:01:55	openstackgerrit	melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578
20:05:38	openstackgerrit	Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
20:06:43	openstackgerrit	Matt Riedemann proposed openstack/nova master: Mark max microversion for Pike in history doc https://review.openstack.org/491581
20:06:43	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add release note for shared storage known issue https://review.openstack.org/491582
20:06:44	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add a prelude section for Pike https://review.openstack.org/491424
20:13:10	openstackgerrit	Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408
20:32:39	openstackgerrit	melanie witt proposed openstack/nova master: Document service layout for consoles with cells https://review.openstack.org/491914
20:34:59	melwitt	mriedem: consoles doc ^
20:35:54	mriedem	cool
20:50:33	openstackgerrit	Sean Dague proposed openstack/nova master: doc: Import configuration reference https://review.openstack.org/491853
20:51:55	sdague	mriedem / melwitt can we get some doc reviews on https://review.openstack.org/#/c/491834/ and stack, that gets our docs landing page in a pretty reasonable state
20:52:11	sdague	all those extra config reference imports are going to be a bear to get sorted
20:52:45	sdague	I'll keep plugging on 491853 but I expect that's at least all of my tomorrow if not more to get it sorted
20:58:09	cdent	jaypipes: I reviewed your stack, got stuck a bit on the last one. And I went through mriedem’s release note stack. Is there other major stuff pending?
20:58:19	jaypipes	cdent: already responded :)
20:58:26	jaypipes	cdent: upi
20:58:30	jaypipes	guh
20:58:43	jaypipes	cdent: have you reviewed the func tests for local delete?
20:58:47	jaypipes	https://review.openstack.org/#/c/470578/4//COMMIT_MSG
20:58:58	jaypipes	from melwitt
20:58:58	mriedem	https://review.openstack.org/#/c/470578/
20:59:08	mriedem	yes he did
20:59:11	cdent	jaypipes: yes
20:59:13	jaypipes	k
20:59:23	mriedem	jaypipes: you should send that home
20:59:26	cdent	jaypipes: my point on the continue is that you’ve removed a continue
20:59:35	cdent	but that it doesn’t matter
20:59:40	jaypipes	cdent: oh, gotcha...
20:59:46	cdent	so neither continue should really be there
20:59:54	cdent	or something… not sure what?
20:59:59	jaypipes	cdent: yeah, it's just a placeholder, sorry... rebase merge conflict mistake really
21:00:18	cdent	I understood the coment was pretty much a *throws hands up*
21:00:42	jaypipes	cdent: indeed.
21:00:48	cdent	fun fun
21:01:19	cdent	i’ll pass through everything again in the morning, and do my morning recheck rituatls
21:01:27	cdent	otherwise: good night all, good luck
21:01:41	jaypipes	k, thx cdent
21:02:28	mriedem	jaypipes: what's the -1 for specifically? https://review.openstack.org/#/c/491900/
21:02:49	jaypipes	melwitt: glad you liked my old-man-joke about the HamburgerHelperFixture yesterday. :)
21:03:11	melwitt	heh
21:04:08	jaypipes	mriedem: that cell comment...
21:04:17	mriedem	jaypipes: i replied
21:04:23	mriedem	i think you misunderstood
21:04:25	jaypipes	mriedem: as a user doc, I don't think that's helpful.
21:04:40	mriedem	it's for an operator
21:04:50	mriedem	the compute nodes live in the cells
21:05:02	mriedem	not sure how that's less appropriate than talking about host UUIDs
21:05:25	sdague	jaypipes: pay no attention to the directory structures on the docs, a bunch landed in probably the wrong place
21:05:51	sdague	https://review.openstack.org/#/c/491815/ tries to reorganize and clarify without generating any new 404s
21:05:53	jaypipes	mriedem: k, will update shortly. sorry, on call with kevinbenton :(
21:06:06	mriedem	gd kevinbenton
21:06:06	jaypipes	kevinbenton: welcome to that bus.
21:22:47	openstackgerrit	Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
21:38:46	kevinbenton	mriedem: sorry about that. jaypipes just wanted to have a sync-up call to tell me how terrible Nova is being managed by the PTL
21:40:38	dansmith	ouch
21:43:01	clarkb	kevinbenton: did you tell him its not too late to run for ptl?
21:43:36	kevinbenton	clarkb: :)
21:43:50	mikal	All right you lot, stop talking and release pike so I can go and break libvirt in queens.
21:43:56	mikal	Less talky, more shippy.
21:43:59	kevinbenton	something about no point in changing the captain of the titanic now :)
21:44:07	clarkb	mikal: red hat already broke libvirt do we have to break it again?
21:44:23	mikal	clarkb: if we break it enought it might just loop around to working again
21:44:35	clarkb	(if you haven't heard rhel 7.4 has libvirt 3.2 which is not compatible with our stable branch libvirt-python constraint)
21:45:01	mikal	In other news, whoever wrote code that said "sudo rm -rf <<path>>" needs to be kicked in the shins
21:56:38	cfriesen	mikal: only in the shins?
21:58:23	melwitt	I think he's just giving everyone a chance to get kicked
22:06:57	mikal	Heh
22:07:22	mikal	We have so much crap code around rootwrap. Its embarrassing.
22:21:21	openstackgerrit	melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578
22:54:37	openstackgerrit	Merged openstack/nova master: Fix the log information argument mistake https://review.openstack.org/478792
23:00:29	openstackgerrit	Merged openstack/nova master: Create For End Users index section https://review.openstack.org/491785

Earlier   Later