Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-26
15:12:09 dansmith sdague hasn't said anything in a few minutes, may be very confused
15:12:40 mriedem i just left a comment that it might be good to mention the reschedule thing,
15:12:45 mriedem if you're doing tiered and multiple computes
15:14:07 bauzas mriedem: 11 comments in https://review.openstack.org/#/c/485435/6 but only 2 I care
15:14:53 bauzas mriedem: tl;dr should we mention in the relnote that nova wouldn't support disabling non-compute services, and why should we having two different representative strings for a service object?
15:15:03 sdague dansmith: sorry, I was writing a patch
15:15:11 sdague I can do a hangout as well
15:15:37 sdague dansmith: I was thinking, change the devstack setup to this https://review.openstack.org/487478
15:16:05 sdague because as much as I don't like this mode switch, I like it even less if there are 2 different ways to do it
15:16:19 dansmith sdague: we have to fix grenade for that first
15:16:24 sdague dansmith: yep
15:16:29 sdague working on that patch right now
15:16:39 dansmith sdague: agreed about the two ways, I was just trying to unbreak the ironic people quickly
15:17:14 dansmith vdrok: following?
15:17:37 vdrok reading
15:18:02 dansmith vdrok: basically, sdague hates it when I play with his toys
15:19:03 mriedem here is the 2-cell goody btw https://review.openstack.org/487479
15:19:36 dansmith mriedem: that's just going to put all the nodes into the same cell again right?
15:20:02 dansmith you need to set CPU_CELL=$node_number or something
15:20:36 dansmith this will just end up with an empty cell1, which is cool, but not much different from what we're already doing, AFAICT
15:21:19 vdrok dansmith: so basically CELLSV2_SETUP=singleconductor instead of NOVA_CELLS_TIER=False?
15:21:26 dansmith vdrok: yes
15:21:27 mriedem vdrok: yes
15:21:34 mriedem dansmith: i'd have to set that from like devstack-gate right?
15:21:41 dansmith mriedem: something yeah
15:21:43 mriedem since devstack doesn't know which subnode it is
15:21:44 mriedem ok
15:21:45 dansmith right
15:21:56 openstackgerrit Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566
15:21:57 openstackgerrit Jay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations() https://review.openstack.org/487483
15:21:58 jaypipes alex_xu, cdent, mriedem, dansmith: ok, added protection against DBDeadlock (separate patch) and cleaned up the one conditional with unit tests that alex_xu pointed out. ^^
15:22:08 jaypipes and rebased to master that cdent wanted...
15:22:10 dansmith mriedem: I should have kept quiet and had you be amazed and impressed at no more failures with your patch :P
15:22:19 vdrok mriedem: dansmith hrm, so doing it in devstack/settings won't work? OK, will add to devstack-gate
15:22:24 cdent jaypipes: cool, will look asap
15:22:30 vdrok smth like https://review.openstack.org/#/c/487458/1/devstack/settings
15:24:45 mriedem jaypipes: questions in the bottom change
15:24:59 dansmith vdrok: I think what you have will work right?
15:25:10 dansmith vdrok: as long as it gets loaded before the other stuff runs
15:25:35 vdrok dansmith: I think so, yes, it should run before nova
15:25:39 mriedem what he has should work, unless we don't go with that patch and instead go with seans
15:26:32 jaypipes mriedem: answered.
15:26:45 vdrok ok, then I'm waiting for your decision for now
15:28:08 sdague mriedem: reved - https://review.openstack.org/487478
15:28:15 mriedem vdrok: like this? http://wac.450f.edgecastcdn.net/80450F/k99.com/files/2013/02/Bachelor-630x419.jpg
15:28:35 vdrok :)
15:29:23 sdague honestly, this makes the grenade code make more sense as well (assuming it all works)
15:29:26 mriedem so many patches to choose from
15:29:36 sdague https://review.openstack.org/#/c/487485/1/projects/60_nova/from-ocata/upgrade-nova
15:31:00 mriedem jaypipes: "Jesus, you're quick."
15:31:06 mriedem you did tell us to review immediately you know :)
15:32:18 efried jaypipes mriedem johnthetubaguy (mordred) https://review.openstack.org/487471 is in support of bp/use-service-catalog-for-endpoints. Should be the last blocker.
15:32:49 mriedem efried: why doesn't that ust go into the change that uses it?
15:38:22 dansmith vdrok: we're doing sdague's I just mean that approach will work
15:39:21 openstackgerrit Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566
15:39:22 openstackgerrit Jay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations() https://review.openstack.org/487483
15:39:41 efried mriedem Daaahhh, I could do that.
15:39:48 jaypipes cdent, mriedem: fixed docstring. sorry, was a copy-paste from the _check_capacity_exceeded() function
15:39:54 openstackgerrit Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265
15:40:31 jaypipes cdent: I'd prefer to not sprinkle the retryondeadlock decorator around willy-nilly. prefer to apply it only where needed.
15:41:08 cdent jaypipes: that’s the root of my question: how do we know, other than when we get a random boom, that a place needs it?
15:42:21 mriedem cdent: we don't
15:42:28 cdent groovy
15:42:31 mriedem but we've tried not to use it if possible within nova
15:42:33 mriedem as a crux
15:44:06 dansmith jaypipes: mriedem: I don't love the "gardening" in that dbdeadlock patch
15:44:42 dansmith the docstring and dead code removal could be separate.. just seems confusing down the road to have something serious like a dbdeadlock mitigation with some random things
15:44:43 jaypipes dansmith: you mean me fixing up the docstring and removing the useless line of code?
15:44:54 jaypipes dansmith: yeah, I was on the fencer.
15:45:15 dansmith jaypipes: yeah, separate those cleanups from the dbdeadlock thing, IMHO
15:45:22 jaypipes ok
15:45:31 mriedem bauzas: replied to everything in https://review.openstack.org/#/c/485435/
15:45:32 dansmith jaypipes: I'll oil up my +2ing finger to get ready
15:45:54 mriedem gross
15:48:53 vdrok dansmith: gotcha, updating
15:50:02 mriedem wow crux?
15:50:03 mriedem crutch
15:50:39 openstackgerrit Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566
15:50:39 openstackgerrit Jay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations() https://review.openstack.org/487483
15:50:39 cdent mriedem: I automagically translated that. I have that functionality built in because otherwise I wouldn’t be able to read myself.
15:50:40 openstackgerrit Jay Pipes proposed openstack/nova master: docstring and unused code removal https://review.openstack.org/487492
15:50:42 jaypipes mriedem, dansmith: done
15:52:02 dansmith jaypipes: and done
15:53:35 sdague mriedem: you probably just typoed horcrux
15:53:48 jaypipes dansmith: and now I'm all oily. thanks a lot.
15:54:02 dansmith jaypipes: you know you'd prefer that over the alternative
15:54:11 openstackgerrit Chris Dent proposed openstack/nova master: remove un-necessary update() in _init_compute_node of rt https://review.openstack.org/483506
15:54:28 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: match exact hypervisor hostnames where applicable https://review.openstack.org/487494
15:55:01 sdague ok, I'm about to walk afk for a bit. https://review.openstack.org/#/c/487478/ hasn't blown up yet. I approved the grenade thing it depends on, because that can't hurt anything. But it's going to be another hour + to get results
15:55:42 jaypipes dansmith: eww.
15:55:45 jaypipes :)
15:59:03 kashyap If anyone has a few minutes, a self-containted change that fixes a performance issue post-migration: https://review.openstack.org/#/c/485752/ -- "libvirt: Post-migration, set cache value for Cinder volume(s)"
15:59:31 openstackgerrit Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance https://review.openstack.org/487495
15:59:33 kashyap Unit tests -- fixed; Jenkins -- succeeds. And the reporter has confirmed the fix resolves the I/O latency issue.
16:02:24 bauzas oh man, I totally missed the IronicHostState.uuid thing
16:02:39 bauzas jaypipes: mriedem: I really apologize for having missed ^ that
16:03:12 bauzas and yeah, most of the problems we have with ironic scheduling is because of the fact we have a different hoststate model :(
16:03:22 bauzas I knew that but I forgot to tell you
16:03:25 bauzas graaah
16:07:20 jaypipes bauzas: no worries man

Earlier   Later