Posted	Nick	Remark
#openstack-nova - 2017-07-26
15:31:06	mriedem	you did tell us to review immediately you know :)
15:32:18	efried	jaypipes mriedem johnthetubaguy (mordred) https://review.openstack.org/487471 is in support of bp/use-service-catalog-for-endpoints. Should be the last blocker.
15:32:49	mriedem	efried: why doesn't that ust go into the change that uses it?
15:38:22	dansmith	vdrok: we're doing sdague's I just mean that approach will work
15:39:21	openstackgerrit	Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566
15:39:22	openstackgerrit	Jay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations() https://review.openstack.org/487483
15:39:41	efried	mriedem Daaahhh, I could do that.
15:39:48	jaypipes	cdent, mriedem: fixed docstring. sorry, was a copy-paste from the _check_capacity_exceeded() function
15:39:54	openstackgerrit	Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265
15:40:31	jaypipes	cdent: I'd prefer to not sprinkle the retryondeadlock decorator around willy-nilly. prefer to apply it only where needed.
15:41:08	cdent	jaypipes: that’s the root of my question: how do we know, other than when we get a random boom, that a place needs it?
15:42:21	mriedem	cdent: we don't
15:42:28	cdent	groovy
15:42:31	mriedem	but we've tried not to use it if possible within nova
15:42:33	mriedem	as a crux
15:44:06	dansmith	jaypipes: mriedem: I don't love the "gardening" in that dbdeadlock patch
15:44:42	dansmith	the docstring and dead code removal could be separate.. just seems confusing down the road to have something serious like a dbdeadlock mitigation with some random things
15:44:43	jaypipes	dansmith: you mean me fixing up the docstring and removing the useless line of code?
15:44:54	jaypipes	dansmith: yeah, I was on the fencer.
15:45:15	dansmith	jaypipes: yeah, separate those cleanups from the dbdeadlock thing, IMHO
15:45:22	jaypipes	ok
15:45:31	mriedem	bauzas: replied to everything in https://review.openstack.org/#/c/485435/
15:45:32	dansmith	jaypipes: I'll oil up my +2ing finger to get ready
15:45:54	mriedem	gross
15:48:53	vdrok	dansmith: gotcha, updating
15:50:02	mriedem	wow crux?
15:50:03	mriedem	crutch
15:50:39	openstackgerrit	Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566
15:50:39	openstackgerrit	Jay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations() https://review.openstack.org/487483
15:50:39	cdent	mriedem: I automagically translated that. I have that functionality built in because otherwise I wouldn’t be able to read myself.
15:50:40	openstackgerrit	Jay Pipes proposed openstack/nova master: docstring and unused code removal https://review.openstack.org/487492
15:50:42	jaypipes	mriedem, dansmith: done
15:52:02	dansmith	jaypipes: and done
15:53:35	sdague	mriedem: you probably just typoed horcrux
15:53:48	jaypipes	dansmith: and now I'm all oily. thanks a lot.
15:54:02	dansmith	jaypipes: you know you'd prefer that over the alternative
15:54:11	openstackgerrit	Chris Dent proposed openstack/nova master: remove un-necessary update() in _init_compute_node of rt https://review.openstack.org/483506
15:54:28	openstackgerrit	Chris Friesen proposed openstack/python-novaclient master: match exact hypervisor hostnames where applicable https://review.openstack.org/487494
15:55:01	sdague	ok, I'm about to walk afk for a bit. https://review.openstack.org/#/c/487478/ hasn't blown up yet. I approved the grenade thing it depends on, because that can't hurt anything. But it's going to be another hour + to get results
15:55:42	jaypipes	dansmith: eww.
15:55:45	jaypipes	:)
15:59:03	kashyap	If anyone has a few minutes, a self-containted change that fixes a performance issue post-migration: https://review.openstack.org/#/c/485752/ -- "libvirt: Post-migration, set cache value for Cinder volume(s)"
15:59:31	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance https://review.openstack.org/487495
15:59:33	kashyap	Unit tests -- fixed; Jenkins -- succeeds. And the reporter has confirmed the fix resolves the I/O latency issue.
16:02:24	bauzas	oh man, I totally missed the IronicHostState.uuid thing
16:02:39	bauzas	jaypipes: mriedem: I really apologize for having missed ^ that
16:03:12	bauzas	and yeah, most of the problems we have with ironic scheduling is because of the fact we have a different hoststate model :(
16:03:22	bauzas	I knew that but I forgot to tell you
16:03:25	bauzas	graaah
16:07:20	jaypipes	bauzas: no worries man
16:07:34	bauzas	I really loved my vacations
16:07:42	bauzas	but honestly, it threw me out
16:15:10	openstackgerrit	Merged openstack/nova master: style-only: s/context/ctx/ https://review.openstack.org/485791
16:15:55	openstackgerrit	Merged openstack/nova master: use os_traits.MISC_SHARES_VIA_AGGREGATE https://review.openstack.org/485792
16:16:43	openstackgerrit	Merged openstack/nova master: Use _error_out_instance_on_exception in finish_resize https://review.openstack.org/485601
16:17:28	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Change Service repr to use self.id always https://review.openstack.org/487502
16:17:29	openstackgerrit	Merged openstack/nova master: Adjust error msg for ImageNUMATopologyAsymmetric https://review.openstack.org/484634
16:17:34	mriedem	bauzas: ^ there you go
16:17:54	bauzas	jaypipes: please, tell me my concern in https://review.openstack.org/#/c/483566/14 is not valid and we self-heal allocations on compute nodes
16:18:05	bauzas	jaypipes: I know we do this but on a periodic base
16:19:18	bauzas	jaypipes: but my question is more about a possible race condition between the time we delete the allocations and the source compute runs again the RT that will self-heal the allocations
16:20:47	jaypipes	bauzas: on call
16:20:52	jaypipes	gimme few
16:21:15	bauzas	mriedem: +2d
16:21:21	bauzas	mriedem: just find another peep :p
16:21:46	bauzas	oh oops
16:21:50	bauzas	s/peep/peer
16:24:46	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
16:32:07	bauzas	jaypipes: need to go awol for dinner, but you can ping me later or drop a note if you think I scared for nothing
16:32:18	jaypipes	bauzas: will do!
16:36:21	openstackgerrit	Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
16:47:24	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Be clear about hypevisors.search used in a few CLIs https://review.openstack.org/487513
16:47:28	mriedem	cfriesen: dansmith: ^
16:47:32	mriedem	that's backportable to stable
16:47:40	mriedem	changing the behavior of those CLIs is not
16:49:14	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance https://review.openstack.org/487495
16:49:15	openstackgerrit	Matthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager https://review.openstack.org/485734
16:49:15	openstackgerrit	Matthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration https://review.openstack.org/479802
16:49:16	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in finish_resize https://review.openstack.org/487515
16:51:46	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
16:51:51	mriedem	sdague: grenade exploded http://logs.openstack.org/85/487485/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/7ab03fb/logs/grenade.sh.txt.gz#_2017-07-26_15_59_28_974
16:52:22	mriedem	but, that's appropriate for a project called 'grenade' i guess
16:53:12	cfriesen	mriedem: who approved "host-evacuate-live" anyway? :)
16:56:38	cfriesen	mriedem: the suggestion to use an fqdn assumes that you have fqdns in your cluster
16:56:54	mdbooth	cfriesen: That tool's old as the hills, isn't it?
16:58:31	cfriesen	in ours we just have hostnames "compute-1, compute-10, compute-100, etc" so there is no way to run "host-evacuate" on just compute-1 without changing the novaclient code.
16:58:59	cfriesen	mdbooth: looks like, yes. really "evacuate" should have been "resurrect" :)
16:59:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
17:00:09	mdbooth	cfriesen: I wrote this a while back, btw: https://gist.github.com/mdbooth/163f5fdf47ab45d7addd
17:00:26	mdbooth	No idea if it's useful to you, or it still works for that matter :)
17:00:32	mdbooth	Although I'd hope the latter
17:01:04	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
17:01:53	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
17:01:54	cfriesen	mdbooth: we've got our own management component that does something similar.
17:01:59	mriedem	cfriesen: why wouldn't you have fqdns on the compute hosts?
17:02:09	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
17:02:22	mdbooth	cfriesen: Not surprised. Seems like a pretty common thing to want.
17:03:18	cfriesen	mriedem: no need for them...the computes don't talk to anything outside the cluster and they know the hostname of everything in the cluster.
17:05:06	dansmith	cfriesen: except you just said the reason to have them :)
17:05:31	jangutter	mriedem, jaypipes: sean-k-mooney gave his +1 on https://review.openstack.org/#/c/483459 have I addressed your concerns too?

Earlier   Later