Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-25
14:51:10 openstackgerrit Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459
14:52:33 openstackgerrit Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459
14:54:17 mriedem jangutter: question in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py
14:55:52 jangutter mriedem: let me see if the downstream code checks that. It hadn't occured to me to do input validation there!
14:56:17 mriedem well, one would probably never think to check it if only testing against a single configuratoin
14:56:22 mriedem *configuration
14:56:46 sdague mriedem: we had to revert it once before right?
14:56:56 sdague maybe an ironic issue
14:57:04 mriedem sdague: yes, but for two issues,
14:57:17 mriedem 1. notifications
14:57:22 sdague if you all tell me it's good to go, I'm fine doing it
14:57:26 mriedem 2. it didn't depent on the quotas change
14:57:34 mriedem sdague: i'm just running tests before we do
14:57:49 sdague sfinucan: https://bugs.launchpad.net/nova/+bug/1704458 that bug on your radar?
14:57:50 openstack Launchpad bug 1704458 in OpenStack Compute (nova) "The use_ipv6 flag not only influences nova networking" [Undecided,New]
14:58:06 mriedem sdague: sfinucan is now stephenfin and stephenfin is out this week
14:58:13 sdague ok
14:58:15 dansmith sdague: ironic and notification issues are fixed, and quotas are merged so those are the things we knew about and reverted for before
14:58:36 sdague mriedem: ok, so run the test you want to run, then poke me when it's successful
14:58:43 moshele mriedem: the generic is used in the old way https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L343 so we can skip it for now
14:58:45 dansmith ack, thanks
14:59:30 mriedem moshele: what controls that getting called over the other?
14:59:35 mriedem for VIFHostDevice?
15:00:01 moshele mriedem: the vif type that send from neutron
15:00:18 jangutter mriedem, moshele: VIFHostDevice isn't used anywhere _yet_, it's not too difficult to fix though.
15:00:23 moshele mriedem: some code uses os-vif path, but most of it not
15:00:53 openstackgerrit Eric Fried proposed openstack/nova master: nova.utils.get_service_url() https://review.openstack.org/458257
15:01:20 jangutter moshele, mriedem: it amounts to adding an if that will prevent future idiots like me to plonk in potholes.
15:01:43 mriedem moshele: ok so a vif with type 'hostdev_physical' would go down that old path, but couldn't something on the neutron side start sending VIFHostDev with dev_type='generic'?
15:01:55 mriedem jangutter: yes that's basically what i'm looking for
15:02:11 moshele mriedem: the nova code create it
15:02:19 moshele mriedem: let me look for it
15:02:44 mriedem moshele: you mean this? https://review.openstack.org/#/c/483459/12/nova/network/os_vif_util.py
15:03:05 mriedem L323
15:03:18 moshele mriedem: yes
15:03:56 jangutter mriedem: good spot, I had forgotten "GENERIC" even existed.
15:04:17 mriedem ok, i guess we should at least have some if check that raises an exception if dev_type isn't 'ethernet' or something
15:04:19 moshele mriedem: so either the vif type will work with the old way of get config or with the new os-vif
15:04:20 mriedem so this doesn't fail in really weird ways
15:05:11 moshele mriedem: we can and also a TODO comment to address generic when it will be use by os-vif
15:06:55 mriedem sure
15:07:04 mriedem just something so we don't have to hunt in the weeds later
15:07:18 mriedem jangutter: ^
15:07:58 jangutter mriedem: isn't this verified as os-vif level?
15:08:19 jangutter mriedem: https://github.com/openstack/os-vif/blob/master/os_vif/objects/fields.py#L61
15:08:21 mriedem sdague: dansmith: novaclient functional single tenant job passed on the fleetify conductor patch, i'm just waiting for some experimental queue jobs to pass on it now
15:08:23 mriedem like cells v1
15:08:37 mriedem jangutter: that's not what i mean
15:08:53 mriedem i meant in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py
15:09:07 mriedem if vif.dev_type != 'ethernet': raise some error,
15:09:09 dansmith mriedem: swebster
15:09:12 dansmith mriedem: er, sweet :)
15:09:15 mriedem or just add a TODO as moshele said
15:09:42 jangutter mriedem: aaah, but I'm almost done adding the GENERIC! (I think....)
15:09:55 mriedem ok whatever floats your boat
15:10:25 mgiles lyarwood: It looks like you were the last person working on https://review.openstack.org/#/c/389798 but it's been a couple of months with no activity
15:10:26 sdague mriedem: sounds good
15:10:37 mgiles lyarwood Any objection if I take this over and fix up the tests to work with the latest codebase?
15:10:54 mriedem mgiles: just take it over, lyarwood is on nova sabbatical
15:10:58 jangutter mriedem: GENERIC == designer.set_vif_host_backend_hostdev_pci_config
15:11:04 mgiles mriedem thanks for the info
15:11:18 mriedem jangutter: yeah just like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L343
15:11:21 mriedem jangutter: that's easy then
15:11:43 jangutter mriedem: more effort to write the comment than the code.
15:18:36 openstackgerrit Merged openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385
15:27:36 openstackgerrit Eric Fried proposed openstack/nova master: Trim the fat from InstanceInfo https://review.openstack.org/471146
15:32:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538
15:32:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications https://review.openstack.org/487126
15:37:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538
15:37:12 openstackgerrit Balazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications https://review.openstack.org/487126
15:38:37 openstackgerrit Sean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable https://review.openstack.org/486623
15:39:12 openstackgerrit Sean Dague proposed openstack/nova master: Suppress some test warnings https://review.openstack.org/486700
15:39:43 mriedem sdague: see my questions in https://review.openstack.org/#/c/486623/1/nova/conf/wsgi.py@54 ?
15:42:43 openstackgerrit Robert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver. https://review.openstack.org/485803
15:47:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667
15:47:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077
15:48:47 openstackgerrit Merged openstack/nova master: Make notification publisher_id consistent https://review.openstack.org/480984
15:51:03 openstackgerrit Gábor Antal proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459
15:55:04 jangutter mriedem: I spoke completely too soon. It looks like implementing that second branch is going to cause a bit of a ripple effect. get_base_config creates an instance of LibvirtConfigGuestInterface, but to get the proper xml rendered we need it to be of class LibvirtConfigGuestHostdevPCI.
15:55:16 sdague mriedem: commented
15:55:42 sdague basically, I don't think it's useful to rollback to oslo.service, because the point is to remove oslo.service from nova-api
15:59:14 jangutter mriedem: So it looks like the xml renderer in config.LibvirtConfigGuestInterface needs to be extended to support generic devices (basically duping the functionality in LibvirtConfigGuestHostdevPCI)
16:04:12 mriedem sdague: makes sense
16:04:23 mriedem jangutter: ok so let's not try to do that now
16:04:32 mriedem just leave a todo or error or something
16:04:55 sdague mriedem: https://review.openstack.org/#/c/486700/ also, just trying to clean up the test runs to make them easier to read
16:04:58 jangutter mriedem: roger wilco. Not throwing an exception?
16:05:01 dansmith sdague: so we're good on that right?
16:05:09 dansmith sdague: the fleetify patch
16:05:15 dansmith sdague: the dependent job passed
16:05:34 mriedem dansmith: sdague: i wanted to go through experimental queue job results
16:05:36 sdague dansmith: mriedem was looking at some experimental bits as well
16:05:46 dansmith oh okay I missed that
16:06:26 sdague I am waiting on mriedem to say go, then I'll +A it.
16:08:53 openstackgerrit Sean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642
16:11:03 openstackgerrit Sean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642
16:11:54 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s) https://review.openstack.org/485752
16:13:10 kashyap mdbooth: or mriedem: When you get a sec, I fixed the "broken" unit tests the above change brings in. But I'm duking around adding the actual test for test_get_volume_config(), any suggestions welcome.
16:14:26 kashyap The core change is simple and does two things:
16:14:35 kashyap (1) In libvirt/driver.py, call _set_cache_mode() from _get_volume_config() method so that libvirt will set disk cache value for Cinder volumes *after* migration.

Earlier   Later