| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-25 | |||
| 15:08:37 | mriedem | jangutter: that's not what i mean | |
| 15:08:53 | mriedem | i meant in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py | |
| 15:09:07 | mriedem | if vif.dev_type != 'ethernet': raise some error, | |
| 15:09:09 | dansmith | mriedem: swebster | |
| 15:09:12 | dansmith | mriedem: er, sweet :) | |
| 15:09:15 | mriedem | or just add a TODO as moshele said | |
| 15:09:42 | jangutter | mriedem: aaah, but I'm almost done adding the GENERIC! (I think....) | |
| 15:09:55 | mriedem | ok whatever floats your boat | |
| 15:10:25 | mgiles | lyarwood: It looks like you were the last person working on https://review.openstack.org/#/c/389798 but it's been a couple of months with no activity | |
| 15:10:26 | sdague | mriedem: sounds good | |
| 15:10:37 | mgiles | lyarwood Any objection if I take this over and fix up the tests to work with the latest codebase? | |
| 15:10:54 | mriedem | mgiles: just take it over, lyarwood is on nova sabbatical | |
| 15:10:58 | jangutter | mriedem: GENERIC == designer.set_vif_host_backend_hostdev_pci_config | |
| 15:11:04 | mgiles | mriedem thanks for the info | |
| 15:11:18 | mriedem | jangutter: yeah just like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L343 | |
| 15:11:21 | mriedem | jangutter: that's easy then | |
| 15:11:43 | jangutter | mriedem: more effort to write the comment than the code. | |
| 15:18:36 | openstackgerrit | Merged openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | |
| 15:27:36 | openstackgerrit | Eric Fried proposed openstack/nova master: Trim the fat from InstanceInfo https://review.openstack.org/471146 | |
| 15:32:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | |
| 15:32:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications https://review.openstack.org/487126 | |
| 15:37:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | |
| 15:37:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications https://review.openstack.org/487126 | |
| 15:38:37 | openstackgerrit | Sean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable https://review.openstack.org/486623 | |
| 15:39:12 | openstackgerrit | Sean Dague proposed openstack/nova master: Suppress some test warnings https://review.openstack.org/486700 | |
| 15:39:43 | mriedem | sdague: see my questions in https://review.openstack.org/#/c/486623/1/nova/conf/wsgi.py@54 ? | |
| 15:42:43 | openstackgerrit | Robert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver. https://review.openstack.org/485803 | |
| 15:47:43 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667 | |
| 15:47:44 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077 | |
| 15:48:47 | openstackgerrit | Merged openstack/nova master: Make notification publisher_id consistent https://review.openstack.org/480984 | |
| 15:51:03 | openstackgerrit | Gábor Antal proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 15:55:04 | jangutter | mriedem: I spoke completely too soon. It looks like implementing that second branch is going to cause a bit of a ripple effect. get_base_config creates an instance of LibvirtConfigGuestInterface, but to get the proper xml rendered we need it to be of class LibvirtConfigGuestHostdevPCI. | |
| 15:55:16 | sdague | mriedem: commented | |
| 15:55:42 | sdague | basically, I don't think it's useful to rollback to oslo.service, because the point is to remove oslo.service from nova-api | |
| 15:59:14 | jangutter | mriedem: So it looks like the xml renderer in config.LibvirtConfigGuestInterface needs to be extended to support generic devices (basically duping the functionality in LibvirtConfigGuestHostdevPCI) | |
| 16:04:12 | mriedem | sdague: makes sense | |
| 16:04:23 | mriedem | jangutter: ok so let's not try to do that now | |
| 16:04:32 | mriedem | just leave a todo or error or something | |
| 16:04:55 | sdague | mriedem: https://review.openstack.org/#/c/486700/ also, just trying to clean up the test runs to make them easier to read | |
| 16:04:58 | jangutter | mriedem: roger wilco. Not throwing an exception? | |
| 16:05:01 | dansmith | sdague: so we're good on that right? | |
| 16:05:09 | dansmith | sdague: the fleetify patch | |
| 16:05:15 | dansmith | sdague: the dependent job passed | |
| 16:05:34 | mriedem | dansmith: sdague: i wanted to go through experimental queue job results | |
| 16:05:36 | sdague | dansmith: mriedem was looking at some experimental bits as well | |
| 16:05:46 | dansmith | oh okay I missed that | |
| 16:06:26 | sdague | I am waiting on mriedem to say go, then I'll +A it. | |
| 16:08:53 | openstackgerrit | Sean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642 | |
| 16:11:03 | openstackgerrit | Sean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642 | |
| 16:11:54 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s) https://review.openstack.org/485752 | |
| 16:13:10 | kashyap | mdbooth: or mriedem: When you get a sec, I fixed the "broken" unit tests the above change brings in. But I'm duking around adding the actual test for test_get_volume_config(), any suggestions welcome. | |
| 16:14:26 | kashyap | The core change is simple and does two things: | |
| 16:14:35 | kashyap | (1) In libvirt/driver.py, call _set_cache_mode() from _get_volume_config() method so that libvirt will set disk cache value for Cinder volumes *after* migration. | |
| 16:14:39 | kashyap | (2) Remove duplicate calls to _set_cache_mode() in _get_guest_storage_config() and attach_volume() methods. | |
| 16:15:04 | kashyap | The reporter has tested the change and confirmed that it removes the perf regression (post migration) on the Cinder volume. | |
| 16:22:31 | openstackgerrit | Artem Tiumentcev proposed openstack/nova master: Add root and ephemeral disk quota https://review.openstack.org/484390 | |
| 16:29:27 | openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | |
| 16:31:37 | openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | |
| 16:32:01 | jangutter | mriedem: ^^ hope this one has the right idea. | |
| 16:51:32 | mriedem | jbernard: dansmith: ceph job failed on the devstack fleetify change for an unrelated reason but fyi since it looks nasty http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-py35-full-devstack-plugin-ceph-ubuntu-xenial-nv/6066e44/logs/screen-g-api.txt.gz?level=TRACE#_Jul_25_14_37_19_667434 | |
| 16:52:07 | dansmith | eesh yeah | |
| 16:57:15 | mriedem | maybe just a py35 thing | |
| 16:57:21 | mriedem | maybe librados doesn't support py35 | |
| 16:58:01 | dansmith | but we get that far only to find radios is None? | |
| 17:00:13 | mriedem | yeah | |
| 17:00:23 | mriedem | import error sets that rados package import to None | |
| 17:00:27 | mriedem | https://github.com/openstack/glance_store/blob/0.21.0/glance_store/_drivers/rbd.py#L41 | |
| 17:00:36 | mriedem | and rados isn't in the pip freeze output for py35 but it is for py27 | |
| 17:00:40 | mriedem | https://bugs.launchpad.net/glance-store/+bug/1706405 | |
| 17:00:41 | openstack | Launchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,New] | |
| 17:00:49 | mriedem | so this is just some py35 package install thing for librados | |
| 17:01:00 | dansmith | no error log when we fail to import? | |
| 17:01:05 | mriedem | eff no | |
| 17:01:17 | mriedem | error logs are in the enterprise edition of glance-store | |
| 17:03:46 | gibi | mriedem: hi! Do you have time to joint to the notification subteam meeting or we should simply skip that? I'm not against skipping it today. | |
| 17:04:36 | sdague | mriedem: ok, how is your look on the experimental job? As I'm going to walk away from the computer for a bit shortly | |
| 17:05:22 | openstackgerrit | Merged openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture https://review.openstack.org/486237 | |
| 17:06:11 | mriedem | sdague: going through results | |
| 17:06:15 | mriedem | but now in the notification meeting | |
| 17:06:21 | mriedem | so you might as well walk | |
| 17:12:44 | jangutter | OK, this is a python newbie question (due to lack of caffeine)... Why would vif.get('ovs_interfaceid',"foobar") return None? ( https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L281 ) | |
| 17:13:45 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 17:15:05 | openstackgerrit | Gábor Antal proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 17:15:12 | edleafe | jangutter: if there is a key named 'ovs_interfaceid' and its value is None | |
| 17:15:33 | edleafe | jangutter: it only returns the default param if the key isn't found | |
| 17:17:08 | mriedem | jangutter: so do vif.get('ovs_interfaceid',"foobar") or 'foobar' | |
| 17:17:33 | jangutter | edleafe: yeah, that makes sense. That's why I see the pattern there. | |
| 17:20:08 | sdague | lyarwood: was there any progress on this bug - https://bugs.launchpad.net/nova/+bug/1640506 ? | |
| 17:20:10 | openstack | Launchpad bug 1640506 in OpenStack Compute (nova) "Switch to os-brick encryptor provider implementations" [Wishlist,New] | |
| 17:20:53 | openstackgerrit | Chris Dent proposed openstack/nova master: Use wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | |
| 17:21:30 | sdague | mriedem: ok, brain sufficiently fried, so walking away from computer now, but the number of bugs in new is down to 60 - https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New - so it's back on one page now | |
| 17:22:09 | mriedem | yay | |
| 17:22:55 | openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | |
| 17:23:02 | mriedem | dansmith: neutron dvr ha job is busted, but that's probably old news http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/console.html#_2017-07-25_15_47_52_092840 | |
| 17:28:11 | jaypipes | mriedem, dansmith: if you have a chance to review https://review.openstack.org/#/c/483566/ that would be great. (the final placemnet-claims one) | |
| 17:28:38 | mriedem | jaypipes: yeah i was checking out the ci results before digging into the review | |
| 17:28:42 | jaypipes | k | |
| 17:28:43 | mriedem | should be done this afternoon | |
| 17:30:20 | openstackgerrit | Robert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver. https://review.openstack.org/485803 | |
| 17:31:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276 | |