Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-18
18:52:57 dansmith that's why
18:53:04 dansmith edleafe: we just need to be good about it (i.e. spawn a thread)
18:53:09 edleafe mostly that it runs once, and nova can't accidentally allocate against it until the healing is run
18:53:36 dansmith edleafe: well, I don't think we can block compute startup entirely right?
18:53:36 edleafe dansmith: well, we can see about improving it once I get it working
18:53:53 dansmith and we don't need to until we convert the requests to be custom-only, which is queens I think
18:54:24 edleafe dansmith: this has to be done in Pike so we can remove it in Queens and go to custom-only
18:54:44 dansmith edleafe: the migration does yeah, so we can do it async
18:54:47 openstackgerrit Baodong (Robert) Li proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.openstack.org/471815
18:55:02 dansmith so nobody is working on reporting allocations for custom resource type overrides in the flavors, right?
18:56:18 edleafe dansmith: the understanding was that operators would add the extra_specs stuff before starting Pike
18:56:41 dansmith edleafe: to the base flavors?
18:56:44 mriedem edleafe: they shouldn't do any of that,
18:56:45 edleafe dansmith: the nodes should already be populated with a resource_class in Ocata
18:56:48 mriedem until this other stuff is done
18:57:02 dansmith right
18:57:03 dansmith they can't
18:57:10 dansmith the spec says that in queens, afaik
18:57:15 mriedem we could likely build something into nova-status in queens
18:57:21 edleafe mriedem: well, yeah - that's why this is going into Pike
18:57:29 dansmith if we report inventory in pike, and allocations for existing, then everything is good to cut over in queens
18:57:39 mriedem you could query all ironic compute nodes in all cells and get the instances from them and check to see if their flavors have been migrated
18:58:14 mriedem anyway i think i put some words about the operator thing in the spec amendment
18:58:47 dansmith so again,
18:58:55 dansmith nobody is working on the reporting allocations part right?
18:59:11 mriedem correctamundo
18:59:29 dansmith okay I think that'll be easy so let me work on that a bit
18:59:43 edleafe dansmith: not sure what you mean by 'reporting allcations'
19:00:10 dansmith edleafe: healing the flavors on the instances to have the resource override is one thing,
19:00:13 mriedem edleafe: let me find that from the spec amendment
19:00:28 dansmith but we have to actually report those values as consumed in placement when we're making/updating the instance allocations
19:00:32 dansmith from resource tracker
19:00:40 mriedem edleafe: https://review.openstack.org/#/c/481748/1/specs/pike/approved/custom-resource-classes-in-flavors.rst@108
19:01:23 edleafe mriedem: ok, that
19:01:51 edleafe mriedem: I am adding similar in the flavor migration stuff
19:02:09 edleafe setting the allocation for the custom ironic RC
19:02:18 dansmith migrating the instance flavor should make the allocation heal in the RT when that runs
19:02:26 dansmith edleafe: don't make those calls from driver init
19:02:30 dansmith otherwise we have it in two places
19:35:26 openstackgerrit Merged openstack/os-vif master: unplug_vf_passthrough: don't try to delete representor netdev https://review.openstack.org/478820
19:40:07 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484218
19:55:54 openstackgerrit Jackie Truong proposed openstack/nova master: [WIP] Add trusted certificates to InstanceExtras https://review.openstack.org/457711
19:57:35 openstackgerrit Jackie Truong proposed openstack/nova master: [WIP] Add trusted certificates to InstanceExtras https://review.openstack.org/457711
20:02:45 oorgeron Hi folks, I'm working on a patch to enable nova to use mysql cluster. In tests, I'm running into errors that seem to indicate that sqlite is being used in the sqlalchemy migrations. Michael Bayer said that this has happened before in the nova gate, anyone know how to fix that? https://review.openstack.org/#/c/446643/
20:06:08 melwitt oorgeron: the unit tests intentionally use sqlite
20:06:27 melwitt and functional tests
20:08:06 melwitt that said, I don't know how you could get things working with your change. probably need to ask someone like sdague
20:12:31 oorgeron melwitt: I'll reach out to sdague.
20:13:14 openstackgerrit Dan Smith proposed openstack/nova master: Consider instance flavor resource overrides in allocations https://review.openstack.org/484935
20:13:30 dansmith mriedem: edleafe ^.. I still need to figure out what gabbit is failing on one of the functional tests
20:13:50 mriedem oorgeron: you can run mysql and postgresql opportunistic tests locally if you do some setup
20:14:32 sdague oorgeron: yeh, everything there looks like unit testable failures because of an assumption about an index
20:14:51 mriedem there should be a script in nova/tools to set this stuff up
20:14:58 sdague mriedem: it's not even that
20:15:20 mriedem https://github.com/openstack/nova/blob/master/tools/test-setup.sh
20:15:30 sdague http://logs.openstack.org/43/446643/6/check/gate-nova-python27-ubuntu-xenial/6e79a39/console.html.gz#_2017-07-14_19_47_37_197086
20:15:39 sdague these are just run of the mill, non mysql / pg tests failing
20:16:01 oorgeron sdague: yeah the test is failing with a sqlite error with dropping an index. The scripts work fine with innodb and ndb as the database.
20:16:13 sdague oorgeron: right, they have to work with sqlite as well
20:16:18 sdague that's our unit testing environment
20:16:37 mriedem yeah...you can't just do stuff like this https://review.openstack.org/#/c/446643/6/nova/db/sqlalchemy/migrate_repo/versions/249_remove_duplicate_index.py
20:17:50 mriedem and this scares me https://review.openstack.org/#/c/446643/6/nova/db/sqlalchemy/models.py
20:18:21 oorgeron mriedmen: A lot of the other services are just doing tests against mysql and maybe postgresql. I could use another method to drop and add the foreignkey and not use the migrate method for doing that.
20:18:40 mriedem oorgeron: everyone is using sqlite for unit tests
20:18:48 mriedem we test with mysql in the devstack jobs in the gate
20:18:52 mriedem for integration testing
20:19:07 mriedem the unit tests also run with the opportunistic mysql and postgresql backends in the gate
20:19:09 oorgeron mriedem: I can drop foreign keys like this in other services and the tests pass.
20:19:14 mriedem but locally you have to set that all up optionally
20:19:23 mriedem oorgeron: that doesn't make it right
20:19:34 mriedem "hey look i deleted a bunch of code and nothing blew up!"
20:19:39 mriedem that probably just means they aren't doing testing
20:20:31 mriedem the model changes here worry me that the schema will change for other backends, like postgresql
20:20:50 oorgeron mriedem: first off, when you drop an index, you supposed to remove the foreign keys, if we're talking about the right order of sql steps. Innodb just happens to be very forgiving on that, doesn't make it right either.
20:21:13 oorgeron mriedem: also, if you look at that, it adds the key back after the index is dropped, which is the right way to do this in sql
20:21:46 jaypipes mriedem: how may I be of assistance?
20:21:49 oorgeron mriedem: But I'll try a dumber wait to drop and recreate the foreign key, instead of using the migrate method here.
20:21:57 oorgeron way
20:23:27 oorgeron mriedem: the changes to model will only apply when ndb is turned on. The ndb function calls there do the right thing automatically.
20:24:16 mriedem so in https://review.openstack.org/#/c/446643/6/nova/db/sqlalchemy/migrate_repo/versions/249_remove_duplicate_index.py you'd have to handle the index not existing before trying to drop it
20:25:02 mriedem jaypipes: half joking
20:25:08 mriedem i unsummon you
20:25:13 mriedem and banish you back to placement land
20:25:17 mriedem *placement island
20:26:22 oorgeron mriedem: besides, 292_drop_nova_volumes_tables.py uses the same method and is not part of my patch :)
20:28:33 openstackgerrit Jan Gutter proposed openstack/os-vif master: Add support for VIFPortProfileOVSRepresentor https://review.openstack.org/483921
20:30:51 openstackgerrit Jackie Truong proposed openstack/nova master: [WIP] Implement certificate_utils https://review.openstack.org/479949
20:49:01 oorgeron sdague: is there a way to run the tests just against sqlite?
20:54:45 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711
20:57:20 openstackgerrit Jan Gutter proposed openstack/os-vif master: Add support for VIFPortProfileOVSRepresentor https://review.openstack.org/483921
21:06:25 openstackgerrit Ed Leafe proposed openstack/nova master: WIP - Migrate Ironic Flavors https://review.openstack.org/484949
21:06:36 edleafe dansmith: ^^ Strawman code that has the inventory/allocation changes
21:06:55 edleafe dansmith: I had already written that before you said not to :)
21:08:13 mriedem dansmith: here it comes
21:08:16 mriedem prepare
21:08:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle uuids in os-hypervisors API https://review.openstack.org/471899
21:08:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280
21:14:45 dansmith edleafe: remember how I asked a few times if anyone was working on that?
21:17:59 edleafe dansmith: remember how I said that I was adding that code to the ironic driver?
21:18:46 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: fix max_version for deprecated os-quota-class-sets parameters https://review.openstack.org/484952

Earlier   Later