| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-18 | |||
| 20:18:48 | mriedem | we test with mysql in the devstack jobs in the gate | |
| 20:18:52 | mriedem | for integration testing | |
| 20:19:07 | mriedem | the unit tests also run with the opportunistic mysql and postgresql backends in the gate | |
| 20:19:09 | oorgeron | mriedem: I can drop foreign keys like this in other services and the tests pass. | |
| 20:19:14 | mriedem | but locally you have to set that all up optionally | |
| 20:19:23 | mriedem | oorgeron: that doesn't make it right | |
| 20:19:34 | mriedem | "hey look i deleted a bunch of code and nothing blew up!" | |
| 20:19:39 | mriedem | that probably just means they aren't doing testing | |
| 20:20:31 | mriedem | the model changes here worry me that the schema will change for other backends, like postgresql | |
| 20:20:50 | oorgeron | mriedem: first off, when you drop an index, you supposed to remove the foreign keys, if we're talking about the right order of sql steps. Innodb just happens to be very forgiving on that, doesn't make it right either. | |
| 20:21:13 | oorgeron | mriedem: also, if you look at that, it adds the key back after the index is dropped, which is the right way to do this in sql | |
| 20:21:46 | jaypipes | mriedem: how may I be of assistance? | |
| 20:21:49 | oorgeron | mriedem: But I'll try a dumber wait to drop and recreate the foreign key, instead of using the migrate method here. | |
| 20:21:57 | oorgeron | way | |
| 20:23:27 | oorgeron | mriedem: the changes to model will only apply when ndb is turned on. The ndb function calls there do the right thing automatically. | |
| 20:24:16 | mriedem | so in https://review.openstack.org/#/c/446643/6/nova/db/sqlalchemy/migrate_repo/versions/249_remove_duplicate_index.py you'd have to handle the index not existing before trying to drop it | |
| 20:25:02 | mriedem | jaypipes: half joking | |
| 20:25:08 | mriedem | i unsummon you | |
| 20:25:13 | mriedem | and banish you back to placement land | |
| 20:25:17 | mriedem | *placement island | |
| 20:26:22 | oorgeron | mriedem: besides, 292_drop_nova_volumes_tables.py uses the same method and is not part of my patch :) | |
| 20:28:33 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Add support for VIFPortProfileOVSRepresentor https://review.openstack.org/483921 | |
| 20:30:51 | openstackgerrit | Jackie Truong proposed openstack/nova master: [WIP] Implement certificate_utils https://review.openstack.org/479949 | |
| 20:49:01 | oorgeron | sdague: is there a way to run the tests just against sqlite? | |
| 20:54:45 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711 | |
| 20:57:20 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Add support for VIFPortProfileOVSRepresentor https://review.openstack.org/483921 | |
| 21:06:25 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Migrate Ironic Flavors https://review.openstack.org/484949 | |
| 21:06:36 | edleafe | dansmith: ^^ Strawman code that has the inventory/allocation changes | |
| 21:06:55 | edleafe | dansmith: I had already written that before you said not to :) | |
| 21:08:13 | mriedem | dansmith: here it comes | |
| 21:08:16 | mriedem | prepare | |
| 21:08:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | |
| 21:08:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280 | |
| 21:14:45 | dansmith | edleafe: remember how I asked a few times if anyone was working on that? | |
| 21:17:59 | edleafe | dansmith: remember how I said that I was adding that code to the ironic driver? | |
| 21:18:46 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix max_version for deprecated os-quota-class-sets parameters https://review.openstack.org/484952 | |
| 21:18:48 | mriedem | alex_xu: gmann: ^ we got confused | |
| 21:23:12 | openstackgerrit | Octave Orgeron proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643 | |
| 21:24:07 | mriedem | edleafe: dansmith: now now now, you're BOTH wrong! :) | |
| 21:24:17 | mriedem | edleafe: you shouldn't be doing the placement stuff in the init_host | |
| 21:24:19 | mriedem | -1 for that | |
| 21:24:24 | mriedem | dan's change builds on top of yours | |
| 21:24:47 | mriedem | edleafe: just need you to update the existing instance flavors on init_host, | |
| 21:24:57 | mriedem | update_available_resource will pick up on that (via dan's change) and adjust the allocations | |
| 21:25:00 | mriedem | automagically | |
| 21:25:30 | openstackgerrit | Octave Orgeron proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643 | |
| 21:29:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: placement: alloc candidates only shared resources https://review.openstack.org/484900 | |
| 21:30:01 | mriedem | jaypipes: +2 | |
| 21:30:14 | jaypipes | mriedem: danke | |
| 21:30:29 | mriedem | kein Problem | |
| 21:31:12 | openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | |
| 21:32:40 | openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | |
| 21:34:39 | edleafe | mriedem: like I said, I had most of that done before our little conversation earlier | |
| 21:35:05 | edleafe | I just pushed it before I gut it :) | |
| 21:39:11 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Migrate Ironic Flavors https://review.openstack.org/484949 | |
| 21:39:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix description of service_disable_reason https://review.openstack.org/484955 | |
| 21:39:34 | edleafe | dansmith: mriedem: rebased it on dansmith's change and deleted the allocation stuff | |
| 21:39:36 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288 | |
| 21:39:41 | edleafe | still needs tests, though | |
| 21:39:51 | edleafe | but they will have to wait until tomorrow | |
| 21:39:54 | mriedem | edleafe: ok, that's the wrong order really, but ok | |
| 21:40:24 | edleafe | mriedem: no, because without his you could get errors | |
| 21:40:31 | edleafe | with mine | |
| 21:40:51 | edleafe | with his first nothing will happen until mine | |
| 21:41:13 | mriedem | i don't understand how dan's change should impact yours | |
| 21:41:28 | mriedem | they could be done in parallel actually | |
| 21:41:30 | mriedem | but dan's builds on yours | |
| 21:41:55 | edleafe | well, maybe it only throws errors with the init_host updating inventory | |
| 21:42:05 | edleafe | didn't get to test that scenario | |
| 21:42:40 | melwitt | dansmith: I'm looking at the fleetify patch to figure out how to build upon it for per cell console proxies. it looks like it sets up only one cell? https://review.openstack.org/#/c/477556 | |
| 21:43:13 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288 | |
| 21:43:38 | mriedem | melwitt: you have to look at the multinode job | |
| 21:43:48 | mriedem | http://logs.openstack.org/56/477556/5/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/aed9486/ | |
| 21:44:03 | melwitt | mriedem: I did, I only see super conductor and one conductor process and NOVA_NUM_CELLS is 1? | |
| 21:44:29 | mriedem | hmm http://logs.openstack.org/56/477556/5/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/aed9486/logs/devstack-gate-discover-hosts.txt.gz | |
| 21:44:48 | mriedem | yeah i see 2 computes, 2 cell mappings, but really only 1 cell | |
| 21:45:00 | dansmith | melwitt: it treats cell0 as the main cell by pointing everything to it, so cell1 is the different cell, | |
| 21:45:04 | dansmith | which is where the computes are | |
| 21:45:17 | melwitt | oh, okay | |
| 21:45:25 | melwitt | thanks | |
| 21:45:42 | dansmith | the plan was to make the second node create a second cell in some configurations to validate that cross-cell migrations don't happen and stuff, | |
| 21:45:54 | dansmith | but there is more devstack and d-g work to do there, | |
| 21:46:05 | dansmith | but have had a lot of time waiting for this to get merged yaknow | |
| 21:46:19 | mriedem | it did get merged once remember? :) | |
| 21:46:31 | melwitt | heh | |
| 21:46:52 | dansmith | even when it merged a couple weeks ago I figured we were a little late in the cycle to be splitting that out and dealing with big config changes | |
| 21:46:53 | dansmith | heh yes for a hot minute | |
| 21:47:04 | dansmith | when we do the two computes in two cells thing we also have to make sure we end up with a two-computes-one-cell job to keep testing migrations and stuff | |
| 21:47:07 | dansmith | it's a whole thing | |
| 21:47:25 | dansmith | but, for your console thing I think the current config is going to test what you want | |
| 21:47:34 | dansmith | because if you don't switch cells, you'll hit cell0 and find nothing | |
| 21:48:19 | dansmith | mriedem: I don't think there's any strict ordering required between ed's patch and mine | |
| 21:48:28 | mriedem | dansmith: there isn't a strict ordering no | |
| 21:48:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not mention that tags are case sensitive in docs https://review.openstack.org/484957 | |
| 21:48:32 | mriedem | could be totally parallel | |
| 21:48:41 | dansmith | mine is fine in isolation, | |
| 21:48:42 | dansmith | mriedem: mine without his would work for all new instances | |
| 21:50:04 | edleafe | dansmith: when I tested the first version (with the allocation stuff in init_host) it would throw errors in the periodic update until I rebased on yours. | |
| 21:50:21 | edleafe | dansmith: now that I removed the allocations, it probably doesn't matter | |
| 21:50:41 | dansmith | "when done properly, ordering doesn't matter" | |