Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-30
08:19:23 alex_xu gmann: just a method like handle_405(), then there is no way to handle microversion
08:19:35 alex_xu gmann: I feel we should keep the current way
08:19:46 gmann alex_xu, oh, it is 400 till 2.35 and then 404
08:20:49 alex_xu gmann: yea...
08:21:39 gmann alex_xu, yea, we have to go till controller then
08:23:16 gmann alex_xu, its becoming large patch now as quota set want networks quota in sample file - https://review.openstack.org/#/c/467938/11
08:24:12 gmann alex_xu, i can add in same patch if you would not mind or can separate the networks quota things for sample files
08:25:27 alex_xu gmann: I think https://review.openstack.org/#/c/467938/11 is right
08:27:16 gmann alex_xu, you mean to fix quota set sample files in same patch?
08:28:59 alex_xu gmann: sorry, the separated patch is better
08:29:19 gmann alex_xu, ok
08:29:24 alex_xu gmann: https://review.openstack.org/#/c/467938 already have a lot of change in the api ref
08:30:10 gmann alex_xu, yes, so i will leave the sample files changes on this and just api-ref for quota class
08:33:22 alex_xu gmann: that is also good choice
08:43:45 openstackgerrit Merged openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
08:43:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
09:07:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use URIOpt https://review.openstack.org/479215
09:16:40 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
09:16:55 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
09:17:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276
09:37:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add 'networks' quota in quota sample files https://review.openstack.org/479227
09:47:35 openstackgerrit Monty Taylor proposed openstack/python-novaclient master: Stop posting to os-volumes_boot https://review.openstack.org/473833
09:57:01 bhagyashri_s johnthetubaguy: Hi, Could you please review patch : https://review.openstack.org/#/c/409644/ ?
09:58:04 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: Fixes Generation 2 VMs volume boot order https://review.openstack.org/461689
09:58:43 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: stop serial console workers while deleting vm files https://review.openstack.org/387831
09:59:16 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
10:00:13 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
10:12:09 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: Fixes log message in livemigrationops https://review.openstack.org/479245
10:12:39 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
10:15:48 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
10:24:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-baremetal-nodes endpoint instead of stevedore https://review.openstack.org/461480
10:53:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (3) https://review.openstack.org/452820
10:53:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818
10:53:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819
10:53:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor instance.power-off notification samples https://review.openstack.org/475860
10:56:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
11:03:07 gmann sfinucan, did not get you comment fully- https://review.openstack.org/#/c/479227/1
11:03:16 gmann sfinucan, you mean bug link
11:07:46 openstackgerrit Merged openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344
11:14:16 openstackgerrit Merged openstack/nova master: Extract custom resource classes from flavors https://review.openstack.org/473627
11:15:03 openstackgerrit Merged openstack/nova master: Add scatter gather utilities for cells https://review.openstack.org/475957
11:52:11 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:21:20 openstackgerrit Merged openstack/nova master: Removes potentially bad exit value from accepted list in Quobyte volume driver https://review.openstack.org/453537
12:43:27 sfinucan gmann: Yup, sorry - a bug link
12:43:36 sfinucan That seems like an outstanding bug, no?
12:43:42 sfinucan Or maybe I don't understand the issue enough
12:48:45 ralonsoh dansmith: hi
12:52:41 sfinucan alex_xu, gmann: Dumb question, but can you explain what's going on here https://review.openstack.org/#/c/478901/ It's funky compared to what I'd expect, heh
12:52:57 ralonsoh dansmith: it's about https://review.openstack.org/#/c/449257/28/nova/objects/instance_pci_requests.py@34. Do you think I need to create a separate object?
12:54:08 alex_xu sfinucan: this extension returned 3 resources https://review.openstack.org/#/c/478901/2/nova/api/openstack/compute/security_groups.py@509
12:54:20 alex_xu sfinucan: so I separate them into 3 patches
12:54:52 alex_xu sfinucan: in each patch, I reduce one resource returned from the extension https://review.openstack.org/#/c/478901/2/nova/api/openstack/compute/security_groups.py@517
12:55:15 sfinucan alex_xu: aha - that makes perfect sense. Thanks for the clarification :)
12:55:29 alex_xu sfinucan: thanks for the review :)
12:57:51 dtantsur edleafe: hi! is it me doing something wrong, or does the placement have to be updated too to support custom resource classes? http://logs.openstack.org/68/476968/4/check/gate-tempest-dsvm-ironic-ipa-partition-redfish-tinyipa-ubuntu-xenial/c0084db/logs/screen-n-sch.txt.gz#_Jun_26_14_32_54_180130
13:03:33 dtantsur hmm, does https://docs.openstack.org/developer/nova/placement.html#id2 mean that we should create the resource classes in use explicitly now?
13:12:06 sfinucan alex_xu: By rights, shouldn't this patch have been broken up in the same way too? https://review.openstack.org/#/c/478502/
13:12:26 sfinucan Not that I care other than to satisfy my curiosity
13:23:16 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove wsdl_location configuration option https://review.openstack.org/463220
13:41:01 bauzas dansmith: wow, just wow +1101, -2090 https://review.openstack.org/#/c/416521/57
13:41:31 dansmith inorite?
13:47:25 bauzas :)
13:55:02 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: mark glance.api_servers opt as required https://review.openstack.org/428241
13:55:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove wsdl_location configuration option https://review.openstack.org/463220
13:58:35 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: fix netconf, my_ip and host are unclear https://review.openstack.org/441210
14:00:54 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/479280
14:03:34 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Improve documentation for defer_iptables_apply https://review.openstack.org/445436
14:11:42 claudiub dansmith: heya. have you seen errors like this before? "OrphanedObjectError: Cannot call obj_load_attr on orphaned Instance object" It's been hitting us really hard: http://64.119.130.115/nova/479245/1/Hyper-V_logs/c2-r21-u28-n04-compute02/nova-compute.log.gz
14:12:39 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: remove *_topic config opts https://review.openstack.org/433924
14:12:43 dansmith claudiub: did this just crop up?
14:14:19 claudiub dansmith: yeap. it seems like today.
14:14:41 dansmith claudiub: yeah, I know what this is, just a sec
14:15:05 lpetrut dansmith: claudiub: seems related to this change: https://review.openstack.org/#/c/478991/
14:15:27 dansmith lpetrut: yep
14:17:34 openstackgerrit Dan Smith proposed openstack/nova master: Touch instance.device_metadata before caching it for InstanceMetadata https://review.openstack.org/479325
14:17:41 dansmith lpetrut: claudiub see if that fixes you ^
14:18:28 dansmith claudiub: that seems to already be set for libvirt.. I wonder why not in hyperv?
14:18:38 dansmith but it probably affects the drivers that don't support this, so..
14:19:42 claudiub dansmith: from what I can see, we hit that error whenever we have to builda new instance config_drive (on spawn)
14:20:32 dansmith maybe it's a configdrive workflow then, I dunno
14:24:29 claudiub dansmith: hm, to be more specific, it seems it happens on rebuild, shelve / unshelve, and rescue, when building the config drive.
14:24:36 lpetrut yeah, the instance.device_metadata field will be accessed when generating configdrives. If I understand correctly, any attribute that may be lazy loaded should be fetched there?
14:24:56 dansmith lpetrut: not after we do that sanitize step, so we have to do it before
14:25:13 dansmith claudiub: yeah, I know, my point is it seems like libvirt already has that field set on the instance by the time we get to this step
14:26:29 openstackgerrit Stephen Finucane proposed openstack/nova master: Clarify that vlan feature means nova-network support https://review.openstack.org/478551
14:26:54 lpetrut system_metadata would be another one. Wondering what's the best way to make sure we're covering *all* of them
14:27:16 dansmith lpetrut: sysmeta should be there already I'm sure, right?
14:27:24 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Remove libvirt imagecache https://review.openstack.org/378497
14:28:40 lpetrut dansmith: for some reason, it was breaking our resize revert logic, in which case the system_metadata field was missing
14:29:16 dansmith lpetrut: that seems really strange to me. and it just means that you were lazy-loading those fields on every metadata access, which is really inefficient
14:29:28 dansmith lpetrut: might be worth tracking that down..
14:29:52 claudiub dansmith: hm, it seems that there is a small difference between libvirt and hyper-v, regarding device_metadata. libvirt still touches the device_metadata like so: instance.device_metadata = self._build_device_metadata(context, instance) while in hyper-v, we only touch it if we actually have metadata to save: if metadata: instance.device_metadata = objects.InstanceDeviceMetadata(devices=metadata)
14:29:57 dansmith lpetrut: in the configdrive case you get to this code from the virt driver
14:30:09 dansmith claudiub: ah, makes sense
14:30:32 dansmith claudiub: any reason not to just do the libvirt thing here? otherwise we'll just try to load it when it's touched
14:32:32 claudiub sure, we could give it a try
14:32:56 dansmith if so, we should do that instead of my patch to touch it
14:34:53 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Remove libvirt imagecache https://review.openstack.org/378497
14:35:25 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: mark glance.api_servers opt as required https://review.openstack.org/428241
14:36:31 openstackgerrit Claudiu Belu proposed openstack/nova master: WIP: hyperv: Always save instance device_metadata https://review.openstack.org/479335

Earlier   Later