Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-30
06:59:37 gmann alex_xu, because bug is since Mitaka (2.14)
06:59:54 alex_xu gmann: yea...
07:01:40 alex_xu mitaka is eol...hope I can found that early
07:09:58 gmann alex_xu, query schema is from v2.1 and we do not need those for v2.0 right
07:10:04 gmann alex_xu, https://github.com/openstack/nova/blob/0ca64a8690ac9de720131b522d29dcaed824eb8d/nova/api/openstack/compute/servers.py#L160
07:11:27 alex_xu gmann: yea, I think yes
07:13:00 alex_xu gmann: at least we didn't talk about legacy v2 in the spec http://specs.openstack.org/openstack/nova-specs/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.html
07:15:06 gmann alex_xu, yea.
07:16:17 gmann also we can get ack from sdague and mriedem
07:16:26 alex_xu gmann: yea
07:25:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Ensure the JSON-Schema covers the legacy v2 API https://review.openstack.org/479170
07:30:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
07:32:23 gibi sfinucan: hi! I answered your latest comment about the extra decorators in the BDM patch https://review.openstack.org/#/c/448779/
07:40:42 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437
07:42:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667
07:42:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077
07:44:56 gmann alex_xu, on quota class bug, actually we cannot fix confg controlled things now - https://bugs.launchpad.net/nova/+bug/1701211
07:44:56 openstack Launchpad bug 1701211 in OpenStack Compute (nova) "The network related quotas aren't deprecated in quota-class API" [Undecided,Confirmed] - Assigned to Ghanshyam Mann (ghanshyammann)
07:45:00 gmann alex_xu, i replied to that bug
07:45:29 alex_xu gmann: checking
07:48:16 alex_xu gmann: looks like nothing break when expose network quota in the old microversion even the configuration disable the network quota
07:50:50 gmann alex_xu, yea. indirectly return values in resp are controlled by config options via QUOTA.resource where network quota will be registered only if config is true
07:51:27 gmann alex_xu, but update request allow it (does not matter we ignore or consider that) as of now
07:57:47 alex_xu gmann: yea, I think you are right
08:03:03 openstackgerrit Merged openstack/nova master: Sanitize instance in InstanceMetadata to avoid un-pickleable context https://review.openstack.org/478991
08:06:22 gmann alex_xu, on this - https://review.openstack.org/#/c/461480/2
08:06:43 gmann alex_xu, actually its 400 for all baremetal APIs except GET
08:07:03 gmann alex_xu, i need to find if we can return 400 from router itself
08:07:35 alex_xu gmann: ah...i see
08:10:23 alex_xu gmann: maybe can create a BadRequestController
08:10:37 alex_xu but I guess that is not simple as sdage expected
08:11:20 gmann alex_xu, yea that is one way, and we can make that version rich and return all proxy APIs from there itself in future
08:12:00 gmann oh version is dynamic cannot work here
08:13:13 gmann alex_xu, with BadRequestController also it is same as going to baremetal controller
08:13:58 alex_xu gmann: or folow the placement to support a simple method https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handler.py#L73
08:15:48 gmann alex_xu, like handle_405() ?
08:15:48 alex_xu but the Resource class handle more things than a simple method https://github.com/openstack/nova/blob/0ca64a8690ac9de720131b522d29dcaed824eb8d/nova/api/openstack/wsgi.py#L424
08:16:23 alex_xu gmann: yea
08:17:02 gmann we can direct configure mapper.connect with return 400
08:17:31 alex_xu gmann: but there is microversion in the baremetal API https://github.com/openstack/nova/blob/0ca64a8690ac9de720131b522d29dcaed824eb8d/nova/api/openstack/compute/baremetal_nodes.py#L136
08:18:21 alex_xu that version is vary from different API, so there can't be generic way
08:18:35 openstackgerrit Luis Pigueiras proposed openstack/nova master: Handle keypair not found from metadata server using cells https://review.openstack.org/476122
08:19:23 alex_xu gmann: just a method like handle_405(), then there is no way to handle microversion
08:19:35 alex_xu gmann: I feel we should keep the current way
08:19:46 gmann alex_xu, oh, it is 400 till 2.35 and then 404
08:20:49 alex_xu gmann: yea...
08:21:39 gmann alex_xu, yea, we have to go till controller then
08:23:16 gmann alex_xu, its becoming large patch now as quota set want networks quota in sample file - https://review.openstack.org/#/c/467938/11
08:24:12 gmann alex_xu, i can add in same patch if you would not mind or can separate the networks quota things for sample files
08:25:27 alex_xu gmann: I think https://review.openstack.org/#/c/467938/11 is right
08:27:16 gmann alex_xu, you mean to fix quota set sample files in same patch?
08:28:59 alex_xu gmann: sorry, the separated patch is better
08:29:19 gmann alex_xu, ok
08:29:24 alex_xu gmann: https://review.openstack.org/#/c/467938 already have a lot of change in the api ref
08:30:10 gmann alex_xu, yes, so i will leave the sample files changes on this and just api-ref for quota class
08:33:22 alex_xu gmann: that is also good choice
08:43:45 openstackgerrit Merged openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
08:43:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
09:07:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use URIOpt https://review.openstack.org/479215
09:16:40 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
09:16:55 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
09:17:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276
09:37:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add 'networks' quota in quota sample files https://review.openstack.org/479227
09:47:35 openstackgerrit Monty Taylor proposed openstack/python-novaclient master: Stop posting to os-volumes_boot https://review.openstack.org/473833
09:57:01 bhagyashri_s johnthetubaguy: Hi, Could you please review patch : https://review.openstack.org/#/c/409644/ ?
09:58:04 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: Fixes Generation 2 VMs volume boot order https://review.openstack.org/461689
09:58:43 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: stop serial console workers while deleting vm files https://review.openstack.org/387831
09:59:16 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
10:00:13 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
10:12:09 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: Fixes log message in livemigrationops https://review.openstack.org/479245
10:12:39 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
10:15:48 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
10:24:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-baremetal-nodes endpoint instead of stevedore https://review.openstack.org/461480
10:53:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (3) https://review.openstack.org/452820
10:53:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818
10:53:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819
10:53:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor instance.power-off notification samples https://review.openstack.org/475860
10:56:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
11:03:07 gmann sfinucan, did not get you comment fully- https://review.openstack.org/#/c/479227/1
11:03:16 gmann sfinucan, you mean bug link
11:07:46 openstackgerrit Merged openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344
11:14:16 openstackgerrit Merged openstack/nova master: Extract custom resource classes from flavors https://review.openstack.org/473627
11:15:03 openstackgerrit Merged openstack/nova master: Add scatter gather utilities for cells https://review.openstack.org/475957
11:52:11 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:21:20 openstackgerrit Merged openstack/nova master: Removes potentially bad exit value from accepted list in Quobyte volume driver https://review.openstack.org/453537
12:43:27 sfinucan gmann: Yup, sorry - a bug link
12:43:36 sfinucan That seems like an outstanding bug, no?
12:43:42 sfinucan Or maybe I don't understand the issue enough
12:48:45 ralonsoh dansmith: hi
12:52:41 sfinucan alex_xu, gmann: Dumb question, but can you explain what's going on here https://review.openstack.org/#/c/478901/ It's funky compared to what I'd expect, heh
12:52:57 ralonsoh dansmith: it's about https://review.openstack.org/#/c/449257/28/nova/objects/instance_pci_requests.py@34. Do you think I need to create a separate object?
12:54:08 alex_xu sfinucan: this extension returned 3 resources https://review.openstack.org/#/c/478901/2/nova/api/openstack/compute/security_groups.py@509
12:54:20 alex_xu sfinucan: so I separate them into 3 patches
12:54:52 alex_xu sfinucan: in each patch, I reduce one resource returned from the extension https://review.openstack.org/#/c/478901/2/nova/api/openstack/compute/security_groups.py@517
12:55:15 sfinucan alex_xu: aha - that makes perfect sense. Thanks for the clarification :)
12:55:29 alex_xu sfinucan: thanks for the review :)
12:57:51 dtantsur edleafe: hi! is it me doing something wrong, or does the placement have to be updated too to support custom resource classes? http://logs.openstack.org/68/476968/4/check/gate-tempest-dsvm-ironic-ipa-partition-redfish-tinyipa-ubuntu-xenial/c0084db/logs/screen-n-sch.txt.gz#_Jun_26_14_32_54_180130
13:03:33 dtantsur hmm, does https://docs.openstack.org/developer/nova/placement.html#id2 mean that we should create the resource classes in use explicitly now?
13:12:06 sfinucan alex_xu: By rights, shouldn't this patch have been broken up in the same way too? https://review.openstack.org/#/c/478502/
13:12:26 sfinucan Not that I care other than to satisfy my curiosity

Earlier   Later