| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-20 | |||
| 15:58:20 | jaypipes | dansmith: after which he will be a VMWare employee. | |
| 15:59:29 | dansmith | oh | |
| 15:59:32 | dansmith | my | |
| 15:59:35 | dansmith | GAWD | |
| 16:01:34 | openstackgerrit | Merged openstack/nova master: Count networks to check quota https://review.openstack.org/446241 | |
| 16:02:29 | gibi_ | jaypipes: good luck with the api.fault bug | |
| 16:02:46 | jaypipes | gibi_: yeah, I might need to pass on that :( | |
| 16:02:56 | jaypipes | gibi_: that's some old-ass code in there :) | |
| 16:03:13 | gibi_ | jaypipes: I hope somebody can say 'delete that code!' | |
| 16:04:47 | jaypipes | gibi_: it's possible. some day. https://twitter.com/dims/status/542002018970529792 | |
| 16:06:27 | gibi_ | :) | |
| 16:07:36 | openstackgerrit | Merged openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245 | |
| 16:08:08 | openstackgerrit | Merged openstack/nova master: Count security groups to check quota https://review.openstack.org/457860 | |
| 16:09:12 | openstackgerrit | Merged openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246 | |
| 16:09:48 | openstackgerrit | Merged openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861 | |
| 16:10:17 | openstackgerrit | Merged openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247 | |
| 16:10:23 | dansmith | wow, just count those counting quotas merges | |
| 16:21:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (3) https://review.openstack.org/452820 | |
| 16:21:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | |
| 16:21:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | |
| 16:21:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/475860 | |
| 16:25:34 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform keypair.delete notification https://review.openstack.org/463946 | |
| 16:32:01 | openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 16:36:15 | openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 16:37:55 | openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 16:40:06 | openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 16:47:24 | openstackgerrit | Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677 | |
| 17:22:28 | openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/475563 | |
| 18:26:59 | mriedem | gibi_: i know this was already approved, but needed to be rebased and while it's sitting there i had a question inline https://review.openstack.org/#/c/460029/8/doc/notification_samples/instance-soft_delete-start.json | |
| 18:27:07 | mriedem | about transforming soft delete notifications to versioned payloads | |
| 18:36:44 | melwitt | mriedem: I deleted those tests on purpose because after changing floating_ips to a CountableResource, there are no more "project scoped quotas" that are refreshable or syncable. the majority of the tests in nova/tests/unit/test_quota.py rely on the global QUOTAS engine and once there are no more real examples of a certain type of quota, we would have to synthesize fake resources for the tests to still work | |
| 18:37:51 | melwitt | instead, I figured delete them since they're no longer applicable to anything real. the quota refresh command only refreshes ReservableResources | |
| 18:38:42 | mriedem | i thought the refresh command was using the _sync_*_quotas stuff still, which is in the db api, but would have to dig | |
| 18:38:57 | mriedem | if it's only using ReservableResources, and we don't have any of those, that's also grounds to remove it - but i need to check | |
| 18:39:27 | melwitt | mriedem: it does, but the _sync_* functions are only used on ReservableResources. the connection is made in nova/quota.py and each patch that removes the connection stops it from working that way | |
| 18:39:55 | melwitt | mriedem: we still have ReservableResources, they are just only user scoped and those unit tests are testing project scoped. it's confusing :( | |
| 18:39:57 | openstackgerrit | Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855 | |
| 18:40:44 | mriedem | i'll dig a bit | |
| 18:42:15 | melwitt | the patch that removes the last ReservableResource is "Count instances" and we're not there yet. k. the "user scoped quotas" are the ones in the "project_user_quotas_table" and the "project scoped quotas" are in the "quotas" table (floating_ips, fixed_ips, networks). that's what the tests refer to when it says "project key" it means one of: 'floating_ips', 'fixed_ips', or 'networks' | |
| 18:43:12 | mriedem | melwitt: ok so https://github.com/openstack/nova/blob/master/nova/quota.py#L900 checks https://github.com/openstack/nova/blob/master/nova/quota.py#L416 | |
| 18:43:15 | melwitt | there's also the global var in nova/db/sqlalchemy/api.py PER_PROJECT_QUOTAS that show the project keys | |
| 18:43:38 | mriedem | and since per_project_resources is fixedips, floatingips and networks, | |
| 18:43:48 | mriedem | and none of those are ReservableResources | |
| 18:44:11 | melwitt | yes | |
| 18:44:16 | mriedem | but we could still have user-scoped resources, | |
| 18:44:36 | mriedem | like server groups | |
| 18:44:53 | melwitt | yes, and we still do. we still have 'instances' 'cores' 'ram' as of that patch I think | |
| 18:45:17 | mriedem | let me check the tests being removed again | |
| 18:45:23 | melwitt | so those will still use reserve/commit/rollback and be synced/refreshed | |
| 18:45:24 | melwitt | k | |
| 18:46:35 | mriedem | rfolco: some issues in here https://review.openstack.org/#/c/460147/ | |
| 18:46:49 | openstackgerrit | Merged openstack/nova master: Fix using targeted cell context when finding services in cells https://review.openstack.org/475830 | |
| 18:46:51 | mriedem | rfolco: i'd really appreciate to leave the translation marker removal to a separate patch devoted to that | |
| 18:47:29 | melwitt | the only one we could argue is test_usage_refresh_invalid_user_key. I could do s/floating_ips/fake_resource_key/ there and the test would still work. the point of it had been, "verify you get Invalid if you try to refresh a valid key that isn't a valid user key" | |
| 18:48:17 | melwitt | and since there are no more project keys, we can't choose any valid keys. the test on L3270 is sort of identical | |
| 18:48:32 | rfolco | mriedem, looking | |
| 18:51:17 | openstackgerrit | Merged openstack/nova master: api-ref: fix hypervisor_hostname description for Ironic https://review.openstack.org/474723 | |
| 18:51:44 | openstackgerrit | Merged openstack/nova master: [doc] Updated sqlalchemy URL in migrate readme https://review.openstack.org/472549 | |
| 18:52:42 | mriedem | melwitt: removed my -1 for that - are we ok with https://review.openstack.org/#/c/457862/22/nova/network/floating_ips.py@225 ? | |
| 18:52:48 | mriedem | i think i talked myself into being ok with it | |
| 18:52:53 | mriedem | but i need you to close the deal | |
| 18:55:07 | melwitt | mriedem: thanks. the test on L3270 is the same test really anyway. looking at the next question ... | |
| 19:00:29 | melwitt | mriedem: looks like that's similar to the fixed ip one. I didn't think to call the self.deallocate* methods bc I thought to just use the inverse object functions to undo the create. but, I think technically maybe someone could create a floating ip and a dns domain in parallel and maybe could end up with orphaned dns domains that way. so it's probably most correct to call self.deallocate* | |
| 19:01:29 | melwitt | I'm not sure if associating the dns domain requires anything from the floating ip create response maybe. but either way it doesn't hurt to call the self.deallocate function | |
| 19:02:59 | mriedem | yeah i'm having a hard time figuring out how/where the dns domains and floating ips are correlated | |
| 19:03:03 | mriedem | just looking at https://developer.openstack.org/api-ref/compute/?expanded=create-allocate-floating-ip-address-detail#floating-ip-dns-records-os-floating-ip-dns-deprecated isn't helping me | |
| 19:03:13 | melwitt | yeah, I just cracked open the api-ref | |
| 19:03:33 | melwitt | heh "Floating IP DNS records (os-floating-ip-dns) (DEPRECATED)" | |
| 19:04:59 | melwitt | maybe it's this one, you provide an IP and it creates an entry Floating IP DNS records (os-floating-ip-dns) (DEPRECATED) | |
| 19:05:05 | melwitt | gah | |
| 19:05:12 | melwitt | https://developer.openstack.org/api-ref/compute/?expanded=create-or-update-dns-domain-detail,create-or-update-dns-entry-detail#create-or-update-dns-entry | |
| 19:06:55 | melwitt | I would guess that you would have to receive the address back from the API after creating the floating ip before you could create dns entries | |
| 19:07:58 | mriedem | wow https://developer.openstack.org/api-ref/compute/?expanded=create-or-update-dns-entry-detail#create-or-update-dns-entry | |
| 19:08:04 | mriedem | the request params table there is all sorts of wrong | |
| 19:08:39 | melwitt | oh, well that's the stuff from the url looks like | |
| 19:08:44 | mgagne | mriedem: actively working on the online volume extend change, adding all relevant unit tests atm. will complete tomorrow. I addressed most if not all comments. | |
| 19:09:06 | melwitt | but the other stuff isn't in the table. yeah | |
| 19:09:53 | mriedem | mgagne: sounds good | |
| 19:10:05 | mriedem | mgagne: i imagine you may be a bit sore | |
| 19:10:43 | mgagne | all fine, just a bit out of time for today ;) | |
| 19:11:27 | mriedem | melwitt: yeah it's this i think https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ip_dns.py#L225 | |
| 19:11:58 | melwitt | ah, yep, that looks like it | |
| 19:12:02 | mriedem | melwitt: so you can't add a floating ip address dns entry to the dns domain if you don't already have the floating ip address, | |
| 19:12:02 | mriedem | so, | |
| 19:12:22 | mriedem | we can probably just delete the floating ip if we go over-quota, rather than call deallocate_floating_ip | |
| 19:12:25 | mriedem | like you're doing | |
| 19:12:43 | melwitt | yeah, so it just looks like the same deal as the fixed ip alloc/dealloc thing, you can't have made other associations before the REST call returns something to the user for the user to call back and make associations | |
| 19:13:06 | mriedem | ok, and if we mess this up, the .002% of people that will likely hit it can yell at us | |
| 19:13:18 | melwitt | so I probably lucked out on that. and yes, that is also true heh | |
| 19:13:20 | mriedem | we'll just tell them dansmith told us it was ok | |
| 19:13:30 | melwitt | :D | |
| 19:13:54 | melwitt | sdague had a good point about calling that option "strict_quotas" instead of "recheck_quota." now that's gonna bug me | |
| 19:14:30 | melwitt | I know I could technically go ahead and deprecate "recheck_quota" and add strict_quotas and have both work for awhile | |
| 19:15:34 | sdague | melwitt: ++ | |
| 19:15:48 | sdague | it's not in a stable yet, so now would be the time to do it | |
| 19:15:48 | mriedem | melwitt: +W on the change, | |
| 19:15:57 | mriedem | you're getting eerily close to seeing light at the end of this quota tunnel | |
| 19:16:30 | melwitt | sdague: yeah, I think I'll do it then. that name is so much better. I just couldn't think of anything good | |
| 19:17:28 | melwitt | mriedem: \o/ can't believe it! also, I need to add all of the recheck quota test cases for instances now, that's gonna be a pain | |
| 19:18:36 | melwitt | I meant to have done it already but was busy and sort of avoiding it :( | |