Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-20
18:38:42 mriedem i thought the refresh command was using the _sync_*_quotas stuff still, which is in the db api, but would have to dig
18:38:57 mriedem if it's only using ReservableResources, and we don't have any of those, that's also grounds to remove it - but i need to check
18:39:27 melwitt mriedem: it does, but the _sync_* functions are only used on ReservableResources. the connection is made in nova/quota.py and each patch that removes the connection stops it from working that way
18:39:55 melwitt mriedem: we still have ReservableResources, they are just only user scoped and those unit tests are testing project scoped. it's confusing :(
18:39:57 openstackgerrit Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855
18:40:44 mriedem i'll dig a bit
18:42:15 melwitt the patch that removes the last ReservableResource is "Count instances" and we're not there yet. k. the "user scoped quotas" are the ones in the "project_user_quotas_table" and the "project scoped quotas" are in the "quotas" table (floating_ips, fixed_ips, networks). that's what the tests refer to when it says "project key" it means one of: 'floating_ips', 'fixed_ips', or 'networks'
18:43:12 mriedem melwitt: ok so https://github.com/openstack/nova/blob/master/nova/quota.py#L900 checks https://github.com/openstack/nova/blob/master/nova/quota.py#L416
18:43:15 melwitt there's also the global var in nova/db/sqlalchemy/api.py PER_PROJECT_QUOTAS that show the project keys
18:43:38 mriedem and since per_project_resources is fixedips, floatingips and networks,
18:43:48 mriedem and none of those are ReservableResources
18:44:11 melwitt yes
18:44:16 mriedem but we could still have user-scoped resources,
18:44:36 mriedem like server groups
18:44:53 melwitt yes, and we still do. we still have 'instances' 'cores' 'ram' as of that patch I think
18:45:17 mriedem let me check the tests being removed again
18:45:23 melwitt so those will still use reserve/commit/rollback and be synced/refreshed
18:45:24 melwitt k
18:46:35 mriedem rfolco: some issues in here https://review.openstack.org/#/c/460147/
18:46:49 openstackgerrit Merged openstack/nova master: Fix using targeted cell context when finding services in cells https://review.openstack.org/475830
18:46:51 mriedem rfolco: i'd really appreciate to leave the translation marker removal to a separate patch devoted to that
18:47:29 melwitt the only one we could argue is test_usage_refresh_invalid_user_key. I could do s/floating_ips/fake_resource_key/ there and the test would still work. the point of it had been, "verify you get Invalid if you try to refresh a valid key that isn't a valid user key"
18:48:17 melwitt and since there are no more project keys, we can't choose any valid keys. the test on L3270 is sort of identical
18:48:32 rfolco mriedem, looking
18:51:17 openstackgerrit Merged openstack/nova master: api-ref: fix hypervisor_hostname description for Ironic https://review.openstack.org/474723
18:51:44 openstackgerrit Merged openstack/nova master: [doc] Updated sqlalchemy URL in migrate readme https://review.openstack.org/472549
18:52:42 mriedem melwitt: removed my -1 for that - are we ok with https://review.openstack.org/#/c/457862/22/nova/network/floating_ips.py@225 ?
18:52:48 mriedem i think i talked myself into being ok with it
18:52:53 mriedem but i need you to close the deal
18:55:07 melwitt mriedem: thanks. the test on L3270 is the same test really anyway. looking at the next question ...
19:00:29 melwitt mriedem: looks like that's similar to the fixed ip one. I didn't think to call the self.deallocate* methods bc I thought to just use the inverse object functions to undo the create. but, I think technically maybe someone could create a floating ip and a dns domain in parallel and maybe could end up with orphaned dns domains that way. so it's probably most correct to call self.deallocate*
19:01:29 melwitt I'm not sure if associating the dns domain requires anything from the floating ip create response maybe. but either way it doesn't hurt to call the self.deallocate function
19:02:59 mriedem yeah i'm having a hard time figuring out how/where the dns domains and floating ips are correlated
19:03:03 mriedem just looking at https://developer.openstack.org/api-ref/compute/?expanded=create-allocate-floating-ip-address-detail#floating-ip-dns-records-os-floating-ip-dns-deprecated isn't helping me
19:03:13 melwitt yeah, I just cracked open the api-ref
19:03:33 melwitt heh "Floating IP DNS records (os-floating-ip-dns) (DEPRECATED)"
19:04:59 melwitt maybe it's this one, you provide an IP and it creates an entry Floating IP DNS records (os-floating-ip-dns) (DEPRECATED)
19:05:05 melwitt gah
19:05:12 melwitt https://developer.openstack.org/api-ref/compute/?expanded=create-or-update-dns-domain-detail,create-or-update-dns-entry-detail#create-or-update-dns-entry
19:06:55 melwitt I would guess that you would have to receive the address back from the API after creating the floating ip before you could create dns entries
19:07:58 mriedem wow https://developer.openstack.org/api-ref/compute/?expanded=create-or-update-dns-entry-detail#create-or-update-dns-entry
19:08:04 mriedem the request params table there is all sorts of wrong
19:08:39 melwitt oh, well that's the stuff from the url looks like
19:08:44 mgagne mriedem: actively working on the online volume extend change, adding all relevant unit tests atm. will complete tomorrow. I addressed most if not all comments.
19:09:06 melwitt but the other stuff isn't in the table. yeah
19:09:53 mriedem mgagne: sounds good
19:10:05 mriedem mgagne: i imagine you may be a bit sore
19:10:43 mgagne all fine, just a bit out of time for today ;)
19:11:27 mriedem melwitt: yeah it's this i think https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ip_dns.py#L225
19:11:58 melwitt ah, yep, that looks like it
19:12:02 mriedem melwitt: so you can't add a floating ip address dns entry to the dns domain if you don't already have the floating ip address,
19:12:02 mriedem so,
19:12:22 mriedem we can probably just delete the floating ip if we go over-quota, rather than call deallocate_floating_ip
19:12:25 mriedem like you're doing
19:12:43 melwitt yeah, so it just looks like the same deal as the fixed ip alloc/dealloc thing, you can't have made other associations before the REST call returns something to the user for the user to call back and make associations
19:13:06 mriedem ok, and if we mess this up, the .002% of people that will likely hit it can yell at us
19:13:18 melwitt so I probably lucked out on that. and yes, that is also true heh
19:13:20 mriedem we'll just tell them dansmith told us it was ok
19:13:30 melwitt :D
19:13:54 melwitt sdague had a good point about calling that option "strict_quotas" instead of "recheck_quota." now that's gonna bug me
19:14:30 melwitt I know I could technically go ahead and deprecate "recheck_quota" and add strict_quotas and have both work for awhile
19:15:34 sdague melwitt: ++
19:15:48 sdague it's not in a stable yet, so now would be the time to do it
19:15:48 mriedem melwitt: +W on the change,
19:15:57 mriedem you're getting eerily close to seeing light at the end of this quota tunnel
19:16:30 melwitt sdague: yeah, I think I'll do it then. that name is so much better. I just couldn't think of anything good
19:17:28 melwitt mriedem: \o/ can't believe it! also, I need to add all of the recheck quota test cases for instances now, that's gonna be a pain
19:18:36 melwitt I meant to have done it already but was busy and sort of avoiding it :(
19:26:07 mriedem that's ok, i'm putting off supporting compute node paging across multiple cells
19:33:24 sdague melwitt: so, given the bug dan was debugging this morning, is this bit right - https://review.openstack.org/#/c/416521/46/nova/compute/api.py@3022
19:33:48 sdague I also kind of wonder if there is going to need to be some standard scatter/gather callers here
19:34:54 dansmith sdague: I just replied to both
19:35:14 melwitt sdague: it is now wrong since dansmith's change to how target_cell works. the change is really old
19:35:36 melwitt so, good catch
19:40:36 openstackgerrit Merged openstack/nova master: placement: separate normalize_resources_qs_param https://review.openstack.org/475599
19:41:10 openstackgerrit Merged openstack/nova master: Use more specific asserts in tests https://review.openstack.org/466609
19:57:25 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP: Add Cinder v3 detach to swap_volume https://review.openstack.org/456971
20:31:47 cfriesen has anyone looked at what the qemu logs look like when block live-migrating under heavy localdisk IO? does it show up in the "Migration running for..." log from the live migration monitor?
20:48:16 mriedem melwitt: were you looking for a release note on this? https://review.openstack.org/#/c/393695/
20:49:30 melwitt mriedem: not really, just wanted a sanity check that we can be assured adding a minimum wouldn't break anyone. maybe a release note is the right thing?
20:50:13 melwitt I don't know why anyone would use -1 but what if they did. I didn't check yet what a -1 would do for that interval, maybe it just wouldn't even work
20:50:32 mriedem melwitt: don't know, but i left a reply in there too - -1 has special meanings in things
20:50:34 mriedem like retry forever,
20:50:35 mriedem or disable
20:51:00 melwitt yeah. so maybe the question is, does -1 work presently or not. if not, then the point is moot
20:57:40 openstackgerrit Merged openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862
21:03:31 openstackgerrit Eric Fried proposed openstack/nova master: WIP: hypervisor_hostname must match get_available_nodes https://review.openstack.org/475926
21:09:10 openstackgerrit Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288
21:16:50 openstackgerrit Merged openstack/nova master: Remove translation of log messages https://review.openstack.org/467948
21:17:22 openstackgerrit Merged openstack/nova master: [placement] Update placement devref to modern features https://review.openstack.org/469047
21:47:52 openstackgerrit Dan Smith proposed openstack/nova master: Fix and optimize external_events for multiple cells https://review.openstack.org/445142
21:52:26 openstackgerrit Eric Fried proposed openstack/nova master: hypervisor_hostname must match get_available_nodes https://review.openstack.org/475926
22:03:12 mriedem dansmith: we need to talk about https://review.openstack.org/#/c/391941/
22:03:23 mriedem the easy one first https://review.openstack.org/#/c/391941/50/nova/compute/cells_api.py
22:03:36 mriedem i'm thinking we don't need to be passing that tag kwarg through for cells v1
22:04:06 dansmith totes agree
22:04:22 mriedem ok now the hard one https://review.openstack.org/#/c/391941/50/nova/compute/api.py
22:04:28 mriedem the way artom has this written,
22:04:36 dansmith if we're checking service version and failing,
22:04:41 mriedem if you try to attach a volume with a tag to a shelved offloaded instance, he fails with a 400

Earlier   Later