| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-01 | |||
| 18:11:55 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | |
| 18:19:14 | mriedem | jaypipes: https://review.openstack.org/469959 btw | |
| 18:21:04 | openstackgerrit | Merged openstack/nova master: placement: shared resources when finding providers https://review.openstack.org/461574 | |
| 18:27:04 | openstackgerrit | Merged openstack/nova master: placement: tests for non-shared with shared https://review.openstack.org/461899 | |
| 18:27:46 | openstackgerrit | Merged openstack/nova master: placement: test non-shared out of inventory https://review.openstack.org/461900 | |
| 18:28:28 | openstackgerrit | Merged openstack/nova master: placement: test for agg association not sharing https://review.openstack.org/461901 | |
| 18:29:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add earlier-version tags for stable branch renos https://review.openstack.org/469969 | |
| 18:50:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add earlier-version tags for stable branch renos https://review.openstack.org/469969 | |
| 18:51:19 | artom | Blargh, InstanceMetadata isn't a Nova object | |
| 18:51:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add earliest-version tags for stable branch renos https://review.openstack.org/469969 | |
| 18:51:24 | mriedem | artom: nope | |
| 18:51:32 | artom | mriedem, that makes thing suck | |
| 18:51:39 | mriedem | "(11:14:26 AM) artom: Plus, how hard can it be?" | |
| 18:51:44 | artom | That was ironic | |
| 18:53:01 | artom | Why was it never made into one? Never sent over the wire between services? | |
| 18:53:09 | cfriesen_ | mriedem: what are the "earliest-version" tags for? | |
| 18:53:35 | mriedem | https://docs.openstack.org/developer/reno/usage.html#configuring-reno | |
| 18:53:44 | mriedem | "The earliest version to be included. This is usually the lowest version number, and is meant to be the oldest version. If unset, all versions will be scanned." | |
| 18:54:10 | mriedem | i'm actually unclear if those are needed or if we should have a config.yaml in each branch | |
| 18:54:16 | mriedem | but we have it for newton | |
| 19:00:00 | mriedem | jaypipes: is this done then? https://review.openstack.org/#/q/topic:bp/shared-resources-pike | |
| 19:03:53 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache https://review.openstack.org/469978 | |
| 19:05:29 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor instance-exists docstring and unit test https://review.openstack.org/462738 | |
| 19:05:30 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 19:10:23 | mriedem | dansmith: melwitt: we probably need to talk through this at some point https://review.openstack.org/#/c/446240/14/nova/api/openstack/compute/server_groups.py | |
| 19:10:46 | dansmith | okay well, not right now, I'm covered up in other stuff | |
| 19:10:53 | mriedem | i know, some point | |
| 19:12:34 | jaypipes | mriedem: nope. need to wire it up to the scheduler now. | |
| 19:12:44 | jaypipes | mriedem: and do the resource tracker side. | |
| 19:13:22 | jaypipes | mriedem: however, claims in the scheduler make things quite a bit simpler, which is why I've been waiting for that to get through | |
| 19:23:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache https://review.openstack.org/469978 | |
| 19:28:25 | melwitt | mriedem: I think that should be all fine because the used limits API calls the same functions that are being switched over to counting. so it will just count server groups to show how much is used, it won't be using the usage records anymore | |
| 19:28:34 | melwitt | but I will double check, of course | |
| 19:31:21 | mriedem | melwitt: ok left some questions in here about the race thing too https://review.openstack.org/#/c/446240/14 | |
| 19:31:25 | jaypipes | melwitt: you see my comment above? :) | |
| 19:31:27 | mriedem | i'm not sure i'm following that | |
| 19:31:42 | melwitt | mriedem: okay, will check and reply | |
| 19:33:59 | mriedem | avolkov also had comments/questions in PS13 | |
| 19:34:57 | melwitt | jaypipes: ah, yes. hmm ... maybe the placement stuff actually, want to make sure that's on the right track from the scheduler experts | |
| 19:35:35 | jaypipes | melwitt: you got it. | |
| 19:35:43 | melwitt | thanks! | |
| 19:37:44 | melwitt | thanks, missed those comments from avolkov | |
| 19:40:37 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Fix to return server groups quota in the quota-classes API https://review.openstack.org/468619 | |
| 19:51:22 | openstackgerrit | Jay Pipes proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578 | |
| 19:55:53 | openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient master: Better handle key=value pair not being key=value https://review.openstack.org/469988 | |
| 20:04:52 | openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient master: Better handle key=value pair not being key=value https://review.openstack.org/469988 | |
| 20:13:30 | edmondsw | what conf setting defines the "default periodic interval"? | |
| 20:14:30 | edmondsw | lots of conf settings have help that says if they are left at 0 (default) then the "default periodic interval" is used, but give no clue as to where that is found | |
| 20:14:50 | melwitt | mriedem: replied to all the comments | |
| 20:14:56 | mriedem | edmondsw: it's hard-coded in oslo | |
| 20:15:20 | mriedem | https://github.com/openstack/oslo.service/blob/master/oslo_service/periodic_task.py#L29 | |
| 20:15:24 | openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient master: Error out if nic auto or none are not alone https://review.openstack.org/470000 | |
| 20:15:38 | artom | There, a couple of paper cuts taken care of | |
| 20:15:53 | edmondsw | mriedem so 60? https://docs.openstack.org/developer/oslo.service/api/periodic_task.html#oslo_service.periodic_task.periodic_task | |
| 20:16:12 | mriedem | edmondsw: yes | |
| 20:16:15 | edmondsw | tx | |
| 20:16:39 | mriedem | artom: we should be able to tag a nic with auto | |
| 20:16:57 | mriedem | auto in most cases is the exact same behavior as not specifying anything for networks before 2.37 | |
| 20:17:05 | artom | mriedem, eh? I though the API was explicit in now allowing anything else with 'auto' | |
| 20:17:16 | artom | *not | |
| 20:17:26 | artom | I mean, we *should*, sure | |
| 20:17:35 | artom | But the way it's currently defined, we can't | |
| 20:17:59 | mriedem | please hand me that knife | |
| 20:18:45 | artom | mriedem, https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L88-L105 | |
| 20:19:00 | artom | It's 'oneOf' - either auto/none, or a "real" nic definition | |
| 20:19:22 | mriedem | yeah, ffs | |
| 20:19:45 | mriedem | probably why i originally had it written for the schema to be auto/none for the uuid field in the dict | |
| 20:20:02 | mriedem | but it was suggested that rather than have networks={'uuid': 'auto'} we just have networks='auto' | |
| 20:20:29 | artom | In retrospect that wasn't smart | |
| 20:20:36 | artom | But I agree the first option is... weird | |
| 20:20:51 | mriedem | well, it also wasn't caught in any way as we knew because of 2.42 | |
| 20:21:03 | artom | That didn't help, indeed | |
| 20:22:17 | mriedem | i suppose the api-ref should be updated, "The auto and none values cannot be used with any other network values, including other network uuids, ports or fixed IPs." to include "tag" | |
| 20:22:47 | mriedem | terrible terrible api | |
| 20:23:06 | mriedem | i guess you can pre-create the port in neutron, provide that to nova with the tag you want if you're an advanced user | |
| 20:23:21 | mriedem | but people don't even like doing that with volume types and boot from volume | |
| 20:24:20 | cfriesen_ | mriedem: doesn't make sense to me...if you script it it's no big deal | |
| 20:25:10 | cfriesen_ | besides, if you only have one vif from "networks='auto'" why would you need to tag it? | |
| 20:25:22 | mriedem | idk | |
| 20:25:24 | mriedem | maybe you don't | |
| 20:25:34 | mriedem | maybe we consider tags an advanced use case | |
| 20:25:40 | mriedem | and that's how we can justify now feeling bad about it | |
| 20:25:44 | mriedem | *not | |
| 20:25:58 | mriedem | whatever i can do to get through this day | |
| 20:29:14 | cfriesen_ | I see in Newton's online_data_migrations we go back and create a RequestSpec object for old instances. Is there stuff that we're going to end up missing since the info isn't available any more? | |
| 20:31:13 | mriedem | cfriesen_: that's a bauzas question | |
| 20:31:53 | cfriesen_ | okay, will ask him. | |
| 20:33:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update server create networks API reference description for tags https://review.openstack.org/470004 | |
| 20:33:13 | mriedem | artom: ^ | |
| 20:34:08 | mriedem | artom: maybe it's not so bad, could you even do networks={'tag': 'foo'} < 2.37? | |
| 20:34:22 | mriedem | i think it would puke if you specified networks w/o a network uuid or a port | |
| 20:35:40 | mriedem | yeah https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L418 | |
| 20:35:47 | mriedem | if port isn't specified, uuid is quired | |
| 20:35:49 | mriedem | *required | |
| 20:35:58 | mriedem | so you couldn't just provide a tag w/o anything else before | |
| 20:35:59 | mriedem | whew | |
| 20:37:36 | artom | mriedem, yeah, I don't think you could ever have a nic with *only* a tag | |
| 20:46:22 | artom | Oh hey, I got 470000! | |
| 20:47:10 | mriedem | is that a special number? | |
| 20:47:17 | artom | It's round | |