Earlier  
Posted Nick Remark
#openstack-nova - 2017-06-01
20:22:47 mriedem terrible terrible api
20:23:06 mriedem i guess you can pre-create the port in neutron, provide that to nova with the tag you want if you're an advanced user
20:23:21 mriedem but people don't even like doing that with volume types and boot from volume
20:24:20 cfriesen_ mriedem: doesn't make sense to me...if you script it it's no big deal
20:25:10 cfriesen_ besides, if you only have one vif from "networks='auto'" why would you need to tag it?
20:25:22 mriedem idk
20:25:24 mriedem maybe you don't
20:25:34 mriedem maybe we consider tags an advanced use case
20:25:40 mriedem and that's how we can justify now feeling bad about it
20:25:44 mriedem *not
20:25:58 mriedem whatever i can do to get through this day
20:29:14 cfriesen_ I see in Newton's online_data_migrations we go back and create a RequestSpec object for old instances. Is there stuff that we're going to end up missing since the info isn't available any more?
20:31:13 mriedem cfriesen_: that's a bauzas question
20:31:53 cfriesen_ okay, will ask him.
20:33:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Update server create networks API reference description for tags https://review.openstack.org/470004
20:33:13 mriedem artom: ^
20:34:08 mriedem artom: maybe it's not so bad, could you even do networks={'tag': 'foo'} < 2.37?
20:34:22 mriedem i think it would puke if you specified networks w/o a network uuid or a port
20:35:40 mriedem yeah https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L418
20:35:47 mriedem if port isn't specified, uuid is quired
20:35:49 mriedem *required
20:35:58 mriedem so you couldn't just provide a tag w/o anything else before
20:35:59 mriedem whew
20:37:36 artom mriedem, yeah, I don't think you could ever have a nic with *only* a tag
20:46:22 artom Oh hey, I got 470000!
20:47:10 mriedem is that a special number?
20:47:17 artom It's round
20:47:22 artom That's beer, right?
20:47:31 mriedem molson?
20:47:33 mriedem or labat?
20:47:40 artom Nah, I drink the fancy microbrews
20:48:01 mriedem so, michelob light ultra?
20:48:28 artom Don't have those here, but if I'm ever in... wherever they're from, I'll try
20:49:33 mriedem they're in 'merica
20:49:35 artom Lately I've taken a fancy to Vrooden's bitter
20:50:03 artom They're so hipster they don't even have their own domain: https://vrooden.wixsite.com/vrooden
20:50:18 artom 'merica eh? I hear it's dangerous for strangers there ;)
20:50:29 mriedem https://www.youtube.com/watch?v=M-MWN-XUtEQ is for when you're working hard all day being white and privileged, you need to relax with a bottle of water
20:51:09 mriedem they skipped the escalator
20:51:12 mriedem because they live in today
20:53:54 artom Dammit, http://www.checkmyprivilege.com/ is gone
21:02:02 openstackgerrit Artom Lifshitz proposed openstack/python-novaclient master: Error out if nic auto or none are not alone https://review.openstack.org/470000
21:32:04 mriedem cfriesen_: never fear, i'm going through your instance flavors api change
21:48:42 mriedem dansmith: cfriesen_: dhellmann fixed the missing renos issue https://review.openstack.org/#/c/470023/
21:49:15 mriedem just in time for everyone and their dog to be moving off mitaka
21:49:23 mriedem except penick
21:57:30 mriedem cfriesen_: reviewed
21:57:32 mriedem in great detail
22:03:16 cfriesen_ mriedem: thanks, will go check it out
22:03:56 cfriesen_ geez, could you add more stuff?
22:06:50 mriedem i don't think so
22:12:42 cfriesen_ mriedem: for the one that will be max_version 2.46, do you want it named as flavor_id_2_46?
22:14:33 mriedem looking
22:15:00 cfriesen_ and for "flavor_links" which is unversioned, did you want me to add a _2_46 version for clarity?
22:15:35 mriedem so flavor_id_body_2 -> flavor_id_body_2_46?
22:15:38 cfriesen_ that way all the sub-fields of flavor would be versioned
22:15:42 cfriesen_ yes
22:15:44 mriedem i think that's probably fine
22:16:02 mriedem i think it makes more sense than incrementing
22:16:46 cfriesen_ what about totally new ones like "flavor_original_name" ? add 2_47 or leave unversioned?
22:17:00 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/470037
22:17:00 cfriesen_ it'd be the only unversioned field
22:17:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Connecting Nova to DRBD storage nodes directly https://review.openstack.org/256292
22:17:35 mriedem melwitt: fixed the link ^
22:17:45 mriedem cfriesen_: i think you can leave it unversioned if it's not a duplicate
22:17:50 mriedem i'm good either way on those
22:17:52 cfriesen_ kay
22:21:12 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581
23:22:45 melwitt mriedem: coolness
23:27:26 openstackgerrit Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876
23:28:00 melwitt mriedem: +2. also wanted to show you this, easy two patch series for the PCIWeigher in scheduler, if you wanted to close out another blueprint https://review.openstack.org/#/c/379524/ cfriesen, you might also be interested in reviewing
23:28:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201
23:41:17 openstackgerrit Artom Lifshitz proposed openstack/python-novaclient master: Error out if nic auto or none are not alone https://review.openstack.org/470000
23:43:18 cfriesen_ melwitt: it's on my review list, but stuff keeps coming up.
23:43:32 melwitt ack
#openstack-nova - 2017-06-02
00:03:29 openstackgerrit John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
00:17:09 openstackgerrit Artom Lifshitz proposed openstack/python-novaclient master: Error out if nic auto or none are not alone https://review.openstack.org/470000
00:25:26 mriedem melwitt: yeah i wanted cfriesen_ to review that first
00:27:32 mriedem i guess i can gander while i'm on a call tonight
00:27:36 mriedem a welcome distraction
00:29:59 openstackgerrit guang-yee proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot https://review.openstack.org/400384
00:33:26 melwitt heh
00:41:23 openstackgerrit Artom Lifshitz proposed openstack/python-novaclient master: Better handle key=value pair not being key=value https://review.openstack.org/469988
00:59:07 mriedem melwitt: reviewed https://review.openstack.org/#/c/379524/ but i clearly don't understand how this works, or weighers for that matter
01:00:25 melwitt mriedem: oh, sorry about that :(
01:02:11 melwitt you're right that the weigher wants to favor hosts with fewer free PCI devices, packing like you said. it intends to leave room for possible future requests that actually need several devices at the same time
01:02:42 melwitt *several devices on the same host
01:05:12 cfriesen_ mriedem: you had suggested a functional test with non-empty extra-specs. I think that means adding extra-specs to one of the flavors used in the functional tests, no?
01:11:24 mriedem cfriesen_: or just create a new flavor for the test
01:11:37 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/470037
01:11:40 cfriesen_ mriedem: yeah, was just looking at that
01:17:04 cfriesen_ mriedem: is there a way to make a new flavor without needing to add new template files?
01:17:35 mriedem cfriesen_: yeah there is an api client used in the non-api sample functional tests
01:18:19 mriedem cfriesen_: something like this https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L171 ?
01:18:44 melwitt you can checkout this badass functional test I wrote for an example https://review.openstack.org/#/c/355091/8/nova/tests/functional/test_boot_from_volume.py@54
01:19:22 mriedem cfriesen_: the api sample tests use that mixin i think https://github.com/openstack/nova/blob/master/nova/tests/functional/api_samples_test_base.py#L69
01:19:34 mriedem yeah, so you can re-use that method
01:19:38 mriedem to create a new flavor with what you need in it
01:19:49 mriedem even extra specs
01:20:22 mriedem although...the flavor ref is in the api sample request,

Earlier   Later