| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-01 | |||
| 17:49:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: fix call args to destroy() during live migration rollback https://review.openstack.org/469958 | |
| 17:50:46 | mriedem | cfriesen_: yes | |
| 17:50:51 | mriedem | flavors are migrated to the api db | |
| 17:51:48 | cfriesen_ | mriedem: I don't see that mentioned anywhere in the Newton upgrade notes...I thought that normally we didn't require "nova-manage db online_data_migrations" to be run immediately after an upgrade, only sometime before the next upgrade. | |
| 17:53:28 | mriedem | it would have been mitaka | |
| 17:53:37 | mriedem | it's a blocker to get to newton | |
| 17:53:39 | mriedem | you run it during mitaka | |
| 17:54:07 | cfriesen_ | the online_data_migrations in mitaka don't touch flavors | |
| 17:54:15 | cfriesen_ | only in newton | |
| 17:54:26 | cfriesen_ | i think it *should* have been in mitaka | |
| 17:54:35 | mriedem | you're going to make me git blame this aren't you | |
| 17:54:44 | cfriesen_ | it was dansmith | |
| 17:54:54 | mriedem | yes i know | |
| 17:55:00 | mriedem | that's not why i'd git blame | |
| 17:55:05 | mriedem | i'd blame dan regardless :) | |
| 17:55:10 | cfriesen_ | lol | |
| 17:55:38 | dansmith | cfriesen_: no, it's not "just any time" it's "after things are back online" | |
| 17:55:44 | mriedem | https://review.openstack.org/#/c/294771/ | |
| 17:55:50 | jaypipes | melwitt: would you like reviews on the remainder of your quota series or reviews on your add project/user to placement series? pick one :) | |
| 17:56:06 | dansmith | that's the gate for a lot of compatibility things, so you're likely taking extra perf penalties until you've completed all of those things | |
| 17:56:56 | mriedem | which is the blocker migration? | |
| 17:57:16 | mriedem | 291 right? https://github.com/openstack/nova/commit/bf8b3946e6964059dce581f54ed4f928e2cdf5ab | |
| 17:57:23 | mriedem | oh no | |
| 17:58:33 | cfriesen_ | dansmith: I get that there would be performance penalties, but I thought nova tried to actually do online conversions as needed if you hadn't run it yet. | |
| 17:58:59 | cfriesen_ | dansmith: it appears that for flavors nova just didn't do the online conversions and relied on the DB to be converted | |
| 17:59:00 | dansmith | it depends on what it is | |
| 17:59:09 | dansmith | not for flavor moving across dbs | |
| 17:59:59 | cfriesen_ | the newton upgrade docs just say "The newton release has a lot of online migrations that must be performed before you will be able to upgrade to ocata. Please take extra note of this fact and budget time to run these online migrations before you plan to upgrade to ocata." | |
| 18:00:19 | cfriesen_ | that note should probably say that you need to run it right after upgrading to newton | |
| 18:00:28 | cfriesen_ | otherwise you won't be able to create flavors | |
| 18:01:14 | dansmith | Flavors are being moved to the API database for CellsV2. In this | |
| 18:01:14 | dansmith | release, the online data migrations will move any flavors you have | |
| 18:01:14 | dansmith | in your main database to the API database, retaining all | |
| 18:01:14 | dansmith | attributes. Until this is complete, new attempts to create flavors | |
| 18:01:15 | dansmith | will return an HTTP 409 to avoid creating flavors in one place that | |
| 18:01:16 | dansmith | may conflict with flavors you already have and are yet to be | |
| 18:01:17 | dansmith | migrated. | |
| 18:01:18 | dansmith | ^^ | |
| 18:02:14 | cfriesen_ | dansmith: I don't see that at https://docs.openstack.org/releasenotes/nova/newton.html#upgrade-notes | |
| 18:02:44 | dansmith | s'right here https://github.com/openstack/nova/blob/master/releasenotes/notes/flavors-moved-to-api-database-b33489ed3b1b246b.yaml | |
| 18:02:54 | dansmith | if it's not in the rendered notes, I dunno why | |
| 18:04:28 | mriedem | hmm wtf yeah that should be in the 14.0.0 release notes | |
| 18:04:40 | mriedem | i've been seeing issues with reno lately where it drops notes | |
| 18:04:45 | mriedem | or something... | |
| 18:04:46 | cfriesen_ | online-data-migrations-48dde6a1d8661e47.yaml says " | |
| 18:04:47 | cfriesen_ | Operators need to make | |
| 18:04:49 | cfriesen_ | sure all data is migrated before upgrading to the next release, and the new | |
| 18:04:50 | cfriesen_ | command provides a unified interface for doing it. | |
| 18:05:19 | cfriesen_ | whoops, sorry about formatting. anyway that doc makes it sound like "online_data_migrations" is intended to be a final cleanup before moving to the next release | |
| 18:05:37 | cfriesen_ | anyways, I now know and will plan accordingly | |
| 18:05:38 | dansmith | mriedem: we should really figure out some way for people to update the release notes when they find something vague or confusing | |
| 18:06:32 | mriedem | dansmith: well, simply showing the actual release notes is kind of a basic requirement | |
| 18:06:44 | mriedem | i shall bug dhellman | |
| 18:06:47 | dansmith | we can start there sure | |
| 18:08:25 | openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | |
| 18:08:54 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | |
| 18:09:04 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 18:11:55 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | |
| 18:19:14 | mriedem | jaypipes: https://review.openstack.org/469959 btw | |
| 18:21:04 | openstackgerrit | Merged openstack/nova master: placement: shared resources when finding providers https://review.openstack.org/461574 | |
| 18:27:04 | openstackgerrit | Merged openstack/nova master: placement: tests for non-shared with shared https://review.openstack.org/461899 | |
| 18:27:46 | openstackgerrit | Merged openstack/nova master: placement: test non-shared out of inventory https://review.openstack.org/461900 | |
| 18:28:28 | openstackgerrit | Merged openstack/nova master: placement: test for agg association not sharing https://review.openstack.org/461901 | |
| 18:29:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add earlier-version tags for stable branch renos https://review.openstack.org/469969 | |
| 18:50:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add earlier-version tags for stable branch renos https://review.openstack.org/469969 | |
| 18:51:19 | artom | Blargh, InstanceMetadata isn't a Nova object | |
| 18:51:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add earliest-version tags for stable branch renos https://review.openstack.org/469969 | |
| 18:51:24 | mriedem | artom: nope | |
| 18:51:32 | artom | mriedem, that makes thing suck | |
| 18:51:39 | mriedem | "(11:14:26 AM) artom: Plus, how hard can it be?" | |
| 18:51:44 | artom | That was ironic | |
| 18:53:01 | artom | Why was it never made into one? Never sent over the wire between services? | |
| 18:53:09 | cfriesen_ | mriedem: what are the "earliest-version" tags for? | |
| 18:53:35 | mriedem | https://docs.openstack.org/developer/reno/usage.html#configuring-reno | |
| 18:53:44 | mriedem | "The earliest version to be included. This is usually the lowest version number, and is meant to be the oldest version. If unset, all versions will be scanned." | |
| 18:54:10 | mriedem | i'm actually unclear if those are needed or if we should have a config.yaml in each branch | |
| 18:54:16 | mriedem | but we have it for newton | |
| 19:00:00 | mriedem | jaypipes: is this done then? https://review.openstack.org/#/q/topic:bp/shared-resources-pike | |
| 19:03:53 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache https://review.openstack.org/469978 | |
| 19:05:29 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor instance-exists docstring and unit test https://review.openstack.org/462738 | |
| 19:05:30 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 19:10:23 | mriedem | dansmith: melwitt: we probably need to talk through this at some point https://review.openstack.org/#/c/446240/14/nova/api/openstack/compute/server_groups.py | |
| 19:10:46 | dansmith | okay well, not right now, I'm covered up in other stuff | |
| 19:10:53 | mriedem | i know, some point | |
| 19:12:34 | jaypipes | mriedem: nope. need to wire it up to the scheduler now. | |
| 19:12:44 | jaypipes | mriedem: and do the resource tracker side. | |
| 19:13:22 | jaypipes | mriedem: however, claims in the scheduler make things quite a bit simpler, which is why I've been waiting for that to get through | |
| 19:23:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache https://review.openstack.org/469978 | |
| 19:28:25 | melwitt | mriedem: I think that should be all fine because the used limits API calls the same functions that are being switched over to counting. so it will just count server groups to show how much is used, it won't be using the usage records anymore | |
| 19:28:34 | melwitt | but I will double check, of course | |
| 19:31:21 | mriedem | melwitt: ok left some questions in here about the race thing too https://review.openstack.org/#/c/446240/14 | |
| 19:31:25 | jaypipes | melwitt: you see my comment above? :) | |
| 19:31:27 | mriedem | i'm not sure i'm following that | |
| 19:31:42 | melwitt | mriedem: okay, will check and reply | |
| 19:33:59 | mriedem | avolkov also had comments/questions in PS13 | |
| 19:34:57 | melwitt | jaypipes: ah, yes. hmm ... maybe the placement stuff actually, want to make sure that's on the right track from the scheduler experts | |
| 19:35:35 | jaypipes | melwitt: you got it. | |
| 19:35:43 | melwitt | thanks! | |
| 19:37:44 | melwitt | thanks, missed those comments from avolkov | |
| 19:40:37 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Fix to return server groups quota in the quota-classes API https://review.openstack.org/468619 | |