| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-25 | |||
| 17:20:47 | sdague | looking | |
| 17:23:32 | cuhler | mriedem: thanks | |
| 17:24:03 | sdague | mriedem: lgtm | |
| 17:28:06 | mriedem | thanks | |
| 17:28:24 | mriedem | dansmith: this is going to need your loving care https://review.openstack.org/#/c/420461/ - that's the newton backport to fix the default cell0 db name connection string we talked about yesterday | |
| 17:30:20 | mriedem | melwitt: do you want me to hold off on https://review.openstack.org/#/c/446239/ for now? | |
| 17:31:25 | mriedem | melwitt: we could probably do facade thing for count() in the object code in a separate cleanup if we want to move forward | |
| 17:32:28 | melwitt | mriedem: I was gonna wait until you were done with the tests to update anything to get them all at once. but, if I remove count() from nova/quota then I need to add a test for the facade thing in nova/objects/quotas. so it's up to you, want me to update it first and then you look again? | |
| 17:32:42 | mriedem | let me skim the tests first | |
| 17:33:06 | melwitt | k. I'm just running through the facade change locally to make sure things don't break | |
| 17:39:48 | mriedem | melwitt: why is test_reservation_expire removed? | |
| 17:40:15 | melwitt | mriedem: gah, I meant to put that back. accidental removal | |
| 17:40:22 | mriedem | ok, i'll leave a reminder | |
| 17:40:26 | melwitt | thanks | |
| 17:47:35 | savvas | mriedem: I noticed your fingerprints on https://blueprints.launchpad.net/nova/+spec/flavor-root-disk-none . Is there a best practice suggestion to secure this? For example I am bypassing the quota limitation on my local disks by removing the DiskFilter filter from nova (which is far from ideal..) but I have no way to enforce instances being created with use of cinder volumes instead of local block devices. | |
| 17:51:24 | savvas | I found this in nova.conf: max_local_block_devices but again this would not be ideal as reading the comments suggests that it won't pick alternative storage instead. | |
| 17:53:10 | mriedem | savvas: max_local_block_devices isn't what you think it is | |
| 17:53:29 | mriedem | savvas: otherwise i don't think there is a way to force users to boot from volume | |
| 17:53:45 | mriedem | let me find something for you to read | |
| 17:54:01 | mriedem | savvas: http://lists.openstack.org/pipermail/openstack-dev/2017-May/117012.html | |
| 17:56:40 | openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | |
| 17:59:09 | mriedem | melwitt: ok comments posted | |
| 18:00:07 | melwitt | mriedem: thanks, looking | |
| 18:03:52 | savvas | mriedem: interesting. So at this time there is no way to bypass/secure this limitation in the software? | |
| 18:05:23 | mriedem | savvas: i'm not aware of one outside of patches people have put into their systems | |
| 18:06:09 | mriedem | savvas: the outcome of that session was to write a spec for the short-term solution to auto-create block device mappings based on the flavor (which the operator controls) if bdms aren't requested by the user | |
| 18:06:20 | mriedem | not using extra specs | |
| 18:06:37 | savvas | ye the short term solution sounds acceptable though | |
| 18:06:59 | mriedem | says the guy that wants *anything* | |
| 18:07:02 | mriedem | :) | |
| 18:07:13 | mriedem | that's all queens release at this point | |
| 18:07:34 | jaypipes | mriedem, dansmith: if you have time. https://review.openstack.org/#/c/461574/ | |
| 18:07:41 | savvas | hehe, ye ;> | |
| 18:08:36 | mriedem | jaypipes: didn't you need an os-traits release and g-r bump for something in this series? | |
| 18:08:45 | savvas | basically it menas if we end up selling a project based solution, at this point having api or heat available to the tenant could lead to resource exhaustion | |
| 18:09:32 | mriedem | savvas: there is the reserved_host_disk_mb config option | |
| 18:09:36 | prometheanfire | mriedem: hi | |
| 18:09:48 | prometheanfire | http://logs.openstack.org/76/466476/9/check/gate-cross-nova-python27-ubuntu-xenial/89a6a52/testr_results.html.gz | |
| 18:10:01 | mriedem | prometheanfire: was this the same thing as last week? | |
| 18:10:04 | prometheanfire | think the new dogpile.cache makes nova sad | |
| 18:10:05 | prometheanfire | probably | |
| 18:10:09 | mriedem | or 2 weeks ago | |
| 18:10:13 | mriedem | did you open a bug for that? | |
| 18:10:23 | jaypipes | mriedem: no, that was this series: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/resource-provider-traits | |
| 18:10:36 | mriedem | jaypipes: ah ok | |
| 18:10:49 | mriedem | prometheanfire: please report a bug | |
| 18:10:55 | mriedem | i'm doing 4 things at once atm | |
| 18:11:03 | prometheanfire | ya | |
| 18:11:10 | prometheanfire | though I don't see a commit that'd do that | |
| 18:11:17 | jaypipes | mriedem: also, global requiremnts is already at os-traits >= 0.3, so we're cool. | |
| 18:11:26 | jaypipes | mriedem: just need to rebase that fix conflicts | |
| 18:11:58 | dansmith | jaypipes: so you still feel it's important/useful to have that giant sql query in comments inline there? | |
| 18:12:05 | dansmith | I commented on that, but don't think I saw a reply | |
| 18:12:24 | jaypipes | dansmith: you asked me to remove it from the commit message, which I did. | |
| 18:12:43 | jaypipes | dansmith: some (cdent, edleafe I think) have said the SQL in the code comment is useful. | |
| 18:13:06 | mriedem | dansmith: the example or the whole thing? | |
| 18:13:18 | melwitt | are they dreaming in SQL now too? | |
| 18:13:19 | mriedem | we do need a book describing what the massive sql build up is doing | |
| 18:13:42 | mriedem | the example starting at L829 could get outdated over time | |
| 18:13:51 | dansmith | jaypipes: you're right, I never committed that comment | |
| 18:14:01 | openstackgerrit | Jay Pipes proposed openstack/nova master: integrate trait cache with TraitList and Trait https://review.openstack.org/462770 | |
| 18:14:02 | openstackgerrit | Jay Pipes proposed openstack/nova master: add cache which keeps DB and os_traits in sync https://review.openstack.org/462769 | |
| 18:14:15 | dansmith | anyway, 200 lines of sql comment before any code is really distracting for me and I'd rather that be in devref if it's really useful to keep, | |
| 18:14:21 | dansmith | but I'm clearly in the minority | |
| 18:14:49 | jaypipes | dansmith: the comment is explaining how the SQLAlchemy joins are being built up. | |
| 18:15:01 | jaypipes | but again, whatevs, I'm happy to move it. just let me know. | |
| 18:15:09 | dansmith | I know | |
| 18:15:47 | dansmith | anyway, I don't think I can really review the sqla and find anything wrong with it, but I'm okay with just going based on the tests if that doesn't scare anyone else | |
| 18:15:47 | mriedem | we should have med_ look at it to spot the bug in the query like during the talk at the summit :) | |
| 18:15:56 | med_ | heh | |
| 18:16:15 | jaypipes | heh, reminds me I need to fix those slides... | |
| 18:16:18 | med_ | only if you are giving away t-shirts for my son. | |
| 18:17:40 | melwitt | I had assumed those were copied from the code, so it made me wonder if the code had the bugs too | |
| 18:19:43 | mriedem | dansmith: i'm in the same boat, i'm going to have to review mostly based on tests | |
| 18:19:52 | dansmith | mriedem: okay | |
| 18:20:12 | mriedem | also, with shit like this, we're going to have to jump in at some point and work out the bugs afterward | |
| 18:20:22 | mriedem | while jay is still working with us :) | |
| 18:20:45 | jaypipes | thanks for all your votes of confidence guys. | |
| 18:20:50 | mriedem | ha | |
| 18:21:41 | melwitt | mriedem: thanks for catching the gaps in the tests. I've changed things so many times I've lost track of some of them | |
| 18:21:47 | mriedem | jaypipes: you realize i'm not commenting on your technical ability but the fact this is a complicated new system being built, and therefore has to have bugs creep out over time | |
| 18:24:48 | openstackgerrit | Eric Fried proposed openstack/nova master: Nix redundant dict in set_inventory_for_provider https://review.openstack.org/468123 | |
| 18:32:50 | openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Have python-novaclient support global_request_id https://review.openstack.org/468126 | |
| 18:34:09 | sdague | mriedem: someone broke stable/newton and turned on a trusty upgrade job - https://review.openstack.org/#/c/420750/ | |
| 18:34:23 | sdague | last time that happened it was related to a bad exclude rule by cinder | |
| 18:35:02 | mriedem | i'm having a hard time parsing that | |
| 18:35:04 | mriedem | failing in the gate? | |
| 18:35:21 | mriedem | and exclude rule on a job in project-config? | |
| 18:35:32 | smcginnis | sdague: I had made changes there, but that was a few weeks back now. | |
| 18:35:53 | smcginnis | sdague: AFAIK, all grenade jobs should have been blocked on stable/newton. | |
| 18:36:16 | sdague | smcginnis: I have no idea the last time someone tried to get grenade changes on stable/newton through, it's not very often | |
| 18:36:33 | sdague | mriedem: yes, it's running a job it definitely should not be | |
| 18:36:42 | smcginnis | sdague: Now that mitaka is EOL, it shouldn't ever be done. | |
| 18:37:11 | sdague | smcginnis: agreed | |
| 18:37:45 | sdague | mriedem: anyway, the backport fixes for the cell naming change jobs aren't going to work until the jobs are cleaned up on the gate | |
| 18:38:24 | mriedem | sigh, ok | |
| 18:38:29 | mriedem | let me coffee up first | |
| 18:39:04 | sdague | mriedem: https://www.youtube.com/watch?v=yysnM407rjE - power up | |
| 18:39:39 | savvas | mriedem: your suggested host space reservation doesn't do much for me. If I enable that, instance creation fails if I select boot from image in new volume. If I set my root disk size to 0 to bypass that, the whole point is gone as heat for example deploys a simple instance with block device again and ignores the reserved host space | |
| 18:39:56 | savvas | any other thoughts? | |