| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-25 | |||
| 18:13:18 | melwitt | are they dreaming in SQL now too? | |
| 18:13:19 | mriedem | we do need a book describing what the massive sql build up is doing | |
| 18:13:42 | mriedem | the example starting at L829 could get outdated over time | |
| 18:13:51 | dansmith | jaypipes: you're right, I never committed that comment | |
| 18:14:01 | openstackgerrit | Jay Pipes proposed openstack/nova master: integrate trait cache with TraitList and Trait https://review.openstack.org/462770 | |
| 18:14:02 | openstackgerrit | Jay Pipes proposed openstack/nova master: add cache which keeps DB and os_traits in sync https://review.openstack.org/462769 | |
| 18:14:15 | dansmith | anyway, 200 lines of sql comment before any code is really distracting for me and I'd rather that be in devref if it's really useful to keep, | |
| 18:14:21 | dansmith | but I'm clearly in the minority | |
| 18:14:49 | jaypipes | dansmith: the comment is explaining how the SQLAlchemy joins are being built up. | |
| 18:15:01 | jaypipes | but again, whatevs, I'm happy to move it. just let me know. | |
| 18:15:09 | dansmith | I know | |
| 18:15:47 | dansmith | anyway, I don't think I can really review the sqla and find anything wrong with it, but I'm okay with just going based on the tests if that doesn't scare anyone else | |
| 18:15:47 | mriedem | we should have med_ look at it to spot the bug in the query like during the talk at the summit :) | |
| 18:15:56 | med_ | heh | |
| 18:16:15 | jaypipes | heh, reminds me I need to fix those slides... | |
| 18:16:18 | med_ | only if you are giving away t-shirts for my son. | |
| 18:17:40 | melwitt | I had assumed those were copied from the code, so it made me wonder if the code had the bugs too | |
| 18:19:43 | mriedem | dansmith: i'm in the same boat, i'm going to have to review mostly based on tests | |
| 18:19:52 | dansmith | mriedem: okay | |
| 18:20:12 | mriedem | also, with shit like this, we're going to have to jump in at some point and work out the bugs afterward | |
| 18:20:22 | mriedem | while jay is still working with us :) | |
| 18:20:45 | jaypipes | thanks for all your votes of confidence guys. | |
| 18:20:50 | mriedem | ha | |
| 18:21:41 | melwitt | mriedem: thanks for catching the gaps in the tests. I've changed things so many times I've lost track of some of them | |
| 18:21:47 | mriedem | jaypipes: you realize i'm not commenting on your technical ability but the fact this is a complicated new system being built, and therefore has to have bugs creep out over time | |
| 18:24:48 | openstackgerrit | Eric Fried proposed openstack/nova master: Nix redundant dict in set_inventory_for_provider https://review.openstack.org/468123 | |
| 18:32:50 | openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Have python-novaclient support global_request_id https://review.openstack.org/468126 | |
| 18:34:09 | sdague | mriedem: someone broke stable/newton and turned on a trusty upgrade job - https://review.openstack.org/#/c/420750/ | |
| 18:34:23 | sdague | last time that happened it was related to a bad exclude rule by cinder | |
| 18:35:02 | mriedem | i'm having a hard time parsing that | |
| 18:35:04 | mriedem | failing in the gate? | |
| 18:35:21 | mriedem | and exclude rule on a job in project-config? | |
| 18:35:32 | smcginnis | sdague: I had made changes there, but that was a few weeks back now. | |
| 18:35:53 | smcginnis | sdague: AFAIK, all grenade jobs should have been blocked on stable/newton. | |
| 18:36:16 | sdague | smcginnis: I have no idea the last time someone tried to get grenade changes on stable/newton through, it's not very often | |
| 18:36:33 | sdague | mriedem: yes, it's running a job it definitely should not be | |
| 18:36:42 | smcginnis | sdague: Now that mitaka is EOL, it shouldn't ever be done. | |
| 18:37:11 | sdague | smcginnis: agreed | |
| 18:37:45 | sdague | mriedem: anyway, the backport fixes for the cell naming change jobs aren't going to work until the jobs are cleaned up on the gate | |
| 18:38:24 | mriedem | sigh, ok | |
| 18:38:29 | mriedem | let me coffee up first | |
| 18:39:04 | sdague | mriedem: https://www.youtube.com/watch?v=yysnM407rjE - power up | |
| 18:39:39 | savvas | mriedem: your suggested host space reservation doesn't do much for me. If I enable that, instance creation fails if I select boot from image in new volume. If I set my root disk size to 0 to bypass that, the whole point is gone as heat for example deploys a simple instance with block device again and ignores the reserved host space | |
| 18:39:56 | savvas | any other thoughts? | |
| 18:44:08 | mriedem | savvas: no immediate thoughts, you could try the #openstack-operators channel to see if others are dealing with this, | |
| 18:44:27 | mriedem | or ask med_, cburgess or mgagne, our resident nova channel friendly ops, about their opinions | |
| 18:44:50 | cburgess | Do what now? | |
| 18:44:57 | mriedem | help someone | |
| 18:44:58 | mriedem | c'mon chet | |
| 18:45:14 | cburgess | Oh OK.. I gues I can try... | |
| 18:45:21 | savvas | :--) | |
| 18:45:34 | cburgess | Whats the question/issue/suggestion? | |
| 18:45:39 | savvas | Right | |
| 18:45:50 | savvas | well I am trying to avoid instances being created on local storage | |
| 18:46:11 | cburgess | Oh that one... | |
| 18:46:15 | savvas | our nodes have a 20G root partition and that should be utilized for system processes only. So apart from the fact that nova doesn't seem to recognize cinder storage as usable space | |
| 18:46:25 | savvas | it also simply refuses not to try and make local block devices | |
| 18:46:54 | cburgess | Define refuse? If you launch an instance with boot from volume you shouldn't see a local device. | |
| 18:49:16 | mriedem | cburgess: the problem is the same as usual, in that you can't force the user to do boot from volume | |
| 18:49:27 | mriedem | unless you automagic something in the api code to do that, as some have done | |
| 18:50:02 | cburgess | Correct | |
| 18:50:30 | cburgess | Hence the point of that whole sessions in bonston. I still need to write that spec... | |
| 18:50:34 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | |
| 18:50:37 | cburgess | You simply can't block an local instance launch in nova unless you write a custom patch. | |
| 18:51:00 | savvas | cburgess: for creating a new instance it works just fine via horizon but for example if I launch a simple stack it doesn't force me to select a boot volume or anything | |
| 18:51:03 | savvas | and it creates a local block device | |
| 18:52:15 | cburgess | savvas Yup.. its a limitation in openstack. Its something thats been of ongoing discussion for the past few cycles and we are working on a spec for.. queens (mriedem??) to try and address this limitation. | |
| 18:52:26 | mriedem | queens yes | |
| 18:52:58 | savvas | ye I read about that | |
| 18:53:08 | savvas | was hoping people may have found a workaround to deal with this problem though | |
| 18:53:44 | savvas | but seems like there aren't any (yet) | |
| 18:53:57 | mriedem | not outside of patching the api | |
| 18:54:01 | mriedem | which i'd advise against | |
| 18:54:25 | cburgess | Even I advise against patching the API now, even though I've been known to do it. | |
| 18:54:58 | cburgess | But yes... its a known issue and hopefully we can have a good discussion about it at the upcoming PTG and agree on a spec for the queens cycle to address this issue. | |
| 18:55:41 | mriedem | chet is in nova-patchers-anonymous | |
| 18:56:08 | cburgess | mriedem Meh.. I got tired of dansmith accusing me of doing awful things with his code. :P | |
| 18:56:21 | mriedem | i know i don't get tired of that | |
| 18:56:38 | dansmith | mriedem kinda likes the pain you know | |
| 18:56:47 | mriedem | i meant you hurting chet | |
| 18:56:47 | mriedem | not me | |
| 18:56:56 | dansmith | heh | |
| 19:02:03 | cfriesen | would there be value in having "nova-manage db online_data_migrations" return a value indicating whether or not it needs to be called again? (when specifying --max-count) | |
| 19:02:45 | cfriesen | seems like currently a calling script needs to parse the output | |
| 19:03:21 | melwitt | I thought it already returns 1 if there's more to do and 0 when there's no more to do. or are you saying it returns 0 when you use --max-count and there is still more to do? | |
| 19:05:01 | cfriesen | melwitt: it currently has "return ran and 1 or 0" and I think an exception in one of the migration routines will give a 0 | |
| 19:05:15 | cfriesen | I want success/partial-success/error return codes | |
| 19:05:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle conflict from neutron when addFloatingIP fails https://review.openstack.org/468136 | |
| 19:05:29 | mriedem | cfriesen: sounds like a bug | |
| 19:06:30 | cfriesen | mriedem: what should it return in the error case? 127 like we have if you specify a nonpositive integer for max-count? or something else | |
| 19:06:55 | mriedem | idk, sometimes we return 2 for things | |
| 19:07:00 | mriedem | it's not really defined | |
| 19:07:35 | sdague | cfriesen: so the problem with that is it means you have to turn off set -e in scripts | |
| 19:07:56 | mriedem | sdague: that's what we do in grenade for the nova-status upgrade check | |
| 19:08:06 | sdague | mriedem: yeh, which is a little suck | |
| 19:08:33 | mriedem | well maybe we don't https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/upgrade.sh#L97 | |
| 19:08:38 | mriedem | i must be thinking of something in d-g | |
| 19:08:56 | mriedem | ah we use || | |
| 19:08:59 | sdague | yeh | |
| 19:09:04 | sdague | which is just mask the world | |