Earlier  
Posted Nick Remark
#openstack-nova - 2017-05-23
20:28:31 mriedem on free granola bar
20:28:33 mriedem *one
20:28:45 penick free granola bar, that's a sweet deal
20:28:53 melwitt I ate a free Cliff bar here earlier
20:28:58 mriedem haha
20:29:26 mriedem i always feel great when some joke i make which might be offensive turns out to be actual fact
20:29:36 melwitt lol, right?
20:29:48 penick man that nova dungeon masters guide is handy
20:29:57 mriedem why do you think we don't add more cores?
20:30:01 mriedem limited supply
20:30:03 mriedem of guides
20:32:02 penick Not cheap to print. also the "Worlds best nova core" mugs don't exactly grow on trees. Those legbreakers at Cafepress charge a fortune
20:32:12 melwitt merge conflicts in local delete code ... grrrr
20:32:24 mriedem melwitt: blame dansmith
20:32:53 melwitt >:| angry eyebrows
20:33:18 dansmith go ahead
20:33:26 dansmith I'll flip this table and leave
20:34:13 melwitt the workstation table might be hard to flip. but could be toppled over
20:34:49 penick Cool cores don't watch tables flip. They just walk away. (-_- )ノ⌒┫ ┻ ┣
20:35:18 dansmith well, I'm not going to flip _this_ table since it has all my monitors and laptop on, but I will go find a suitable table with minimal collateral damage and flip that mofo
20:35:35 melwitt :D
20:36:07 melwitt we're all on the same page here
20:36:40 cburgess dansmith pics or it didn't happen
20:36:45 mriedem you know what i think we can all agree on?
20:36:51 mriedem removing the gluster volume driver https://review.openstack.org/#/c/463992/
20:36:59 cburgess +1 LGTM
20:37:02 dansmith heh
20:39:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup update_instance cell mapping handling https://review.openstack.org/467380
20:39:53 mriedem dansmith: i'm also hoping you don't find problems with ^
20:40:10 mriedem i think that stuff all predates _get_instance storing the targeted cell context on the instance object
20:40:41 dansmith mriedem: can we wait and or depends-on that on the multicell devstack patch?
20:40:56 mriedem i can put a change on top with the depends-on to test it out
20:41:02 dansmith okay
20:41:19 dansmith or just dependson it and remove it if it's good
20:41:20 mriedem https://review.openstack.org/#/c/436094/ right?
20:41:28 dansmith yar
20:41:38 mriedem i'm going to do another one on top of this for something else in that method
20:41:43 dansmith okay
20:41:44 mriedem we have some funny business toward the end
20:42:17 efried mriedem Thanks for the Sphinx thing; that spec change merged.
20:42:53 mriedem \o/
20:59:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove cells v2 transition code from update_instance https://review.openstack.org/467382
20:59:42 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test changes with multiple cells https://review.openstack.org/467383
21:00:40 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test changes with multiple cells https://review.openstack.org/467383
21:00:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove cells v2 transition code from update_instance https://review.openstack.org/467382
21:05:41 mriedem efried: heh https://review.openstack.org/#/c/465135/
21:05:46 mriedem this was a known issue awhile ago
21:06:41 efried mriedem Yes, I'm pretty sure I also proposed blocking 1.6.1 last week in some other project that didn't get updated by the bot.
21:07:14 efried mriedem keystone-specs, it was: https://review.openstack.org/#/c/465543/
21:08:04 efried mriedem I believe it was to get https://review.openstack.org/#/c/460344/ to pass.
21:36:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI._find_service https://review.openstack.org/461519
21:36:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532
21:36:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Use uuid for id in Services API https://review.openstack.org/464280
21:42:10 melwitt the target_cell behavior change tripped me up, sigh
21:42:10 melwitt I wish I had realized it much earlier
21:44:31 mriedem that's why i had to rebase ^
21:44:36 dansmith you're welcome
21:45:36 melwitt I totes forgot I used target_cell in my patches. go me
21:46:00 melwitt I was like, why are my counts totally whack?
21:47:07 dansmith because you forgot to use target_cel and were in 1998?
21:47:22 mriedem i'm assuming pants were backward
21:47:25 mriedem *weren't
21:47:49 melwitt dansmith: does target_cell magically make objects queried from the db under it have self._context set to the cell db?
21:48:45 dansmith melwitt: if you use the yielded context to initialize them then yes
21:48:54 melwitt like with target_cell(ctxt, mapping): instance = Instance.get()
21:49:28 dansmith target_cell(ctxt, mapping) as cctxt
21:49:36 dansmith instance = Instance.get_by_uuid(cctx)
21:49:38 dansmith will work
21:50:11 melwitt dansmith: like this, the instances are queried inside of group.count_members_by_user() https://review.openstack.org/#/c/457859/7/nova/quota.py@1890
21:50:40 melwitt and I'm not sure if the instances will have the right context in that case?
21:51:07 dansmith melwitt: no, see that's the problem.. group already has a context, right?
21:51:15 dansmith the target won't do anything it that context anymore
21:52:15 melwitt okay, I see
21:52:53 dansmith melwitt: not sure that code would actually work before actually
21:52:55 dansmith with multiple cells
21:53:09 melwitt yeah, I don't think so, now that I realize what's going on here
21:53:15 dansmith because it'll start several greenthreads, but by the time they run they'll all be back to untargeted I think
21:53:31 dansmith unless you copied it first, but that's what you get with the yield now anyway
21:54:20 penick mriedem did you just make a kris kross reference?
21:54:36 mriedem penick: you need to be around more,
21:54:40 mriedem those get made nearly weekly
21:54:46 melwitt yep, that
21:55:07 penick I felt like I had to say something, so you'd know at least someone got it
21:55:28 cdent don't encourage him
21:55:29 melwitt we all know kris kross
21:56:52 melwitt dansmith: I think things worked by chance bc the already targeted (via set_target or something) got the instance_group from the right cell earlier in the request
21:56:52 penick Ah ok. I wont jump (jump) next time I see it then
21:57:07 dansmith melwitt: sounds right
22:01:24 mriedem efried is gone?
22:01:40 melwitt instance create does a get for the requested server group to check the number of members quota. it currently assumes the group is in the same cell as the instance but I think that might not be always true. ugh
22:09:36 melwitt I guess that's out of scope for my patches though
23:19:59 openstackgerrit melanie witt proposed openstack/nova master: Add FixedIP.get_count_by_project() https://review.openstack.org/446246
23:19:59 openstackgerrit melanie witt proposed openstack/nova master: Add FloatingIP.get_count_by_project() https://review.openstack.org/446247
23:20:00 openstackgerrit melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to Instance object https://review.openstack.org/446244
23:20:01 openstackgerrit melanie witt proposed openstack/nova master: Add SecurityGroup.get_counts() https://review.openstack.org/446245
23:20:01 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
23:20:01 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
23:20:02 openstackgerrit melanie witt proposed openstack/nova master: Count server groups to check quota https://review.openstack.org/446240
23:20:02 openstackgerrit melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241
23:20:05 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521

Earlier   Later