| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-28 | |||
| 13:36:41 | figleaf | cdent: I missed the missing stuff :) | |
| 13:36:51 | mriedem | cdent: do we need that if the keep_alive thing fixed it? | |
| 13:37:09 | leakypipes | bauwser: feel like +2ing https://review.openstack.org/#/c/460281/ and/or figleaf's https://review.openstack.org/#/c/453862/? | |
| 13:37:27 | cdent | mriedem: no, I'm just mentioning it for sake of data (that using eventlet in tests is somewhat bad...) | |
| 13:37:41 | bauwser | leakypipes: I *could* | |
| 13:37:43 | mriedem | cdent: ah ok | |
| 13:37:47 | bauwser | just need to rebase some stuff :) | |
| 13:38:21 | cdent | mriedem: and with that done, I'll abandon | |
| 13:38:40 | leakypipes | Vgq | |
| 13:38:42 | leakypipes | :wq | |
| 13:38:45 | leakypipes | oh ffs | |
| 13:39:10 | figleaf | leakypipes: I didn't know 'ffs' was a vim command | |
| 13:39:17 | leakypipes | lmao | |
| 13:39:28 | bauwser | leakypipes: so, you'd be killing me | |
| 13:39:34 | bauwser | leakypipes: /me runs | |
| 13:40:03 | bauwser | because https://review.openstack.org/#/c/460281/ will have a bad day because of https://review.openstack.org/#/c/460281/ | |
| 13:40:36 | figleaf | bauwser: we need one to merge so that the other can rebase on top of it | |
| 13:40:47 | bauwser | figleaf: I know | |
| 13:40:50 | leakypipes | bauwser: yup, I know. it's a quick rebase for me, so feel free to +2 ed's | |
| 13:41:06 | bauwser | leakypipes: figleaf: FWIW, I did +2 ed's one | |
| 13:41:12 | leakypipes | coolio, thx! | |
| 13:41:15 | bauwser | hence my point about you needing extra work :) | |
| 13:41:28 | leakypipes | not a prob :) | |
| 13:41:37 | bauwser | I'll just +2 yours and so, we could +2/+W quickly after the rebase | |
| 13:41:37 | figleaf | bauwser: thanks. Always good to make jay work harder | |
| 13:41:44 | leakypipes | heh | |
| 13:41:45 | sfinucan | johnthetubaguy: Turns out the DB isn't what populates the output. A ViewBuilder does, which appears to be doing exactly as expected. Seems we do need a deprecation cycle for that policy, as you suggest | |
| 13:42:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't lazy-load flavor.projects during destroy() https://review.openstack.org/461032 | |
| 13:42:06 | mriedem | gibi: ^ | |
| 13:42:56 | johnthetubaguy | sfinucan: yeah, view builder extracts from the DB object, else DB changes would leak out the API by acciedent | |
| 13:48:44 | mriedem | johnthetubaguy: is there anything holding you up on https://review.openstack.org/#/c/459111/ and below? | |
| 13:49:45 | johnthetubaguy | mriedem: was doing TC stuff this morning, just been thinking of getting a coffee and looking at that now | |
| 13:49:53 | leakypipes | bauwser: k, rebased https://review.openstack.org/460281 | |
| 13:50:05 | mriedem | johnthetubaguy: cool | |
| 13:50:17 | mriedem | johnthetubaguy: i applaud you for actually doing TC stuff | |
| 13:50:33 | bauwser | leakypipes: +wapit | |
| 13:51:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove compatibility code for flavors https://review.openstack.org/460377 | |
| 13:52:58 | mriedem | bauwser: you wanted to do a newton release soon yeah? | |
| 13:53:03 | mriedem | we have two changes with +2s https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton | |
| 13:53:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove useless API tests https://review.openstack.org/461011 | |
| 13:53:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'FlavorRxtxController' extension https://review.openstack.org/461010 | |
| 13:53:11 | bauwser | mriedem: k | |
| 13:53:15 | bauwser | mriedem: looking at those | |
| 13:55:05 | bauwser | figleaf: not sure you understood my comment on https://review.openstack.org/#/c/460177/1/nova/compute/resource_tracker.py@1004 | |
| 13:55:34 | cdent | thanks sfinucan, TIL | |
| 13:55:53 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: implement get_inventory() for libvirt https://review.openstack.org/457782 | |
| 13:55:54 | leakypipes | bauwser, mriedem, cdent, figleaf: ^ | |
| 13:56:10 | sfinucan | cdent: Intel's favourite paradox, last I checked ;) | |
| 13:56:48 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Delete existing allocations for move operations or retries https://review.openstack.org/460433 | |
| 13:56:48 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Don't delete allocation if instance being scheduled https://review.openstack.org/460177 | |
| 13:56:49 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor https://review.openstack.org/460455 | |
| 13:56:49 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add reserved_host_cpus option https://review.openstack.org/460113 | |
| 13:57:09 | bauwser | leakypipes: mriedem: https://review.openstack.org/460113 is now with a reno file | |
| 13:58:26 | leakypipes | bauwser: +2 from me. thx for adding the reno. :) | |
| 13:58:50 | bauwser | leakypipes: and ty for adding the TODO note for the reserved value <3 | |
| 13:59:00 | leakypipes | :) np | |
| 13:59:28 | mriedem | leakypipes: you removed the ... :( | |
| 13:59:29 | openstackgerrit | Béla Vancsics proposed openstack/nova master: [WIP] Transform aggregate.update_metadata notification https://review.openstack.org/460625 | |
| 13:59:36 | mriedem | leakypipes: like, ...murder?! | |
| 14:01:33 | mriedem | leakypipes: https://review.openstack.org/#/c/457782/3/nova/virt/libvirt/driver.py | |
| 14:06:06 | leakypipes | mriedem: sorry, fixed. | |
| 14:06:06 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: implement get_inventory() for libvirt https://review.openstack.org/457782 | |
| 14:06:09 | leakypipes | ^ | |
| 14:08:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove dead code https://review.openstack.org/460662 | |
| 14:08:54 | mriedem | bauwser: comments inline https://review.openstack.org/#/c/460113/ | |
| 14:09:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Replace reserved_host_disk_mb with reserved_host_disk_gb https://review.openstack.org/460661 | |
| 14:09:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Reword 'reserved_host_memory_mb' help text https://review.openstack.org/461054 | |
| 14:09:08 | mriedem | bauwser: if you want to defer talking about the overheads stuff until we actually replace claims with allocations, that's fine | |
| 14:09:30 | bauwser | mriedem: jinx my mind | |
| 14:09:41 | bauwser | mriedem: I didn't wrote that for that reason | |
| 14:09:54 | bauwser | mriedem: adding that conf opt is separate from the use we could have for it | |
| 14:10:34 | bauwser | but given we don't use it now, it's unrelated, and either way both the 3 reserved opts need some doc string modifcation once we merge claims | |
| 14:10:44 | mriedem | leakypipes: https://review.openstack.org/#/c/457782/4/nova/tests/unit/virt/libvirt/test_driver.py :) | |
| 14:10:52 | mriedem | bauwser: true | |
| 14:11:23 | bauwser | mriedem: that said, very good point because I didn't changed that for the claims change | |
| 14:11:40 | bauwser | so you should leave a note for the top change | |
| 14:11:45 | mriedem | bauwser: throw a DocImpact on your claims change too so we get a docs bug | |
| 14:11:57 | bauwser | mriedem: fair to say | |
| 14:12:32 | sfinucan | melwitt: Could you have a look at mriedem's comments on this change? https://review.openstack.org/#/c/453174/2/releasenotes/notes/add-nova-manage-quota-commands-3ad1eb3186f9e29d.yaml | |
| 14:12:44 | mriedem | bauwser: left a comment | |
| 14:13:02 | bauwser | <3 | |
| 14:13:17 | mriedem | sfinucan: i've got a tattoo now that has a picture of melwitt telling me "s/quota/usage/" | |
| 14:13:20 | mriedem | literally scarred | |
| 14:13:27 | melwitt | lol | |
| 14:14:11 | melwitt | DID SOMEONE SAY QUOTAS >:| | |
| 14:14:20 | mriedem | ha | |
| 14:14:22 | mriedem | just like that | |
| 14:15:02 | melwitt | yeah, that has angry eyebrows on it | |
| 14:15:11 | mriedem | and a duck bill | |
| 14:16:52 | sfinucan | mriedem: can't argue with that. Thanks for reviewing those, btw | |
| 14:17:05 | sfinucan | mriedem: Seeing as you're at it, this one is the really interesting one -> https://review.openstack.org/#/c/453808/ | |
| 14:17:09 | sfinucan | ;) | |
| 14:17:14 | sfinucan | *a | |
| 14:17:23 | sfinucan | (they're all really interesting, naturally) | |
| 14:17:32 | mriedem | sfinucan: i glanced over that one last night | |
| 14:22:21 | sfinucan | bauwser: How does 'reserved_host_cpus' differ from 'vcpu_pin_set' https://review.openstack.org/#/c/460113/ | |
| 14:22:26 | sfinucan | outside of being less specific | |
| 14:22:42 | bauwser | sfinucan: well | |
| 14:23:15 | melwitt | sfinucan: I added a comment on the review | |
| 14:23:25 | sfinucan | melwitt: Cheers :) | |