Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-21
09:42:32 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Detach volumes on _rebuild_default_impl failure https://review.openstack.org/442105
09:42:33 frickler cdent: ah, that is a good point, so a public endpoint will make sense in the long run.
09:42:46 cdent frickler: another one of the things that might happen in the future warnings (like described above with asettle) is that the preference is for interface type to notmatter
09:42:55 cdent but that's a long way off
09:46:18 asettle Hey cdent since you're loving doc nova bugs, want another one? :D
09:46:37 cdent asettle: I can certainly look, but I'm making no promises
09:46:44 asettle Hooray!
09:46:46 asettle :p thanks
09:46:47 asettle https://bugs.launchpad.net/openstack-manuals/+bug/1683104
09:46:47 openstack Launchpad bug 1683104 in openstack-manuals "instance is not created rightly" [Undecided,New]
09:47:00 asettle I'm not convinced of this one, let's put it that way
09:47:57 asettle But, my nova deep dive konwledge is bad :(
09:48:06 cdent mine too!
09:49:36 cdent asettle: heh, interesting. their solution works but is undesirable :)
09:49:40 cdent s
09:50:10 asettle cdent: I guess my real concern is whether or not what we have is going to work or not.
09:51:03 cdent asettle: while the apache configuration is incorrect things will not work and the bugs that cascade from that will be various
09:51:15 asettle -.-
09:51:33 cdent the original cause of this person's problem is that their apache config is wrong and they have worked around it by not using apache at all for the placement service
09:52:00 asettle Well, that's info I can work with.
09:52:11 asettle Okay.
09:52:18 asettle Thanks cdent. I can reply to the reporter with that :)
09:52:32 asettle Unless you've already said something?
09:52:43 cdent I've started something, yeah, but haven't finished it yet
09:52:50 asettle Okay :) tahnks cdent I appreciate this
09:56:47 cdent asettle: I left a comment but more might be needed
09:59:18 asettle cdent: lgtm.
09:59:45 asettle Thanks again :)
10:00:33 cdent asettle: you're very welcome
10:00:39 asettle I owe you and bauzas a drink
10:34:48 openstackgerrit jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805
10:37:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
10:37:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
10:37:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228
10:59:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
10:59:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
10:59:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: add tags field to instance.update notification https://review.openstack.org/407228
11:11:47 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807
11:26:37 ralonsoh sfinucan: hi
11:29:37 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807
11:33:53 lyarwood kashyap, mdbooth ; ^ hopefully a straight forward bugfix for review if you have anytime this afternoon
11:35:12 kashyap lyarwood: Yeah, will look after lunch
11:57:54 openstackgerrit Andy McCrae proposed openstack/nova master: Allow CONTENT_LENGTH to be present but empty https://review.openstack.org/455710
11:59:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667
12:10:27 sfinucan ralonsoh: Hey
12:10:32 sfinucan Sorry - just back from lunch
12:17:00 ralonsoh sfinucan, me too
12:17:14 ralonsoh sfinucan, it's about https://review.openstack.org/#/c/427145/
12:18:27 ralonsoh sfinucan: don't you think optimizing this function (and adding a tool for future optimizations) worth the effort?
12:23:27 sfinucan ralonsoh: not really, no
12:23:40 sfinucan I mean, we're saving a fraction of a fraction of a second per instance boot
12:24:15 sfinucan and that's a not insignificant chunk of code to do so
12:24:39 ralonsoh sfinucan: I know, but the point is this function should have been done like this
12:24:51 sfinucan ralonsoh: Would there be any real world improvements by doing that?
12:25:20 ralonsoh sfinucan: and the biggest part of this code is a function useful for other possible optimizations
12:27:14 sfinucan and if they yield more significant results, I'd be happy to reassess that :)
12:27:14 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
12:28:05 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Fix races with nfs volume mount/umount https://review.openstack.org/383859
12:28:05 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Pass instance to connect_volume and disconnect_volume https://review.openstack.org/450383
12:28:33 mdbooth sfinucan johnthetubaguy: ^^^ also rebases those 2 commits, btw, but the only change is an additional comment in test_mount.py.
12:30:47 sfinucan ralonsoh: That whole section of the code could do with being examined closer for larger optimizations, particularly wrt integration with resource providers
12:31:55 sfinucan jaypipes would be able to provide more info, but iirc the PCI tracker model doesn't integrate into the resource providers model very well. Lots of opportunities for larger optimizations there
12:32:00 sfinucan mdbooth: Cool. Looking now
12:33:25 ralonsoh sfinucan: I'll talk to jaypipes
12:34:20 ralonsoh sfinucan: I'll see if we can optimize the code related to resource providers
12:34:37 ralonsoh sfinucan, thank you!
12:35:07 sfinucan ralonsoh: Definitely. I'm sure Jay would be ecstatic to have someone working on that :)
12:37:35 efried sdague Thanks for watching the PowerVM changes :)
12:38:57 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729
12:39:30 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288
12:39:59 sfinucan mdbooth: done and done. Thanks for addressing that small comment
12:40:27 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402
12:41:01 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
12:41:26 openstackgerrit Takashi NATSUME proposed openstack/nova master: WIP: Specify keymap on server boot (1/2) https://review.openstack.org/458752
12:41:27 efried sdague ^^ Rebased up through "SSP ephemeral disk support".
12:41:54 leakypipes ralonsoh: hey, I'm here :)
12:42:38 sfinucan oops
12:42:45 ralonsoh leakypipes: I was talking to Stephen about a patch I submitted https://review.openstack.org/#/c/427145/
12:43:29 ralonsoh leakypipes: it's an small optimization. The point is if the memoize function could be useful to store in cache and optimize some parts of resourde providers
12:43:43 sdague efried: ok, cool, I'll back through them in a minute
12:43:54 efried sdague Awesome.
12:43:59 ralonsoh leakypipes: let me know if you know any interesting place to use it
12:44:32 johnthetubaguy sfinucan: +1
12:45:05 leakypipes ralonsoh: will do. :)
12:45:22 zioproto dansmith: I have been in meetings the all day... later I hope to find time to clean that broken database we have seen yesterday, I will keep you updated
12:45:23 ralonsoh leakypipes: thanks!
12:52:39 openstackgerrit sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514
12:52:40 openstackgerrit sahid proposed openstack/nova master: network: add command to configure trusted mode for VFs https://review.openstack.org/458513
12:52:40 openstackgerrit sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820
12:53:21 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807
12:54:42 lyarwood mdbooth: posted some comments in the change, basically I was going to follow up with another change for resize failures as we can't just disconnect the new volume at that point.
12:56:09 sdague efried: there is an oslo_utils method for something in patch #4
12:58:28 mdbooth lyarwood: That's an excellent point.
13:00:20 openstackgerrit Andy McCrae proposed openstack/nova master: Allow CONTENT_LENGTH to be present but empty https://review.openstack.org/455710
13:12:09 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/458834
13:13:02 efried andymccr For the love of all that is holy, at some point you gotta tell us to bugger off and merge your patch already.
13:16:44 mriedem o/
13:18:31 rpodolyaka mriedem: hey! could you please take a look at https://review.openstack.org/#/c/458837/? Am I missing something or "?h=stable/newton" part was just missed in the original change?
13:19:57 mriedem was probably just missed, and i bet newton was master when that was added to novaclient
13:20:34 rpodolyaka ack, thanks!

Earlier   Later