Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-15
16:24:15 mdbooth Right, I thought so
16:24:20 dansmith being unscheduled means there is no instance record at all
16:29:34 bauzas dansmith: okay, I'm trying to keep things as simple as I can
16:30:01 bauzas dansmith: I think we're good having instance.az being set in the conductor
16:30:25 bauzas dansmith: but the problem is that we populate the Spec in the migrate method before calling the scheduler
16:31:15 dansmith bauzas: didn't we _just_ discuss why that's okay?
16:31:22 dansmith and the path to get out of that is you finishing your cleanup, if there's some reason for it
16:31:49 mriedem sfinucan: +W on the bottom one, i hit that yesterday
16:31:50 mriedem thanks
16:32:01 bauzas dansmith: well, it would mean that an instance having no AZ would be kept within that AZ
16:32:16 dansmith bauzas: which is by definition the default az anyway
16:32:32 sfinucan mriedem: (y)
16:32:32 bauzas dansmith: well, not exactly
16:32:59 bauzas dansmith: if I have a cloud with 999 nodes not in aggregates and one in one aggregate with metadata AZ foo
16:33:29 bauzas dansmith: then there are chances that instances can be booted on the single host part of foo
16:33:34 bauzas dansmith: which is okaty
16:34:11 bauzas dansmith: but then, a migrate would be only providing this host, compared to previously where it could return other hosts
16:34:42 dansmith bauzas: yeah, but.. again, the fix for that is finishing the reqspec cleanup right?
16:34:48 bauzas yup
16:35:03 bauzas I see your point
16:36:02 dansmith I don't think this is overly harmful if you're going to clean that bit up before the end of pike
16:39:17 bauzas dansmith: anyway, just reviewed your new change, you're updating instance.az after we regenerate the Spec, so it's all good
16:39:36 dansmith bauzas: no because we updated it on boot to the host we got to
16:39:42 dansmith bauzas: so resize will see that az
16:39:45 bauzas correct
16:39:54 bauzas nevermind the previous comment
16:40:19 dansmith bauzas: for this: https://review.openstack.org/#/c/442163/14/nova/availability_zones.py
16:40:34 bauzas yup ?
16:40:35 dansmith bauzas: I think I just want to make sure that the az thing calls the hostapi for listing services,
16:40:46 dansmith and then make sure I cover that method to ensure it iterates cells, okay?
16:40:49 bauzas yeah, like I said, I'm not opposed to merging this
16:41:26 bauzas I was just thinking of our test very not aware of cells
16:41:45 bauzas which could be a problem in the future given it's a DB-backed test case
16:41:55 dansmith I don't think it really needs to be, as long as it's getting the right service list,
16:42:01 dansmith but converting it is going to be somework
16:42:05 bauzas yeah
16:42:13 bauzas I'm turning my vote to +2
16:42:33 bauzas I'm just reviewing the conductor change
16:42:52 dansmith a functional test might be easier for that anyway, since they already have multiple cells
16:50:26 bauzas dansmith: I agree, most of the AZ unittests could be done in the functional tree even
16:50:49 mriedem dansmith: are we doing a cells pow wow in 10 min?
16:51:25 mriedem i hope so because 3 days in working from home and i'm starting to get lonely
16:52:01 dansmith mriedem: oh yeah
16:52:10 bauzas mriedem: dansmith: I won't be able to attend it
16:52:18 dansmith mriedem: man, you're going to have a hard road ahead then :)
16:52:20 dansmith bauzas: ack
16:56:40 dansmith bauzas: hmm, the notification sample test is failing because I end up with None for my az instead of 'nova'
16:57:01 dansmith so I guess I need to replicate that "or the default" logic in there somehwere
16:58:57 dansmith er, actually it should be in there already
16:59:01 dansmith guh this is ugly
17:00:01 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364
17:00:01 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906
17:00:02 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883
17:00:02 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add .keep files https://review.openstack.org/446069
17:02:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Introduce fast8 tox target https://review.openstack.org/446070
17:02:29 mriedem melwitt: just for you ^
17:02:31 mriedem (and me)
17:04:04 openstackgerrit Kaitlin Farr proposed openstack/nova master: Parse algorithm from cipher for ephemeral disk encryption https://review.openstack.org/446072
17:05:19 melwitt mriedem: <3
17:05:55 melwitt fast8, sounds like another fast and the furious movie
17:06:01 mdbooth mriedem: -- -HEAD is hardwired into my fingers now
17:07:12 mriedem mdbooth: i used to forget it, but yeah i have it like that too now
17:07:18 mriedem but some people didn't even know it existed
17:07:19 mriedem hence this
17:07:31 mriedem melwitt: let's call it tox -e niccage then
17:07:40 mriedem oh wait, wrong movie
17:07:55 mdbooth jason staitham?
17:08:01 melwitt you're probably thinking of xander cage
17:08:02 mdbooth however you spell that
17:09:19 sfinucan mdbooth is missing out
17:09:32 sfinucan ...and it's a xXx reference (also awesome)
17:09:37 jroll tox -e ludacris, duh
17:09:37 kashyap mdbooth: JSON statham
17:09:42 mdbooth kashyap: hehe
17:09:52 jroll both for the actor in F&F and because ludicrous speed
17:09:52 mdbooth sfinucan: Do you like the Transformers movies?
17:10:31 sfinucan mdbooth: Nope. All them robots fighting sounds too much like nightclub music
17:10:44 sfinucan #dubstep4lyf
17:10:50 melwitt same. I like F&F and xXx but not transformers
17:10:51 mdbooth sfinucan: Ok, we may have some movie taste in common :)
17:10:59 mdbooth Perhaps I'll try it.
17:11:16 openstackgerrit Matthew Booth proposed openstack/nova master: Add InstanceMappingList.get_by_instance_uuids https://review.openstack.org/445139
17:11:16 openstackgerrit Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142
17:11:17 openstackgerrit Matthew Booth proposed openstack/nova master: Add RequestContext.for_cell() https://review.openstack.org/445140
17:11:17 openstackgerrit Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141
17:11:30 sfinucan mdbooth: It's all Vin Diesel. He's just ridiculously likeable/charismatic
17:11:43 mdbooth The Groot guy?
17:12:09 sfinucan The one and only
17:20:02 lyarwood mdbooth: are you reviewing the rest of the bdm db and object change series btw? The UUID changes aren't that important overall, the attachment_id changes are the real priority
17:20:30 mdbooth lyarwood: Yes. However I got distracted by a 5 minute job which took rather longer.
17:20:53 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
17:20:53 openstackgerrit Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053
17:20:53 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
17:21:17 lyarwood mdbooth: np, just got back in from a walk myself
17:21:28 rfolco cdent, I got stuck on 409 conflict test case for delete all inventory. a fake generation number maybe ?
17:28:31 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Re-add templates https://review.openstack.org/446069
17:28:31 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364
17:28:32 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906
17:28:32 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883
17:29:56 cdent rfolco: there are two different cases: one where the generation is wrong (so a fake one would work), one where some of the inventory is in use (make some inventory, make an allocation against that inventory, try to do the DELETE). make sense?

Earlier   Later