Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-15
16:59:01 dansmith guh this is ugly
17:00:01 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364
17:00:01 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906
17:00:02 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883
17:00:02 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add .keep files https://review.openstack.org/446069
17:02:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Introduce fast8 tox target https://review.openstack.org/446070
17:02:29 mriedem melwitt: just for you ^
17:02:31 mriedem (and me)
17:04:04 openstackgerrit Kaitlin Farr proposed openstack/nova master: Parse algorithm from cipher for ephemeral disk encryption https://review.openstack.org/446072
17:05:19 melwitt mriedem: <3
17:05:55 melwitt fast8, sounds like another fast and the furious movie
17:06:01 mdbooth mriedem: -- -HEAD is hardwired into my fingers now
17:07:12 mriedem mdbooth: i used to forget it, but yeah i have it like that too now
17:07:18 mriedem but some people didn't even know it existed
17:07:19 mriedem hence this
17:07:31 mriedem melwitt: let's call it tox -e niccage then
17:07:40 mriedem oh wait, wrong movie
17:07:55 mdbooth jason staitham?
17:08:01 melwitt you're probably thinking of xander cage
17:08:02 mdbooth however you spell that
17:09:19 sfinucan mdbooth is missing out
17:09:32 sfinucan ...and it's a xXx reference (also awesome)
17:09:37 jroll tox -e ludacris, duh
17:09:37 kashyap mdbooth: JSON statham
17:09:42 mdbooth kashyap: hehe
17:09:52 jroll both for the actor in F&F and because ludicrous speed
17:09:52 mdbooth sfinucan: Do you like the Transformers movies?
17:10:31 sfinucan mdbooth: Nope. All them robots fighting sounds too much like nightclub music
17:10:44 sfinucan #dubstep4lyf
17:10:50 melwitt same. I like F&F and xXx but not transformers
17:10:51 mdbooth sfinucan: Ok, we may have some movie taste in common :)
17:10:59 mdbooth Perhaps I'll try it.
17:11:16 openstackgerrit Matthew Booth proposed openstack/nova master: Add InstanceMappingList.get_by_instance_uuids https://review.openstack.org/445139
17:11:16 openstackgerrit Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142
17:11:17 openstackgerrit Matthew Booth proposed openstack/nova master: Add RequestContext.for_cell() https://review.openstack.org/445140
17:11:17 openstackgerrit Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141
17:11:30 sfinucan mdbooth: It's all Vin Diesel. He's just ridiculously likeable/charismatic
17:11:43 mdbooth The Groot guy?
17:12:09 sfinucan The one and only
17:20:02 lyarwood mdbooth: are you reviewing the rest of the bdm db and object change series btw? The UUID changes aren't that important overall, the attachment_id changes are the real priority
17:20:30 mdbooth lyarwood: Yes. However I got distracted by a 5 minute job which took rather longer.
17:20:53 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
17:20:53 openstackgerrit Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053
17:20:53 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
17:21:17 lyarwood mdbooth: np, just got back in from a walk myself
17:21:28 rfolco cdent, I got stuck on 409 conflict test case for delete all inventory. a fake generation number maybe ?
17:28:31 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Re-add templates https://review.openstack.org/446069
17:28:31 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364
17:28:32 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906
17:28:32 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883
17:29:56 cdent rfolco: there are two different cases: one where the generation is wrong (so a fake one would work), one where some of the inventory is in use (make some inventory, make an allocation against that inventory, try to do the DELETE). make sense?
17:31:03 rfolco cdent, hmm, will try to find the allocation example. thx
17:32:41 cdent rfolco: there are some examples in allocation.yaml and with-allocations.yaml
17:33:24 cdent rfolco: in fact you could probably add a DELETE .../inventories in the with-allocations.yaml file and the existing allocations will provide the data for you
17:34:10 rfolco cdent, stop, you're almost writing the test for me :)
17:34:17 cdent :)
17:35:24 mdbooth lyarwood: Given that I'm conflicted myself on bdm.uuid naming issue, I'm going to drop that to bikeshed status and leave it up to you.
17:36:05 mdbooth Either way it's weird.
17:37:57 lyarwood mdbooth: yeah agreed that it's weird, I assume it's a hangover from copying BDMs the ec2 api
17:38:12 lyarwood from the ec2 api even
17:42:19 mdbooth lyarwood: We're absolutely never going to have more than 1 BDM with the same attachment_id, right? Just confirming that makes absolutely no sense.
17:44:15 lyarwood mdbooth: right, it's unique to along with the instance_uuid and volume_id iirc, pretty sure the spec calls that out /me checks
17:44:51 mdbooth lyarwood: I can't think how it would make sense.
17:45:20 lyarwood mdbooth: to have >1 bdms with the same attachment_id?
17:45:50 mdbooth lyarwood: Yes
17:45:58 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
17:45:58 openstackgerrit Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053
17:45:59 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
17:46:25 lyarwood mdbooth: yeah, I can't think of a use case
17:46:29 rebase /que/close
17:47:16 lyarwood mdbooth: from the spec '* Volume attachment is specific to a host uuid, instance uuid, and volume uuid'
17:48:14 mdbooth lyarwood: Cool, so dup attachment_id would definitely be a bug
17:49:23 lyarwood mdbooth: yeah mriedem suggested that already but as its nullable some backends might not allow it iirc
17:49:29 lyarwood mdbooth: but ask away and I can take another look
17:49:46 mdbooth lyarwood: ah, good point
17:49:58 mriedem mysql is fine with it a unique constraint over a nullable column
17:50:11 mdbooth mriedem: Does it allow more than 1 null?
17:50:14 mriedem i think postgres is too, but i think both can be configured to be more strict
17:50:22 mriedem mdbooth: not sure about that, i'd hope not
17:50:35 mdbooth In that case it wouldn't work here, which is unfortunate
17:50:53 mriedem to be clear, i was thinking of db2 when i said the constraint thing, because of muscle memory, but i know we don't support or care about db2
17:51:31 mdbooth They make debugging easier
17:52:46 mdbooth lyarwood: Incidentally, on the bdm.uuid thing, couldn't we mass populate that with an online migration?
17:55:19 mdbooth lyarwood: Same for attachment_id now that I think of it, if cinder gives us an api to create an attachment for a legacy-attached volume.
17:56:22 lyarwood mdbooth: I think that did come up for attachment_id but I don't think there's anything for us to call atm
17:57:25 lyarwood mdbooth: I can't find it at the moment but I'm sure there's also a comment against doing this for uuids btw
18:02:50 mriedem johnthetubaguy: i've reviewed the policy doc spec https://review.openstack.org/#/c/433010/
18:02:56 mriedem johnthetubaguy: some niggles inline
18:03:04 mriedem see what i did there, with your word?
18:03:08 johnthetubaguy mriedem: looking
18:03:17 johnthetubaguy mriedem: I totally did :)
18:03:34 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
18:03:34 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
18:03:35 openstackgerrit Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053
18:03:35 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
18:09:15 mdbooth lyarwood: Next 3 are the meaty ones. I'll start them in the morning.
18:14:12 mriedem cdent: edleafe: has anyone brought up the microversion question in https://review.openstack.org/#/c/433010/ yet?
18:14:27 mriedem or is that restriction already in place in the object code somewhere?
18:15:14 mriedem sorry wrong link
18:15:18 cdent sorry, mriedem, I'm not sure I've got enough context

Earlier   Later