| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-13 | |||
| 20:18:09 | sdague | sean-k-mooney: sure, and there are 2 other options here. One is deal with the fact that flake8-import-order is really pretty suplerfuous | |
| 20:18:32 | sdague | the other is get ovs-dpdk to run it's pep8 during build under isolation | |
| 20:19:17 | sean-k-mooney | well that would require chaging upstream ovs makefile which we coudl explore but it would be up to them to accept that change | |
| 20:19:43 | sdague | sean-k-mooney: or create and activate a venv before running it | |
| 20:20:23 | sean-k-mooney | sdague: so activate venv and run make as part of our devstack plugin then deactivte | |
| 20:20:37 | sdague | sean-k-mooney: sure, if that works for the isolation | |
| 20:21:01 | sean-k-mooney | sdague: thats an option that i had not taught of. thats certenly possibel. | |
| 20:21:10 | sdague | I also, honestly think that flake8-import-order being installed globally seems weird just in general due to fallout | |
| 20:21:31 | efried | I just joined, so I don't have the scrollback, but +1 to that. | |
| 20:21:41 | sean-k-mooney | sdague: yes but to me that is a direct resutl of the devstack behavor | |
| 20:21:52 | sdague | and I would tend to pull that from global requirements, as I think that's going to have knock on break effects for lots of people that flake8 from the system (which is not an unreasonable thing to want to do) | |
| 20:22:13 | sean-k-mooney | sdague: generally test-requireemnt.txt are not expected to be installed systemwide or at least i never assume they will be | |
| 20:22:40 | sdague | sean-k-mooney: I accept that if you make it so that we never install them | |
| 20:23:22 | sdague | I don't want to be in a weird middle ground where we have to explain to devs... "oh, well for that use case you have to set this to TRUE, but to get this other thing to work, it has to be FALSE" | |
| 20:24:12 | sean-k-mooney | sdague: ill look into the vnev to wrap make, but would you be open to a patch to never install test requirement in devstack then without the conditional | |
| 20:24:37 | sdague | sean-k-mooney: yep, if you can validate that it's going to work for people | |
| 20:26:21 | sdague | git log -S TESTONLY | |
| 20:26:36 | sdague | will give you some of the change history about when this was conditional | |
| 20:27:03 | sean-k-mooney | well i can ask on the mailing list if people have objection to that change and we could try running the exsitng gate jobs for several projects with the proposed patch and see if they break? | |
| 20:27:17 | sean-k-mooney | git log -S TESTONLY ? in what repo | |
| 20:27:32 | sdague | sean-k-mooney: well, the issue is also for developer use case, not just the gate case | |
| 20:27:37 | sdague | sean-k-mooney: devstack repo | |
| 20:28:40 | sean-k-mooney | ah yes but again when im doing upstream dev i use devstack to set up my enviornment but i have always used the tox workflow so im not sure how many people expect them to be system wide | |
| 20:28:58 | sean-k-mooney | but that is a vail point | |
| 20:29:05 | sean-k-mooney | it has to work for both usecases | |
| 20:33:03 | sean-k-mooney | sdague: any thanks for taking a look at this. ill feedback you suggestion to the rest of my team and we will see if the venv change works. if not we will procuse this as an addtional path. as for flake8-import-order are you going to propose a revert or let it stand for now | |
| 20:33:55 | sean-k-mooney | *anyway | |
| 20:34:57 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | |
| 20:39:12 | rfolco | cdent, around? | |
| 20:39:26 | cdent | yeah rfolco, for a little while longer, what's up? | |
| 20:39:47 | sdague | sean-k-mooney: I'll +2 a removal of it if you put it up | |
| 20:39:59 | sdague | we can leave the import reordering, just pull the install of it | |
| 20:40:09 | rfolco | cdent, quick question: how to make tox -epy27 run my new created lass under test_microversions.py? where am I noob'ing ? | |
| 20:40:24 | sdague | sean-k-mooney: then look at removing it from global-requirements | |
| 20:40:49 | edleafe | rfolco: what command are you running now? | |
| 20:40:54 | cdent | rfolco: you mean running just one test? | |
| 20:40:55 | rfolco | tox -epy27 test_microversion.TestMicroversionUtility | |
| 20:41:08 | rfolco | its ignoring my class | |
| 20:41:11 | sean-k-mooney | sdague: of flake8-import-order, ok i can do that tomorow, i am just wrapping up for the evening so ill add you to the review when its up. | |
| 20:41:39 | sean-k-mooney | sdague: and ya i did not want to revert the whole patch as everything else looked good to me. | |
| 20:41:54 | cdent | rfolco: if you do 'tox -epy27 test_microversion' does it get all the tests in the file? | |
| 20:42:11 | rfolco | all them, except mine :) | |
| 20:42:36 | edleafe | rfolco: did you save your changes? :) | |
| 20:42:42 | cdent | rfolco: what's the name of your test method(s)/ in the class? | |
| 20:43:21 | rfolco | class TestMicroversionUtility(test.NoDBTestCase): .... and def raise_405_out_of_date_version(self): | |
| 20:43:35 | cdent | s/raise/test_raise/ | |
| 20:43:44 | edleafe | rfolco: test names have to start with 'test_' | |
| 20:43:47 | rfolco | oh boy | |
| 20:44:14 | rfolco | cdent, edleafe: thats it. Thx | |
| 20:44:19 | cdent | frustratring isn't it? | |
| 20:44:38 | cdent | wow, it's a bad day for typing. it might be time for me to retire for the day | |
| 20:45:25 | rfolco | cdent, silly mistake :-/ | |
| 20:45:38 | edleafe | cdent: I'll be leaving early to catch this tonight: https://www.tobincenter.org/box-office/2017-03/purple-rain-live | |
| 20:46:02 | cdent | \o/ | |
| 20:46:03 | edleafe | Our daughter is in the philharmonic | |
| 20:46:06 | cdent | that'll be fun | |
| 20:47:20 | cdent | yeah, this cold is killing me, I'm calling it a day | |
| 20:53:29 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.unrescue notifications https://review.openstack.org/388275 | |
| 20:56:39 | mriedem | hmm, functional test in https://review.openstack.org/#/c/443395/ fails in ocata, methinks we need the context untarget thing... | |
| 20:56:58 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | |
| 20:57:48 | mriedem | hmm, but the context should have a cell set on it in ocata | |
| 21:03:11 | satyar | johnthetubaguy: tested the fix https://review.openstack.org/#/c/437222 for bug https://bugs.launchpad.net/nova/+bug/1668267 | |
| 21:03:11 | openstack | Launchpad bug 1668267 in OpenStack Compute (nova) "Nova fails to correctly update the quota when deleting lots of VMs, some of which previously failed due to a quota error" [High,In progress] - Assigned to Pushkar Umaranikar (pushkar-umaranikar) | |
| 21:03:33 | satyar | still able to reproduce the issue | |
| 21:04:10 | dansmith | satyar: that's not the fix | |
| 21:04:31 | dansmith | satyar: this is: https://review.openstack.org/#/c/443395/ | |
| 21:04:45 | mriedem | well, | |
| 21:04:54 | mriedem | on master it's that and https://review.openstack.org/#/c/443403/ | |
| 21:05:07 | mriedem | on ocata it should just be https://review.openstack.org/#/c/443395/ and i'm working on the backport but hitting some issues | |
| 21:06:02 | satyar | ohh ok will be testing it Thanks :) | |
| 21:06:25 | satyar | thanks dansmith and mriedem | |
| 21:08:57 | mriedem | satyar: i've marked the other bug as a duplicate | |
| 21:09:09 | satyar | to? | |
| 21:09:42 | satyar | ok got it | |
| 21:09:45 | mriedem | https://bugs.launchpad.net/nova/+bug/1670627 | |
| 21:09:45 | openstack | Launchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,Confirmed] | |
| 21:10:26 | openstackgerrit | Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035 | |
| 21:11:32 | satyar | ideally it should be opposite that bug should be duplicate of the first one ;) but its fine | |
| 21:11:59 | satyar | aslong as we fix the issue :) | |
| 21:12:04 | mriedem | satyar: yeah, i guess triage failed us, it went under the one it did because someone showed up in the channel last wednesday and brought it up | |
| 21:12:17 | mriedem | right place right time | |
| 21:12:21 | satyar | :P | |
| 21:23:23 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/347161 | |
| 21:28:43 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | |
| 21:33:06 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Reset instance status on invalid host https://review.openstack.org/401009 | |
| 21:35:25 | mriedem | wtf, in ocata, when the instance is in cell0 and i go to delete it, i get a 404, but when i do a GET i get a response | |
| 21:43:27 | melwitt | mriedem: are you using novaclient to delete it or the REST API directly? because I feel like I have seen that before when I had bugs in my own code because of how novaclient does a GET before doing the delete. I can't remember the details off the top of my head | |
| 21:46:34 | mriedem | melwitt: rest api, this is that functional regression test for the quota patch | |
| 21:46:54 | mriedem | https://review.openstack.org/#/c/443395/ but on ocata | |
| 21:47:15 | mriedem | the functional regression test fails waiting for the server to be gone after the delete request, and it's because the delete request fails with a 404 when looking up the instance.flavor | |
| 21:47:17 | melwitt | oh, hm | |
| 21:47:45 | mriedem | https://gist.github.com/mriedem/cece80e5ab375c2fad6d9d599851c2dc | |
| 21:48:19 | mriedem | i think i know why, | |
| 21:48:27 | mriedem | in master the context is targeted when you get the instance | |
| 21:48:31 | mriedem | in ocata it's not, | |
| 21:48:46 | mriedem | so in this change when it's looking up the flavor from the instance, the context isn't targeted to cell0 | |
| 21:49:29 | mriedem | but we want the quotas in the main cell db, | |
| 21:49:49 | mriedem | so i'm going to have to do the same helper method that i had on master for getting the flavor from a targeted context before creating the reservation | |
| 21:49:49 | mriedem | ugh | |
| 21:50:45 | openstackgerrit | Anusha Unnam proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |