| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-13 | |||
| 20:33:03 | sean-k-mooney | sdague: any thanks for taking a look at this. ill feedback you suggestion to the rest of my team and we will see if the venv change works. if not we will procuse this as an addtional path. as for flake8-import-order are you going to propose a revert or let it stand for now | |
| 20:33:55 | sean-k-mooney | *anyway | |
| 20:34:57 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | |
| 20:39:12 | rfolco | cdent, around? | |
| 20:39:26 | cdent | yeah rfolco, for a little while longer, what's up? | |
| 20:39:47 | sdague | sean-k-mooney: I'll +2 a removal of it if you put it up | |
| 20:39:59 | sdague | we can leave the import reordering, just pull the install of it | |
| 20:40:09 | rfolco | cdent, quick question: how to make tox -epy27 run my new created lass under test_microversions.py? where am I noob'ing ? | |
| 20:40:24 | sdague | sean-k-mooney: then look at removing it from global-requirements | |
| 20:40:49 | edleafe | rfolco: what command are you running now? | |
| 20:40:54 | cdent | rfolco: you mean running just one test? | |
| 20:40:55 | rfolco | tox -epy27 test_microversion.TestMicroversionUtility | |
| 20:41:08 | rfolco | its ignoring my class | |
| 20:41:11 | sean-k-mooney | sdague: of flake8-import-order, ok i can do that tomorow, i am just wrapping up for the evening so ill add you to the review when its up. | |
| 20:41:39 | sean-k-mooney | sdague: and ya i did not want to revert the whole patch as everything else looked good to me. | |
| 20:41:54 | cdent | rfolco: if you do 'tox -epy27 test_microversion' does it get all the tests in the file? | |
| 20:42:11 | rfolco | all them, except mine :) | |
| 20:42:36 | edleafe | rfolco: did you save your changes? :) | |
| 20:42:42 | cdent | rfolco: what's the name of your test method(s)/ in the class? | |
| 20:43:21 | rfolco | class TestMicroversionUtility(test.NoDBTestCase): .... and def raise_405_out_of_date_version(self): | |
| 20:43:35 | cdent | s/raise/test_raise/ | |
| 20:43:44 | edleafe | rfolco: test names have to start with 'test_' | |
| 20:43:47 | rfolco | oh boy | |
| 20:44:14 | rfolco | cdent, edleafe: thats it. Thx | |
| 20:44:19 | cdent | frustratring isn't it? | |
| 20:44:38 | cdent | wow, it's a bad day for typing. it might be time for me to retire for the day | |
| 20:45:25 | rfolco | cdent, silly mistake :-/ | |
| 20:45:38 | edleafe | cdent: I'll be leaving early to catch this tonight: https://www.tobincenter.org/box-office/2017-03/purple-rain-live | |
| 20:46:02 | cdent | \o/ | |
| 20:46:03 | edleafe | Our daughter is in the philharmonic | |
| 20:46:06 | cdent | that'll be fun | |
| 20:47:20 | cdent | yeah, this cold is killing me, I'm calling it a day | |
| 20:53:29 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.unrescue notifications https://review.openstack.org/388275 | |
| 20:56:39 | mriedem | hmm, functional test in https://review.openstack.org/#/c/443395/ fails in ocata, methinks we need the context untarget thing... | |
| 20:56:58 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | |
| 20:57:48 | mriedem | hmm, but the context should have a cell set on it in ocata | |
| 21:03:11 | satyar | johnthetubaguy: tested the fix https://review.openstack.org/#/c/437222 for bug https://bugs.launchpad.net/nova/+bug/1668267 | |
| 21:03:11 | openstack | Launchpad bug 1668267 in OpenStack Compute (nova) "Nova fails to correctly update the quota when deleting lots of VMs, some of which previously failed due to a quota error" [High,In progress] - Assigned to Pushkar Umaranikar (pushkar-umaranikar) | |
| 21:03:33 | satyar | still able to reproduce the issue | |
| 21:04:10 | dansmith | satyar: that's not the fix | |
| 21:04:31 | dansmith | satyar: this is: https://review.openstack.org/#/c/443395/ | |
| 21:04:45 | mriedem | well, | |
| 21:04:54 | mriedem | on master it's that and https://review.openstack.org/#/c/443403/ | |
| 21:05:07 | mriedem | on ocata it should just be https://review.openstack.org/#/c/443395/ and i'm working on the backport but hitting some issues | |
| 21:06:02 | satyar | ohh ok will be testing it Thanks :) | |
| 21:06:25 | satyar | thanks dansmith and mriedem | |
| 21:08:57 | mriedem | satyar: i've marked the other bug as a duplicate | |
| 21:09:09 | satyar | to? | |
| 21:09:42 | satyar | ok got it | |
| 21:09:45 | mriedem | https://bugs.launchpad.net/nova/+bug/1670627 | |
| 21:09:45 | openstack | Launchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,Confirmed] | |
| 21:10:26 | openstackgerrit | Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035 | |
| 21:11:32 | satyar | ideally it should be opposite that bug should be duplicate of the first one ;) but its fine | |
| 21:11:59 | satyar | aslong as we fix the issue :) | |
| 21:12:04 | mriedem | satyar: yeah, i guess triage failed us, it went under the one it did because someone showed up in the channel last wednesday and brought it up | |
| 21:12:17 | mriedem | right place right time | |
| 21:12:21 | satyar | :P | |
| 21:23:23 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/347161 | |
| 21:28:43 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | |
| 21:33:06 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Reset instance status on invalid host https://review.openstack.org/401009 | |
| 21:35:25 | mriedem | wtf, in ocata, when the instance is in cell0 and i go to delete it, i get a 404, but when i do a GET i get a response | |
| 21:43:27 | melwitt | mriedem: are you using novaclient to delete it or the REST API directly? because I feel like I have seen that before when I had bugs in my own code because of how novaclient does a GET before doing the delete. I can't remember the details off the top of my head | |
| 21:46:34 | mriedem | melwitt: rest api, this is that functional regression test for the quota patch | |
| 21:46:54 | mriedem | https://review.openstack.org/#/c/443395/ but on ocata | |
| 21:47:15 | mriedem | the functional regression test fails waiting for the server to be gone after the delete request, and it's because the delete request fails with a 404 when looking up the instance.flavor | |
| 21:47:17 | melwitt | oh, hm | |
| 21:47:45 | mriedem | https://gist.github.com/mriedem/cece80e5ab375c2fad6d9d599851c2dc | |
| 21:48:19 | mriedem | i think i know why, | |
| 21:48:27 | mriedem | in master the context is targeted when you get the instance | |
| 21:48:31 | mriedem | in ocata it's not, | |
| 21:48:46 | mriedem | so in this change when it's looking up the flavor from the instance, the context isn't targeted to cell0 | |
| 21:49:29 | mriedem | but we want the quotas in the main cell db, | |
| 21:49:49 | mriedem | so i'm going to have to do the same helper method that i had on master for getting the flavor from a targeted context before creating the reservation | |
| 21:49:49 | mriedem | ugh | |
| 21:50:45 | openstackgerrit | Anusha Unnam proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |
| 21:58:26 | dansmith | mriedem: how do we not trip over that in tempest? | |
| 21:58:34 | mriedem | dansmith: it's for this patch, | |
| 21:58:38 | mriedem | as a result of this patch i mean | |
| 21:58:46 | mriedem | i've got it sorted out, it's just kind of a mess for the backport, | |
| 21:58:52 | mriedem | since it's a mix of the 2 changes on master | |
| 21:59:02 | mriedem | you'll see shortly | |
| 21:59:03 | dansmith | oh, I see I thought you meant the regression test doesn't run on ocata before the change | |
| 22:00:18 | openstackgerrit | melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521 | |
| 22:00:18 | openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | |
| 22:00:19 | openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | |
| 22:01:26 | mriedem | i should have probably backported this first to see how it would work | |
| 22:04:32 | mriedem | looks like we have another ocata regression https://review.openstack.org/#/c/444106/ | |
| 22:10:02 | dansmith | hmm, I thought we did that _on_ retry | |
| 22:11:59 | dansmith | populate_filter_properties() creates the retry of the selected host | |
| 22:12:02 | dansmith | which we are calling already | |
| 22:12:18 | dansmith | oh | |
| 22:12:30 | dansmith | only if populate_retry has done the initial work first I guess | |
| 22:12:31 | dansmith | huh | |
| 22:14:26 | mriedem | gd how many postgres packages do i really need to install just to run pep8 | |
| 22:15:14 | mriedem | sudo apt-get install -y (*pg*|*pq*) | |
| 22:15:21 | mriedem | install -y *everything* | |
| 22:16:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035 | |
| 22:20:04 | mriedem | we should have a functional regression test for that retry fix, | |
| 22:21:01 | mriedem | should be relatively simple, run 2 nova-compute services, make the scheduler pick the first one and make that one fail to trigger a retry, and then make sure it's actually retried to the 2nd host | |
| 22:21:54 | dansmith | is that enough? it might do that by itself by chance | |