Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-13
18:01:07 openstackgerrit Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174
18:01:07 openstackgerrit Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292
18:01:08 openstackgerrit Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487
18:01:08 openstackgerrit Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293
18:01:09 openstackgerrit Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861
18:01:09 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
18:01:10 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
18:01:10 openstackgerrit Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035
18:05:09 dansmith johnthetubaguy: have you gone away for the day yet?
18:05:51 melwitt hah, my counting quota patch failed mriedem's recent quota regression functional test (the expected fail part) because I forgot it also fixes the problem
18:06:31 johnthetubaguy dansmith: about to go
18:06:42 johnthetubaguy dansmith: whats up?
18:06:48 dansmith johnthetubaguy: okay well, just heads up on https://review.openstack.org/#/c/445035/
18:08:03 johnthetubaguy dansmith: ah, cool, I will try go through that chain again tomorrow
18:08:44 johnthetubaguy dansmith: I forgot we don't get the cell from the host object already, which kinda sucks, but that cache seems like a good stop gap
18:09:57 dansmith johnthetubaguy: it should fill up pretty fast, not require too much memory, and only change when we add a host, so not too bad I think
18:16:36 siva_krishnan johnthetubaguy: can you unabandon thhese patches https://review.openstack.org/#/c/308198/ https://review.openstack.org/#/c/328280/ ?
18:52:02 mriedem rfolco: do you know who juergen leopold at ibm is? running ci on nova. i'm guessing a z person.
18:52:46 rfolco mriedem, hmm let me check, I knew Arne from zKVM CI from Germany these days...
18:54:39 rfolco mriedem, I guess his on the same team. They were having problems with their CI last week.
18:54:56 mriedem ok, i just emailed him and copied markus
18:55:05 mriedem asking to start using a system id rather than his email
18:55:12 mriedem and just asking what he's running
19:01:43 openstackgerrit Pushkar Umaranikar proposed openstack/nova master: Remove unused columns from BuildRequest table in nova_api db https://review.openstack.org/422259
19:13:06 openstackgerrit Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228
19:13:51 openstackgerrit Sujitha proposed openstack/nova master: Change tags to default field in Instance object. https://review.openstack.org/415298
19:14:01 openstackgerrit Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
19:14:11 openstackgerrit Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146
19:24:24 cfriesen someone pointed out to me that InstanceActionEvent.pack_action_event_finish() uses a "message" field, but the InstanceActionEvent model in the DB uses "details". Is this a bug?
19:26:08 cfriesen and given that it's been in there since 2014, is anyone actually looking at it?
19:28:50 openstackgerrit Pushkar Umaranikar proposed openstack/nova master: Remove config_drive attribute from build_requests table https://review.openstack.org/432511
19:37:44 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357
19:39:22 sean-k-mooney sdague: o/
19:39:36 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/445120
19:39:43 sean-k-mooney sdague: not sure if your about currently but could you take a look at https://review.openstack.org/#/c/444788/ if you get a chance
19:40:39 sean-k-mooney sdague: i asked sc68cal earlier and he said he would like you to take a look at it first.
19:40:56 openstackgerrit Matthew Booth proposed openstack/nova master: Add InstanceMappingList.get_by_instance_uuids https://review.openstack.org/445139
19:40:56 openstackgerrit Matthew Booth proposed openstack/nova master: Add RequestContext.for_cell() https://review.openstack.org/445140
19:40:57 openstackgerrit Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141
19:40:57 openstackgerrit Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142
19:42:09 mdbooth dansmith: I was playing with the cell context thing and came up with this series ^^^
19:42:12 sean-k-mooney sdague: it addresses a sidefect of https://review.openstack.org/#/c/435575/ which due to the fact that devstack installes test-requirements globally effect the test cases of ovs in our ci and any other pep8 tests that are not run in a virtual envirionment
19:43:03 mdbooth dansmith: It only affects server_external_events, but the idea's there.
19:46:33 openstackgerrit Anusha Unnam proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
20:04:19 sdague sean-k-mooney: wait, this is all to include flake8-import-order?
20:04:28 sdague can we just revert that instead?
20:05:16 sdague sean-k-mooney: or more importantly, please explain to me the actual issue that's currently happening, how we got there, and why this is the fix?
20:06:17 sean-k-mooney sdague: well the flake8-import-order change is what broke use but if your are running tempest test only there is noe reasong to install all the test requirements
20:06:30 sean-k-mooney sdague: so this change also speed up our test runs
20:06:59 sdague so, why did flake8-import-order break you?
20:07:23 sean-k-mooney sdague: but basically when flake8-import-order was added to the test requirements devstack installes it systemwide. flake8-import-order enables it test by default
20:07:42 sdague sean-k-mooney: the thing we've been here before, it used to be conditional
20:08:01 sdague ok, so I think that's actually a really good reason to remove flake8-import-order from global requirements
20:08:04 sdague and not allow it
20:08:12 sean-k-mooney when we build ovs from source to test ovs-dpdk there makefile enable pep testing if flake8 is installed
20:08:51 sean-k-mooney ovs does not enforce ordering so it cause the make command to fail and then we broke
20:08:57 sean-k-mooney sdague: well that is one option
20:09:13 sdague right, flake8-import-order seems to be far more intrusive to everything than previously realized
20:09:21 sdague and I think the answer is just remove it
20:09:45 sean-k-mooney but why is devstack installing the test dependecies globally?
20:09:51 sdague because everyone wanted that
20:09:52 sean-k-mooney that seams just wronge
20:10:08 sdague because they wanted devstack to be setting up a dev / test environment
20:10:09 sean-k-mooney what why is that better then leaving tox install them
20:10:43 sdague we can go dig up that change, the code used to be with a conditional here
20:10:55 sean-k-mooney yes and when i use devstack to set up a test environment i always use tox to run my test and i creats a python virtual enve and installs the test requirement in it
20:11:13 sdague yeh, and some of those tox environments use system libs
20:11:37 sean-k-mooney sdague: ok but is there any reson to not make it condional and default to true as we proposed
20:11:54 sdague because it's going to be another odd point of difference here
20:12:16 sdague and every one of these end up causing confusion
20:12:24 sean-k-mooney yes but devstack is breaking the seperation of test and real requirements
20:12:55 sdague sean-k-mooney: there are a bunch of different things that are bleeding across, as far as I can tell
20:13:17 sdague flake8-import-order enables true by default, which is unexpected
20:13:42 sdague ovs-dpdk is running pep8 without isolation to a venv, so it gets the impact of systems
20:13:49 sdague system installed packages
20:14:08 sdague devstack is installing test-requirements system level because that is what people previously wanted
20:14:46 sdague sean-k-mooney: you will also find that many projects use test-requirements to specify optional dependencies
20:15:04 sean-k-mooney sdague: yep
20:15:13 sdague like all the db drivers are in the nova test-requirements
20:15:30 sean-k-mooney that is why installing test requiremetns is a bad thing in my view as we neever test without them currently
20:15:36 edleafe bauzas: if a compute node goes offline, where is that caught? Currently we don't have any way of removing its resource provider information in that event.
20:15:42 sdague If you would like to get everything working with test-requirements not installed at all, I'm good with that
20:15:46 sdague I don't want a switch there
20:16:29 sdague because that is just, my 3rd party CI can just barely work based on the contents in different requirements files
20:16:54 sdague and something else will change, and break you
20:17:06 sean-k-mooney well devstack installs fine with the switch set to false and teh tempest squite works. im not sure about none tempets jobs though
20:17:34 sean-k-mooney sdague: well neutron are build ovs from source for their fuctional and fullstak jobs currently.
20:17:38 sdague sean-k-mooney: in some configuration you happen to have
20:18:02 sean-k-mooney sdague: they dont deploy nova for those but it would have broke them if they did when flake8-import-order was introduced in nova
20:18:09 sdague sean-k-mooney: sure, and there are 2 other options here. One is deal with the fact that flake8-import-order is really pretty suplerfuous
20:18:32 sdague the other is get ovs-dpdk to run it's pep8 during build under isolation
20:19:17 sean-k-mooney well that would require chaging upstream ovs makefile which we coudl explore but it would be up to them to accept that change
20:19:43 sdague sean-k-mooney: or create and activate a venv before running it
20:20:23 sean-k-mooney sdague: so activate venv and run make as part of our devstack plugin then deactivte
20:20:37 sdague sean-k-mooney: sure, if that works for the isolation
20:21:01 sean-k-mooney sdague: thats an option that i had not taught of. thats certenly possibel.
20:21:10 sdague I also, honestly think that flake8-import-order being installed globally seems weird just in general due to fallout
20:21:31 efried I just joined, so I don't have the scrollback, but +1 to that.
20:21:41 sean-k-mooney sdague: yes but to me that is a direct resutl of the devstack behavor
20:21:52 sdague and I would tend to pull that from global requirements, as I think that's going to have knock on break effects for lots of people that flake8 from the system (which is not an unreasonable thing to want to do)

Earlier   Later