| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-07 | |||
| 14:44:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Fix indentation in conf/netconf https://review.openstack.org/430717 | |
| 14:44:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: netutils: Ignore 'use_ipv6' for network templates https://review.openstack.org/430910 | |
| 14:44:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'use_ipv6' https://review.openstack.org/430911 | |
| 14:44:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'use_ipv6' for port filters https://review.openstack.org/430909 | |
| 14:44:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'allow_same_net_traffic' https://review.openstack.org/430913 | |
| 14:44:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Final cleanups in conf/network https://review.openstack.org/431023 | |
| 14:44:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'allow_same_net_traffic' for port filters https://review.openstack.org/430912 | |
| 14:44:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate most 'network' option https://review.openstack.org/430914 | |
| 14:44:25 | mdbooth | kaboom! | |
| 14:44:27 | mriedem | i'd like to get that backported to ocata and released before a lot of people start upgrading | |
| 14:44:38 | sfinucan | sdague: ^^^ | |
| 14:44:44 | sfinucan | mriedem: Sure. I'll take a look now | |
| 14:46:08 | edleafe | mriedem: not sure I follow. The test you added is in ova/tests/functional/api/openstack/placement/test_report_client.py | |
| 14:46:32 | mriedem | edleafe: yeah which is a functional test on the scheduler report client | |
| 14:46:34 | mriedem | which is what we need | |
| 14:47:06 | mriedem | edleafe: as noted in the review, the functional test is testing the entire report client stack for that negative scenario, rather than just piecemeal unit tests - which are removed in that same change | |
| 14:47:10 | mriedem | because the unit tests can lie | |
| 14:49:04 | mriedem | bauzas: i plan on backport https://review.openstack.org/#/c/442035/ to ocata, do you have any issue with that? | |
| 14:49:09 | mriedem | *backporting | |
| 14:49:46 | ildikov | smcginnis: FYI, I added a few extra characters and whitespaces to that reno and now the test seems happy... :) | |
| 14:50:13 | smcginnis | ildikov: Oh good. I should take a look at how you did that. I wasn't able to get it to work. | |
| 14:50:24 | smcginnis | (and was too lazy to really figure it out) :) | |
| 14:50:59 | mriedem | smcginnis: you need the | for rst formatting | |
| 14:51:00 | sfinucan | mriedem: Yeah, that fix makes sense. Done | |
| 14:51:10 | mriedem | sfinucan: thanks | |
| 14:51:24 | mriedem | smcginnis: https://docs.openstack.org/developer/reno/usage.html#note-file-syntax | |
| 14:51:26 | mdbooth | mriedem: Speaking of backports, you had a W-1 on this Newton backport until the Ocata backport merged, which it now has: https://review.openstack.org/#/c/431540/ | |
| 14:51:31 | ildikov | mriedem: smcginnis: that was my guess too, but wasn't 100% sure | |
| 14:51:36 | smcginnis | ildikov, mriedem: So use a | and guve a little extra indent. | |
| 14:51:37 | sfinucan | mriedem: Someone should probably submit a patch to reno to use '|' in the default templates | |
| 14:51:49 | mriedem | sfinucan: go for it | |
| 14:51:51 | mriedem | i always use | | |
| 14:51:57 | mriedem | regardless of whether i need it or not | |
| 14:52:03 | ildikov | smcginnis: I think the extra indent wasn't necessary | |
| 14:52:15 | ildikov | mriedem: +1 | |
| 14:52:32 | smcginnis | ildikov: That link helps. I know I've read it before, but must have missed that detail. | |
| 14:52:55 | ildikov | smcginnis: it's a pretty easy one to miss like how I did yesterday | |
| 14:53:09 | smcginnis | ildikov: Definitely. | |
| 14:53:14 | ildikov | smcginnis: but the tests look good for that patch overall, so I'm optimistic about v3 :) | |
| 14:53:39 | sfinucan | mriedem: Ah, someone already has. Good to know | |
| 14:54:00 | smcginnis | ildikov: It looked pretty good other than the reno failure last ime. | |
| 14:54:42 | ildikov | smcginnis: yep, so the base v3 should be there any minute and then we can figure out the microversion part | |
| 14:55:02 | mdbooth | sfinucan: Thanks for the re-review of the nfs patch. It's now on top of this one, btw: https://review.openstack.org/#/c/438970/ | |
| 14:55:05 | smcginnis | ildikov: Great first step to build off of. | |
| 14:55:09 | ildikov | smcginnis: and will need a new cinderclient for that too IIRC | |
| 14:55:30 | mdbooth | This had a bit of discussion last week in the context of the Cinder v3 stuff. | |
| 14:55:36 | smcginnis | ildikov: I'm still waiting on one final fix before a new release. I'll try to push on that one. | |
| 14:55:40 | sfinucan | mdbooth: Ah - missed that. I'll take a look at that too shortly | |
| 14:55:45 | mdbooth | sfinucan: Thanks | |
| 14:55:52 | ildikov | smcginnis: cool, tnx | |
| 15:00:31 | mriedem | mdbooth: lyarwood: on https://review.openstack.org/#/c/431540/ | |
| 15:00:38 | mriedem | so you've got this nice tempest test https://review.openstack.org/#/c/427808/ | |
| 15:00:43 | mriedem | but the problem is that doesn't run on stable/newton | |
| 15:00:49 | mriedem | because devstack on newton doesn't enable swap volume testing | |
| 15:01:01 | mriedem | i think that's because we needed that other pivot patch | |
| 15:01:07 | mriedem | but i think that's merged | |
| 15:02:15 | lyarwood | mriedem: true, so I need to backport the devstack change to stable/newton before this lands right? | |
| 15:02:18 | mriedem | this one https://review.openstack.org/#/c/427290/ | |
| 15:02:28 | mriedem | ^ is what we needed to fix swap volume right? | |
| 15:02:40 | lyarwood | mriedem: yeah | |
| 15:04:08 | mriedem | ok hold up there were actually 2 changes in devstack | |
| 15:05:15 | mdbooth | mriedem: You're an encyclopaedia(sp?) of CI knowledge | |
| 15:05:41 | mriedem | i will take that as a compliment | |
| 15:06:09 | lyarwood | mriedem: are you cp'ing them back to newton? | |
| 15:06:15 | lyarwood | mriedem: happy to if you don't have time | |
| 15:06:50 | mriedem | lyarwood: https://review.openstack.org/#/c/442548/ | |
| 15:07:10 | lyarwood | mriedem: thanks | |
| 15:13:34 | mriedem | lyarwood: btw i think i'll plan a stable/ocata release for early next week | |
| 15:15:33 | lyarwood | mriedem: cool, I'll try to go over the open queue a few times this week to clear it out | |
| 15:15:45 | mriedem | lyarwood: btw, https://review.openstack.org/#/c/441457/ | |
| 15:15:54 | mriedem | the ocata backport of that isn't merged yet :) | |
| 15:16:05 | mriedem | maybe i should have -WIP'ed | |
| 15:16:08 | lyarwood | really? | |
| 15:16:12 | lyarwood | urgh | |
| 15:16:14 | mriedem | https://review.openstack.org/#/c/441456/ | |
| 15:16:36 | lyarwood | time to uninstall gertty | |
| 15:16:38 | mriedem | despite being the fuel for intergalactic travel, no one uses spice | |
| 15:16:49 | lyarwood | haha, true | |
| 15:17:02 | lyarwood | I'll +W the ocata one now, I was sure I had already | |
| 15:17:16 | mriedem | cool | |
| 15:18:29 | openstackgerrit | Roman Podoliaka proposed openstack/nova-specs master: Ironic: add support for instance RAID configuration https://review.openstack.org/408151 | |
| 15:55:16 | jaypipes | vdrok: good evening. so the first patch in the Ironic inventory series has merged: https://review.openstack.org/#/c/441543/ | |
| 15:55:37 | vdrok | jaypipes: yup, saw that, thank you! | |
| 15:55:39 | jaypipes | vdrok: the next in the series is here: https://review.openstack.org/#/c/441544/3 | |
| 15:55:44 | jaypipes | vdrok: working on that now. | |
| 15:55:50 | vdrok | I'm tacking those :) | |
| 15:56:03 | jaypipes | vdrok: would be great to take the final patch in the series and start running your integration tests. | |
| 15:56:16 | jaypipes | vdrok: final patch is a new functional test mriedem added: https://review.openstack.org/#/c/442254/1 | |
| 15:56:59 | mriedem | that's not the final patch is it? | |
| 15:57:04 | mriedem | just a side thing | |
| 15:57:10 | mriedem | little something something on the side | |
| 15:57:27 | jaypipes | mriedem: oh, it's not dependent? | |
| 15:57:29 | jaypipes | gotcha | |
| 15:57:42 | jaypipes | vdrok: k, feel free to ignore that last patch ;) | |
| 15:57:55 | jaypipes | vdrok: just test on 441544 :) | |
| 15:58:12 | vdrok | gotcha | |
| 15:58:56 | mriedem | jaypipes: right i just thought, while reviewing the base patch, that we could do an easy functional test to the invalid resource class case to avoid the mocked unit tests failing us later, | |
| 15:59:04 | mriedem | it was easier to add than i thought so i pushed it up last night | |
| 15:59:22 | jaypipes | mriedem: cool, thanks very much for that :) | |
| 15:59:24 | openstackgerrit | Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | |