Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-06
21:43:13 alexandrelevine "write"
21:44:26 alexandrelevine I just want to remind that in order to provide my design ideas for refactoring I had to develop the whole solution and make it pass all of the existing tests. Then I was sure that my ideas would work and I was ready to write a spec.
21:49:59 alexandrelevine mriedem: Please let me know when the conversation is finished and you made up your mind with some verdict because it's 0:49 am here and unless we keep talking I can go and get some sleep.
21:51:28 mriedem alexandrelevine: i think i'm done right now. i'm not ready to add the scaleio specific driver without having a better idea of how the generic driver would happen (or not happen).
21:52:41 alexandrelevine mriedem: Ok, thank you. Do we abandon our spec or just leave it be?
21:52:56 mriedem alexandrelevine: i'd leave it for now
21:53:12 alexandrelevine Ok. Bye.
22:29:16 mriedem jgriffith: dumped my recap notes on the talk with alex in https://review.openstack.org/#/c/304715/
22:41:44 mriedem dansmith: i moved your nova meeting stuff on the forum planning into the reminders section since it's something that will probably continue to come up as we get closer
22:41:51 mriedem like for the ptg planning
22:41:52 dansmith mriedem: cool
22:51:45 ildikov mriedem: hi, are you around for a quick question?
22:52:34 mriedem ildikov: i am
22:52:42 ildikov mriedem: tnx
22:52:52 ildikov mriedem: so I always confuse myself with the release notes
22:53:12 ildikov mriedem: I'm cleaning up the patch to move Nova to Cinder v3, the base 3.0
22:53:37 ildikov mriedem: and was wondering whether it's 'other' or 'upgrade' category?
22:54:22 mriedem ildikov: depends on the change
22:54:29 ildikov mriedem: and how much we want to go into if anyone wants v2 as they might have a that old Cinder but they love it they can modify the 'catalog_info' in the config?
22:54:31 mriedem supporting cinder v3 would probably be a feature
22:54:42 mriedem are you also changing the default?
22:55:17 mriedem changing the default on a config option means a reno in the upgrade section
22:55:29 ildikov mriedem: if changing the default equals to set the catalog_info to v3, then I'm changing the default
22:55:36 mriedem yeah
22:55:40 mriedem so upgrade section
22:56:08 ildikov mriedem: as we agreed to change the default in case I need to do more than that please point me to that too :)
22:57:08 ildikov mriedem: cool, I will add an upgrade section then, just wanted to be sure
22:57:12 ildikov mriedem: tnx!
22:57:24 mriedem yw
23:09:49 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
23:09:50 openstackgerrit Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162
23:09:50 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
23:09:51 openstackgerrit Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023
23:09:51 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
23:09:52 openstackgerrit Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024
23:09:52 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
23:09:53 openstackgerrit Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200
23:14:54 tonygunk Wondering if someone can point me in the right direction in error I'm getting with Ocata and Xen Hypervisor
23:15:07 tonygunk http://paste.openstack.org/raw/601670/
23:15:58 tonygunk Getting the following: TypeError: Argument must be bytes or unicode, got 'NoneType'
23:17:12 tonygunk All other hypervisors are running KVM and no issues of course - just trying Xen on one node
23:22:49 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: DELETE all inventories for a resource provider https://review.openstack.org/415885
23:23:39 mriedem tonygunk: libvirt + xen or xenapi?
23:23:46 mriedem because this looks like it's hitting libvirt code
23:23:59 tonygunk libvirt + xen
23:24:06 mriedem anthonyper: ^
23:24:54 mriedem https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/config.py#L1665
23:28:16 mriedem tonygunk: gotta be something wrong down this path https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L4415
23:29:07 mriedem https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L4435
23:29:22 mriedem https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L4489
23:29:25 mriedem log_path would be None there
23:29:30 mriedem for xen
23:30:21 mriedem tonygunk: do you have these minimum versions for libvirt/qemu? https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L275
23:32:01 mriedem looks like the libvirt+xen CI running against nova is testing against an older libvirt
23:32:03 mriedem 1.3.1
23:32:08 mriedem so that CI wouldn't have caught this
23:33:02 mriedem but yeah that's the bug
23:33:43 mriedem tonygunk: looks like you could set [serial_console]/enabled=True in nova.conf to workaround this for now
23:37:59 tonygunk mriedem: I just tried the workaround and it works
23:38:40 tonygunk mriedem: I sincerely appreciate you looking at this. My python fu is not equivalent
23:39:10 mriedem sure, yw
23:39:14 mriedem also https://bugs.launchpad.net/nova/+bug/1670522
23:39:14 openstack Launchpad bug 1670522 in OpenStack Compute (nova) "TypeError booting instance with libvirt+xen in _create_pty_device with libvirt>=1.3.3" [High,Triaged]
23:39:21 mriedem anthonyper: ^
23:40:11 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Use Cinder API v3 as default https://review.openstack.org/420201
23:41:17 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Use Cinder API v3 as default https://review.openstack.org/420201
23:48:57 mriedem tonygunk: should have a fix shortly
#openstack-nova - 2017-03-07
00:04:50 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: pass log_path to _create_pty_device for non-kvm/qemu https://review.openstack.org/442209
00:04:51 mriedem tonygunk: ^
00:06:13 mriedem dansmith: melwitt: ^ simple fix for a breaking bug once you upgrade to ocata if you fall into that deployment scenario
00:13:12 openstackgerrit Dan Smith proposed openstack/nova master: Avoid logging entire CellMapping objects https://review.openstack.org/442211
00:27:42 openstackgerrit Logan V proposed openstack/nova master: Add LVM thin pool support https://review.openstack.org/442126
01:26:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused placement_database config options https://review.openstack.org/442035
02:15:29 openstackgerrit Dan Smith proposed openstack/nova master: Make CellMapping use SensitiveStringField https://review.openstack.org/442235
02:28:29 openstackgerrit Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199
02:28:30 openstackgerrit Alex Xu proposed openstack/nova master: placement: Add simple cache object for traits https://review.openstack.org/441829
03:13:10 mriedem dansmith: she fell asleep
03:13:22 dansmith mriedem: laura?
03:15:48 mriedem yeah
03:15:52 mriedem dansmith: also, i was wrong in https://review.openstack.org/#/c/441543/1/nova/scheduler/client/report.py@692
03:15:59 mriedem it took the diff between 1..2 to see it
03:16:14 mriedem the lack of a test in ps1 showed that the exception we'd hit there wasn't even defined :(
03:16:50 dansmith mriedem: how does that mean that we report the good ones and not the bad ones?
03:16:54 dansmith we just don't report anything right?
03:17:03 mriedem we won't report anything
03:17:08 mriedem it'll be an error
03:17:10 dansmith yeah
03:17:27 dansmith just seems like it'd be better for us to sanitize each thing and report
03:17:52 dansmith in the case of traits we have to be graceful about being newer than placement
03:18:03 dansmith might not be as much of a deal here, but still..
03:20:38 dansmith mriedem: are you going to +W the latest?
03:20:58 mriedem i believe so,
03:21:12 mriedem but i'm going to mention the lack of actual functional testing of the report client and all of the mock-based tests concerns me
03:21:47 mriedem because there is quite a bit of per-method mocking going on for error conditions and that could miss some things later, functional tests would be best
03:22:47 dansmith did you seem my comments from the previous patch?
03:22:55 dansmith I wish he hadn't abandoned that and re-used it for one of these, but oh well
03:23:08 dansmith either way, I said the same thing.. I feel like the coverage is fine, but it seems like these are very unit-y tests
03:23:32 dansmith however, placement kinda has to be considered external to nova so not having solid functional tests seems as resonable as not having them for cinder
03:25:55 mriedem we do have functional tests for a lot of this report client stack though
03:26:11 mriedem i think for the negative scenario we need a fake virt driver that returns garbage, which is easy enough

Earlier   Later