| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-06 | |||
| 23:23:46 | mriedem | because this looks like it's hitting libvirt code | |
| 23:23:59 | tonygunk | libvirt + xen | |
| 23:24:06 | mriedem | anthonyper: ^ | |
| 23:24:54 | mriedem | https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/config.py#L1665 | |
| 23:28:16 | mriedem | tonygunk: gotta be something wrong down this path https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L4415 | |
| 23:29:07 | mriedem | https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L4435 | |
| 23:29:22 | mriedem | https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L4489 | |
| 23:29:25 | mriedem | log_path would be None there | |
| 23:29:30 | mriedem | for xen | |
| 23:30:21 | mriedem | tonygunk: do you have these minimum versions for libvirt/qemu? https://github.com/openstack/nova/blob/15.0.0/nova/virt/libvirt/driver.py#L275 | |
| 23:32:01 | mriedem | looks like the libvirt+xen CI running against nova is testing against an older libvirt | |
| 23:32:03 | mriedem | 1.3.1 | |
| 23:32:08 | mriedem | so that CI wouldn't have caught this | |
| 23:33:02 | mriedem | but yeah that's the bug | |
| 23:33:43 | mriedem | tonygunk: looks like you could set [serial_console]/enabled=True in nova.conf to workaround this for now | |
| 23:37:59 | tonygunk | mriedem: I just tried the workaround and it works | |
| 23:38:40 | tonygunk | mriedem: I sincerely appreciate you looking at this. My python fu is not equivalent | |
| 23:39:10 | mriedem | sure, yw | |
| 23:39:14 | mriedem | also https://bugs.launchpad.net/nova/+bug/1670522 | |
| 23:39:14 | openstack | Launchpad bug 1670522 in OpenStack Compute (nova) "TypeError booting instance with libvirt+xen in _create_pty_device with libvirt>=1.3.3" [High,Triaged] | |
| 23:39:21 | mriedem | anthonyper: ^ | |
| 23:40:11 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Use Cinder API v3 as default https://review.openstack.org/420201 | |
| 23:41:17 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Use Cinder API v3 as default https://review.openstack.org/420201 | |
| 23:48:57 | mriedem | tonygunk: should have a fix shortly | |
| #openstack-nova - 2017-03-07 | |||
| 00:04:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: pass log_path to _create_pty_device for non-kvm/qemu https://review.openstack.org/442209 | |
| 00:04:51 | mriedem | tonygunk: ^ | |
| 00:06:13 | mriedem | dansmith: melwitt: ^ simple fix for a breaking bug once you upgrade to ocata if you fall into that deployment scenario | |
| 00:13:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Avoid logging entire CellMapping objects https://review.openstack.org/442211 | |
| 00:27:42 | openstackgerrit | Logan V proposed openstack/nova master: Add LVM thin pool support https://review.openstack.org/442126 | |
| 01:26:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused placement_database config options https://review.openstack.org/442035 | |
| 02:15:29 | openstackgerrit | Dan Smith proposed openstack/nova master: Make CellMapping use SensitiveStringField https://review.openstack.org/442235 | |
| 02:28:29 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | |
| 02:28:30 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add simple cache object for traits https://review.openstack.org/441829 | |
| 03:13:10 | mriedem | dansmith: she fell asleep | |
| 03:13:22 | dansmith | mriedem: laura? | |
| 03:15:48 | mriedem | yeah | |
| 03:15:52 | mriedem | dansmith: also, i was wrong in https://review.openstack.org/#/c/441543/1/nova/scheduler/client/report.py@692 | |
| 03:15:59 | mriedem | it took the diff between 1..2 to see it | |
| 03:16:14 | mriedem | the lack of a test in ps1 showed that the exception we'd hit there wasn't even defined :( | |
| 03:16:50 | dansmith | mriedem: how does that mean that we report the good ones and not the bad ones? | |
| 03:16:54 | dansmith | we just don't report anything right? | |
| 03:17:03 | mriedem | we won't report anything | |
| 03:17:08 | mriedem | it'll be an error | |
| 03:17:10 | dansmith | yeah | |
| 03:17:27 | dansmith | just seems like it'd be better for us to sanitize each thing and report | |
| 03:17:52 | dansmith | in the case of traits we have to be graceful about being newer than placement | |
| 03:18:03 | dansmith | might not be as much of a deal here, but still.. | |
| 03:20:38 | dansmith | mriedem: are you going to +W the latest? | |
| 03:20:58 | mriedem | i believe so, | |
| 03:21:12 | mriedem | but i'm going to mention the lack of actual functional testing of the report client and all of the mock-based tests concerns me | |
| 03:21:47 | mriedem | because there is quite a bit of per-method mocking going on for error conditions and that could miss some things later, functional tests would be best | |
| 03:22:47 | dansmith | did you seem my comments from the previous patch? | |
| 03:22:55 | dansmith | I wish he hadn't abandoned that and re-used it for one of these, but oh well | |
| 03:23:08 | dansmith | either way, I said the same thing.. I feel like the coverage is fine, but it seems like these are very unit-y tests | |
| 03:23:32 | dansmith | however, placement kinda has to be considered external to nova so not having solid functional tests seems as resonable as not having them for cinder | |
| 03:25:55 | mriedem | we do have functional tests for a lot of this report client stack though | |
| 03:26:11 | mriedem | i think for the negative scenario we need a fake virt driver that returns garbage, which is easy enough | |
| 03:26:48 | mriedem | i +Wed it just to keep it moving | |
| 03:26:57 | mriedem | i think we can hammer out a functional test as a follow on | |
| 03:29:34 | dansmith | mriedem: for the report stuff? like, it runs a placement? | |
| 03:30:51 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [POC] Searchlight intergration https://review.openstack.org/442248 | |
| 03:30:59 | mriedem | i was thinking of self.url | |
| 03:31:01 | mriedem | damn | |
| 03:31:07 | mriedem | https://review.openstack.org/#/c/441543/2/nova/tests/functional/api/openstack/placement/test_report_client.py | |
| 03:31:15 | mriedem | but that's not running a placement service | |
| 03:31:39 | mriedem | well, actually i think it is | |
| 03:31:44 | mriedem | it deploys a wsgi app | |
| 03:31:55 | mriedem | i'm not sure how the wsgi_intercept stuff works | |
| 03:32:20 | dansmith | is that different from this patch though? it uses wsgi_intercept too | |
| 03:32:38 | diga | mriedem: https://bugs.launchpad.net/nova/+bug/1670262 Getting this issues when setup fresh devstack & run server list command from cli | |
| 03:32:38 | openstack | Launchpad bug 1670262 in OpenStack Compute (nova) "DBNonExistenceDatabase: Unknown database "nova_cell0"" [Undecided,Incomplete] | |
| 03:32:57 | mriedem | diga: then create nova_cell0 | |
| 03:34:46 | mriedem | diga: https://github.com/openstack-dev/devstack/blob/8fe48af1625cd2deca496de81dd72573e78b3ef2/lib/nova#L709 | |
| 03:35:11 | diga | mriedem: okay, will go through it | |
| 03:35:41 | diga | mriedem: may be my devstack source code is old | |
| 03:35:49 | mriedem | dansmith: i'm actually not sure why he couldn't have just modified https://review.openstack.org/#/c/441543/2/nova/tests/functional/api/openstack/placement/test_report_client.py to call set_inventory_for_provider with a garbage resource class | |
| 03:35:50 | diga | mriedem: need to pull latest | |
| 03:35:54 | diga | mriedem: thank you | |
| 03:35:59 | mriedem | and assert it raises the expected exception | |
| 03:36:03 | mriedem | i can try that quick | |
| 03:45:11 | mriedem | dansmith: yeah this would have been much easier https://gist.github.com/mriedem/1fb38bd4bb62cff0c5bcd90abb049c88 | |
| 03:48:48 | dansmith | oh well | |
| 03:49:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for bad res class in set_inventory_for_provider https://review.openstack.org/442254 | |
| 03:49:42 | mriedem | dansmith: ^ oh nothing | |
| 03:50:03 | dansmith | that's what we need, more patches | |
| 03:50:16 | mriedem | "more good patches" | |
| 03:50:21 | mriedem | was the BCN phrase of the week | |
| 03:51:31 | dansmith | heh | |
| 03:54:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: autospec the virt driver mock in test_resource_tracker https://review.openstack.org/442258 | |
| 03:56:51 | mriedem | with that i'll call it a day | |
| 04:14:32 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 04:43:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 04:43:42 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 04:44:00 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 04:44:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 05:05:34 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | |
| 05:53:59 | wllabs | version 2.14 | |
| 05:54:05 | wllabs | how to define version? | |
| 05:54:27 | wllabs | how to know my code's version | |
| 06:02:52 | wllabs | qinatov | |