Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-26
16:37:58 mriedem but i already had https://review.openstack.org/#/c/405954 in a tab
16:38:14 dansmith sfinucan: you know mriedem is on vacation right? I know, it's hard to tell
16:38:27 sfinucan a tab will do nicely
16:38:29 jaypipes_ edleafe: are you handling the change to https://review.openstack.org/#/c/404472/17/nova/compute/resource_tracker.py that you said you were looking at yesterday?
16:38:33 jaypipes_ edleafe: if not, I will do so.
16:38:41 jaypipes_ and good morning fellas.
16:38:46 sfinucan dansmith: I do. I've already given out to him for being around but he won't listen
16:38:56 dansmith sfinucan: he's not very good at vacation
16:39:11 sfinucan You Americans and your pesky work ethic
16:39:50 sfinucan We clearly need a Greek PTL
16:39:55 jaypipes_ lol
16:40:11 jaypipes_ my idea of vacation is doing code reviews by a pool.
16:40:46 dansmith mriedem: bauzas: that change is failing because it can't find placement.password
16:41:05 kashyap sfinucan: Quit giving those non-apologies
16:41:05 bauzas dansmith: yup, I'm working on a new PS
16:41:26 dansmith bauzas: you have a fix?
16:41:27 kashyap sfinucan: Reminds me about an article on the word 'humbled' in NY Times lately. ;-)
16:41:39 mriedem jaypipes: edleafe: just left some comments in https://review.openstack.org/#/c/404472/
16:41:42 bauzas dansmith: by also excepting the NoConfOpt + modifying the ServiceFixture
16:41:44 sfinucan :D
16:41:44 mriedem jaypipes: i'm not all of the way through it yet
16:41:55 mriedem jaypipes: but the 'latest' microversion in the scheduler report client is what the -1 is for
16:42:02 dansmith bauzas: is that going to work?
16:42:05 dansmith bauzas: because it's failing to find it on a run that should have it
16:42:37 bauzas dansmith: if we ConfPatcher the ServiceFixture
16:42:37 dansmith bauzas: you might have to check the region name, since that's our conf opt
16:42:46 dansmith bauzas: it's failing in real devstack runs!
16:42:52 dansmith http://logs.openstack.org/61/417961/28/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/ed475f7/logs/screen-n-cpu.txt.gz?level=TRACE
16:42:54 dansmith bauzas: ^
16:42:58 bauzas interesting
16:43:03 cfriesen jaypipes_: get a toughbook and you can do code reviews *in* the pool
16:43:06 bauzas anyway, I'm just splitting the big change
16:43:15 dansmith bauzas: I think it's because of lazy conf evaluation
16:44:06 mriedem NoSuchOptError: no such option password in group [placement]
16:44:09 mriedem that seems wonky
16:44:15 edleafe jaypipes_: yes, I fixed that already
16:44:24 jaypipes_ cfriesen: :)
16:44:49 jaypipes_ edleafe: ty sir
16:45:02 jaypipes_ edleafe: sorry was looking at an old rev comment
16:48:41 jaypipes_ edleafe: I don't want to step on toes if you are already working on it, so let me know if you are addressing mriedem's comments?
16:48:50 johnthetubaguy bauzas: I would try auth_url anyways, as password bit is pluggable
16:48:54 edleafe yeah, looking at them now
16:49:12 johnthetubaguy funky though, looks like it is there: http://logs.openstack.org/61/417961/28/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/ed475f7/logs/etc/nova/nova.conf.txt.gz
16:49:19 edleafe jaypipes_: aren't you suposed to be drinking pina coladas or something?
16:49:54 jaypipes_ edleafe: meh, coffee and email this morning :)
16:51:07 cdent jaypipes_: what about getting caught in the rain?
16:52:33 dansmith it's not even morning in florida anymore
16:52:51 edleafe jaypipes_: any idea about mriedem's comment here: https://review.openstack.org/#/c/404472/20/nova/scheduler/client/report.py@174
16:53:01 edleafe That got changed in PS 8
16:55:58 openstackgerrit Dan Smith proposed openstack/nova: WIP: Allow graceful service exits from compute https://review.openstack.org/425751
16:57:12 jaypipes_ edleafe: I don't see that changed in PS8. but anyway, it's likely just an oversight. There were so many patches that changed that line that I've lost track at this point which introduced latest and which introduced 1.X specified explicitly.
16:57:32 jaypipes_ edleafe: in this particular case, it should be the microversion that added resource classes, so 1.2, yes?
16:58:02 edleafe jaypipes_: not sure, but that sounds about right
16:58:54 bauzas johnthetubaguy: dansmith: so I made the spit
16:58:57 bauzas split even
16:59:13 bauzas johnthetubaguy: dansmith: are you suggesting me other way to verify if the placement section is correct?
16:59:16 bauzas I'm all ears
16:59:20 edleafe jaypipes_: https://review.openstack.org/#/c/404472/8..20/nova/scheduler/client/report.py@174
16:59:30 edleafe jaypipes_: that's where it got added
16:59:31 dansmith bauzas: I said check os_region right?
16:59:38 johnthetubaguy bauzas: I was thinking of using auth_url CONF instead
16:59:43 dansmith bauzas: that's our config value, should be there by the time you need it
17:00:07 dansmith johnthetubaguy: is that going to be different than password from an order of loading perspective? because his patch fails on password not even being a thing by the time we're loading
17:00:12 dansmith s/loading/running/
17:00:40 bauzas dansmith: you mean os_region_name?
17:00:48 bauzas that's something coming from us ?
17:01:05 johnthetubaguy dansmith: unsure, but I like your os_region suggestion better
17:01:12 johnthetubaguy https://github.com/openstack/nova/blob/master/nova/conf/placement.py#L22
17:01:44 johnthetubaguy dansmith: bauzas: password is part of the pluggable auth and not not actually required, so it shouldn't be that one
17:02:08 bauzas okay, let's try os_region_name then
17:02:19 bauzas dansmith is right, given it's the only one we have in tree
17:02:30 johnthetubaguy (assuming we don't later decide os_region_name should be defaulted to RegionOne, but lets just be sure not to do that this cycle!)
17:02:32 bauzas and password means a password auth, which could be changing in the future
17:03:00 bauzas johnthetubaguy: I could write an unittest for preventing that
17:03:11 johnthetubaguy bauzas: cool
17:03:16 bauzas johnthetubaguy: meaning that I'm expecting a None value
17:03:20 johnthetubaguy ack
17:03:27 openstackgerrit Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509
17:03:28 bauzas so someone defaulting the opt would have to cut that
17:03:50 bauzas okay, let's try again
17:07:22 bauzas shit, I need a fixturre
17:07:25 jaypipes_ edleafe: I must be seeing something different than you... I don't see placement latest being added in that patch?
17:07:31 bauzas dansmith: johnthetubaguy ^
17:07:54 jaypipes_ edleafe: i.e. that line isn't green in gerrit.
17:08:28 jaypipes_ edleafe: in any case, not sure it matter, right? solution is straight-forward. just s/latest/1.2/, yesh?
17:09:07 sfinucan erm, vladikr - you're looking at this, right? https://review.openstack.org/#/c/424786/ :)
17:09:24 mriedem jaypipes: i'd prefer the calling code is explicit about the microversion it needs, so GET and POST for resource classes,
17:09:28 mriedem not globally in the init
17:09:34 mriedem edleafe: ^
17:09:56 vladikr sfinucan, yeah, but it's not really possible to test this with tempest
17:10:19 sfinucan vladikr: Oh, wait - that was the thing that required hardware, right?
17:10:23 edleafe jaypipes_: this is what I see: http://imgur.com/a/ocO8X
17:10:33 vladikr sfinucan, yeah, I should abandon that
17:10:36 edleafe jaypipes_: just so you don't think I crazy (well, crazier)
17:10:41 sfinucan vladikr: Do please
17:10:48 sfinucan though I'd also suggest submitting a patch for https://github.com/wznoinsk/hw-tests
17:11:02 dansmith bauzas: I'm confused -- is os_region_name what you're going to use instead of password?
17:11:08 vladikr yeah
17:11:09 bauzas dansmith: yup
17:11:11 sfinucan vladikr: wznoinsk should be able to provide more information on that project, if you ask nicely

Earlier   Later