| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-26 | |||
| 17:10:23 | edleafe | jaypipes_: this is what I see: http://imgur.com/a/ocO8X | |
| 17:10:33 | vladikr | sfinucan, yeah, I should abandon that | |
| 17:10:36 | edleafe | jaypipes_: just so you don't think I crazy (well, crazier) | |
| 17:10:41 | sfinucan | vladikr: Do please | |
| 17:10:48 | sfinucan | though I'd also suggest submitting a patch for https://github.com/wznoinsk/hw-tests | |
| 17:11:02 | dansmith | bauzas: I'm confused -- is os_region_name what you're going to use instead of password? | |
| 17:11:08 | vladikr | yeah | |
| 17:11:09 | bauzas | dansmith: yup | |
| 17:11:11 | sfinucan | vladikr: wznoinsk should be able to provide more information on that project, if you ask nicely | |
| 17:11:15 | dansmith | okay I thought you were saying you weren't | |
| 17:11:19 | dansmith | so.. good | |
| 17:11:21 | bauzas | dansmith: sorry then | |
| 17:11:22 | dansmith | :) | |
| 17:11:27 | edleafe | mriedem: ok, I'll look for where those are needed. | |
| 17:11:31 | bauzas | dansmith: so, it works with devstack (like the t-shirt) | |
| 17:11:51 | bauzas | dansmith: but for UTs and functional tests, I need to make a fixture and add it to nova.test | |
| 17:12:06 | bauzas | dansmith: in order to set the config opt | |
| 17:12:19 | mriedem | bauzas: just throw it in the global conf patcher | |
| 17:12:22 | bauzas | unless I'm just setting the opt straight | |
| 17:12:23 | mriedem | that is run on all tests by default | |
| 17:12:25 | mriedem | it's a 1 line change | |
| 17:12:32 | bauzas | mriedem: oh right | |
| 17:12:38 | bauzas | I forgot it, but yeah, much better | |
| 17:13:14 | jaypipes_ | edleafe: yes, that's what I see too. Notice that the line he is referring to is white, meaning the patch has not changed that line. | |
| 17:14:26 | jaypipes_ | mriedem: you mean passing in a specific microversion header for each GET/POST call? | |
| 17:14:55 | mriedem | jaypipes_: yes, like we're already doing for 1.1 with aggregates | |
| 17:15:12 | jaypipes_ | mriedem: got it. edleafe, got it? :) | |
| 17:15:47 | edleafe | jaypipes_: yeah, but if you compare to PS7, it's green | |
| 17:15:58 | openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404 | |
| 17:16:00 | edleafe | meaning it's been in the code since PS8 | |
| 17:16:09 | edleafe | IAC, I'm working on the changes | |
| 17:17:23 | mriedem | bauzas: yeah in here somewhere https://github.com/openstack/nova/blob/master/nova/tests/unit/conf_fixture.py#L30 | |
| 17:17:34 | bauzas | mriedem: already did | |
| 17:17:40 | mriedem | dansmith: oh nice https://review.openstack.org/319379 is approved | |
| 17:17:43 | bauzas | running tests and uploading in a sec | |
| 17:17:44 | mriedem | was just going to check on that | |
| 17:17:53 | dansmith | mriedem: #10 in the gate MOFO | |
| 17:18:01 | dansmith | mriedem: I'm watching it like my life depends on t | |
| 17:18:29 | johnthetubaguy | melwitt: I sent a note on that quota patch, its not a blocker I am just curious what you think though. | |
| 17:18:44 | johnthetubaguy | melwitt: looking at the latest one now. | |
| 17:19:07 | mriedem | dansmith: was melwitt good with it? | |
| 17:19:14 | dansmith | mriedem: she pushed the last change | |
| 17:19:28 | dansmith | so I'm guessing | |
| 17:19:34 | mriedem | oh excellent | |
| 17:19:39 | melwitt | mriedem, dansmith: yes, all good | |
| 17:20:39 | melwitt | johnthetubaguy: I just saw, thanks. I do like the idea of making the limit check atomic but I'm not familiar with the generation id and how passing a deltas dict helps? | |
| 17:21:12 | johnthetubaguy | melwitt: I was really thinking, we do the generation thing much later, but the new interface would allow us to do that without changing all the callers | |
| 17:21:27 | melwitt | johnthetubaguy: ah, gotcha | |
| 17:21:51 | jaypipes_ | edleafe: danke | |
| 17:24:53 | melwitt | johnthetubaguy: okay, so you mean moving the counting call inside of Quotas.check_deltas for now. that makes sense | |
| 17:25:12 | johnthetubaguy | melwitt: yeah, squash the two calls into a single call | |
| 17:25:48 | mriedem | vladikr: question in https://review.openstack.org/#/c/405954/ | |
| 17:26:01 | vladikr | mriedem, looking | |
| 17:26:26 | melwitt | johnthetubaguy: it would clean things up a lot too | |
| 17:26:34 | johnthetubaguy | melwitt: its a nit, I was wondering if get counts should be on the list object? | |
| 17:28:01 | melwitt | johnthetubaguy: it could. I wasn't opinionated about it. I feel like there might be an example of a count on an existing list object already | |
| 17:28:39 | johnthetubaguy | melwitt: I could see arguments both ways I guess | |
| 17:29:38 | mriedem | vladikr: similar in https://review.openstack.org/#/c/405951/ | |
| 17:29:54 | mriedem | vladikr: basically, we're doing the same stuff in both the metadata api code as in the libvirt driver, | |
| 17:30:14 | mriedem | vladikr: i'm not sure why we don't just store the vlan on the NetworkInterfaceMetadata object in the libvirt driver, like the tag, | |
| 17:30:18 | mriedem | and then use that in the metadata api | |
| 17:30:52 | melwitt | johnthetubaguy: yeah. I just did a quick grep and didn't find an existing example of a count. so I think I just guessed :P | |
| 17:31:28 | melwitt | there's the InstanceGroup.count_members_by_user but it counts members for a single group so that makes sense | |
| 17:31:32 | vladikr | mriedem, yes, in the first patch we need to determine which vifs to include in the list of device that the metadata will receive and then in the second patch we will create the metadata only for those device that has a vlan or a tag | |
| 17:31:38 | vladikr | mriedem, https://review.openstack.org/#/c/405951/13/nova/api/metadata/base.py@428 | |
| 17:36:52 | mriedem | vladikr: yeah but we build that list twice | |
| 17:36:59 | mriedem | when we already know it in the libvirt driver, | |
| 17:37:08 | mriedem | and could store the vlan on the same object that has the tag | |
| 17:37:39 | mriedem | dansmith: bauzas: johnthetubaguy: i'm heading out for a few hours, | |
| 17:37:51 | mriedem | just a reminder on https://review.openstack.org/#/c/424256/ so we can release novaclient 7.1.0 | |
| 17:38:34 | bauzas | mriedem: want me to tag the release btw. ? | |
| 17:38:49 | vladikr | mriedem, yes, that's what the previous iteration of the code was doing | |
| 17:39:03 | openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | |
| 17:39:03 | openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185 | |
| 17:39:04 | openstackgerrit | Sylvain Bauza proposed openstack/nova: Block starting compute unless placement conf is provided https://review.openstack.org/425806 | |
| 17:39:20 | vladikr | mriedem, I'll look at it again | |
| 17:39:23 | mriedem | bauzas: i'll be back around this afternoon to do that assuming we get the other things merged | |
| 17:39:35 | bauzas | dansmith: mriedem: the branch is now up ^ | |
| 17:40:13 | bauzas | mriedem: okay, I'll have to bail out by around 11pm UTC because I have to wake up early tomorrow | |
| 17:40:21 | bauzas | mriedem: ie. midnight my time | |
| 17:40:32 | bauzas | not sure which TZ you're in | |
| 17:40:44 | mriedem | bauzas: GMT | |
| 17:40:52 | bauzas | mriedem: I need to go back and forth tomorrow to Patis | |
| 17:40:56 | bauzas | Paris even | |
| 17:40:58 | mriedem | bauzas: i'm asking about the o-3 timeline + FF in the release channel too | |
| 17:41:03 | bauzas | so mostly on train during the day | |
| 17:41:55 | bauzas | mriedem: oh f*** I tought I was following | |
| 17:42:51 | dansmith | bauzas: is the change to _enabled_filters still needed there? | |
| 17:43:02 | johnthetubaguy | melwitt: that destroy_and_raise_if_over_quota, is that worth the extra maintenance cost? | |
| 17:43:06 | bauzas | you mean the bottom change? | |
| 17:43:09 | bauzas | dansmith: ^ | |
| 17:43:24 | melwitt | johnthetubaguy: replying to that right now on the review | |
| 17:43:25 | dansmith | bauzas: L48 of the bottom change | |
| 17:43:39 | bauzas | dansmith: yeah it should still, because we have a different behaviour in case we don't have all the filters | |
| 17:44:10 | bauzas | dansmith:oh sec | |
| 17:44:15 | bauzas | dansmith: I misunderstood your question | |
| 17:44:22 | dansmith | I don't think it should be different if we're ignoring those filters | |
| 17:44:27 | bauzas | dansmith: in theory, the affinity filters are part of the default | |
| 17:44:39 | dansmith | bauzas: also, the other tests didn't have a list for that parameter? | |
| 17:44:41 | bauzas | dansmith: so we should not need L48 theorically | |