| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-03 | |||
| 20:53:51 | _gryf | :) | |
| 20:57:08 | efried | slunkad, thanks for your patience. I've reviewed https://review.openstack.org/#/c/408148/ | |
| 21:05:56 | mriedem | _gryf: to do what? | |
| 21:06:03 | _gryf | mriedem, so what is the preferred approach regarding updating bp? if BP was already implemented in previous cycle, should w amend it in place, or move it to the ocata directory? | |
| 21:06:10 | mriedem | the generic resource pools spec isn't a carte blanche | |
| 21:06:38 | mriedem | _gryf: we already have generic-resource-pools-ocata, | |
| 21:06:47 | mriedem | but that was mostly for tying up loose ends with aggregates | |
| 21:07:21 | cdent | mriedem, _gryf: there's this in progress too, with regard to updating that spec: https://review.openstack.org/#/c/407562/ | |
| 21:08:26 | _gryf | cdent, oh, so maybe I'll do the patch on top of yours | |
| 21:08:32 | mriedem | cdent: ok but those are clarifications on what actually got implemented, right? not new things | |
| 21:08:44 | cdent | mriedem: correct, just mentioning it for context | |
| 21:08:45 | mriedem | _gryf: amending a spec from newton to add new things isn't appropriate | |
| 21:09:15 | mriedem | _gryf: for example, we have a separate spec for returning uuids from os-aggregates which is something we'll need for generic-resource-pools, but wasn't actually called out in the original spec, | |
| 21:09:20 | mriedem | and was a separate API change so we created a separate spec | |
| 21:09:32 | _gryf | right | |
| 21:09:47 | mriedem | i believe jay also created a separate bp for getting notifications out of the placement API on resource provider CRUD ops | |
| 21:09:58 | _gryf | ok, so I'll do the separate bp than | |
| 21:10:36 | mriedem | https://blueprints.launchpad.net/nova/+spec/placement-notifications | |
| 21:10:48 | mriedem | _gryf: it would be helpful if you told me what you're looking to do | |
| 21:10:51 | mriedem | code-wise | |
| 21:11:27 | _gryf | mriedem, here is jaypipes patch: https://review.openstack.org/#/c/404990/5 | |
| 21:11:43 | mriedem | you want to return specific codes from the placement API yes? | |
| 21:11:50 | mriedem | in a header or something? | |
| 21:11:53 | _gryf | yeah, that's the brief idea | |
| 21:12:04 | _gryf | I was thinking on json response rather | |
| 21:12:47 | mriedem | either way i think it's out of scope for ocata, and it's an api change, so probably requires a spec queue up for pike | |
| 21:12:55 | mriedem | *queued | |
| 21:13:26 | mriedem | a spec would be good for describing how that's going to look to the consumer, because i'm sure the api-wg will have input on this | |
| 21:14:07 | cdent | _gryf: codes meaning what? | |
| 21:14:24 | _gryf | so, I can cook it up and place on the pike directory | |
| 21:14:40 | _gryf | cdent, for distinguish between different 409 cases | |
| 21:15:09 | cdent | ah, I see. yeah the errors guideline from the api-wg has ideas on that | |
| 21:15:12 | mriedem | e.g. resource provider generation conflict vs inventory in use conflict | |
| 21:15:30 | _gryf | yeah | |
| 21:15:42 | cdent | the 'code' thing here: http://specs.openstack.org/openstack/api-wg/guidelines/errors.html | |
| 21:15:43 | mriedem | let it be known, i will +2 anything that can work in lyrics from rime of the ancient mariner... | |
| 21:16:36 | _gryf | oh, nice | |
| 21:16:45 | dtp | mriedem i wrote this in rime OTAM https://review.openstack.org/#/c/336293/ | |
| 21:19:03 | openstackgerrit | Chris Dent proposed openstack/nova: [placement] Add an "Adding a Handler" section to placement_dev https://review.openstack.org/416304 | |
| 21:19:04 | mriedem | dtp: the albatross is around that patch's neck right now | |
| 21:19:28 | dtp | lol ty | |
| 21:23:18 | mriedem | dansmith: nit on https://review.openstack.org/#/c/407238/ when you fix the pep8 | |
| 21:23:24 | mriedem | othrewise lgtm | |
| 21:23:27 | mriedem | *otherwise | |
| 21:23:34 | dansmith | mriedem: yeah, fixing that now.. apparently I ran pep8 on master whilst rebasing | |
| 21:23:35 | dansmith | doh | |
| 21:24:08 | dansmith | mriedem: so I put it all inside the try..except because it looked a lot more confusing the other way | |
| 21:24:21 | dansmith | I shall change it and you can decide if you really think it's better | |
| 21:25:06 | mriedem | ok | |
| 21:25:17 | mriedem | 9 minutes into this 14 minute song is when things really get rockin' | |
| 21:25:38 | dansmith | actually, maybe I'll just break this up | |
| 21:25:39 | mriedem | i'm hoping my wife walks in right about now | |
| 21:25:43 | dansmith | it's already not awesome | |
| 21:26:00 | mriedem | dansmith: we could do the if 'fault' in instance thing in a separate patch at the beginning of the series, | |
| 21:26:06 | mriedem | since it's an optimization we could make regardless | |
| 21:26:20 | mriedem | well, i guess it's not that big a deal today, it's either set or it isn't | |
| 21:35:27 | dansmith | mriedem: okay, refactored it with post-holiday brain and it's a lot better I think | |
| 21:35:32 | openstackgerrit | Dan Smith proposed openstack/nova: Make servers api view load instance fault from proper cell https://review.openstack.org/407238 | |
| 21:35:33 | openstackgerrit | Dan Smith proposed openstack/nova: Multicell support for instance listing https://review.openstack.org/396775 | |
| 21:35:33 | openstackgerrit | Dan Smith proposed openstack/nova: Fix non-parameterized service id in hypervisors sample tests https://review.openstack.org/410471 | |
| 21:35:34 | openstackgerrit | Dan Smith proposed openstack/nova: Make the SingleCellSimple fixture a little more comprehensive https://review.openstack.org/410472 | |
| 21:35:34 | openstackgerrit | Dan Smith proposed openstack/nova: WIP: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | |
| 21:35:36 | openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | |
| 21:41:38 | openstackgerrit | Jin Li proposed openstack/nova: Transform instance.soft_delete notifications https://review.openstack.org/383970 | |
| 21:45:10 | mriedem | dansmith: nice, looks better | |
| 21:45:29 | dansmith | I dunno why I didn't do that first, | |
| 21:45:38 | dansmith | probably pent-up angst over the whole thing | |
| 21:52:06 | mriedem | well it could be worse, we're having a hamburger bun fiasco here | |
| 21:52:23 | mriedem | i asked for just plain white hamburger buns but that's not what i got, and it's a problem | |
| 21:53:44 | dansmith | oh my | |
| 21:54:44 | openstackgerrit | Matt Riedemann proposed openstack/nova: Remove more deprecated nova-manage commands https://review.openstack.org/386788 | |
| 22:12:46 | jaypipes | mriedem: I'm stumped on https://review.openstack.org/#/c/414214/ :( | |
| 22:17:08 | mriedem | hrm | |
| 22:18:17 | jaypipes | mriedem: I've tried with unicode(), with and without trailing newlines... | |
| 22:18:24 | jaypipes | nothing seems to make a difference. | |
| 22:19:11 | mriedem | will take a look after i wrap something up quick | |
| 22:19:52 | jaypipes | no worries. I'm heading off for the night. If you see something put it on the review and I'll get to it first thing tomorrow. | |
| 22:28:17 | openstackgerrit | Matt Riedemann proposed openstack/nova: Add 'disabled' to WatchdogAction field https://review.openstack.org/386221 | |
| 22:31:44 | jlvillal | jaypipes: mriedem: On that patch for Ironic | |
| 22:32:09 | jlvillal | Oh, hmmm. Let me look more... | |
| 22:34:21 | jlvillal | jaypipes: mriedem: I added comment. I think need to add: re.MULTILINE | |
| 22:35:55 | mriedem | i'm playing with the unit test using the actual error text from the logs | |
| 22:38:11 | mriedem | jlvillal: looks like re.MULTILINE just treats ^ as the beginning of a new line, which would be ok except the things we're looking for isn't at the beginning | |
| 22:38:11 | mriedem | http://logs.openstack.org/23/415523/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial/7be247c/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-01-03_20_43_16_699 | |
| 22:38:16 | mriedem | so i think we still have to use search() | |
| 22:38:17 | jlvillal | yeah... | |
| 22:38:30 | mriedem | ok i've got a recreate in the test | |
| 22:39:03 | mriedem | http://paste.openstack.org/show/593822/ | |
| 22:39:46 | jlvillal | mriedem: I thought it was using search() | |
| 22:40:08 | mriedem | it is now | |
| 22:40:11 | mriedem | let me try with multiline | |
| 22:40:27 | jlvillal | Oh you got the regex to not match | |
| 22:42:18 | mriedem | yeah, i fixed the unit test to use the actual error response text we're getting in the CI job | |
| 22:42:24 | mriedem | anyway, removing .$ fixed it | |
| 22:42:46 | mriedem | here it comes | |
| 22:43:02 | openstackgerrit | Matt Riedemann proposed openstack/nova: placement: Do not save 0-valued inventory https://review.openstack.org/414214 | |
| 22:43:03 | mriedem | jaypipes: jlvillal: ^ | |
| 22:43:29 | jlvillal | mriedem: Thanks! | |
| 22:44:40 | jlvillal | mriedem: Ah, so re.MULTILINE would also have worked. So I wasn't totally wrong :) | |
| 22:45:13 | jlvillal | At least in my test. So '$' impacts the multiline searching | |