| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-03 | |||
| 21:23:35 | dansmith | doh | |
| 21:24:08 | dansmith | mriedem: so I put it all inside the try..except because it looked a lot more confusing the other way | |
| 21:24:21 | dansmith | I shall change it and you can decide if you really think it's better | |
| 21:25:06 | mriedem | ok | |
| 21:25:17 | mriedem | 9 minutes into this 14 minute song is when things really get rockin' | |
| 21:25:38 | dansmith | actually, maybe I'll just break this up | |
| 21:25:39 | mriedem | i'm hoping my wife walks in right about now | |
| 21:25:43 | dansmith | it's already not awesome | |
| 21:26:00 | mriedem | dansmith: we could do the if 'fault' in instance thing in a separate patch at the beginning of the series, | |
| 21:26:06 | mriedem | since it's an optimization we could make regardless | |
| 21:26:20 | mriedem | well, i guess it's not that big a deal today, it's either set or it isn't | |
| 21:35:27 | dansmith | mriedem: okay, refactored it with post-holiday brain and it's a lot better I think | |
| 21:35:32 | openstackgerrit | Dan Smith proposed openstack/nova: Make servers api view load instance fault from proper cell https://review.openstack.org/407238 | |
| 21:35:33 | openstackgerrit | Dan Smith proposed openstack/nova: Multicell support for instance listing https://review.openstack.org/396775 | |
| 21:35:33 | openstackgerrit | Dan Smith proposed openstack/nova: Fix non-parameterized service id in hypervisors sample tests https://review.openstack.org/410471 | |
| 21:35:34 | openstackgerrit | Dan Smith proposed openstack/nova: Make the SingleCellSimple fixture a little more comprehensive https://review.openstack.org/410472 | |
| 21:35:34 | openstackgerrit | Dan Smith proposed openstack/nova: WIP: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | |
| 21:35:36 | openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | |
| 21:41:38 | openstackgerrit | Jin Li proposed openstack/nova: Transform instance.soft_delete notifications https://review.openstack.org/383970 | |
| 21:45:10 | mriedem | dansmith: nice, looks better | |
| 21:45:29 | dansmith | I dunno why I didn't do that first, | |
| 21:45:38 | dansmith | probably pent-up angst over the whole thing | |
| 21:52:06 | mriedem | well it could be worse, we're having a hamburger bun fiasco here | |
| 21:52:23 | mriedem | i asked for just plain white hamburger buns but that's not what i got, and it's a problem | |
| 21:53:44 | dansmith | oh my | |
| 21:54:44 | openstackgerrit | Matt Riedemann proposed openstack/nova: Remove more deprecated nova-manage commands https://review.openstack.org/386788 | |
| 22:12:46 | jaypipes | mriedem: I'm stumped on https://review.openstack.org/#/c/414214/ :( | |
| 22:17:08 | mriedem | hrm | |
| 22:18:17 | jaypipes | mriedem: I've tried with unicode(), with and without trailing newlines... | |
| 22:18:24 | jaypipes | nothing seems to make a difference. | |
| 22:19:11 | mriedem | will take a look after i wrap something up quick | |
| 22:19:52 | jaypipes | no worries. I'm heading off for the night. If you see something put it on the review and I'll get to it first thing tomorrow. | |
| 22:28:17 | openstackgerrit | Matt Riedemann proposed openstack/nova: Add 'disabled' to WatchdogAction field https://review.openstack.org/386221 | |
| 22:31:44 | jlvillal | jaypipes: mriedem: On that patch for Ironic | |
| 22:32:09 | jlvillal | Oh, hmmm. Let me look more... | |
| 22:34:21 | jlvillal | jaypipes: mriedem: I added comment. I think need to add: re.MULTILINE | |
| 22:35:55 | mriedem | i'm playing with the unit test using the actual error text from the logs | |
| 22:38:11 | mriedem | jlvillal: looks like re.MULTILINE just treats ^ as the beginning of a new line, which would be ok except the things we're looking for isn't at the beginning | |
| 22:38:11 | mriedem | http://logs.openstack.org/23/415523/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial/7be247c/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-01-03_20_43_16_699 | |
| 22:38:16 | mriedem | so i think we still have to use search() | |
| 22:38:17 | jlvillal | yeah... | |
| 22:38:30 | mriedem | ok i've got a recreate in the test | |
| 22:39:03 | mriedem | http://paste.openstack.org/show/593822/ | |
| 22:39:46 | jlvillal | mriedem: I thought it was using search() | |
| 22:40:08 | mriedem | it is now | |
| 22:40:11 | mriedem | let me try with multiline | |
| 22:40:27 | jlvillal | Oh you got the regex to not match | |
| 22:42:18 | mriedem | yeah, i fixed the unit test to use the actual error response text we're getting in the CI job | |
| 22:42:24 | mriedem | anyway, removing .$ fixed it | |
| 22:42:46 | mriedem | here it comes | |
| 22:43:02 | openstackgerrit | Matt Riedemann proposed openstack/nova: placement: Do not save 0-valued inventory https://review.openstack.org/414214 | |
| 22:43:03 | mriedem | jaypipes: jlvillal: ^ | |
| 22:43:29 | jlvillal | mriedem: Thanks! | |
| 22:44:40 | jlvillal | mriedem: Ah, so re.MULTILINE would also have worked. So I wasn't totally wrong :) | |
| 22:45:13 | jlvillal | At least in my test. So '$' impacts the multiline searching | |
| 22:45:15 | mriedem | maybe the string ends with a newline? | |
| 22:45:36 | mriedem | i could still add multiline if we cared | |
| 22:45:41 | mriedem | since we're using search though, | |
| 22:45:46 | mriedem | i don't think we need ^ or $ | |
| 22:46:00 | mriedem | anyway, here's to throwing things at the wall with regex until something works :) | |
| 22:46:02 | jlvillal | mriedem: Right as long as no '^' or '$' don't need the multiline | |
| 23:24:41 | openstackgerrit | Dan Peschman proposed openstack/nova: Option to always create network metadata information as static https://review.openstack.org/336293 | |
| 23:26:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 23:27:08 | dtp | mriedem added some tests ^ | |
| 23:27:16 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 23:27:36 | openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 23:28:55 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in unit/api/openstack/test_wsgi.py https://review.openstack.org/414941 | |
| 23:29:03 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 23:29:13 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases https://review.openstack.org/394738 | |
| 23:29:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py https://review.openstack.org/308746 | |
| 23:29:28 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876 | |
| 23:29:37 | openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-server-groups.inc https://review.openstack.org/415377 | |
| 23:29:46 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.41 - Enable cold migration with target host https://review.openstack.org/406707 | |
| 23:29:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases https://review.openstack.org/395436 | |
| 23:39:47 | EmilienM | mriedem: hi! happy new year. What port should we use to deploy nova placement api | |
| 23:40:10 | EmilienM | I'm confused between 8780 or 80 or | |
| 23:41:15 | EmilienM | doc says 8778 http://docs.openstack.org/developer/nova/placement.html?highlight=placement | |
| 23:49:09 | mriedem | EmilienM: i think bauzas has a patch up to change those docs | |
| 23:49:20 | EmilienM | mriedem: which port should we use? | |
| 23:49:35 | mriedem | because of this https://review.openstack.org/#/c/413118/ | |
| 23:49:36 | EmilienM | in production, not in devstack. | |
| 23:50:18 | mriedem | EmilienM: see https://review.openstack.org/#/c/413158/ | |
| 23:51:12 | EmilienM | using 80 is a terrible idea for operators | |
| 23:53:01 | EmilienM | the problem is that you can't mix vhosts with *:80 and IP:80 | |
| 23:54:23 | EmilienM | why making things complex? it's first OpenStack API service i've seen where 80 is used by default | |
| 23:55:21 | mriedem | EmilienM: honestly some of this discussion is already in the ML and a lot of it was had between bauzas, cdent and sdague | |
| 23:55:55 | dansmith | EmilienM: are you sure you can't mix those two? because I thought you could | |
| 23:56:19 | dansmith | however, I thought this was mostly about not choosing a "conventional port" for placement and just relying on the service catalog? | |
| 23:56:51 | dansmith | https://httpd.apache.org/docs/2.4/vhosts/examples.html#mixed | |
| 23:57:10 | mwhahaha | for ssl you wouldn't be able to mix them i don't think | |
| 23:57:36 | dansmith | why not? with SNI it should be the same, no? | |
| 23:57:37 | mwhahaha | so it's not a good practice to assume that | |
| 23:57:56 | mwhahaha | it depends on the way apache handles the vhost configs and I thought they weren't merged together | |
| #openstack-nova - 2017-01-04 | |||
| 00:00:30 | EmilienM | mwhahaha: i'm trying it now | |
| 00:00:43 | mwhahaha | maybe we need to go dig into apache more but it seems odd to have this be the first service with such a configuration and from a deployer's standpoint it complicates things | |
| 00:00:51 | mwhahaha | just some feedback on it | |
| 00:01:29 | dansmith | but it's not like it has to be on 80, right? | |
| 00:02:45 | mwhahaha | no it doesn't but it would be nice to have some sort of standard expectation around a standalone deployment if not 80 | |
| 00:02:49 | EmilienM | dansmith: we're *trying* to deploy this service in tripleo, with ssl activated. So we need to pick a port and 443 seems like the one you would choose. | |
| 00:03:24 | dansmith | mwhahaha: I dunno, it seems kinda silly that we have any such defaults as it has only facilitated us avoiding using the service catalog properly in many places :) | |