| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-09 | |||
| 19:34:47 | gmann | it has been lot of other things and gate failures and I did not get chance to update that | |
| 19:34:59 | sean-k-mooney | ack | |
| 19:35:08 | sean-k-mooney | i was more wondering if we still planned to land it this cycle | |
| 19:35:25 | sean-k-mooney | i was hopeing we could but if it slips we can do it early next cycle | |
| 19:35:35 | sean-k-mooney | after RC1 is shiped in ~4 weeks | |
| 19:43:49 | gmann | yeah, let see if I can do it before FF | |
| 19:44:05 | gmann | elodilles: you need to remove it from check pipeline also along with template https://review.opendev.org/c/openstack/nova/+/873242 | |
| 19:45:42 | opendevreview | Ghanshyam proposed openstack/nova stable/victoria: [stable-only] Remove broken sdk job from wallaby https://review.opendev.org/c/openstack/nova/+/873295 | |
| 19:46:12 | opendevreview | Ghanshyam proposed openstack/nova stable/victoria: [stable-only] Remove broken sdk job from wallaby https://review.opendev.org/c/openstack/nova/+/873295 | |
| 19:46:31 | gmann | elodilles: basically backporting this ti victoria ^^ | |
| 19:46:38 | gmann | I have updated the depend-on | |
| 21:34:22 | opendevreview | Merged openstack/nova stable/xena: nova-live-migration tests not needed for Ironic https://review.opendev.org/c/openstack/nova/+/855469 | |
| #openstack-nova - 2023-02-10 | |||
| 03:49:36 | opendevreview | Yusuke Okada proposed openstack/nova master: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/873216 | |
| 04:10:02 | opendevreview | Yusuke Okada proposed openstack/nova master: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/873216 | |
| 08:28:28 | opendevreview | Jorge San Emeterio proposed openstack/nova master: WIP: Look for cpu controller on cgroups v2 https://review.opendev.org/c/openstack/nova/+/873127 | |
| 08:50:03 | gibi | bauzas: I start to think that the functional test failure is somehow changing behavior just becuase we added logging. | |
| 08:50:24 | bauzas | really ? | |
| 08:50:50 | bauzas | gibi: btw. saw your highlight yesterday, thanks, didn't had yet time to look at my series but I can surely rush for the nits | |
| 08:50:55 | gibi | we rechecked it through multiple days | |
| 08:51:09 | gibi | without hit | |
| 08:51:26 | bauzas | gibi: then we should merge it and see whether it magically solves our problem | |
| 08:51:32 | bauzas | gibi: we could prepare a revert | |
| 08:51:33 | gibi | lol :D | |
| 08:52:11 | bauzas | we're not really at risk for Feature Freeze and we have time to revert before RC1 | |
| 08:52:22 | bauzas | butn, | |
| 08:52:25 | gibi | OK, let me push a new PS to clean things a bit up | |
| 08:52:32 | gibi | then I'm OK to merge it with a pending revert | |
| 08:52:40 | bauzas | if that solves the problem, then honestly, I don't know what to say | |
| 08:53:04 | gibi | yeah, I feel the same | |
| 08:53:07 | bauzas | we could merge some log saying "meh, don't be afraid, we love you" | |
| 09:00:54 | bauzas | gibi: btw. you know that our master branch is broken broken ? (c) elodilles | |
| 09:01:12 | gibi | bauzas: that is a news to me | |
| 09:01:13 | bauzas | I gonna recheck https://review.opendev.org/c/openstack/tempest/+/873300 just looking up the root cause of the CI failure | |
| 09:03:09 | bauzas | gibi: tl;dr when dan fixed the image caching issue in Tempest, unfortunately we were not having coverage so we regressed | |
| 09:03:51 | bauzas | I was in the train with limited connection yesterday so I haven't send a status email, but basically our ceph-multistore job is unhappy | |
| 09:04:31 | bauzas | the tempest fix went accepted soon so now there is no need to send a signal to the community but I just hope to not face problems with merging it | |
| 09:09:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add logging to find test cases leaking libvirt threads https://review.opendev.org/c/openstack/nova/+/872975 | |
| 09:09:49 | gibi | bauzas: pimped out ^^ | |
| 09:10:14 | bauzas | lol | |
| 09:10:18 | gibi | bauzas: ack, thanks for the summary | |
| 09:10:22 | bauzas | it brightens | |
| 09:11:40 | bauzas | gibi: sean-k-mooney is on PTO today until wed, we need a second core | |
| 09:12:00 | gibi | hm mh | |
| 09:12:13 | sean-k-mooney[m] | i am but im reviewing your pm series | |
| 09:12:18 | sean-k-mooney[m] | right now | |
| 09:12:34 | sean-k-mooney[m] | so if you want me to look at something quickly i can | |
| 09:12:58 | bauzas | sean-k-mooney: oh, as you can | |
| 09:13:00 | gibi | sean-k-mooney[m]: just blindly merge https://review.opendev.org/c/openstack/nova/+/872975 please :D this is still trying to catch the functional tc | |
| 09:13:19 | gibi | that cause the libvirt import error in a later test | |
| 09:13:36 | bauzas | sean-k-mooney: for the PM series, I'll update the 3rd patch and work on a FUP given the method rename discussing in patch #2 | |
| 09:13:48 | gibi | after couple of days of constant rechecks we did not get a hit | |
| 09:14:00 | gibi | so we think if we merge the extra log it will fix the gate (kidding) | |
| 09:15:48 | gibi | bauzas: one thing hit me during the night and now I remember it. If we do the rename of the get_online_cpus and return the offlined ones as well then I think cpu_shared_set will allow listing offline CPUs without nova rejecting it. While in the past such config was rejected | |
| 09:16:04 | sean-k-mooney[m] | hehe a the famous add a debug line to fix the race technique | |
| 09:16:14 | sean-k-mooney[m] | there are man | |
| 09:16:19 | bauzas | technically this is a warning line :D | |
| 09:16:41 | bauzas | gibi: I need to look at that code, tbh | |
| 09:16:45 | sean-k-mooney[m] | *many c programs that are fixt with strategicly placed printfs | |
| 09:17:19 | gibi | sean-k-mooney[m]: it is a heisenbug so we merge the observer into the system and hope that it won't get entangled with it | |
| 09:17:42 | bauzas | lol | |
| 09:17:46 | bauzas | we need a cat | |
| 09:17:46 | gibi | but I know my fate | |
| 09:18:22 | bauzas | I'd rather say that the race condition is actually low | |
| 09:18:37 | bauzas | and we were blinded by the false positives | |
| 09:18:40 | gibi | maybe the race condition is affraid of cats ... | |
| 09:18:56 | bauzas | (just a theory) | |
| 09:19:05 | bauzas | cats don't like races | |
| 09:19:14 | bauzas | they prefer to sit down and lick their bottoms | |
| 09:19:43 | sean-k-mooney[m] | wont that break tempest | |
| 09:20:04 | bauzas | tempest is already broken :) | |
| 09:20:09 | gibi | sean-k-mooney[m]: in which way? | |
| 09:20:15 | bauzas | that's another fun story | |
| 09:20:40 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/872975/7/nova/virt/libvirt/driver.py | |
| 09:20:42 | sean-k-mooney[m] | if we ever do an abort in tempest | |
| 09:21:09 | sean-k-mooney[m] | then wont that either crash on parent being none or keep looping | |
| 09:21:52 | bauzas | you mean for the real tempest checks ? | |
| 09:22:37 | sean-k-mooney[m] | ya if we test live migration abort | |
| 09:23:04 | sean-k-mooney[m] | like we never set testcase_id in reall code in the eventlet | |
| 09:23:13 | bauzas | that's a good point | |
| 09:23:23 | bauzas | gibi: ^ | |
| 09:23:46 | bauzas | formerly, I restricted zuul to only run the functests | |
| 09:24:02 | bauzas | but if we merge this, it will be run for *all* tests | |
| 09:25:35 | sean-k-mooney[m] | its a simple fix commeted inline | |
| 09:25:47 | sean-k-mooney[m] | we just need to check that current is not None | |
| 09:25:56 | sean-k-mooney[m] | and only log if its not None | |
| 09:26:30 | sean-k-mooney[m] | so too None check in the while and around the log and it will work without breaking abort | |
| 09:27:39 | gibi | good point | |
| 09:27:42 | gibi | fixing it up... | |
| 09:51:51 | bauzas | gibi: working on the alternative for the PM series patch #2 | |
| 09:51:55 | bauzas | it won't be a fup | |
| 09:52:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add logging to find test cases leaking libvirt threads https://review.opendev.org/c/openstack/nova/+/872975 | |
| 09:52:43 | gibi | bauzas: sean-k-mooney[m]: ^^ | |
| 09:52:45 | gibi | bauzas: ack | |
| 09:53:57 | bauzas | gibi: +2d | |
| 09:54:38 | sean-k-mooney[m] | +2w | |
| 09:54:56 | sean-k-mooney[m] | also sylvain i completed a pass on the pm seriese | |
| 09:55:12 | sean-k-mooney[m] | nothing major but if your reworking it anyway please take a look | |
| 09:55:25 | sean-k-mooney[m] | i dont have any comments really worth holding the seriese over | |
| 09:55:42 | sean-k-mooney[m] | but perhaps things to think about in followups | |
| 09:57:14 | sean-k-mooney[m] | ok im going to have a coffee. check on freya then play some factorio. my ipad will be near by so if there is anything else just ping but im mostly done for the day now | |