| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-28 | |||
| 14:26:26 | gibi | dansmith: true | |
| 14:26:30 | gibi | zigo: interesting | |
| 14:26:49 | zigo | Maybe I should try downgrading to oslo.policy 3.7.0 to see what's going on? | |
| 14:26:56 | dansmith | that error can come from the json encoder/decoder, maybe there's something wrong with the policy file? | |
| 14:27:26 | zigo | dansmith: What I'm surprised of, is that I'm using a yaml policy file in /etc/placement/policy.d/00_default_policy.yaml | |
| 14:27:43 | dansmith | zigo: ah, good, that was going to be my next question | |
| 14:27:54 | zigo | And there, everything was supposed to be commented out, but it's not: every DEPRECATED stuff is active ... | |
| 14:28:00 | zigo | Same for Nova. | |
| 14:28:07 | zigo | (I had to comment out everything...) | |
| 14:28:51 | zigo | dansmith: So you can rule out a policy.json thingy, as I don't have one ! :) | |
| 14:30:39 | zigo | Same result with oslo.policy 3.7.0 | |
| 14:33:23 | zigo | Ok, got it to work ... | |
| 14:33:42 | zigo | Again, same stuff: oslopolicy-sample-generator is generating a default policy yaml file that DOES NOT WORK ! | |
| 14:33:52 | zigo | When commenting everything out, it works... | |
| 14:34:20 | gmann | zigo: I do not think oslopolicy-sample-generator add the deprecated rules | |
| 14:34:41 | gmann | zigo: best way is not to have policy file if no rule overridden is needed | |
| 14:34:41 | zigo | gmann: That's what it did for me ... | |
| 14:35:26 | zigo | gmann: Well, in my package, I'm writing a /etc/placement/policy.d/00_default_policy.yaml with the expectation that this fille will only contain commented out directives ... | |
| 14:35:33 | zigo | It worked this way for the last 2 or 3 releases. | |
| 14:35:36 | zigo | Now that's broken. | |
| 14:36:25 | gmann | zigo: commented out you mean except deprecated rules right? | |
| 14:36:43 | zigo | gmann: Why would there be some special cases for the deprecated rules? | |
| 14:37:32 | gmann | zigo: no, I mean everything was commented out ? because earlier you mentioned deprecated rules were not commented? | |
| 14:38:13 | zigo | gmann: That's what I mean yes, in my packages, now, I have everything commented out but all what's deprecated ... :/ | |
| 14:39:18 | gmann | I feel we should extend these tool oslopolicy-sample-generator and oslopolicy-policy-generator to add deprecated rule too with flag so that it does not break deployment not moved to new policies yet | |
| 14:40:10 | zigo | Anyway, GOT MY FIRST Xena VM UP AND RUNNING AND PINGING !!! \o/ | |
| 14:40:28 | gibi | \o/ | |
| 14:40:28 | gmann | zigo: can you paste your old (failing) policy file? | |
| 14:40:32 | gmann | zigo: perfect | |
| 14:40:38 | bauzas | dansmith: I saw gibi answered you, not for the moment | |
| 14:40:49 | dansmith | ack | |
| 14:47:13 | gmann | zigo: and that policy file (failing ) one is not generated from oslopolicy-sample-generator tool right? is it old one of wallaby or something? | |
| 14:48:35 | bauzas | dansmith: gibi: that said, I'll try to create an agenda for next week's meeting | |
| 14:48:55 | bauzas | create a *PTG tentative agenda | |
| 14:49:00 | gibi | bauzas: sounds good let me know if you need help | |
| 14:49:10 | bauzas | gibi: will copy/think/paste :p | |
| 14:49:21 | gmann | gibi: bauzas I added one more cross project topic oslo-nova about this ^^ policy file stuff L56 for now | |
| 14:49:28 | bauzas | ack | |
| 14:49:45 | gibi | bauzas: I can definitely help with the first and last step, not sure about the middle :P | |
| 14:50:02 | gmann | this keep coming in every cycle especially when new policy are implemented, I feel we can find some better solution | |
| 14:52:23 | gmann | zigo: FYI, in case you attend ptg, I have added this topic in PTG discussion. we will discuss if oslopolicy-sample-generator tool can be extended in way that it works for both deployment with old tokens + new tokens | |
| 14:53:17 | zigo | gmann: I've put the files over here: http://shade.infomaniak.ch/policy-files/ | |
| 14:53:40 | zigo | I wonder, should I add a sed in all my packages when generating the policy files then? | |
| 14:53:55 | zigo | As in, commenting-out everything that not commented? | |
| 14:55:03 | gmann | zigo: yeah or can you skip generating it (no policy file) ? I think you need to ship one in packaging ? | |
| 14:55:43 | zigo | With something like: sed -i 's/^"/#"/ $(CURDIR)/debian/nova-common/etc/nova/policy.d/00_default_policy.yaml | |
| 14:56:07 | gmann | zigo: ok, let me debug that today/tomorrow, having only deprecated rules in policy file should work | |
| 14:56:11 | zigo | gmann: I do not *NEED* to generate one, but I think it is a service to the Debian users to provide them with a policy file that has all what's possible... | |
| 14:57:04 | zigo | gmann: Well, maybe we should add an option in oslopolicy-sample-generator to comment out the DEPRECATED options ? | |
| 14:57:35 | zigo | oslopolicy-sample-generator --commented-out-deprecated-options --output-file=$(CURDIR)/debian/nova-common/etc/nova/policy.d/00_default_policy.yaml --format yaml --namespace nova | |
| 14:57:53 | gmann | zigo: oh does oslopolicy-sample-generator tool generated that file with depreacted rule not commented? | |
| 14:58:08 | zigo | gmann: Yeah, that's what I'm saying since the begining ! :) | |
| 14:58:16 | zigo | Sorry for not expressing myself correctly ... | |
| 14:58:19 | gmann | humm | |
| 14:58:28 | zigo | PYTHONPATH=$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages oslopolicy-sample-generator \ | |
| 14:58:28 | zigo | mkdir -p $(CURDIR)/debian/nova-common/etc/nova/policy.d | |
| 14:58:28 | zigo | My package simply does: | |
| 14:58:29 | zigo | --output-file=$(CURDIR)/debian/nova-common/etc/nova/policy.d/00_default_policy.yaml \ | |
| 14:58:31 | zigo | --format yaml \ | |
| 14:58:33 | zigo | --namespace nova | |
| 14:58:38 | zigo | Nothing more ... | |
| 14:59:05 | zigo | (note: the PYTHONPATH setting is there to use the installed python3-nova package as if it was in the system) | |
| 15:13:45 | bauzas | lyarwood: seen this ? https://bugs.launchpad.net/nova/+bug/1945323 | |
| 15:13:56 | bauzas | gibi: the reporter proposes ^ for a RC3 | |
| 15:14:07 | bauzas | wondering whether it's a regression | |
| 15:14:48 | bauzas | but this sounds valid as it's due to a recent osbrick release | |
| 15:15:35 | gibi | bauzas: lyarwood: left a -1 on the fix, but I think his comments confirms that this needs to fixed | |
| 15:16:08 | bauzas | ok, so let's do a RC2 for the moment and prepare a RC3 release if so | |
| 15:17:06 | gibi | bauzas: based on the gate status we will go with RC2 :D | |
| 15:18:27 | bauzas | gibi: hmmm, because of the pipeline ? | |
| 15:18:45 | bauzas | gibi: I can only see a 2-hour delay which looks a bit busy but still ok-ish | |
| 15:19:15 | gibi | bauzas: becuase i) of apache placement break needs to be fixed from victoria to master direction then ii) nova-granade-multinode still need to be fixed with trunk port | |
| 15:19:33 | gibi | just to enable landing things on master :) | |
| 15:19:39 | bauzas | hah | |
| 15:20:03 | gibi | an we have 2 days left | |
| 15:22:29 | bauzas | gibi: could we say to not use the latest osbrick release for Xena then ? | |
| 15:23:02 | gibi | that also a patch to the requirements.txt to pin osbrick | |
| 15:23:14 | gibi | which we need to land | |
| 15:23:29 | gibi | we can say in the bug report this as a suggestion | |
| 15:23:30 | bauzas | surely | |
| 15:23:35 | gibi | and packagers can apply it | |
| 15:23:43 | bauzas | I wasn't thinking of our reqs | |
| 15:23:50 | bauzas | but rather documenting it for packagers | |
| 15:23:57 | bauzas | in reno | |
| 15:24:11 | gibi | yeah reno could work as that does not require full CI run | |
| 15:24:17 | bauzas | we have a "bugs" reno section AFAICR | |
| 15:24:34 | gibi | yepp you are right, this is a good idea | |
| 15:24:42 | gibi | to doc as known bug | |
| 15:24:52 | bauzas | let's discuss then it during the meeting | |
| 15:25:07 | bauzas | I'll be off for the next 30 mins, I have some appointment coming at home | |
| 15:25:16 | bauzas | but I'll be there for the start | |
| 15:25:30 | bauzas | gibi: ^ (fyk) | |
| 15:25:47 | gibi | bauzas: ack | |
| 15:26:34 | zigo | Had to do this: https://salsa.debian.org/openstack-team/services/nova/-/commit/7c55fbf4356399f96906162accb3fa80d70f9d24 | |
| 15:26:35 | zigo | :/ | |
| 15:26:48 | zigo | Should that be reported to oslo.policy? | |
| 15:27:00 | bauzas | gibi: grabbing the bug reports for the gate hold | |
| 15:27:11 | bauzas | gibi: do you have them already somewhere ? | |
| 15:27:25 | bauzas | I wanna write them for the meeting agenda | |
| 15:27:44 | gibi | bauzas: we don't have bugreport for devstack about the apache placement break | |