| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-11 | |||
| 17:00:05 | bauzas | sounds like we have a debate :) | |
| 17:00:42 | sean-k-mooney | fungi: wel part of the idea was to use it to replace oru old runway proces where anyone could add something to the queue but only core move thing into the runway slots | |
| 17:00:42 | bauzas | sean-k-mooney: just before you came back, I was exposing to gibi the fact that I don't think the signal is useful if it's just a ask for cores to review | |
| 17:00:42 | sean-k-mooney | fungi: wel part of the idea was to use it to replace oru old runway proces where anyone could add something to the queue but only core move thing into the runway slots | |
| 17:00:42 | bauzas | sean-k-mooney: just before you came back, I was exposing to gibi the fact that I don't think the signal is useful if it's just a ask for cores to review | |
| 17:01:06 | bauzas | sean-k-mooney: and gibi told me the crux of the idea was "commitment" | |
| 17:01:06 | bauzas | sean-k-mooney: and gibi told me the crux of the idea was "commitment" | |
| 17:01:20 | sean-k-mooney | bauzas: yes that is why it was going to be restrited to cores to set | |
| 17:01:20 | sean-k-mooney | bauzas: yes that is why it was going to be restrited to cores to set | |
| 17:01:28 | fungi | maybe look at it as being similar to bug triage. do you restrict who can set the severity on bug reports? | |
| 17:01:28 | fungi | maybe look at it as being similar to bug triage. do you restrict who can set the severity on bug reports? | |
| 17:01:45 | bauzas | sean-k-mooney: the problem is that we had a process with runways which didn't really work because of the lack of commitment | |
| 17:01:45 | bauzas | sean-k-mooney: the problem is that we had a process with runways which didn't really work because of the lack of commitment | |
| 17:01:52 | sean-k-mooney | fungi: its an open team but ithink the motivates are different | |
| 17:01:52 | bauzas | fungi: nope | |
| 17:01:52 | sean-k-mooney | fungi: its an open team but ithink the motivates are different | |
| 17:01:52 | bauzas | fungi: nope | |
| 17:02:15 | sean-k-mooney | bauzas: well not entirly | |
| 17:02:15 | sean-k-mooney | bauzas: well not entirly | |
| 17:02:24 | bauzas | sean-k-mooney: if we're creating labels for marking changes for reviews, we'll just recreate the runway process but gerrit driven this time | |
| 17:02:24 | bauzas | sean-k-mooney: if we're creating labels for marking changes for reviews, we'll just recreate the runway process but gerrit driven this time | |
| 17:02:46 | bauzas | which honestly didn't greatly work | |
| 17:02:46 | bauzas | which honestly didn't greatly work | |
| 17:02:53 | sean-k-mooney | bauzas: partly | |
| 17:02:53 | sean-k-mooney | bauzas: partly | |
| 17:02:55 | bauzas | gibi: sean-k-mooney: here is what I'm proposing | |
| 17:02:55 | bauzas | gibi: sean-k-mooney: here is what I'm proposing | |
| 17:03:25 | gibi | * gibi listens but pretty out of steam already today | |
| 17:03:30 | bauzas | we should Depend-On the ACL change to some new change in the contribs docs | |
| 17:03:30 | bauzas | we should Depend-On the ACL change to some new change in the contribs docs | |
| 17:03:42 | bauzas | that would explain the process | |
| 17:03:42 | bauzas | that would explain the process | |
| 17:03:56 | bauzas | b/c the acl change is just implementation | |
| 17:03:56 | bauzas | b/c the acl change is just implementation | |
| 17:04:04 | bauzas | but we miss the design phase | |
| 17:04:04 | bauzas | but we miss the design phase | |
| 17:04:08 | sean-k-mooney | sure no issue with that | |
| 17:04:08 | sean-k-mooney | sure no issue with that | |
| 17:04:21 | fungi | but yes, if the goal is to only ever have x number of "priority" flagged reviews, and you expect to have a limited number of people with the necessary perspective to decide which those are, then restricting the label might be a way of avoiding problems with coordination. it all depends on how you expect to use that signal | |
| 17:04:21 | fungi | but yes, if the goal is to only ever have x number of "priority" flagged reviews, and you expect to have a limited number of people with the necessary perspective to decide which those are, then restricting the label might be a way of avoiding problems with coordination. it all depends on how you expect to use that signal | |
| 17:04:38 | gibi | bauzas: I agree | |
| 17:04:38 | gibi | bauzas: I agree | |
| 17:04:46 | bauzas | gibi: take a break and just commit yourself about describing your ideal view on what should be the process for those labels in a separate change | |
| 17:04:46 | bauzas | gibi: take a break and just commit yourself about describing your ideal view on what should be the process for those labels in a separate change | |
| 17:04:49 | gibi | bauzas: and I sign up to write the proposal | |
| 17:04:49 | gibi | bauzas: and I sign up to write the proposal | |
| 17:04:59 | bauzas | cool | |
| 17:05:24 | bauzas | I'm way more interested in debating over this change rather than the gerrit one :p | |
| 17:05:24 | bauzas | I'm way more interested in debating over this change rather than the gerrit one :p | |
| 17:05:25 | gibi | thank you all for the input I really appreciate it | |
| 17:05:25 | gibi | thank you all for the input I really appreciate it | |
| 17:05:59 | bauzas | np, and it's late and I'm thristy typing | |
| 17:05:59 | bauzas | np, and it's late and I'm thristy typing | |
| 17:06:18 | bauzas | * bauzas will avoid the coronas and just use his keg again | |
| 17:06:20 | sean-k-mooney | bauzas: i will happily try and translate what ever ye decied into gerrit | |
| 17:06:20 | sean-k-mooney | bauzas: i will happily try and translate what ever ye decied into gerrit | |
| 17:06:32 | bauzas | sean-k-mooney: thanks | |
| 17:06:32 | bauzas | sean-k-mooney: thanks | |
| 17:06:42 | bauzas | folks, should be around unofficially tomorrow morning | |
| 17:06:42 | bauzas | folks, should be around unofficially tomorrow morning | |
| 17:06:44 | bauzas | ++ | |
| 17:06:44 | bauzas | ++ | |
| 17:08:50 | gibi | bauzas: o/. | |
| 17:08:50 | gibi | bauzas: o/. | |
| 20:28:48 | melwitt | dansmith: I noticed you reviewed the rbd error sanitize patch earlier today, it depends on this one below it that re-enables the rbd unit tests, if you wanted to hit that too https://review.opendev.org/c/openstack/nova/+/790511 | |
| 20:28:48 | melwitt | dansmith: I noticed you reviewed the rbd error sanitize patch earlier today, it depends on this one below it that re-enables the rbd unit tests, if you wanted to hit that too https://review.opendev.org/c/openstack/nova/+/790511 | |
| 20:40:22 | dansmith | oh sorry | |
| 20:40:22 | dansmith | oh sorry | |
| 20:40:43 | dansmith | I actually had that one open too and then just didn't look at it | |
| 20:40:43 | dansmith | I actually had that one open too and then just didn't look at it | |
| 20:42:25 | melwitt | thanks :) | |
| 20:42:25 | melwitt | thanks :) | |
| 21:00:11 | lyarwood | *facepalm* sorry about that melwitt | |
| 21:00:11 | lyarwood | *facepalm* sorry about that melwitt | |
| 21:01:48 | melwitt | np lyarwood | |
| 21:01:48 | melwitt | np lyarwood | |
| 21:02:22 | amodi | Stable branch requires either cherry-pick -x headers or [stable-only] tag! | |
| 21:02:22 | amodi | Stable branch requires either cherry-pick -x headers or [stable-only] tag! | |
| 21:02:37 | amodi | https://review.opendev.org/c/openstack/nova/+/790724 can i not cherry=pick from gerrit ui? | |
| 21:02:37 | amodi | https://review.opendev.org/c/openstack/nova/+/790724 can i not cherry=pick from gerrit ui? | |
| 21:02:43 | amodi | what did i miss | |
| 21:02:43 | amodi | what did i miss | |
| 21:03:57 | openstackgerrit | Merged openstack/nova master: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790511 | |
| 21:03:57 | openstackgerrit | Merged openstack/nova master: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790511 | |
| 21:04:44 | melwitt | amodi: the gerrit ui only does the needed "cherry-pick -x" after the change you want to backport has merged. if you do the cherry pick in the ui before it merges, it will miss the -x option to cherry-pick | |
| 21:04:44 | melwitt | amodi: the gerrit ui only does the needed "cherry-pick -x" after the change you want to backport has merged. if you do the cherry pick in the ui before it merges, it will miss the -x option to cherry-pick | |
| 21:05:25 | amodi | melwitt: ohh, ok so i guess i need to abandon this and re-cherry-pick it? now that the change has merged | |
| 21:05:25 | amodi | melwitt: ohh, ok so i guess i need to abandon this and re-cherry-pick it? now that the change has merged | |
| 21:06:18 | melwitt | amodi: I'm not sure if there's a way to re-kick it from the ui perspective. you could try it but I'm not sure if that will work. usually we just do an edit to the commit message to add the line manually if this happens | |
| 21:06:18 | melwitt | amodi: I'm not sure if there's a way to re-kick it from the ui perspective. you could try it but I'm not sure if that will work. usually we just do an edit to the commit message to add the line manually if this happens | |
| 21:06:58 | amodi | i want to try with ui itself, one sec | |
| 21:06:58 | amodi | i want to try with ui itself, one sec | |
| 21:07:01 | openstackgerrit | melanie witt proposed openstack/nova stable/wallaby: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790836 | |
| 21:07:01 | openstackgerrit | melanie witt proposed openstack/nova stable/wallaby: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790836 | |
| 21:07:31 | openstackgerrit | Archit Modi proposed openstack/nova stable/wallaby: Fix typo in test_utils https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:07:31 | openstackgerrit | Archit Modi proposed openstack/nova stable/wallaby: Fix typo in test_utils https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:08:34 | amodi | melwitt: yeah looks like it re-kicked it correctly, https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:08:34 | amodi | melwitt: yeah looks like it re-kicked it correctly, https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:08:37 | amodi | thanks!! | |
| 21:08:37 | amodi | thanks!! | |