Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-15
12:44:48 sean-k-mooney gibi: we do not need to rebinding them in the neutron case just replug them.
12:45:18 sean-k-mooney in the neutorn case os-vif is the thing that attaches the ports to the network backend in general
12:45:37 sean-k-mooney which si the equivalent of creating the mdev
12:45:45 gibi sean-k-mooney: I see
12:47:47 sean-k-mooney i just find it unsetaling that we would considre change a get form a simple db lookup into an rpc call
12:48:25 gibi sean-k-mooney: so at compute startup nova gets the binding state from cyborg, if it is unknow or provisioning then keep the guest power state off but set up an event waiter. If the arq state is "OK" then nova would start the guest during compute startup.
12:48:45 sean-k-mooney gibi: not quite
12:48:50 gibi correct me please
12:49:30 sean-k-mooney i was thinking we would always set up the waiter and early out if it was bound like we do for normal spwan
12:50:02 gibi can nova we loose an event during the compute reboot?
12:50:29 gibi if yes then that guest would be stuck waiting of the event that was sent by cyborg but lost in the comptue restart
12:51:03 gibi if the event is never lost then I'm OK to wait for the event
12:51:05 sean-k-mooney the event would hit the api and then be enqued to the compute node topic queue
12:51:15 gibi sean-k-mooney: cool
12:51:15 sean-k-mooney so i dont think it would be lost
12:51:20 gibi that seem OK
12:51:34 gibi hm
12:52:12 gibi so in this case the sending the event is triggered by cyborg agent restart, in any other case sending the event is triggered by a nova bind request
12:52:39 sean-k-mooney yes
12:53:09 gibi so there are extra cases to handle. 1) a single cyborg agent restart will send events and if the compute service was not restarted then these events needs to be consumed but ignored
12:53:14 sean-k-mooney we could just call bind if we wanted too and not require teh cyborg agent to auto create them but i think the auto create would be more efficent
12:54:00 sean-k-mooney gibi: we have unexpeted event handeling in nova already
12:54:05 gibi cool
12:54:19 sean-k-mooney if we dont have a waiter when we deque it we just log it and discard
12:54:28 gibi that seems OK too then
12:54:34 sean-k-mooney which si ok because we will check the state when we get to that part of the code
12:55:44 sean-k-mooney basically im just suggesting using the exact saem event system we use of inital sapwn after where we start the binidng in the conductor then wait for it with an early out in the compute
12:56:03 gibi OK, I don't have a #2 actually :)
12:56:06 sean-k-mooney but in this case the cyborg agent would start the bind on start up
12:56:25 gibi sean-k-mooney: so far what you suggest feels OK to me
12:57:25 sean-k-mooney ill find the time stamp for this and add it to the reveiw
12:57:31 gibi cool
12:57:32 gibi thanks
12:57:55 sean-k-mooney bauzas: if you have time to read scool back and find anything concering with that please chime in
13:26:56 bauzas sean-k-mooney: looking
13:33:44 bauzas sean-k-mooney: are you talking about creating the mdevs in sysfs or binding them to the instance by modifying the XML ?
13:35:54 sean-k-mooney bauzas: sysfs
13:36:01 bauzas ack
13:36:16 bauzas if so, I agree, Cyborg should create them
13:36:22 sean-k-mooney specifically cyborg creating them
13:36:28 bauzas (the agent)
13:36:43 sean-k-mooney right but it shoudl do it automatically rather then as a result of a GET ot ARQ show
13:37:23 sean-k-mooney well GET /ARQ/<uuid>
13:55:34 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929
13:55:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach https://review.opendev.org/c/openstack/nova/+/770246
13:59:34 bauzas sean-k-mooney: yeah, provisioning them directly
14:00:00 bauzas once the operator modifies the config
14:00:22 sean-k-mooney what config?
14:00:40 bauzas their own config for telling which vgpu type for each pGPU
14:00:45 sean-k-mooney we are talking about recreating them after a host reboot
14:01:14 sean-k-mooney the cyborg spec currently say after a host reboot when we reboot the instance that we will do a arq show
14:01:25 bauzas I haven't seen it
14:01:26 sean-k-mooney and that show will do an rpc to the agent to create the mdev
14:01:28 bauzas if so, -1 for me
14:01:59 sean-k-mooney im suggesting that instead on start up the agent shoucl check what instance are on the current host and ensure there mdevs exist
14:02:15 sean-k-mooney and that arqs should have 2 newe states
14:02:25 sean-k-mooney unknon meaning the agent missed it heart beat
14:02:35 sean-k-mooney and provisioning meaning its currenlty seting up the mdev
14:03:18 sean-k-mooney so when we do the show arq binding call if its in provisioning or unknow we wait for the async event
14:03:27 sean-k-mooney if its in bound we know cyborg is done and we proceed
14:10:53 bauzas sean-k-mooney: then I agree with you
14:11:21 bauzas have you provided those comments in the spec ?
14:11:43 sean-k-mooney yes although not that cohently initally so i reference the irc logs above
14:11:59 sean-k-mooney i had give that feedbac in patch set 7 or 9 too
14:22:30 bauzas ++
14:22:41 bauzas I'll then add my comments then too
14:39:41 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: trivial: Resolve (most) flake8 3.x issues https://review.opendev.org/c/openstack/nova/+/770943
14:39:42 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: WIP/DNM Switch to hacking 2.x https://review.opendev.org/c/openstack/nova/+/770944
14:47:45 stephenfin lyarwood: Does this need a blueprint, I wonder? It is kind of feature'ish https://review.opendev.org/c/openstack/nova/+/770926
15:03:28 lyarwood stephenfin: likely, I was procrastinating this morning and wrote that without thinking
15:07:14 lyarwood gibi: ^ re this, should I create a blueprint for this?
15:08:33 gibi lyarwood: yeah, a bp would be good for that it is adding a feature basically
15:09:20 gibi or we can phrase the whole thing as a bug
15:09:34 gibi we forget to log resetState into the instance actions
15:09:40 gibi so meh, either a bp or a bug would be good
15:10:05 gibi no structural API impact so definetly not a spec
15:19:55 lyarwood gibi: ack let me spin this into a bug
15:20:04 gibi works for me
15:21:25 openstackgerrit Stephen Finucane proposed openstack/nova master: api-ref: Clarify 'all_tenants' command https://review.opendev.org/c/openstack/nova/+/770947
15:21:38 stephenfin That's the easiest "bugfix" anyone will see this week ^
15:24:39 gibi stephenfin: +@
15:24:41 gibi stephenfin: +2
15:24:58 stephenfin thanks :)
15:30:29 dansmith ahh, the rare but coveted +@ vote
15:30:36 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926
15:39:05 gibi dansmith: :)
15:41:14 stephenfin Is https://docs.openstack.org/ down for anyone else?
15:42:41 stephenfin nvm, it's back
15:43:43 lyarwood stephenfin: rate limited again? :D
16:06:14 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926
16:06:19 lyarwood stephenfin: well you did ask me to write another bloody reno ;) ^
16:09:30 dansmith stephenfin: really nice job on the db compaction series... you made validating them as easy as I hoped, so I hope we'll get at least another core or two to do it :)
16:12:40 stephenfin oh, thanks. Hopefully
16:28:38 stephenfin melwitt: quota question: if I create a server in a server group, should I expect the server_group_members.in_use count seen in 'nova quota-show --detail' to increment?
16:29:25 melwitt stephenfin: that might be one that stays stuck at zero. let me look and refresh my memory
16:32:27 melwitt stephenfin: yeah, that is one of the two that stays at zero (legacy behavior that hasn't been changed) https://github.com/openstack/nova/blob/master/nova/quota.py#L178-L182
16:32:39 melwitt so you would expect it not to ever increment
16:32:56 stephenfin okay, great. Thanks for the confirmation
16:33:04 openstack Launchpad bug 1909269 in OpenStack Compute (nova) "I create a server_groups vm , but server_group_members doesn't add one." [Undecided,New]
16:43:59 lyarwood stephenfin: did you plan on wiring up openstack server migration show btw?

Earlier   Later