Earlier  
Posted Nick Remark
#openstack-nova - 2020-09-17
08:56:40 lyarwood gibi: ^ also if you wouldn't mind, it's a regression for an awkward slightly convoluted encrypted volume use case
08:57:11 gibi lyarwood: looking..
08:58:45 lyarwood many thanks
09:17:36 aarents Hi Nova!
09:17:43 aarents lyarwood you where close to +2 on that https://review.opendev.org/#/c/743708/ few weeks ago, if you can have a look when possible thks!
09:21:04 lyarwood aarents: morning, looking
09:42:18 lyarwood aarents: sorry for the delay, LGTM still, can you follow up with a devstack change so we can see it running somewhere?
09:42:30 lyarwood aarents: I left an example in the change FWIW
09:59:47 openstackgerrit Merged openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
10:11:41 admin0 hi all .. what do I need to do in the database when i rename a hypervisor
10:11:51 admin0 i changed the hostname and did a nova-compute restart
10:12:01 admin0 what do i need to do to associate running instances to the new name
10:12:49 lyarwood erm that isn't supported at all
10:13:02 lyarwood your placement allocations are going to be totally borked
10:13:40 lyarwood can you undo the hostname change, empty the host of any instances and then do the hostname change?
10:14:16 lyarwood you should be able to delete service in nova and resource provider in placement with the old hostname
10:14:25 lyarwood and migrate everything back into the host
10:22:26 admin0 lyarwood, thanks
10:26:32 aarents lyarwood: thank you will check
10:27:45 stephenfin lyarwood: question on https://review.opendev.org/#/c/752247/
10:28:58 lyarwood stephenfin: https://review.opendev.org/#/c/752247/2/nova/tests/fixtures.py@2541 was the reason I left this in the fixture
10:29:07 lyarwood stephenfin: I can do that in the test itself as well tbh
10:55:11 lyarwood stephenfin: ^ there you go, slightly more self contained now.
10:55:11 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090
10:55:11 openstack bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood)
10:55:11 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247
10:55:24 lyarwood stephenfin: should be easy enough to backport as well
11:16:31 gibi lyarwood: +2 from me, sorry to take soo long I was distracted midday
11:17:11 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090
11:17:11 openstack bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood)
11:17:11 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247
11:17:13 lyarwood gibi: np, ^ just sorted the nit out quickly
11:19:24 gibi thanks
11:24:47 openstackgerrit Hemanth Nakkina proposed openstack/nova master: Update pci stat pools based on PCI device changes https://review.opendev.org/749175
12:00:27 nightmare_unreal brinzhang_: hello \0 , brinzhang. Can you please see my comment on your patch : https://review.opendev.org/#/c/675304/ . Thanks
12:02:39 brinzhang_ nightmare_unreal: of course ^^
12:04:05 brinzhang_ nightmare_unreal: IMO, this patch is ready a looong time, but I dont know the where need to change, and why no-body +2 or -1 for it
12:05:47 sean-k-mooney brinzhang_: it looks like it has not really got any code review
12:05:57 sean-k-mooney at least not in the last year or so
12:06:30 sean-k-mooney nightmare_unreal: brinzhang_ so ye need to join the sdk/osc irc channel and talk to the core team about it
12:06:36 nightmare_unreal can we please have a review for that patch
12:06:37 brinzhang_ IMHO, since mriedem left, there is no body care that pach
12:07:08 nightmare_unreal brinzhang_: i am in #osc channel but couldn't find your username
12:07:15 sean-k-mooney this is not the correct channel to ask in really. i think stephenfin might have osc core rights
12:07:15 nightmare_unreal i mean sdk
12:07:26 nightmare_unreal yeah right, sorry about the noise
12:07:33 nightmare_unreal we will move the disucssion
12:07:44 sean-k-mooney its ok to bring it up
12:07:50 sean-k-mooney its for nova migrations
12:08:05 sean-k-mooney but just bring it up here wont help get it merged
12:08:18 nightmare_unreal haha true
12:08:19 sean-k-mooney it might make sense to add a ptg topic
12:08:28 sean-k-mooney or a mailing list topic
12:08:29 brinzhang_ nightmare_unreal: yes, it also belongs to nova ^^
12:08:38 sean-k-mooney it might make sense to add teh core teams to osc
12:09:11 sean-k-mooney i.e. so each project core team that does not ahve a plugin can review there onw part of osc
12:09:25 nightmare_unreal I see
12:09:48 brinzhang_ sean-k-mooney: ok, I will add the osc core to that patch
12:11:12 brinzhang_ nightmare_unreal: which channel?
12:11:35 brinzhang_ #osc, #sdk seems not right
12:11:43 sean-k-mooney #openstack-sdk
12:12:02 sean-k-mooney actully no that no right
12:12:04 sean-k-mooney one sec
12:12:10 nightmare_unreal i am in #openstack-sdks
12:12:18 sean-k-mooney ah yes plural
12:12:25 nightmare_unreal yup
12:13:08 brinzhang_ sean-k-mooney, nightmare_unreal: thanks
12:15:29 brinzhang_ sean-k-mooney> Maybe I cannot add all osc core as the reviewer, sometimes they dont like do that way :(
12:15:51 sean-k-mooney generally you are better off to ask for reviews in irc
12:16:20 sean-k-mooney if now one responds then after a day or two look at who has been active in stackaltics and add one or two
12:16:56 brinzhang_ yeah, this is a good way
12:17:12 sean-k-mooney https://www.stackalytics.com/?module=python-openstackclient&release=victoria
12:18:12 sean-k-mooney frickler nad gtema
12:18:19 sean-k-mooney *and
12:18:22 brinzhang_ Aha, I was missed this place, here we can know who is active in the project/model
12:18:31 sean-k-mooney yep
12:18:39 sean-k-mooney they are likely your best bet
12:18:54 sean-k-mooney monty has recently left openstack developement and changed job
12:19:23 brinzhang_ ack, thank for your help
12:21:00 brinzhang_ nightmare_unreal> I think I will review your patch tomorrow, I will go later, my timezone is UTC+8, thx
12:23:26 nightmare_unreal thanks brinzhang_ . Understood
12:46:36 openstackgerrit Merged openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908
12:52:47 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use cell targeted context to query instance metadata https://review.opendev.org/752459
13:03:43 openstackgerrit Merged openstack/nova stable/ussuri: functional: Don't inherit from 'ProviderUsageBaseTestCase' https://review.opendev.org/751351
13:03:48 openstackgerrit Merged openstack/nova stable/ussuri: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/751352
13:35:54 openstackgerrit Sylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section https://review.opendev.org/751045
13:36:47 bauzas gibi: stephenfin: takashi made a good comment on https://review.opendev.org/751045, could you please review again ?
13:37:01 bauzas ideally, we could merge this prelude now and just amend it in a later change if we need
13:37:28 stephenfin done
13:55:31 bauzas thanks
13:56:31 gibi will check soon
13:56:48 openstackgerrit Merged openstack/nova stable/queens: Removed the host FQDN from the exception message https://review.opendev.org/749613
14:00:58 openstack Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Undecided,New]
14:00:58 bauzas gibi: I saw you already looked at https://bugs.launchpad.net/nova/+bug/1884217
14:01:12 bauzas gibi: this one seems legit to me but the bugfix isn't easy
14:16:12 openstack Launchpad bug 1888237 in Ubuntu "nova-next job fails as novnc service fails with TypeError: _wrap_socket() argument 1 must be _socket.socket, not GreenSSLSocket" [Undecided,New]
14:16:12 lyarwood gibi: https://bugs.launchpad.net/nova/+bug/1888237 - shouldn't this be moved to fix released btw?
14:28:22 openstackgerrit Elod Illes proposed openstack/nova stable/pike: Removed the host FQDN from the exception message https://review.opendev.org/752477
14:30:53 openstack Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Low,Incomplete]
14:30:53 gibi bauzas: I've just tagged https://bugs.launchpad.net/nova/+bug/1884217 I don't know the way forward with it

Earlier   Later