| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-21 | |||
| 14:50:26 | stephenfin | real easy bugfix there if anyone fancies a gawk ^ | |
| 14:59:13 | lyarwood | stephenfin: I'll take a look now, would you mind looking at https://review.opendev.org/#/c/729261/ in return? | |
| 14:59:35 | stephenfin | fair | |
| 15:00:58 | artom | Hehe, raise from? | |
| 15:01:27 | stephenfin | artom: lyarwood: http://paste.openstack.org/show/793850/ | |
| 15:01:38 | stephenfin | try that with and without the from and it'll be obvious | |
| 15:01:53 | stephenfin | tl;dr: we drop the context from the captured exception | |
| 15:01:58 | lyarwood | TIL | |
| 15:02:09 | stephenfin | python3++ | |
| 15:13:59 | stephenfin | lyarwood: awkward question left on https://review.opendev.org/#/c/729261/ | |
| 15:16:43 | lyarwood | stephenfin: ack, quick nit on yours otherwise it LGTM | |
| 15:23:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Raise useful error for invalid mempage size https://review.opendev.org/729967 | |
| 15:43:21 | lyarwood | stephenfin: are we good to use f-string in nova now? | |
| 15:43:27 | stephenfin | yup | |
| 15:43:54 | lyarwood | oh wait backports | |
| 15:43:57 | lyarwood | gah | |
| 15:47:29 | sean-k-mooney | lyarwood: stephen already has used them i think | |
| 15:47:46 | sean-k-mooney | lyarwood: im pretty sure we have merged a couple of patches with fstrings | |
| 15:47:55 | stephenfin | yeah, they're used in the extra spec validator code anyway, though that's not being backported | |
| 15:48:11 | sean-k-mooney | ya i think that is what i was thinking of | |
| 15:48:20 | sean-k-mooney | i think i used them for something too | |
| 15:48:36 | sean-k-mooney | but i think that someting that can be fixed in the backport | |
| 15:50:18 | gibi | nova meeting will start in 10 minutes on #openstack-meeting-3 | |
| 15:51:02 | lyarwood | yeah my git grep failed to find them but I was sure we had some in the codebase already | |
| 15:51:10 | lyarwood | for anything that I'm not going to backport back to Queens | |
| 15:51:14 | lyarwood | I'll use them | |
| 15:51:15 | sean-k-mooney | gibi: im proably not going to attend as i have a rather annoying headache right now so going to lie down for a bit | |
| 15:51:33 | gibi | sean-k-mooney: ack, I hope it will be gone soon | |
| 15:53:57 | sean-k-mooney | i think its partly dehydration and partly the wether so ya it should go away on its own | |
| 16:09:46 | openstackgerrit | Dan Smith proposed openstack/nova stable/stein: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729088 | |
| 16:10:20 | dansmith | mnaser: lyarwood ^ added missing mock to the test file, which will need to go back to the stein one if that passes tests | |
| 16:13:06 | lyarwood | dansmith: that is the stein one, looks like it was already there in train | |
| 16:13:40 | dansmith | ah dang, I guess I got confused | |
| 16:13:44 | dansmith | which makes the commit message wrong | |
| 16:14:28 | dansmith | I need to coin some sort of term that conveys the common practice of getting lost in following gerrit topic links between branches | |
| 16:14:54 | dansmith | maybe I'm the only one, but I forget which alternate 1985 I'm in pretty easily when following that circular loop | |
| 16:15:43 | openstackgerrit | Dan Smith proposed openstack/nova stable/stein: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729088 | |
| 16:19:00 | artom | minmax(manhours, beerhours) ftw | |
| 16:37:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/729261 | |
| 17:05:38 | openstackgerrit | Merged openstack/nova master: [Trivial]Add missing white spaces between words in log messages https://review.opendev.org/729880 | |
| 18:41:41 | dansmith | can someone help sync me up with where we are on like servicey tokeny things? | |
| 18:42:04 | dansmith | when we're talking to glance, are we using the user's token exclusively still? | |
| 18:42:27 | dansmith | and if we have the servicey tokeny thing, I assume that just helps us for the case where the user | |
| 18:42:56 | dansmith | token has expired, but doesn't give us any other permissions? | |
| 18:43:03 | dansmith | do/can we talk to glance with a more authoritative token specifically, like to look at tasks, which are admin-only? | |
| 20:19:51 | melwitt | dansmith: I don't know the answer to your question but here's a relatively recent change we made to our neutron interaction in a case where we changed to use admin to get specific info that wasn't available to non-admin, in case that is helpful https://github.com/openstack/nova/commit/aab4b7a0e2504c04e08389145bcb1414dea63631 | |
| 20:22:05 | dansmith | melwitt: if you had used fewer words, you'd have sounded like an irc bot :) | |
| 20:22:25 | dansmith | melwitt: that's relevant-adjacent I think.. I need glance specifically and I'm sure we could be doing each service N+1 different ways | |
| 20:23:03 | dansmith | BUT, it looks like glance exposes a minor amount of information about the task I'm concerned with to the regular users, so at least at the moment I think I can get away without hitting the task api and thus I can put off having to learn the answer to my question for a while longer :D | |
| 20:24:01 | melwitt | I do sound like a bot. words are hard | |
| 20:24:26 | melwitt | ah, ok. yeah I was thinking if you're looking to elevate the token for certain APIs you need, that's an example of where we've done that before | |
| 20:24:55 | dansmith | okay, yeah, then probably relevant | |
| 20:25:13 | dansmith | but if I can avoid elevation, then that's probably better and it looks like I can, at least at the moment | |
| 20:25:21 | melwitt | yeah, for sure | |
| 20:32:40 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make libvirt able to trigger a backend image copy when needed https://review.opendev.org/656998 | |
| 21:11:29 | openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add rbd-glance-multistore spec https://review.opendev.org/730126 | |
| 21:57:02 | openstackgerrit | melanie witt proposed openstack/nova stable/stein: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729088 | |
| #openstack-nova - 2020-05-22 | |||
| 02:40:00 | openstackgerrit | zhangboye proposed openstack/nova-specs master: Fix hacking min version to 3.0.1 https://review.opendev.org/730162 | |
| 03:12:50 | openstackgerrit | zhaoleilc proposed openstack/nova master: Fix an erroneous grammar in explanatory notes https://review.opendev.org/730176 | |
| 05:43:39 | openstackgerrit | Wenping Song proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | |
| 06:07:49 | openstackgerrit | junbo proposed openstack/nova master: use dpdk interface type for ovs dpdk representor port https://review.opendev.org/729874 | |
| 08:48:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/729540 | |
| 08:56:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/729540 | |
| 08:56:29 | openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 08:56:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Reproduce bug 1862633 https://review.opendev.org/729539 | |
| 09:00:08 | openstackgerrit | Wenping Song proposed openstack/nova master: WIP: Cyborg shelve/unshelve support https://review.opendev.org/729563 | |
| 09:24:45 | openstackgerrit | Merged openstack/nova-specs master: re-propose numa with placement https://review.opendev.org/728009 | |
| 09:32:10 | gibi | stephenfin: hi! I'm not sure about your suggestion in https://review.opendev.org/#/c/729924/1/nova/compute/manager.py@a280 | |
| 09:34:15 | stephenfin | gibi: Ah, I'm wrong then. I was searching for Migration._from_db_object since it was a static method | |
| 09:34:38 | gibi | stephenfin: ack | |
| 09:49:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove inject_file from compute manager and virt driver https://review.opendev.org/729934 | |
| 09:50:24 | elod | lyarwood: any reason holding up the +W here: https://review.opendev.org/#/c/729530/ ? | |
| 09:51:16 | gibi | stephenfin: also yesterday I collected some cleanups for after RPC 6.0 here https://etherpad.opendev.org/p/compute-rpc-6.0 If you see more just plug it there | |
| 09:54:08 | lyarwood | elod: no, I likely had the tab open prior to your review, apologies. | |
| 09:54:23 | lyarwood | +W'd | |
| 09:59:31 | gibi | thanks guys! | |
| 10:06:29 | sean-k-mooney | oh we are finally removing file injection | |
| 10:06:54 | sean-k-mooney | that been deprecated almost as long as nova networks | |
| 10:06:54 | gibi | it was dead code | |
| 10:07:07 | sean-k-mooney | gibi: was it not used for the vm personalities | |
| 10:07:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data https://review.opendev.org/729949 | |
| 10:07:49 | gibi | sean-k-mooney: the RPC method was removed in compute RPC 3.18 | |
| 10:08:01 | gibi | and there was no other usage for the driver call too | |
| 10:08:03 | elod | lyarwood: ok, thanks! I just thought that we should wait for something and was curious :] | |
| 10:08:18 | sean-k-mooney | ah ok | |
| 10:16:39 | sean-k-mooney | gibi: ah so you are just removing the function not the file inject capablity | |
| 10:17:14 | gibi | sean-k-mooney: is there another way to inject_files other than inject_file virt driver method? | |
| 10:17:22 | sean-k-mooney | yes | |
| 10:18:14 | sean-k-mooney | via the deprecated personality server atibute | |
| 10:19:09 | sean-k-mooney | although i dont know if that ends up calling that function or not | |
| 10:19:22 | sean-k-mooney | you have not removed any fo the personality code | |
| 10:19:31 | sean-k-mooney | gibi: like this https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/api/openstack/compute/helpers.py#L106-L116 | |
| 10:21:26 | gibi | sean-k-mooney: thanks. looking | |
| 10:21:29 | sean-k-mooney | gibi: we pass the injected files to build_instance | |
| 10:22:01 | sean-k-mooney | so i dont think we use a dedicated rpc call | |
| 10:25:06 | gibi | sean-k-mooney: yeah I just checked the driver.spawn() also take injected_files argument so I think server create and rebuild still inject_files | |
| 10:25:17 | sean-k-mooney | yep | |
| 10:25:42 | sean-k-mooney | so we stoped using the dedicated rpc and move to passing it as part of create or rebuild | |
| 10:26:00 | sean-k-mooney | but only when using the de | |
| 10:26:09 | sean-k-mooney | deprecated personality attibute | |