| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-25 | |||
| 09:18:37 | brinzhang_ | sean-k-mooney: https://review.opendev.org/#/c/694430/ and https://review.opendev.org/#/c/699669/ need your check, gmann have a question -1 for the new policy for show events:details, and I think it's necessary, and adopt my case, I left my comment in the spec. | |
| 09:28:43 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | |
| 09:36:58 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'MIXED' CPU allocation policy for instance https://review.opendev.org/713354 | |
| 09:36:58 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Refactor the code in checking available host CPUs https://review.opendev.org/714657 | |
| 09:36:59 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | |
| 09:36:59 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the interface of creating 'MIXED' policy instance through 'PCPU' and 'VCPU' https://review.opendev.org/713355 | |
| 09:37:29 | huaqiang | stephenfin: nice! you quickly fixed so much for mixed-instance bp! | |
| 09:37:55 | huaqiang | I'd like to follow your code and also contributes | |
| 09:38:11 | stephenfin | huaqiang: Feel free to take ownership of the whole lot of them, if they're helpful | |
| 09:38:33 | huaqiang | so I also updated the code to address the comments already made | |
| 09:39:04 | huaqiang | You are the gurantee of the code | |
| 09:39:28 | huaqiang | If you like to let me do some thing I'd like to do | |
| 09:39:35 | huaqiang | maybe from testing your code? | |
| 09:39:42 | huaqiang | I see not all test passed | |
| 09:40:49 | stephenfin | Oh, I hadn't checked that yet. Let me respin things to fix those | |
| 09:40:57 | stephenfin | Then we can figure out if any of them are useful | |
| 09:43:08 | huaqiang | I'll spend about two hours in testing your patches that not marked with 'WIP' if you haven't test by yourself. or you can tell me which patch need more test | |
| 09:44:11 | stephenfin | I think everything not marked in WIP is potentially useful | |
| 09:45:05 | stephenfin | The WIP patches duplicate your work so I'll probably abandon my ones. I wrote those WIP patches last week before you submitted the new revision | |
| 09:45:12 | huaqiang | I'd like to know if you will continue these 'WIP' patches? | |
| 09:45:22 | huaqiang | ok | |
| 09:45:39 | huaqiang | a lot of them are simular | |
| 09:45:40 | stephenfin | I won't. You've already done that work | |
| 09:45:57 | huaqiang | got. | |
| 09:46:32 | huaqiang | I'd like the take the reposibility | |
| 10:00:55 | elod | lyarwood: hi, +W'd | |
| 10:01:12 | lyarwood | elod: many thanks :) | |
| 10:01:53 | elod | luyao: thanks, looks good to me, +2 | |
| 10:04:58 | elod | lyarwood: thanks, too :) Now there are a bunch of patches in the gate queue in pike, hope we won't hit too many error_extending failures :S | |
| 10:12:05 | lyarwood | elod: I noticed the tempest job had failed a few times, was that the issue? | |
| 10:12:14 | lyarwood | elod: I haven't had time to look into it yet but wanted to later today | |
| 10:12:24 | lyarwood | elod: really want to flush the stable/pike queue once and for all :) | |
| 10:14:09 | elod | lyarwood: yes, most of them are that failure :S yes, stable/pike will look nice if everything will be merged in the queue \o/ | |
| 10:19:49 | lyarwood | elod: I'll take a look later today | |
| 10:26:39 | elod | lyarwood: thanks! AFAIK that issue is not a new one, but strange that we hit now in that number... maybe because there were not so many check/gate runs towards pike in the last months | |
| 10:44:01 | lyarwood | elod: https://review.opendev.org/#/c/697523/ - I don't think we can workaround the issue on stable/pike within c-vol, thoughts on blacklisting the specific test in our compute jobs? | |
| 10:44:38 | openstackgerrit | John Garbutt proposed openstack/nova master: Prevent compute manager freeze when greenpool is full https://review.opendev.org/575034 | |
| 10:44:43 | openstackgerrit | John Garbutt proposed openstack/nova master: Prevent compute manager freeze when greenpool is full https://review.opendev.org/575034 | |
| 10:47:29 | johnthetubaguy | gibi: stephenfin: I noticed we were all talking about this patch, it seem very like one of the big ironic pain points, so I fixed up my worries: https://review.opendev.org/#/c/575034 | |
| 10:49:18 | johnthetubaguy | belmoreira: I am wondering if you have seen this patch, and if it would help your powersync issues at all: https://review.opendev.org/#/c/575034 | |
| 10:51:54 | belmoreira | johnthetubaguy: no, let me have a look | |
| 10:52:15 | johnthetubaguy | its from the vmware folks, which I guess see related issues | |
| 10:57:44 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: tempest: Avoid bug #1796708 on slower stable/pike CI hosts https://review.opendev.org/714915 | |
| 10:57:45 | openstack | bug 1796708 in Cinder "VolumesExtendTest.test_volume_extend_when_volume_has_snapshot intermittently fails with "Extend volume failed.: VolumeNotDeactivated: Volume volume-5514a6ad-abbb-46b3-a464-d73cc67e55af was not deactivated in time."" [Medium,Confirmed] https://launchpad.net/bugs/1796708 | |
| 10:57:47 | lyarwood | elod: ^ lets skip that test for now. | |
| 11:03:32 | elod | lyarwood: usually i don't like disabling tests, but maybe now that is OK for that test on pike, especially for that bug is open since 2018 and has no fix. Let's see the regex works well in your patch :) | |
| 11:12:06 | openstackgerrit | John Garbutt proposed openstack/nova master: Prevent compute manager freeze when greenpool is full https://review.opendev.org/575034 | |
| 11:13:27 | openstackgerrit | John Garbutt proposed openstack/nova master: Prevent compute manager freeze when greenpool is full https://review.opendev.org/575034 | |
| 11:33:45 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce resource limits using oslo.limit https://review.opendev.org/615180 | |
| 11:40:21 | openstackgerrit | Merged openstack/nova stable/pike: Avoid circular reference during serialization https://review.opendev.org/714148 | |
| 11:40:27 | openstackgerrit | Merged openstack/nova stable/pike: Mask the token used to allow access to consoles https://review.opendev.org/708876 | |
| 11:40:35 | openstackgerrit | Merged openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061 | |
| 11:41:07 | lyarwood | well well well | |
| 11:41:17 | lyarwood | looks like we got some faster CI nodes on that run | |
| 11:55:04 | luyao | lyarwood: Hi, thanks for your quick comments on 'do_cleanup' flag bug-fix https://review.opendev.org/#/c/714593 | |
| 12:00:19 | lyarwood | luyao: np, I agree this needs cleaning up, I just don't think setting do_cleanup to True is the correct way of doing it for now. | |
| 12:01:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: [Community goal] Update contributor documentation https://review.opendev.org/712420 | |
| 12:02:14 | luyao | lyarwood: it's what I want to ask, I'm confusing about that, do you mean I need another cleanup method to do the cleanup? not invoking driver.cleanup directly or rollback_live_migration_at_destination | |
| 12:04:11 | lyarwood | luyao: yes, I think something like live_migration_cleanup_source and live_migration_cleanup_destination would be better instead of overloading cleanup itself | |
| 12:05:24 | lyarwood | elod: fun, we can't limit the regex used by the tempest-full jobs as they are using this tox env to run the commands - https://github.com/openstack/tempest/blob/51fe1ae61bed5d62c18864748520db25144f6db9/tox.ini#L103-L116 | |
| 12:05:51 | luyao | lyarwood: thingking.....what's the difference between the new cleanup methed and the existing one | |
| 12:07:10 | lyarwood | luyao: the existing one duplicates lots of cleanup already handled during the live migration flow | |
| 12:07:22 | lyarwood | luyao: we already unplug VIFs, disconnect volumes etc on success | |
| 12:07:29 | lyarwood | luyao: and depending on the failure we also do it there | |
| 12:08:07 | lyarwood | luyao: IMHO we should break up the cleanup method into smaller private methods that handle each aspect of this and use them only when required during the LM flows | |
| 12:09:24 | elod | lyarwood: :-/ anyway, at least a couple of patch got merged. so maybe recheck is enough for now as we don't have that many pike patches... | |
| 12:10:51 | lyarwood | I'll post a change removing it so if it does end up blocking things we can still remove it | |
| 12:11:19 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: zuul: Remove tempest-full from the gate due to bug #1796708 https://review.opendev.org/714915 | |
| 12:11:20 | elod | lyarwood: sounds like a plan :) | |
| 12:11:20 | openstack | bug 1796708 in Cinder "VolumesExtendTest.test_volume_extend_when_volume_has_snapshot intermittently fails with "Extend volume failed.: VolumeNotDeactivated: Volume volume-5514a6ad-abbb-46b3-a464-d73cc67e55af was not deactivated in time."" [Medium,Confirmed] https://launchpad.net/bugs/1796708 | |
| 12:13:39 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: fix typo in wrong cpu_model message https://review.opendev.org/714928 | |
| 12:16:10 | luyao | lyarwood: OK, got it, I'll look into the code and reply you in more detail on that patch, thanks :) | |
| 12:20:36 | hrw | morning | |
| 12:38:55 | openstackgerrit | Merged openstack/nova stable/train: nova-live-migration: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713961 | |
| 12:40:06 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834 | |
| 12:40:43 | lyarwood | ^ gibi / kashyap / stephenfin ; rebased with a bug created and referenced for tracking if you have time to review. | |
| 12:41:14 | kashyap | lyarwood: Will look. Trying to investigate a different bug I was thrown at elsewhere | |
| 12:58:32 | hrw | kevinz: thanks for https://review.opendev.org/#/c/709494 - finally booted VM in qemu TCG | |
| 12:59:30 | kevinz | hrw: np, good to hear that :-D | |
| 13:00:08 | hrw | kevinz: I wonder how many aarch64 changes done in nova should be redone in libvirt ;d | |
| 13:00:23 | hrw | but then still would stay due to desync between projects | |
| 13:02:58 | kevinz | hrw: hope not so many, we just tweak tweak and tweak | |
| 13:04:02 | hrw | kevinz: -M virt as default feels like something for libvirt ;D | |
| 13:04:18 | hrw | no, it is default there. it's qemu where it is not | |
| 13:04:54 | sean-k-mooney | do we still have the cpu feature flag check disabled for aarch64 | |
| 13:05:03 | kevinz | yes, there are some methods in libvirt regarding with CPU are not implemented on aarch64 | |
| 13:05:37 | sean-k-mooney | so its not safe to use max as the default model if we want to support livemigration | |
| 13:05:51 | hrw | sean-k-mooney: anything around cpu features/model/passthrough on aarch64 is like walking on minefield | |
| 13:05:56 | sean-k-mooney | well in an upgrade case at least | |
| 13:06:02 | kevinz | sean-k-mooney: yes, I know that Kevin Zheng from Huawei is working on libvirt side to make that happen | |
| 13:06:10 | sean-k-mooney | hrw: well we have the info in /sys | |
| 13:06:13 | brinzhang_ | sean-k-mooney: did you look at https://review.opendev.org/#/c/694430/ and https://review.opendev.org/#/c/699669/3, gmann want you can check that ^^ | |
| 13:06:19 | sean-k-mooney | libvirt is just not reading it | |
| 13:06:40 | sean-k-mooney | brinzhang_: no but ill look now | |
| 13:06:48 | kevinz | so hopefully live migration will works well on arm64 soon | |
| 13:06:54 | hrw | sean-k-mooney: can you remind me /sys path? | |
| 13:07:17 | brinzhang_ | sean-k-mooney: yeah, thanks. I think we need the new policy | |
| 13:07:21 | sean-k-mooney | hrw: actully its in /proc/cpuinfo | |
| 13:07:47 | sean-k-mooney | hrw: the "flags" filed is "Flags" on aarch64 | |
| 13:07:56 | sean-k-mooney | which prevents libvirt reading it | |