| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-31 | |||
| 16:08:34 | sean-k-mooney | tonyb: johnthetubaguy can you take a look at https://review.opendev.org/#/c/663888/ for stephenfin | |
| 16:18:26 | dansmith | sean-k-mooney: pretty sure we said that's not a problem on stable especially for clean backports, and especially for something like this | |
| 16:19:18 | sean-k-mooney | ya i think you are right | |
| 16:20:22 | stephenfin | dansmith: cheers | |
| 16:28:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653 | |
| 16:29:25 | stephenfin | sean-k-mooney, efried, bauzas: That ought to be useful if/when we start working on mempage modelling in placement ^ | |
| 16:31:06 | stephenfin | also artom who cares about functional tests ^ | |
| 16:32:07 | artom | stephenfin, yep, I'll take a look - and thanks for re-visiting NUMA func tests :) | |
| 16:32:27 | artom | There's one outstanding piece of dansmith's feedback I need to address though, about forcing servers on hosts | |
| 16:34:04 | sean-k-mooney | stephenfin: more func test for this stuff is always useful | |
| 16:34:46 | sean-k-mooney | if we can use that as a basis to also validate the placemnt reshape that will be needed even more so | |
| 16:37:39 | efried | wow, neat, a 3+yo patch | |
| 16:59:19 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847 | |
| 17:00:53 | artom | stephenfin, there, done | |
| 17:00:59 | stephenfin | wonderful | |
| 17:01:09 | stephenfin | 1:1 then I'll finish my comments on yours | |
| 17:01:18 | stephenfin | (it's 90% there) | |
| 17:03:02 | openstackgerrit | Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256 | |
| 17:10:29 | stephenfin | artom: done | |
| 17:11:06 | efried | Hey kids, it looks like blockdiag 2.0.0 breaks our docs build. I'm working on it. | |
| 17:11:07 | artom | stephenfin, thank you! I'll go do sean-k-mooney's downstream review, then circle back here | |
| 17:11:36 | artom | efried, would you say that it's... block-ing us? :D | |
| 17:11:56 | efried | yeah, just give me a few minutes to diag-nose it. | |
| 17:12:10 | dansmith | like, by smell? | |
| 17:12:22 | efried | just so | |
| 17:12:45 | gibi | dansmith: thanks. I have to get back to that patch next week. I appreciate your time and I see your point how a future instance.save() can ruin things. | |
| 17:13:43 | dansmith | gibi: ack, I've been looking at some of the related things you found too | |
| 17:14:30 | efried | stephenfin: jfyi although I opened an issue against blockdiag, I suspect it's possible the problem is in the monkeypatching in doc/source/conf.py | |
| 17:15:45 | efried | mm, maybe not, removing that didn't resolve. But I went and built docs in another repo that uses blockdiag (networking-bagpipe) and didn't have the same problem. | |
| 17:16:56 | stephenfin | efried: Looks like that project has had a lot of releases since so that monkeypatching probably isn't necessary any more. However, I'm not sure how it would affect things. What's the error? | |
| 17:17:09 | openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | |
| 17:17:29 | efried | stephenfin: https://github.com/blockdiag/blockdiag/issues/126 | |
| 17:18:11 | stephenfin | could you edit that comment so I can read it. Just indent everything by 4 or add ``` before and after the code blocks | |
| 17:18:30 | stephenfin | please and thanks :) | |
| 17:18:44 | efried | stephenfin: done | |
| 17:19:33 | efried | stephenfin: hm, I don't actually see blockdiag being *used* in our repo. | |
| 17:20:30 | stephenfin | neither do I, now that you say it | |
| 17:20:56 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847 | |
| 17:21:13 | efried | stephenfin: except for a static svg | |
| 17:21:35 | efried | stephenfin: which I would have thought, since it was static, wouldn't affect anything... but we're also using the svg2pdfconverter | |
| 17:21:36 | efried | so maybe | |
| 17:21:45 | stephenfin | Remove it and see what happens? :) | |
| 17:21:51 | efried | remove the svg? | |
| 17:22:12 | stephenfin | Looks like da7e1ede9e73bf0e107b9b37954f204cea544439 may have remove the vestigial traces of blockdiag | |
| 17:22:17 | stephenfin | nah, the extension | |
| 17:22:39 | efried | ... | |
| 17:23:04 | stephenfin | We do use seqdiag | |
| 17:23:11 | stephenfin | but I think that's a different project | |
| 17:23:52 | stephenfin | yup, sure is | |
| 17:24:16 | efried | removing the rsvgconverter extension didn't resolve. | |
| 17:25:18 | openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | |
| 17:28:22 | openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | |
| 17:29:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653 | |
| 17:30:29 | openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | |
| 17:32:21 | openstackgerrit | Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256 | |
| 17:32:27 | efried | stephenfin: hm, I also tried blacklisting in doc/requirements but that didn't work. ISTR something about upper-constraints overriding no matter what you do locally. | |
| 17:33:03 | sean-k-mooney | efried: is repoducing as simple as pull master and run tox -e docs locally | |
| 17:33:09 | stephenfin | sean-k-mooney: yup | |
| 17:33:42 | stephenfin | oh, okay, seqdiag uses blockdiag. Lovely | |
| 17:33:52 | stephenfin | as does actdiag | |
| 17:34:10 | sean-k-mooney | cool ill take a look while i wait for test to finish | |
| 17:34:26 | sean-k-mooney | ok it sould like we need a temproy cap then | |
| 17:35:18 | stephenfin | efried: Does that other project also use stestr, out of curiosity? | |
| 17:35:37 | stephenfin | actually, nvm | |
| 17:35:59 | stephenfin | this is docs, not tests | |
| 17:36:32 | sean-k-mooney | right we are invoking sphinx not stestr | |
| 17:37:44 | stephenfin | efried: This is the thing I introduced the monkeypatching to fix | |
| 17:37:53 | stephenfin | I remember now. I bet they've moved some modules around | |
| 17:37:53 | sean-k-mooney | we should just put blockdiag<2.0.0 in upper-constrats.txt | |
| 17:38:04 | efried | I tried to remove the monkeypatching and it didn't help | |
| 17:38:22 | sean-k-mooney | well they did a major version bump so likely | |
| 17:38:31 | sean-k-mooney | the just went form 1.5.4 to 2.0.0 | |
| 17:38:32 | dustinc | efried: no, I probably won't be working on this further https://review.opendev.org/#/q/topic:bp/openstacksdk-in-nova+status:open | |
| 17:38:33 | efried | it looks to me like a bug in blockdiag itself, it's trying to get a BufferedReader's buffer. | |
| 17:39:12 | efried | dustinc: okay, I'm going to push the blueprint out of ussuri then. | |
| 17:40:53 | openstackgerrit | Merged openstack/nova stable/rocky: tox: Stop build *all* docs in 'docs' https://review.opendev.org/663888 | |
| 17:41:02 | openstackgerrit | Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256 | |
| 17:41:50 | efried | dustinc: You can abandon the changes I guess. If we find a new owner, we can restore them. | |
| 17:42:14 | dustinc | efried: will do, thanks | |
| 17:42:50 | sean-k-mooney | efried: it does not look like they change that code recently | |
| 17:43:25 | efried | dustinc: You're still driving the provider config changes for the near term though, right? Looks to me like the next action is to you, to rev based on gibi's comments. You agree? | |
| 17:43:44 | dustinc | efried: yes, but priority is low for me at the moment | |
| 17:43:59 | efried | okay. Please let me know if someone needs to take over. | |
| 17:46:40 | stephenfin | efried: done. patch coming | |
| 17:46:44 | sean-k-mooney | efried: it looks like the correct way to get the buffer would be to call getbuffer https://docs.python.org/3/library/io.html#io.BytesIO.getbuffer | |
| 17:47:09 | efried | stephenfin: cool. where? | |
| 17:47:26 | efried | in blockdiag or nova or... | |
| 17:47:29 | stephenfin | for us | |
| 17:47:38 | stephenfin | could be ages before blockdiag get their act together | |
| 17:48:01 | efried | okay, so I should leave the issue open there. | |
| 17:48:46 | sean-k-mooney | stephenfin: im goint to quickly just chagne the deference to the call to function call locally and see if that ifxes it | |
| 17:49:00 | sean-k-mooney | i assume that is what you are going to monky patch | |
| 17:49:06 | sean-k-mooney | or is it something else | |
| 17:50:05 | efried | also if you have reason to believe we no longer need the old monkey patches, could remove those. | |
| 17:50:10 | efried | separate patch | |
| 17:50:13 | efried | brb | |
| 17:50:52 | stephenfin | ack | |
| 17:51:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263 | |
| 17:53:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263 | |
| 17:56:33 | efried | stephenfin: tbc, will this ^ work with all versions of blockdiag? | |