Posted	Nick	Remark
#openstack-nova - 2019-08-14
20:07:43	mordred	there's got to be something
20:08:03	efried	mordred: problem is a bunch of other things hit Adapter and Adapter.get_endpoint
20:08:22	mordred	yeah
20:10:24	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: Restore soft-deleted compute node with same uuid https://review.opendev.org/676509
20:14:40	openstack	bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem)
20:14:40	openstackgerrit	Merged openstack/nova master: Add functional regression recreate test for bug 1839560 https://review.opendev.org/675705
20:14:49	openstackgerrit	Merged openstack/nova master: Restore soft-deleted compute node with same uuid https://review.opendev.org/675496
20:16:21	openstack	bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem)
20:16:21	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676513
20:19:17	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Restore soft-deleted compute node with same uuid https://review.opendev.org/676514
20:19:21	mriedem	mnaser: backports are all up
20:20:58	mriedem	TheJulia: looks like ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is busted on stable/rocky,
20:21:11	mriedem	seeing this: It looks like a path. File ''/home/zuul/src/opendev.org/openstack/ironic-tempest-plugin'' does not exist.
20:23:24	mriedem	queens and stein are ok
20:27:09	mriedem	oh i bet it's this https://github.com/openstack/ironic/commit/ef0fde41e9c78e79d0b3b618102bcb475fa1f691
20:30:09	TheJulia	but that was on master and stein
20:30:39	mriedem	"The has stopped working out of a sudden." doesn't mention the root cause
20:30:45	mriedem	which might be something that affects rocky as well
20:30:49	TheJulia	mriedem: unless your meaning that it might be the fix?
20:30:55	mriedem	yeah
20:31:02	TheJulia	maybe, I'm wondering why we've not seen it on rocky then
20:31:23	TheJulia	mriedem: are you guys just invoking the job directly by name, or do you hae a definition in nova's config?
20:31:28	mriedem	looks like you have... https://review.opendev.org/#/c/648360/
20:31:49	mriedem	we just use the job name
20:32:09	mriedem	https://github.com/openstack/nova/blob/stable/rocky/.zuul.yaml#L213
20:32:37	TheJulia	interesting
20:32:53	mriedem	yeah stable/rocky is broken for ironic as well,
20:32:59	mriedem	i'm working on backporting that fix but there are merge conflicts
20:34:44	TheJulia	well, it was working as of Aug 3
20:35:06	TheJulia	mriedem: okay, if your doing that, I'll wait then
21:18:54	melwitt	mriedem: I'm thinking I should fix this up and rebase on it for the multi-cell archive patch https://review.opendev.org/675218
21:19:53	melwitt	bc if it does the re-use of db engine, I won't have to make any changes to the "for table" method
21:21:13	mriedem	melwitt: i forgot all about that patch :(
21:21:41	mriedem	i've got part of it fixed, i can push that up once i'm done rebasing the cross-cell-resize series and mark as WIP if you want to swing at it
21:21:50	mriedem	but yeah i assumed you'd rebase on that series of fixups
21:22:04	melwitt	me too kinda, until I went to address review feedback and was like, hm, I think mriedem did something about this in another patch
21:22:22	melwitt	ok, that would be great. thanks
21:38:58	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
21:38:59	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
21:38:59	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
21:39:00	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
21:39:00	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
21:39:01	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
21:39:01	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
21:39:02	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
21:39:02	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
21:39:03	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
21:39:03	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
21:39:04	openstackgerrit	Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
21:39:04	openstackgerrit	Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
21:39:05	openstackgerrit	Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
21:39:05	openstackgerrit	Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.opendev.org/614037
21:39:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
21:39:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
21:39:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
21:45:05	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Re-use DB engine connection during archive_deleted_rows https://review.opendev.org/675218
21:45:16	mriedem	melwitt: ^ some test_db_api tests are failing with unique constraint errors, like an instance was archived when it didn't expect it to
21:45:50	melwitt	mriedem: ok, thanks
21:49:35	mriedem	ok i fixed it
21:49:49	mriedem	still need to call metadata.bind.connect() per call to _archive_deleted_rows_for_table
21:49:52	mriedem	not entirely sure why...
21:52:18	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
21:52:29	mriedem	ah crap need to remove the WIP
21:52:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
21:52:58	mriedem	ok now i need to run
21:56:19	openstackgerrit	Dustin Cowles proposed openstack/nova master: WIP: Public method to retrieve custom resource providers https://review.opendev.org/676029
21:56:19	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
21:56:20	openstackgerrit	Dustin Cowles proposed openstack/nova master: WIP: Load the custom resource providers to resource tracker https://review.opendev.org/676522
22:00:13	melwitt	thanks mriedem++
22:08:46	openstackgerrit	Eric Fried proposed openstack/nova master: Enhance SDK fixture for 0.34.0 https://review.opendev.org/676495
22:08:59	efried	mordred: A big but very focused hammer ^
22:14:24	mordred	efried: wow
22:14:44	mordred	efried: I feel like pep8 isn't going to like it - but I do
22:14:55	efried	oh, rat farts, forgot to fix that part...
22:15:19	openstackgerrit	Eric Fried proposed openstack/nova master: Enhance SDK fixture for 0.34.0 https://review.opendev.org/676495
22:15:33	efried	thanks mordred for saving me a failed zuul run on a stupid
22:17:31	openstackgerrit	Merged openstack/nova stable/rocky: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676290
22:18:53	sean-k-mooney	gibi: by the way you asked me over a month ago if i had an example of how to configure a host to use the same interface for both ovs and sriov. i am setting up my sriov servers again and this is the local.conf i use http://paste.openstack.org/show/757169/
22:20:55	sean-k-mooney	im using port enp1s0f1 as teh ovs port on the br-ex and its also the pf of the sriov vfs with the neutron fdb extention enalbed to make sure that ovs vm to sriov vm traffic does nto need to hairpin at teh top of rack switch
#openstack-nova - 2019-08-15
00:03:58	openstackgerrit	Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072
00:05:05	openstackgerrit	Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074
00:05:49	openstackgerrit	Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075
00:06:13	efried	would be nice to have it merged by morning to unwedge https://review.opendev.org/#/c/676457/
00:06:13	efried	dansmith, melwitt: If you're still around, this iteration of that fixture passed zuul: https://review.opendev.org/#/c/676495/
00:06:35	openstackgerrit	Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952
00:26:41	melwitt	efried: looking
00:28:12	efried	thanks melwitt
00:31:09	melwitt	guh, I don't know what I'm looking at here
00:31:35	efried	melwitt: I can splain if you got a minute
00:32:01	melwitt	ok. I see mordred said earlier that he thinks it looks good, if he could +1 it again that would be helpful too
00:36:10	efried	So I can't just mock away the ksa stuff - which was my first PS on this fix - because then those all puke.
00:36:10	efried	The problem is that the discovery stuff is done through ksa - and we have other things (glance, cinder, ironic...) that rely on those ksa-isms either not being mocked at all, or being mocked a certain way in their own tests.
00:36:10	efried	And in unit/functional tests, we don't care about any of that.
00:36:10	efried	When we try to load up sdk, it normally does some discovery for us, things like checking the service catalog and asking for version documents.
00:36:10	efried	Without any fixturing, unit and functional tests fail because many of them hit paths that try to use placement, and placement now uses sdk.
00:36:11	efried	The linked patch shows the code I cribbed from.
00:36:11	efried	So instead I'm mocking the thing in the sdk that triggers that discovery. And I'm making it do almost all of what it would do anyway - just skipping that one part that hits ksa.
00:37:17	melwitt	ok, thanks
00:38:57	efried	The problem is that sdk is a moving target right now, which is why I had to change it; but hopefully this version will stick for a little while longer until we can get real fixtures from sdk.
00:38:57	efried	As before, this is just making sure that unit/func tests that only care about a default no-op-ish ksa Adapter actually get something that looks like an Adapter.

Earlier   Later