Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-13
13:58:16 sean-k-mooney stephenfin: can you take a look at these quickly https://review.opendev.org/#/q/topic:bug/1832652+(status:open+OR+status:merged)
13:58:25 stephenfin ;sure
14:00:17 efried nova meeting now in #openstack-meeting
14:00:47 bhagyashris stephenfin, sean-k-mooney: Hi, I just want your opinion about http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007084.html http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007109.html
14:01:36 sean-k-mooney bhagyashris i replied to both this morning
14:02:19 sean-k-mooney bhagyashris: http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007118.html and http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007119.html
14:02:44 bhagyashris sean-k-mooney; Thank you! i would also like more opinions about the same so that i can proceed
14:03:44 sean-k-mooney the important thing to remember is vcpu_pin_set does not and has never ment that the host was use for pinnned instances
14:04:34 sean-k-mooney its related but it not a direct mapping
14:07:26 openstackgerrit Arnaud Morin proposed openstack/nova stable/stein: Refresh instance network info on deletion https://review.opendev.org/665143
14:08:27 amorin mriedem and others see ^, cherry pick for stein
14:08:36 mriedem ack
14:08:48 openstackgerrit Arnaud Morin proposed openstack/nova stable/rocky: Refresh instance network info on deletion https://review.opendev.org/665144
14:09:03 openstackgerrit Arnaud Morin proposed openstack/nova stable/queens: Refresh instance network info on deletion https://review.opendev.org/665145
14:09:52 amorin mriedem: are pike and ocata still cherry-pickable also?
14:10:02 amorin or are they freezed?
14:10:22 mriedem they're open, we just don't release them anymore
14:10:27 mriedem they are in extended maintenance mode
14:10:38 mriedem https://docs.openstack.org/project-team-guide/stable-branches.html
14:16:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315
14:16:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967
14:16:20 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Start rewriting all these tests https://review.opendev.org/665146
14:16:20 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: conductor: Remove cells v1 workarounds https://review.opendev.org/651316
14:21:43 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: Fix double word hacking test https://review.opendev.org/665147
14:21:59 stephenfin mriedem: As promised. lyarwood might want to take a look too ^
14:22:38 lyarwood stephenfin: ah cool, I don't think the change to disable this has landed in stein yet
14:22:51 stephenfin nope, just left a comment on that backport of yours
14:22:56 lyarwood thanks
14:26:37 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201
14:31:56 jangutter Could I ask someone more familiar with tox and multiple python versions to check sean-k-mooney's one-liner here: https://review.opendev.org/#/c/665034
14:33:42 stephenfin The 'build_instances' function is so fricking complex. It's almost impossible figure out what most of these tests are supposed to be testing :( https://review.opendev.org/665146
14:33:57 stephenfin jangutter: I've already hit it. It's correct
14:34:41 sean-k-mooney stephenfin: yep thats why i pinged you to review :)
14:34:50 sean-k-mooney and you know its os-vif
14:34:52 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245
14:34:52 openstackgerrit Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
14:34:53 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102
14:34:55 jangutter stephenfin: thanks, I suspected as much, but if it summons Cthulhu, I'm pointing him to you.
14:36:44 stephenfin #success Cells v1 has finally be removed from nova. Next up, nova-network
14:36:46 openstackstatus stephenfin: Added success to Success page (https://wiki.openstack.org/wiki/Successes)
14:36:58 stephenfin s/be/been/ Damn it
15:00:17 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def) https://review.opendev.org/651554
15:00:18 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.opendev.org/652103
15:00:18 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.opendev.org/651555
15:00:19 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104
15:02:06 sean-k-mooney before i forget my alternitive proposal for the trait -> aggrage mapping would be as follows. when we set tratis in nova host_aggrages we create a resouceless shareing RP in placmeent and add the traits to that
15:02:10 mriedem mgoddard: you might want to read through https://review.opendev.org/#/c/449155/ first
15:02:15 sean-k-mooney and dont modify the host at all
15:02:20 sean-k-mooney then the sync is simple
15:02:48 sean-k-mooney that would require resouceless RPs for it to work however
15:03:10 mgoddard mriedem: I'll add it to my reading list
15:03:14 sean-k-mooney efried: ^ was for you and i guess anyone that is interested
15:03:28 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Stop starting consoleauth in functional tests https://review.opendev.org/652966
15:03:28 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Remove references to nova-consoleauth https://review.opendev.org/652965
15:03:29 openstackgerrit Stephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens https://review.opendev.org/652967
15:03:30 efried sean-k-mooney: That could work, but sounds like a pretty big hammer.
15:03:30 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969
15:03:30 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check https://review.opendev.org/652968
15:03:31 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rework nova console diagram https://review.opendev.org/660147
15:03:31 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970
15:03:54 sean-k-mooney efried: it might be but it makes the nova and placmenet logic a lot simpler
15:04:05 sean-k-mooney but it also intoduce a depency on resouceles providers
15:04:13 mriedem mgoddard: the things you'd have to be aware of is the allow_resize_to_same_host config option in the compute api - you'd have to ignore that for baremetal instances, and figuring out if the instance is baremetal to begin with to change how scheduling is going to work etc - and then it's implementing some virt driver methods
15:04:20 sean-k-mooney maybe something to consider after train?
15:04:36 mriedem sean-k-mooney: or, or, we just say nova doesn't orchestrate that and if you want it, do it external to nova
15:04:55 mriedem b/c christ almighty we're already bad at orchestrating external resources,
15:04:59 sean-k-mooney mriedem: yes which is definetly what i think we shoudl do for train
15:05:01 mriedem case in point, see my ML thread about deleting a compute service
15:05:24 sean-k-mooney :) fair point
15:05:31 sean-k-mooney we are also terrible at math
15:05:36 efried mriedem, mgoddard: ironic resize: Is the consensus that someone should produce a spec (either revive the one linked above or write a new one)? But generally speaking there's no major objection to doing some form of "same host resize" for ironic?
15:06:26 sean-k-mooney efried: you would proably need a prefilter or somthing that could understand its a baremetal instance and force the same host
15:06:37 efried yes, mriedem mentioned that above
15:06:47 sean-k-mooney the allow same hsot resize jsut allows it rather then forces it
15:06:56 efried yes, mriedem mentioned that above
15:07:08 sean-k-mooney yep
15:07:18 sean-k-mooney the question i have however is do we really need to force that
15:07:30 sean-k-mooney i mean ironic could support resize in general
15:07:34 efried are you suggesting allowing ironic resize to a new node?
15:07:40 sean-k-mooney yes
15:07:43 efried baby steps, sean-k-mooney. Baby steps.
15:08:17 aspiers sean-k-mooney: turns out meetbot will recognise anyone issuing an #action
15:08:24 sean-k-mooney for bfv guest there is nothitng ot copy and for non-bfv the ironic agent could be extended to dd the data form one to anohter
15:08:34 aspiers which matches my memory
15:08:36 aspiers http://eavesdrop.openstack.org/meetings/nova/2019/nova.2019-06-13-14.00.html
15:08:40 sean-k-mooney aspiers: cool good to know
15:08:57 efried sean-k-mooney: Yes, but let's address the case we know we want to solve first, before enabling the general case and all the test surface that goes with it.
15:09:34 sean-k-mooney efried: sure although im pretty sure the general case had a spec form a few cylces ago which is why i brought it up
15:10:13 artom mriedem, efried, https://wiki.openstack.org/wiki/Nova/Mentoring#Work_Items_for_New_Contributors and https://etherpad.openstack.org/p/nova-reviews-looking-for-owner
15:10:35 sean-k-mooney efried: but yes i think that the simpler case of same host could be a stepping stone
15:11:19 efried thanks artom
15:21:51 mriedem artom: i'll update 522084 underneath the scheduler hints change
15:22:28 artom mriedem, ah, thanks, didn't notice it was a 2-patch series
15:25:11 openstackgerrit Merged openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583
15:25:12 openstackgerrit Merged openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786
15:28:49 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.opendev.org/629597
15:28:50 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: fix up numa-topology live migration hypervisor check https://review.opendev.org/648939
15:29:02 stephenfin lyarwood: Could you take a look at https://review.opendev.org/#/c/629597 when you have a chance?
15:35:46 lyarwood stephenfin: queued
15:36:05 openstackgerrit Eric Fried proposed openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003

Earlier   Later