| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-31 | |||
| 17:01:42 | openstack | Launchpad bug 1831269 in OpenStack Compute (nova) "Resize ignores mem_page_size in new flavor" [Medium,Confirmed] | |
| 17:02:17 | sean-k-mooney | stephenfin: it should in theory be a fairly simple fix | |
| 17:02:45 | stephenfin | Yup, it should | |
| 17:03:08 | sean-k-mooney | i think it should be backportable too | |
| 17:03:18 | sean-k-mooney | rebuild is harder to fix | |
| 17:03:45 | sean-k-mooney | or rather inplace rebuild without the double allocations | |
| 17:03:45 | stephenfin | I'm not sure why this is passing though https://review.rdoproject.org/r/#/c/11297/11/whitebox_tempest_plugin/api/compute/test_cpu_pinning.py@108 | |
| 17:04:24 | sean-k-mooney | the downstream bug only happens because the destination host did not have any 2mb hugepages only 1G | |
| 17:04:27 | stephenfin | Actually, maybe it is. But we have a host that actually has enough free CPUs | |
| 17:04:40 | kashyap | efried: aspiers: Thanks for the reviews. | |
| 17:04:52 | stephenfin | So we'd start seeing this more when cpu-resources is done, because we might only have limited PCPU inventory | |
| 17:04:55 | aspiers | kashyap: we still need one more +2 | |
| 17:05:09 | aspiers | I guess we should wait for cdent | |
| 17:05:10 | kashyap | aspiers: Right, not sure who can give it. Chris Dent? | |
| 17:05:15 | kashyap | Bingo | |
| 17:05:27 | stephenfin | oooh, review.rdoproject.org supports polygerrit now | |
| 17:05:28 | sean-k-mooney | stephenfin we likely are looking up the cpu policy differently | |
| 17:05:30 | stephenfin | pretty | |
| 17:05:52 | aspiers | stephenfin: still waiting for OpenStack Gerrit upgrade | |
| 17:06:27 | stephenfin | yup, but I'm assured they're on it. Looking forward to a few of those features | |
| 17:06:32 | sean-k-mooney | nope https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1100 | |
| 17:06:38 | aspiers | stephenfin: but even that upgrade is fairly old: 2.14.7, and 3.0 is now out | |
| 17:06:55 | aspiers | there are lots of really nice improvements since 2.14 | |
| 17:07:13 | stephenfin | Yeah, I think we discussed before and the strategy was to go to 2.16, which deprecates a load of things but would provide time to prepare for 3.0 | |
| 17:07:28 | aspiers | stephenfin: skip upgrades are not supported anyway | |
| 17:07:42 | aspiers | you have to go to 2.16 to migrate to notedb before moving to 3.0 | |
| 17:07:48 | stephenfin | yup | |
| 17:08:07 | efried | stephenfin: Not sure how much mikal is monitoring his reviews these days; if I do those two fixups (remove redundant lines) would you fast approve? | |
| 17:08:34 | sean-k-mooney | stephenfin: so ya https://review.rdoproject.org/r/#/c/11297/11/whitebox_tempest_plugin/api/compute/test_cpu_pinning.py@108 should fail | |
| 17:08:47 | stephenfin | efried: I would | |
| 17:09:01 | stephenfin | sean-k-mooney: I'm thinking it would fail if the other had no free cores | |
| 17:09:04 | stephenfin | *other host | |
| 17:09:33 | sean-k-mooney | stephenfin: the self.get_server_cpu_pinning call should be checking the xml | |
| 17:09:38 | stephenfin | but because it does, the NUMATopologyFilter is passing and then things get recalculated properly when it starts building the instance on the host | |
| 17:09:56 | sean-k-mooney | unless we actully update the request spec later | |
| 17:10:06 | sean-k-mooney | e.g. on the compute node | |
| 17:10:19 | sean-k-mooney | right | |
| 17:10:36 | sean-k-mooney | ok so ya that is passing because there is enough free cpus | |
| 17:11:05 | sean-k-mooney | ok so resize with numa is not totally broken | |
| 17:11:15 | sean-k-mooney | just the sechduler bit | |
| 17:11:37 | sean-k-mooney | the compute node will still validate it with the new flavor when it trys to build the instance xml | |
| 17:12:28 | sean-k-mooney | or just before it when it generates the new numa toplogy | |
| 17:14:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 17:14:56 | stephenfin | sean-k-mooney: ^ untested (completely) but something like that should do the trick, I imagine? | |
| 17:15:22 | sean-k-mooney | yes that is exactly what i was thinking too | |
| 17:15:44 | stephenfin | Nice | |
| 17:15:57 | sean-k-mooney | the one thing im not sure about however is should we but using the tempory mutation thing | |
| 17:16:12 | stephenfin | I'll try whip up a functional test for the on Monday^H^H^H Tuesday and see if I can reproduce it there | |
| 17:16:15 | sean-k-mooney | e.g. if we revert we need to make sure we go back to the old numa toplogy | |
| 17:16:15 | stephenfin | Possibly | |
| 17:16:45 | stephenfin | The fact that we're overwriting some RequestSpec fields already leads me to think we might be rolling back somewhere, but I haven't investigated | |
| 17:17:15 | sean-k-mooney | i think we nolonger persist the ignore_hosts field to the db | |
| 17:17:36 | sean-k-mooney | anyway that is at least a step in the right direction | |
| 17:23:46 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.opendev.org/643894 | |
| 17:23:47 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.opendev.org/643896 | |
| 17:23:47 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.opendev.org/643895 | |
| 17:23:48 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793 | |
| 17:23:54 | efried | stephenfin: done | |
| 18:08:56 | openstackgerrit | melanie witt proposed openstack/nova master: Add documentation for counting quota usage from placement https://review.opendev.org/653845 | |
| 18:08:56 | openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.opendev.org/638324 | |
| 18:08:57 | openstackgerrit | melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056 | |
| 18:52:23 | openstackgerrit | Merged openstack/nova stable/stein: Fix live-migration when glance image deleted https://review.opendev.org/662152 | |
| 18:53:18 | mriedem | dansmith: thanks, replied | |
| 18:53:39 | mriedem | dansmith: sounds like you're prefer me to go back to PS3 for the backports and leave the group_uuid stuff separately on master - if so, that's fine and i can do that | |
| 18:53:45 | mriedem | *you'd | |
| 18:59:00 | dansmith | mriedem: ah I didn't see that it was that way in a previous set.. I'm not super opposed, but just feels like the right thing to do | |
| 19:00:03 | mriedem | ok i'll split that one apart and make the func test change to pop request_spec from kwargs | |
| 19:01:18 | artom | dansmith, welcome back from PTO. I left you a steaming homecoming present: https://review.opendev.org/#/c/653498/ | |
| 19:02:05 | artom | (It's the revert resize thing we had a hangouts about) | |
| 19:03:13 | mriedem | ....except much different | |
| 19:03:26 | dansmith | um, great? | |
| 19:04:04 | mriedem | something something very specific vif type / profile thing right? | |
| 19:04:11 | mriedem | b/c i have not tried to grok any of it | |
| 19:04:23 | artom | Well, the problem turned out to be specific | |
| 19:04:32 | artom | Hence the proposed solution is as well | |
| 19:04:52 | mriedem | and the generic solution we talked about on the hangout wouldn't have fixed it? | |
| 19:04:59 | artom | But yeah, it only happens (in this specific case) when Neutron uses OVS hybrid plug | |
| 19:05:09 | mnaser | two annoying Friday questions: why is the UEFI path hard-coded and why does it have no functional tests (lack of UEFI image?) | |
| 19:05:14 | mriedem | i.e. register the callback in compute manager before updating the port binding and calling the virt driver method | |
| 19:05:29 | artom | mriedem, no, because Neutron sends the event at different times depending on its internals | |
| 19:05:32 | mriedem | mnaser: it was bolted it years ago... | |
| 19:05:34 | mriedem | *in | |
| 19:06:13 | artom | mriedem, wait, say that again? Callback for what? | |
| 19:06:31 | mriedem | artom: the event | |
| 19:07:06 | mriedem | mnaser: https://bugs.launchpad.net/nova/+bug/1825386 is the first issue right? | |
| 19:07:07 | mnaser | because the fact centos and ubuntu both host it in different places is pretty gross right now | |
| 19:07:07 | openstack | Launchpad bug 1825386 in OpenStack Compute (nova) "nova is looking for OVMF file no longer provided by CentOS 7.6" [Undecided,New] | |
| 19:07:15 | mnaser | bahaha | |
| 19:07:16 | mnaser | yes | |
| 19:07:24 | artom | mriedem, you mean wrapping the call to update the port binding with wait_for_event? | |
| 19:07:55 | mnaser | okay, well I guess it's being addressed then | |
| 19:07:56 | mriedem | mnaser: so the workaround from kashyap in there is to create a link | |
| 19:08:06 | mnaser | fair nuff | |
| 19:08:09 | mriedem | mnaser: just b/c there is a bug doesn't mean it's being addressed :) you should know that | |
| 19:08:21 | mriedem | artom: yeah | |
| 19:08:34 | mnaser | well I think kashyap is doing this work | |
| 19:08:51 | mnaser | oh its not even approved yet | |
| 19:08:57 | mriedem | functional testing would catch that anyway | |
| 19:09:00 | mriedem | *wouldn't | |
| 19:09:05 | artom | mriedem, that only works if Neutron sends the event in response to the port binding update | |