| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-31 | |||
| 19:04:23 | artom | Well, the problem turned out to be specific | |
| 19:04:32 | artom | Hence the proposed solution is as well | |
| 19:04:52 | mriedem | and the generic solution we talked about on the hangout wouldn't have fixed it? | |
| 19:04:59 | artom | But yeah, it only happens (in this specific case) when Neutron uses OVS hybrid plug | |
| 19:05:09 | mnaser | two annoying Friday questions: why is the UEFI path hard-coded and why does it have no functional tests (lack of UEFI image?) | |
| 19:05:14 | mriedem | i.e. register the callback in compute manager before updating the port binding and calling the virt driver method | |
| 19:05:29 | artom | mriedem, no, because Neutron sends the event at different times depending on its internals | |
| 19:05:32 | mriedem | mnaser: it was bolted it years ago... | |
| 19:05:34 | mriedem | *in | |
| 19:06:13 | artom | mriedem, wait, say that again? Callback for what? | |
| 19:06:31 | mriedem | artom: the event | |
| 19:07:06 | mriedem | mnaser: https://bugs.launchpad.net/nova/+bug/1825386 is the first issue right? | |
| 19:07:07 | openstack | Launchpad bug 1825386 in OpenStack Compute (nova) "nova is looking for OVMF file no longer provided by CentOS 7.6" [Undecided,New] | |
| 19:07:07 | mnaser | because the fact centos and ubuntu both host it in different places is pretty gross right now | |
| 19:07:15 | mnaser | bahaha | |
| 19:07:16 | mnaser | yes | |
| 19:07:24 | artom | mriedem, you mean wrapping the call to update the port binding with wait_for_event? | |
| 19:07:55 | mnaser | okay, well I guess it's being addressed then | |
| 19:07:56 | mriedem | mnaser: so the workaround from kashyap in there is to create a link | |
| 19:08:06 | mnaser | fair nuff | |
| 19:08:09 | mriedem | mnaser: just b/c there is a bug doesn't mean it's being addressed :) you should know that | |
| 19:08:21 | mriedem | artom: yeah | |
| 19:08:34 | mnaser | well I think kashyap is doing this work | |
| 19:08:51 | mnaser | oh its not even approved yet | |
| 19:08:57 | mriedem | functional testing would catch that anyway | |
| 19:09:00 | mriedem | *wouldn't | |
| 19:09:05 | artom | mriedem, that only works if Neutron sends the event in response to the port binding update | |
| 19:09:07 | mnaser | it's probably trivial to make a config option I guess | |
| 19:09:17 | artom | Which it only does when OVS hybrid plug is in use | |
| 19:09:19 | mriedem | mnaser: or create a link in osa | |
| 19:09:19 | mnaser | but having a config option with two defaults (i.e. aarch64 vs x86)... EH. | |
| 19:09:30 | mnaser | yeah I think that seems like the likely path | |
| 19:09:31 | mriedem | but then all deployment tools have to do that | |
| 19:09:44 | artom | mriedem, the rest of the time, it's business as usual with waiting as we currently do in the virt driver | |
| 19:09:47 | mnaser | yeah it seems like having a config option is the right thing™ | |
| 19:10:18 | mriedem | mnaser: every deployment tool will still have to make a change | |
| 19:10:22 | mriedem | either way | |
| 19:10:29 | mriedem | unless/until nova can auto-detect it | |
| 19:10:58 | mriedem | artom: ok it sounds like a similar issue with hard reboot depending on the type of vif (odl ovs doesn't send the event unless you change the port binding) | |
| 19:11:43 | artom | mriedem, not quite type of vif, but yeah. The real root cause here is Neutron not being consistent in when it sends the events | |
| 19:12:04 | mriedem | mnaser: regarding testing :) https://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/boot-from-uefi.html#testing | |
| 19:12:18 | mriedem | damn those neutrinios | |
| 19:13:41 | artom | Since I'm not sure how realistic is to expect Neutron to change in the near future, the next best alternative is a hopefully-not-too-ugly Nova hack :/ | |
| 19:16:32 | mriedem | i was joking, i like the neutrinos | |
| 19:17:00 | artom | Don't worry, I didn't rat you out | |
| 19:19:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression recreate test for bug 1830747 https://review.opendev.org/661822 | |
| 19:19:02 | openstack | bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | |
| 19:19:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786 | |
| 19:26:42 | openstackgerrit | Merged openstack/nova stable/stein: cleanup evacuated instances not on hypervisor https://review.opendev.org/662189 | |
| 19:28:46 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Set/get group uuid when transforming RequestSpec to/from filter_properties https://review.opendev.org/662550 | |
| 19:28:50 | mriedem | dansmith: there you go, all 3 ^ | |
| 19:28:57 | mriedem | assuming you can fast approve the func test one | |
| 19:31:12 | dansmith | right on | |
| 19:33:15 | mnaser | mriedem: fwiw -- https://review.opendev.org/662552 | |
| 19:34:01 | mriedem | delicious ansible | |
| 19:37:32 | mriedem | mnaser: question in there | |
| 19:37:40 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 19:37:41 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Add configs for AMD SEV https://review.opendev.org/636318 | |
| 19:37:41 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Add iommu driver to devices https://review.opendev.org/644564 | |
| 19:37:42 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | |
| 19:37:42 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | |
| 19:37:43 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | |
| 19:37:43 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Use launchSecurity element when SEV was required https://review.opendev.org/662557 | |
| 19:37:44 | openstackgerrit | Boris Bobrov proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | |
| 19:39:00 | mnaser | mriedem: good call, done | |
| 19:42:08 | mriedem | melwitt: thing in https://review.opendev.org/#/c/638324/ which you can tack into your FUP change | |
| 20:00:52 | openstackgerrit | Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897 | |
| 20:01:14 | openstackgerrit | Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897 | |
| 20:03:08 | efried | mriedem, melwitt: ^ | |
| 20:03:46 | efried | sounded like they weren't super interested in continuing to follow that patch given the controversy, I went ahead and fixed my nits. | |
| 20:04:13 | efried | The changes are small and test-only, but a fair number of lines, so I'd prefer not to +2 it myself at this point. | |
| 20:07:24 | mriedem | i think they just didn't care b/c they've already been running with it in prod for a year or more | |
| 20:09:41 | mriedem | but yeah thanks for updating it | |
| 20:13:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update quota known issues docs https://review.opendev.org/662570 | |
| 20:18:10 | efried | mriedem: I'm updating the nested magic 1 spec, what do you want that footnote to look like? | |
| 20:19:39 | mriedem | just a footnote? | |
| 20:19:52 | mriedem | not a huge deal to me, that won't make me +2 the spec or anything | |
| 20:20:02 | mriedem | as i said, i feel unqualified to approve that spec | |
| 20:20:32 | efried | I don't know what you mean by "just a footnote" | |
| 20:21:10 | efried | you mean plain non-RST'd non-linked text? | |
| 20:22:05 | mnaser | I can't quite grasp if https://github.com/openstack/nova/blob/5868303f2c33021310eb4fade97828ef1757dc6b/nova/network/linux_net.py is nova-network or nova's networking code. | |
| 20:22:23 | mnaser | (I'm cleaning up OSA's long list of old dependencies, and we install bridge-utils which provides brctl, and im just wondering if its necessary) | |
| 20:22:39 | efried | mnaser: Pretty sure it's nova networking, but I could be wrong. | |
| 20:22:52 | efried | by which I mean: pretty sure it's still needed | |
| 20:22:57 | mnaser | I mean I dont think nova should be creating or deleting any bridges? | |
| 20:23:08 | mnaser | right, the neutron role should install bridge-utils, not nova in this case | |
| 20:23:22 | mnaser | (it'll end up there, but just want to make sure its the right thing that puts it there) | |
| 20:30:22 | melwitt | mriedem: k thanks | |
| 20:34:26 | mriedem | mnaser: os-vif likely handles the low-level bridge stuff now | |
| 20:34:36 | mriedem | sean-k-mooney would be the person to ask such questions | |
| 20:35:05 | mriedem | efried: i guess using a footnote http://docutils.sourceforge.net/docs/user/rst/quickref.html#footnotes | |
| 20:35:33 | mriedem | i guess what was in the spec was a citation? | |
| 20:35:34 | efried | mriedem: Yes, I'm using that third form. | |
| 20:37:03 | mriedem | ok just tell me to stfu on the spec then | |
| 20:37:30 | efried | mriedem, I live to make you happy. It's easy to change to something you consider prettier. Just tell me what that is and I'll do it. | |
| 20:38:19 | efried | note that the theme is going to mung the appearance - that's what's giving you the magical backreference link instead of the bold full-sized text on the footnote itself | |
| 20:38:36 | efried | so if I changed to [1] it's still going to be "ugly". | |
| 20:40:16 | mnaser | mriedem: ah good call, fyi -- https://github.com/openstack/os-vif/commit/1f6fed6a69e9fd386e421f3cacae97c11cdd7c75#diff-17b53d4f2c04032fb60eec093a443af0 | |
| 20:40:19 | mnaser | so .. no longer needed now | |
| 20:41:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup quota user docs https://review.opendev.org/662573 | |