Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-31
14:54:38 efried esp on the os-traits side?
14:54:47 efried cause the can't-build-shit thing is getting annoying.
14:55:01 kashyap efried: Hiya, _just_ about to push one
14:55:10 efried ack, please ping when done, thx
14:55:20 kashyap efried: I'm done addressing your remarks. Feel free to nit-pick away
14:55:35 efried feel like we were on the downward slope
14:56:04 kashyap Heh, no. I appreciate the "soft -1"
14:58:32 openstackgerrit Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits https://review.opendev.org/655193
14:58:39 kashyap efried: aspiers --^ Did I get it right?
14:59:53 kashyap [I'm here for an hour more, then I need to bike to get some groceries]
15:01:11 openstackgerrit melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.opendev.org/638324
15:01:12 openstackgerrit melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056
15:01:12 openstackgerrit melanie witt proposed openstack/nova master: Add documentation for counting quota usage from placement https://review.opendev.org/653845
15:31:44 openstack Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Undecided,New]
15:31:44 mriedem gibi: i suspect this bug https://bugs.launchpad.net/nova/+bug/1829479 is a duplicate of the orphaned allocations from wiped evacuated node you worked on, but i'm having a hard time parsing it from the reporter
15:41:28 openstackgerrit Merged openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/639091
15:54:55 mriedem oof the ironic hashring stuff in nova is not documented at all
15:56:54 mriedem re https://bugs.launchpad.net/nova/+bug/1831195
15:56:55 openstack Launchpad bug 1831195 in OpenStack Compute (nova) "disable one compute service will prevent scheduler to choose the hypervisor the compute service manange" [Undecided,Invalid]
15:57:18 mriedem "i've disabled my nova-compute service managing ironic nodes but still want to schedule stuff there, what gives?!"
15:58:43 mriedem i'm assuming they just aren't aware of the hashring
16:00:41 aspiers kashyap: think you missed the s/e\.g\./i.e./
16:00:58 kashyap aspiers: ****; let me do it. I _knew_ I'd miss something
16:01:03 aspiers :)
16:01:23 kashyap It's not even a nit-pick, it's a logical mistake, so I _want_ to correct it :-)
16:01:51 kashyap Anything else?
16:01:53 aspiers nope
16:01:56 aspiers Not that I can see
16:02:37 openstackgerrit Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits https://review.opendev.org/655193
16:02:42 kashyap aspiers: Hehe, done.
16:03:07 aspiers Hrm
16:03:10 aspiers not sure I see a difference
16:03:30 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils' https://review.opendev.org/662501
16:03:31 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController https://review.opendev.org/662503
16:03:31 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects https://review.opendev.org/662502
16:03:32 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505
16:03:32 openstackgerrit Stephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils https://review.opendev.org/662504
16:03:33 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506
16:03:36 aspiers kashyap: "Uploaded patch set 8: Commit message was updated."
16:04:01 aspiers stephenfin: No technical debt to see here, move along now!
16:04:20 kashyap aspiers: That's it, no?
16:04:35 aspiers Doh
16:04:37 aspiers Yes it is
16:04:50 aspiers +1
16:05:01 aspiers Hopefully efried likes too
16:05:04 mriedem stephenfin: i really wish you'd ask about that kind of stuff before spending time on doing it
16:05:31 stephenfin Why?
16:06:06 mriedem because that ec2 stuff is used by the out of tree ec2 api stuff
16:06:20 mriedem which as far as i know we haven't agreed, as a team, to deliberatly break
16:07:11 stephenfin I need to double check some of them but codesearch wasn't bringing up hits for a lot of them, and for the others it was bringing up dupes from the ec2 stuff
16:07:44 mriedem ec2api out of tree code won't show hits for things that are internal to nova but necessary for that api to work
16:09:18 mriedem i also noticed https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:hacking-update this morning and it'd be nice, as a courtesy to the core team and others working on nova, to at least raise some of this stuff up in the ML or meeting *before* starting work on it
16:09:56 mriedem i'm not saying i'm against those hacking changes fwiw, just saying they are big changes that once merged will impact everyone so a heads up would be nice
16:11:24 mriedem while i'm ranting, can i get some eyes on https://review.opendev.org/#/q/topic:bug/1830747+(status:open+OR+status:merged) since bauzas is on EU PTO infinitum so i can start backports since that's going to hammer anyone with rescheduled cold migrations / resizes before stein, which is pretty gd nasty
16:11:38 mriedem dansmith: ^ you'd probably be best besides bauzas
16:11:40 mriedem if you're around
16:12:00 dansmith ack
16:12:15 mriedem danke
16:12:53 mriedem and welcome back to the fun house
16:13:50 dansmith heh thanks
16:16:19 stephenfin mriedem: I get where you're coming from but I really don't agree. If I'm happy to burn an hour on tech debt reduction, my patches are reviewable, and I keep them rebased as conflicts pop up, why not? EAFP and all that
16:16:40 stephenfin hacking being a fair exception since that touches a _lot_ of stuff, sadly
16:17:00 stephenfin I left the comments on https://review.opendev.org/#/c/662501/1/nova/api/ec2/ec2utils.py anyway. That -2 can probably be removed unless I've missed something obvious
16:27:01 dansmith mriedem_hangry: question I'll probably regret asking in that set
16:36:15 sean-k-mooney stephenfin: are you looking at the resize issue
16:36:27 stephenfin sean-k-mooney: I am
16:36:35 stephenfin sean-k-mooney: Are you?
16:36:49 sean-k-mooney no i know why it happens
16:36:58 stephenfin shoot
16:37:03 sean-k-mooney i looked at the code a few days ago
16:37:24 sean-k-mooney and asked them to file a bz which you triaged but i have filed an upstream bug
16:37:34 stephenfin Got a link?
16:37:35 sean-k-mooney if you want to fix it feel free
16:37:48 sean-k-mooney *have not
16:38:50 stephenfin sean-k-mooney: Want to give the tl;dr?
16:39:20 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1038
16:39:37 sean-k-mooney we use the pagesize form the embeded instance numa toplogy object
16:40:22 sean-k-mooney so in a resize when we do https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L98
16:40:33 stephenfin sean-k-mooney: Right, which we have one of already https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L74
16:40:35 stephenfin yeah
16:40:51 stephenfin Why doesn't this hit rebuild though?
16:41:13 sean-k-mooney because its a resize
16:41:16 stephenfin Oh, because the size hasn't changed
16:41:18 stephenfin Yah
16:41:20 stephenfin *yeah
16:41:29 stephenfin *mempage size
16:42:16 sean-k-mooney anyway for a resize we need to update the instance toplogy object with the mem_page_size form the new flavor
16:42:43 sean-k-mooney so we can either make a copy of the toplogy and pass that in our maybe use the tempory_mutation decorator
16:42:56 stephenfin I'm trying to figure out what sets it for the requested_topology the first day (i.e. on a server create)
16:43:34 sean-k-mooney i belive we generate it form the flavor but dont fill in all the fields
16:43:45 sean-k-mooney but i didnt look
16:44:13 sean-k-mooney its foming from the sepc_object whic is the request_spec
16:44:48 stephenfin Must be https://github.com/openstack/nova/blob/master/nova/compute/api.py#L978
16:45:50 stephenfin which is set by https://github.com/openstack/nova/blob/master/nova/compute/api.py#L876-L877
16:50:37 stephenfin sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1831269
16:50:38 openstack Launchpad bug 1831269 in OpenStack Compute (nova) "Resize ignores mem_page_size in new flavor" [Undecided,New]
16:50:48 sean-k-mooney we should proably be updating the request spec here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3558-L3560
16:51:48 sean-k-mooney which is just before we call resize instnace
16:52:08 sean-k-mooney that or self.compute_task_api.resize_instance should do it
17:01:41 sean-k-mooney stephenfin: i have triage it upstream and commented on the issue https://bugs.launchpad.net/nova/+bug/1831269

Earlier   Later